X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fsignal.cpp;h=ad139f7e4ad21cbbb79a03355aa1917fdfbd2d03;hp=fab76fcfd1f1fcbf593d3cb853eff457ba70f8cb;hb=3a21afa6;hpb=b86aa8f4a22857a90bbfca6e7993b2deaf1157d4

diff --git a/pv/view/signal.cpp b/pv/view/signal.cpp
index fab76fcf..ad139f7e 100644
--- a/pv/view/signal.cpp
+++ b/pv/view/signal.cpp
@@ -21,7 +21,7 @@
 #include <extdef.h>
 
 #include <assert.h>
-#include <math.h>
+#include <cmath>
 
 #include <QApplication>
 #include <QFormLayout>
@@ -29,14 +29,15 @@
 #include <QLineEdit>
 #include <QMenu>
 
-#include <libsigrok/libsigrok.hpp>
+#include <libsigrokcxx/libsigrokcxx.hpp>
 
-#include "signal.h"
-#include "view.h"
+#include "pv/data/signalbase.hpp"
 
-using std::shared_ptr;
+#include "signal.hpp"
+#include "view.hpp"
 
-using sigrok::Channel;
+using std::shared_ptr;
+using std::make_shared;
 
 namespace pv {
 namespace view {
@@ -47,8 +48,8 @@ const char *const ChannelNames[] = {
 	"IN",
 	"OUT",
 	"RST",
-	"Tx",
-	"Rx",
+	"TX",
+	"RX",
 	"EN",
 	"SCLK",
 	"MOSI",
@@ -58,64 +59,81 @@ const char *const ChannelNames[] = {
 	"SCL"
 };
 
-Signal::Signal(pv::SigSession &session,
-	std::shared_ptr<sigrok::Channel> channel) :
-	Trace(channel->name().c_str()),
-	_session(session),
-	_channel(channel),
-	_name_widget(NULL),
-	_updating_name_widget(false)
+Signal::Signal(pv::Session &session,
+	std::shared_ptr<data::SignalBase> channel) :
+	Trace(channel),
+	session_(session),
+	scale_handle_(make_shared<SignalScaleHandle>(*this)),
+	items_({scale_handle_}),
+	name_widget_(nullptr)
 {
-	assert(_channel);
+	assert(base_);
+
+	connect(base_.get(), SIGNAL(enabled_changed(bool)),
+		this, SLOT(on_enabled_changed(bool)));
 }
 
 void Signal::set_name(QString name)
 {
 	Trace::set_name(name);
-	_updating_name_widget = true;
-	_name_widget->setEditText(name);
-	_updating_name_widget = false;
+
+	if (name != name_widget_->currentText())
+		name_widget_->setEditText(name);
 }
 
 bool Signal::enabled() const
 {
-	return _channel->enabled();
+	return base_->enabled();
 }
 
-void Signal::enable(bool enable)
+shared_ptr<data::SignalBase> Signal::base() const
 {
-	_channel->set_enabled(enable);
-	visibility_changed();
+	return base_;
 }
 
-shared_ptr<Channel> Signal::channel() const
+void Signal::save_settings(QSettings &settings) const
 {
-	return _channel;
+	(void)settings;
 }
 
-void Signal::populate_popup_form(QWidget *parent, QFormLayout *form)
+void Signal::restore_settings(QSettings &settings)
 {
-	int index;
+	(void)settings;
+}
 
-	_name_widget = new QComboBox(parent);
-	_name_widget->setEditable(true);
+const ViewItemOwner::item_list& Signal::child_items() const
+{
+	return items_;
+}
 
-	for(unsigned int i = 0; i < countof(ChannelNames); i++)
-		_name_widget->insertItem(i, ChannelNames[i]);
+void Signal::paint_back(QPainter &p, const ViewItemPaintParams &pp)
+{
+	if (base_->enabled())
+		Trace::paint_back(p, pp);
+}
 
-	index = _name_widget->findText(_name, Qt::MatchExactly);
+void Signal::populate_popup_form(QWidget *parent, QFormLayout *form)
+{
+	name_widget_ = new QComboBox(parent);
+	name_widget_->setEditable(true);
+	name_widget_->setCompleter(nullptr);
+
+	for (unsigned int i = 0; i < countof(ChannelNames); i++)
+		name_widget_->insertItem(i, ChannelNames[i]);
+
+	const int index = name_widget_->findText(base_->name(), Qt::MatchExactly);
 
 	if (index == -1) {
-		_name_widget->insertItem(0, _name);
-		_name_widget->setCurrentIndex(0);
+		name_widget_->insertItem(0, base_->name());
+		name_widget_->setCurrentIndex(0);
 	} else {
-		_name_widget->setCurrentIndex(index);
+		name_widget_->setCurrentIndex(index);
 	}
 
-	connect(_name_widget, SIGNAL(editTextChanged(const QString&)),
-		this, SLOT(on_text_changed(const QString&)));
+	connect(name_widget_, SIGNAL(editTextChanged(const QString&)),
+		this, SLOT(on_nameedit_changed(const QString&)));
 
-	form->addRow(tr("Name"), _name_widget);
+	form->addRow(tr("Name"), name_widget_);
 
 	add_colour_option(parent, form);
 }
@@ -139,9 +157,30 @@ void Signal::delete_pressed()
 	on_disable();
 }
 
+void Signal::on_name_changed(const QString &text)
+{
+	// On startup, this event is fired when a session restores signal
+	// names. However, the name widget hasn't yet been created.
+	if (!name_widget_)
+		return;
+
+	if (text != name_widget_->currentText())
+		name_widget_->setEditText(text);
+
+	Trace::on_name_changed(text);
+}
+
 void Signal::on_disable()
 {
-	enable(false);
+	base_->set_enabled(false);
+}
+
+void Signal::on_enabled_changed(bool enabled)
+{
+	(void)enabled;
+
+	if (owner_)
+		owner_->extents_changed(true, true);
 }
 
 } // namespace view