X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fruler.cpp;h=a8d25fc9df6a2ee4dfa5c3cfcfe9b9035e5c9b3a;hp=2f9b140eec8d0f9d1649155166b89f3a0638e5cd;hb=f4e57597347e47a4ea58fbdc7b0a22e07f1c0ede;hpb=803cdac41caf71af9298e3f612468aa522a107d5 diff --git a/pv/view/ruler.cpp b/pv/view/ruler.cpp index 2f9b140e..a8d25fc9 100644 --- a/pv/view/ruler.cpp +++ b/pv/view/ruler.cpp @@ -27,20 +27,19 @@ #include "ruler.hpp" #include "view.hpp" -#include - using namespace Qt; using std::shared_ptr; using std::vector; namespace pv { -namespace view { +namespace views { +namespace TraceView { -const float Ruler::RulerHeight = 2.5f; // x Text Height +const float Ruler::RulerHeight = 2.5f; // x Text Height const int Ruler::MinorTickSubdivision = 4; -const float Ruler::HoverArrowSize = 0.5f; // x Text Height +const float Ruler::HoverArrowSize = 0.5f; // x Text Height Ruler::Ruler(View &parent) : MarginWidget(parent) @@ -49,6 +48,18 @@ Ruler::Ruler(View &parent) : connect(&view_, SIGNAL(hover_point_changed()), this, SLOT(hover_point_changed())); + connect(&view_, SIGNAL(offset_changed()), + this, SLOT(invalidate_tick_position_cache())); + connect(&view_, SIGNAL(scale_changed()), + this, SLOT(invalidate_tick_position_cache())); + connect(&view_, SIGNAL(tick_prefix_changed()), + this, SLOT(invalidate_tick_position_cache())); + connect(&view_, SIGNAL(tick_precision_changed()), + this, SLOT(invalidate_tick_position_cache())); + connect(&view_, SIGNAL(tick_period_changed()), + this, SLOT(invalidate_tick_position_cache())); + connect(&view_, SIGNAL(time_unit_changed()), + this, SLOT(invalidate_tick_position_cache())); } QSize Ruler::sizeHint() const @@ -67,6 +78,38 @@ QSize Ruler::extended_size_hint() const ViewItem::HighlightRadius); } +QString Ruler::format_time_with_distance( + const pv::util::Timestamp& distance, + const pv::util::Timestamp& t, + pv::util::SIPrefix prefix, + pv::util::TimeUnit unit, + unsigned precision, + bool sign) +{ + const unsigned limit = 60; + + if (t.is_zero()) + return "0"; + + // If we have to use samples then we have no alternative formats + if (unit == pv::util::TimeUnit::Samples) + return pv::util::format_time_si_adjusted(t, prefix, precision, "sa", sign); + + // View zoomed way out -> low precision (0), big distance (>=60s) + // -> DD:HH:MM + if ((precision == 0) && (distance >= limit)) + return pv::util::format_time_minutes(t, 0, sign); + + // View in "normal" range -> medium precision, medium step size + // -> HH:MM:SS.mmm... or xxxx (si unit) if less than limit seconds + // View zoomed way in -> high precision (>3), low step size (<1s) + // -> HH:MM:SS.mmm... or xxxx (si unit) if less than limit seconds + if (abs(t) < limit) + return pv::util::format_time_si_adjusted(t, prefix, precision, "s", sign); + else + return pv::util::format_time_minutes(t, precision, sign); +} + vector< shared_ptr > Ruler::items() { const vector< shared_ptr > time_items(view_.time_items()); @@ -85,61 +128,53 @@ shared_ptr Ruler::get_mouse_over_item(const QPoint &pt) void Ruler::paintEvent(QPaintEvent*) { - const int ValueMargin = 3; - - QPainter p(this); - p.setRenderHint(QPainter::Antialiasing); - - const double tick_period = view_.tick_period(); - const unsigned int prefix = view_.tick_prefix(); - - // Draw the tick marks - p.setPen(palette().color(foregroundRole())); - - const double minor_tick_period = tick_period / MinorTickSubdivision; - const double first_major_division = - floor(view_.offset() / tick_period); - const double first_minor_division = - ceil(view_.offset() / minor_tick_period); - const double t0 = first_major_division * tick_period; + if (!tick_position_cache_) { + auto ffunc = [this](const pv::util::Timestamp& t) { + return format_time_with_distance( + this->view_.tick_period(), + t, + this->view_.tick_prefix(), + this->view_.time_unit(), + this->view_.tick_precision()); + }; + + tick_position_cache_ = calculate_tick_positions( + view_.tick_period(), + view_.offset(), + view_.scale(), + width(), + ffunc); + } - int division = (int)round(first_minor_division - - first_major_division * MinorTickSubdivision) - 1; + const int ValueMargin = 3; const int text_height = calculate_text_height(); const int ruler_height = RulerHeight * text_height; const int major_tick_y1 = text_height + ValueMargin * 2; const int minor_tick_y1 = (major_tick_y1 + ruler_height) / 2; - double x; + QPainter p(this); - do { - const double t = t0 + division * minor_tick_period; - x = (t - view_.offset()) / view_.scale(); - - if (division % MinorTickSubdivision == 0) - { - // Draw a major tick - p.drawText(x, ValueMargin, 0, text_height, - AlignCenter | AlignTop | TextDontClip, - pv::util::format_time(t, prefix)); - p.drawLine(QPointF(x, major_tick_y1), - QPointF(x, ruler_height)); - } - else - { - // Draw a minor tick - p.drawLine(QPointF(x, minor_tick_y1), - QPointF(x, ruler_height)); - } + // Draw the tick marks + p.setPen(palette().color(foregroundRole())); - division++; + for (const auto& tick: tick_position_cache_->major) { + p.drawText(tick.first, ValueMargin, 0, text_height, + AlignCenter | AlignTop | TextDontClip, tick.second); + p.drawLine(QPointF(tick.first, major_tick_y1), + QPointF(tick.first, ruler_height)); + } - } while (x < width()); + for (const auto& tick: tick_position_cache_->minor) { + p.drawLine(QPointF(tick, minor_tick_y1), + QPointF(tick, ruler_height)); + } // Draw the hover mark draw_hover_mark(p, text_height); + p.setRenderHint(QPainter::Antialiasing); + // The cursor labels are not drawn with the arrows exactly on the // bottom line of the widget, because then the selection shadow // would be clipped away. @@ -154,9 +189,46 @@ void Ruler::paintEvent(QPaintEvent*) } } -void Ruler::mouseDoubleClickEvent(QMouseEvent *e) +Ruler::TickPositions Ruler::calculate_tick_positions( + const pv::util::Timestamp& major_period, + const pv::util::Timestamp& offset, + const double scale, + const int width, + std::function format_function) { - view_.add_flag(view_.offset() + ((double)e->x() + 0.5) * view_.scale()); + TickPositions tp; + + const pv::util::Timestamp minor_period = major_period / MinorTickSubdivision; + const pv::util::Timestamp first_major_division = floor(offset / major_period); + const pv::util::Timestamp first_minor_division = ceil(offset / minor_period); + const pv::util::Timestamp t0 = first_major_division * major_period; + + int division = (round(first_minor_division - + first_major_division * MinorTickSubdivision)).convert_to() - 1; + + double x; + + do { + pv::util::Timestamp t = t0 + division * minor_period; + x = ((t - offset) / scale).convert_to(); + + if (division % MinorTickSubdivision == 0) { + // Recalculate 't' without using 'minor_period' which is a fraction + t = t0 + division / MinorTickSubdivision * major_period; + tp.major.emplace_back(x, format_function(t)); + } else { + tp.minor.emplace_back(x); + } + + division++; + } while (x < width); + + return tp; +} + +void Ruler::mouseDoubleClickEvent(QMouseEvent *event) +{ + view_.add_flag(view_.offset() + ((double)event->x() + 0.5) * view_.scale()); } void Ruler::draw_hover_mark(QPainter &p, int text_height) @@ -189,5 +261,17 @@ void Ruler::hover_point_changed() update(); } -} // namespace view +void Ruler::invalidate_tick_position_cache() +{ + tick_position_cache_ = boost::none; +} + +void Ruler::resizeEvent(QResizeEvent*) +{ + // the tick calculation depends on the width of this widget + invalidate_tick_position_cache(); +} + +} // namespace TraceView +} // namespace views } // namespace pv