X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Flogicsignal.cpp;h=e071e720b33991a34f21e0ec240874c7f17a783d;hp=cf3f3e5a58dd076b1a58a9bfd39a3e93bf092de4;hb=a55c544b0fefead0786633d6d7c2356002b192ae;hpb=8d634081d8b0cc741dd34d8c646474ff6754aea8

diff --git a/pv/view/logicsignal.cpp b/pv/view/logicsignal.cpp
index cf3f3e5a..e071e720 100644
--- a/pv/view/logicsignal.cpp
+++ b/pv/view/logicsignal.cpp
@@ -23,8 +23,9 @@
 #include <math.h>
 
 #include "logicsignal.h"
-#include "../logicdata.h"
-#include "../logicdatasnapshot.h"
+#include "view.h"
+#include "pv/data/logic.h"
+#include "pv/data/logicsnapshot.h"
 
 using namespace boost;
 using namespace std;
@@ -32,14 +33,13 @@ using namespace std;
 namespace pv {
 namespace view {
 
-const float LogicSignal::Margin = 10.0f;
 const float LogicSignal::Oversampling = 2.0f;
 
 const QColor LogicSignal::EdgeColour(0x80, 0x80, 0x80);
 const QColor LogicSignal::HighColour(0x00, 0xC0, 0x00);
 const QColor LogicSignal::LowColour(0xC0, 0x00, 0x00);
 
-const QColor LogicSignal::LogicSignalColours[10] = {
+const QColor LogicSignal::SignalColours[10] = {
 	QColor(0x16, 0x19, 0x1A),	// Black
 	QColor(0x8F, 0x52, 0x02),	// Brown
 	QColor(0xCC, 0x00, 0x00),	// Red
@@ -52,50 +52,71 @@ const QColor LogicSignal::LogicSignalColours[10] = {
 	QColor(0xEE, 0xEE, 0xEC),	// White
 };
 
-LogicSignal::LogicSignal(QString name, shared_ptr<LogicData> data,
-	int probe_index) :
-	Signal(name),
-	_probe_index(probe_index),
+LogicSignal::LogicSignal(const sr_probe *const probe,
+	shared_ptr<data::Logic> data) :
+	Signal(probe),
 	_data(data)
 {
-	assert(_probe_index >= 0);
-	_colour = LogicSignalColours[
-		_probe_index % countof(LogicSignalColours)];
+	_colour = SignalColours[probe->index % countof(SignalColours)];
 }
 
-void LogicSignal::paint(QPainter &p, const QRect &rect, double scale,
-	double offset)
+LogicSignal::~LogicSignal()
 {
+}
+
+const list<QAction*> LogicSignal::get_context_bar_actions()
+{
+	list<QAction*> actions;
+	return actions;
+}
+
+void LogicSignal::paint(QPainter &p, int y, int left, int right,
+		double scale, double offset)
+{
+	using pv::view::View;
+
 	QLineF *line;
 
 	vector< pair<int64_t, bool> > edges;
 
+	assert(_probe);
 	assert(scale > 0);
 	assert(_data);
+	assert(right >= left);
 
-	const float high_offset = rect.top() + Margin + 0.5f;
-	const float low_offset = rect.bottom() - Margin + 0.5f;
+	if (!_probe->enabled)
+		return;
 
-	const deque< shared_ptr<pv::LogicDataSnapshot> > &snapshots =
+	paint_axis(p, y, left, right);
+
+	const float high_offset = y - View::SignalHeight + 0.5f;
+	const float low_offset = y + 0.5f;
+
+	const deque< shared_ptr<pv::data::LogicSnapshot> > &snapshots =
 		_data->get_snapshots();
-	if(snapshots.empty())
+	if (snapshots.empty())
 		return;
 
-	const shared_ptr<pv::LogicDataSnapshot> &snapshot =
+	const shared_ptr<pv::data::LogicSnapshot> &snapshot =
 		snapshots.front();
 
+	double samplerate = _data->get_samplerate();
+
+	// Show sample rate as 1Hz when it is unknown
+	if (samplerate == 0.0)
+		samplerate = 1.0;
+
 	const double pixels_offset = offset / scale;
-	const double samplerate = _data->get_samplerate();
 	const double start_time = _data->get_start_time();
 	const int64_t last_sample = snapshot->get_sample_count() - 1;
 	const double samples_per_pixel = samplerate * scale;
 	const double start = samplerate * (offset - start_time);
-	const double end = start + samples_per_pixel * rect.width();
+	const double end = start + samples_per_pixel * (right - left);
 
 	snapshot->get_subsampled_edges(edges,
 		min(max((int64_t)floor(start), (int64_t)0), last_sample),
 		min(max((int64_t)ceil(end), (int64_t)0), last_sample),
-		samples_per_pixel / Oversampling, _probe_index);
+		samples_per_pixel / Oversampling, _probe->index);
 	assert(edges.size() >= 2);
 
 	// Paint the edges
@@ -103,11 +124,11 @@ void LogicSignal::paint(QPainter &p, const QRect &rect, double scale,
 	QLineF *const edge_lines = new QLineF[edge_count];
 	line = edge_lines;
 
-	for(vector<pv::LogicDataSnapshot::EdgePair>::const_iterator i =
+	for (vector<pv::data::LogicSnapshot::EdgePair>::const_iterator i =
 			edges.begin() + 1;
 		i != edges.end() - 1; i++) {
 		const float x = ((*i).first / samples_per_pixel -
-			pixels_offset) + rect.left();
+			pixels_offset) + left;
 		*line++ = QLineF(x, high_offset, x, low_offset);
 	}
 
@@ -121,10 +142,10 @@ void LogicSignal::paint(QPainter &p, const QRect &rect, double scale,
 
 	p.setPen(HighColour);
 	paint_caps(p, cap_lines, edges, true, samples_per_pixel,
-		pixels_offset, rect.left(), high_offset);
+		pixels_offset, left, high_offset);
 	p.setPen(LowColour);
 	paint_caps(p, cap_lines, edges, false, samples_per_pixel,
-		pixels_offset, rect.left(), low_offset);
+		pixels_offset, left, low_offset);
 
 	delete[] cap_lines;
 }
@@ -136,9 +157,9 @@ void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
 {
 	QLineF *line = lines;
 
-	for(vector<pv::LogicDataSnapshot::EdgePair>::const_iterator i =
+	for (vector<pv::data::LogicSnapshot::EdgePair>::const_iterator i =
 		edges.begin(); i != (edges.end() - 1); i++)
-		if((*i).second == level) {
+		if ((*i).second == level) {
 			*line++ = QLineF(
 				((*i).first / samples_per_pixel -
 					pixels_offset) + x_offset, y_offset,
@@ -149,10 +170,5 @@ void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
 	p.drawLines(lines, line - lines);
 }
 
-int LogicSignal::get_nominal_offset(const QRect &rect) const
-{
-	return rect.bottom() - Margin;
-}
-
 } // namespace view
 } // namespace pv