X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fheader.cpp;h=60d64b2f401f2483aad1226dc00e66d62ca54191;hp=f31a91cc820400fcf707228438fe2f5d2373fca1;hb=af503b104d890a357c736c678bb00296d889c090;hpb=dbf74f26f6bd9fd5277f090fea8e4f5506c19911 diff --git a/pv/view/header.cpp b/pv/view/header.cpp index f31a91cc..60d64b2f 100644 --- a/pv/view/header.cpp +++ b/pv/view/header.cpp @@ -54,7 +54,7 @@ namespace view { const int Header::Padding = 12; const int Header::BaselineOffset = 5; -static bool item_selected(shared_ptr r) +static bool item_selected(shared_ptr r) { return r->selected(); } @@ -89,7 +89,7 @@ shared_ptr Header::get_mouse_over_item(const QPoint &pt) for (auto &i : view_) if (i->enabled() && i->label_rect(r).contains(pt)) return i; - return shared_ptr(); + return shared_ptr(); } void Header::paintEvent(QPaintEvent*) @@ -99,17 +99,17 @@ void Header::paintEvent(QPaintEvent*) // would be clipped away. const QRect rect(0, 0, width() - BaselineOffset, height()); - vector< shared_ptr > row_items( + vector< shared_ptr > items( view_.begin(), view_.end()); - stable_sort(row_items.begin(), row_items.end(), - [](const shared_ptr &a, const shared_ptr &b) { + stable_sort(items.begin(), items.end(), + [](const shared_ptr &a, const shared_ptr &b) { return a->visual_v_offset() < b->visual_v_offset(); }); QPainter painter(this); painter.setRenderHint(QPainter::Antialiasing); - for (const shared_ptr r : row_items) + for (const shared_ptr r : items) { assert(r); @@ -160,17 +160,17 @@ void Header::keyPressEvent(QKeyEvent *e) void Header::on_group() { - vector< shared_ptr > selected_items( + vector< shared_ptr > selected_items( make_filter_iterator(item_selected, view_.begin(), view_.end()), make_filter_iterator(item_selected, view_.end(), view_.end())); stable_sort(selected_items.begin(), selected_items.end(), - [](const shared_ptr &a, const shared_ptr &b) { + [](const shared_ptr &a, const shared_ptr &b) { return a->visual_v_offset() < b->visual_v_offset(); }); shared_ptr group(new TraceGroup()); - shared_ptr mouse_down_item( - std::dynamic_pointer_cast(mouse_down_item_)); - shared_ptr focus_item( + shared_ptr mouse_down_item( + std::dynamic_pointer_cast(mouse_down_item_)); + shared_ptr focus_item( mouse_down_item ? mouse_down_item : selected_items.front()); assert(focus_item); @@ -182,7 +182,7 @@ void Header::on_group() focus_item->v_extents().first); for (size_t i = 0; i < selected_items.size(); i++) { - const shared_ptr &r = selected_items[i]; + const shared_ptr &r = selected_items[i]; assert(r->owner()); r->owner()->remove_child_item(r); group->add_child_item(r); @@ -198,7 +198,7 @@ void Header::on_ungroup() bool restart; do { restart = false; - for (const shared_ptr r : view_) { + for (const shared_ptr r : view_) { const shared_ptr tg = dynamic_pointer_cast(r); if (tg && tg->selected()) {