X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Ftoolbars%2Fsamplingbar.cpp;h=21421bca34f16b235b644ca3096996f2aa9e0a2d;hp=f58f4fc38fd60c2ecedce0aefae3bd8468fa6ffa;hb=c042b5d2b18fca9fe79b9a33b730b890387bbfc7;hpb=945745012eb57cefa1ef457daf48cfffa99f9ec2 diff --git a/pv/toolbars/samplingbar.cpp b/pv/toolbars/samplingbar.cpp index f58f4fc3..21421bca 100644 --- a/pv/toolbars/samplingbar.cpp +++ b/pv/toolbars/samplingbar.cpp @@ -22,24 +22,32 @@ #include -#include - #include #include +#include +#include #include "samplingbar.h" #include -#include #include -#include +#include +#include + +#include -using boost::shared_ptr; using std::map; +using std::vector; using std::max; using std::min; +using std::shared_ptr; using std::string; +using sigrok::Capability; +using sigrok::ConfigKey; +using sigrok::Device; +using sigrok::Error; + namespace pv { namespace toolbars { @@ -54,7 +62,7 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : _updating_device_selector(false), _configure_button(this), _configure_button_action(NULL), - _probes_button(this), + _channels_button(this), _sample_count(" samples", this), _sample_rate("Hz", this), _updating_sample_rate(false), @@ -65,6 +73,8 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : _icon_grey(":/icons/status-grey.svg"), _run_stop_button(this) { + setObjectName(QString::fromUtf8("SamplingBar")); + connect(&_run_stop_button, SIGNAL(clicked()), this, SLOT(on_run_stop())); connect(&_device_selector, SIGNAL(currentIndexChanged (int)), @@ -81,73 +91,64 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : _configure_button.setIcon(QIcon::fromTheme("configure", QIcon(":/icons/configure.png"))); - _probes_button.setIcon(QIcon::fromTheme("probes", - QIcon(":/icons/probes.svg"))); + _channels_button.setIcon(QIcon::fromTheme("channels", + QIcon(":/icons/channels.svg"))); _run_stop_button.setToolButtonStyle(Qt::ToolButtonTextBesideIcon); addWidget(&_device_selector); _configure_button_action = addWidget(&_configure_button); - addWidget(&_probes_button); + addWidget(&_channels_button); addWidget(&_sample_count); addWidget(&_sample_rate); addWidget(&_run_stop_button); + + _sample_count.installEventFilter(this); + _sample_rate.installEventFilter(this); } void SamplingBar::set_device_list( - const std::list< shared_ptr > &devices) + const std::list< std::pair, std::string> > &devices, + shared_ptr selected) { + int selected_index = -1; + + assert(selected); + _updating_device_selector = true; _device_selector.clear(); - _device_selector_map.clear(); - BOOST_FOREACH (shared_ptr dev_inst, devices) { - assert(dev_inst); - const string title = dev_inst->format_device_title(); - const sr_dev_inst *sdi = dev_inst->dev_inst(); - assert(sdi); + for (auto entry : devices) { + auto device = entry.first; + auto display_name = entry.second; - _device_selector_map[sdi] = dev_inst; - _device_selector.addItem(title.c_str(), - qVariantFromValue((void*)sdi)); - } - - _updating_device_selector = false; + assert(device); - on_device_selected(); -} + if (selected == device) + selected_index = _device_selector.count(); -shared_ptr SamplingBar::get_selected_device() const -{ - const int index = _device_selector.currentIndex(); - if (index < 0) - return shared_ptr(); + _device_selector.addItem(display_name.c_str(), + qVariantFromValue(device)); + } - const sr_dev_inst *const sdi = - (const sr_dev_inst*)_device_selector.itemData( - index).value(); - assert(sdi); + // The selected device should have been in the list + assert(selected_index != -1); + _device_selector.setCurrentIndex(selected_index); - map >:: - const_iterator iter = _device_selector_map.find(sdi); - if (iter == _device_selector_map.end()) - return shared_ptr(); + update_device_config_widgets(); - return shared_ptr((*iter).second); + _updating_device_selector = false; } -void SamplingBar::set_selected_device(shared_ptr dev_inst) +shared_ptr SamplingBar::get_selected_device() const { - assert(dev_inst); + const int index = _device_selector.currentIndex(); + if (index < 0) + return shared_ptr(); - for (int i = 0; i < _device_selector.count(); i++) - if (dev_inst->dev_inst() == - _device_selector.itemData(i).value()) { - _device_selector.setCurrentIndex(i); - return; - } + return _device_selector.itemData(index).value>(); } void SamplingBar::set_capture_state(pv::SigSession::capture_state state) @@ -156,32 +157,35 @@ void SamplingBar::set_capture_state(pv::SigSession::capture_state state) _run_stop_button.setIcon(*icons[state]); _run_stop_button.setText((state == pv::SigSession::Stopped) ? tr("Run") : tr("Stop")); + _run_stop_button.setShortcut(QKeySequence(Qt::Key_Space)); } void SamplingBar::update_sample_rate_selector() { - GVariant *gvar_dict, *gvar_list; + Glib::VariantContainerBase gvar_dict; + GVariant *gvar_list; const uint64_t *elements = NULL; gsize num_elements; if (_updating_sample_rate) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + const shared_ptr device = get_selected_device(); + if (!device) return; assert(!_updating_sample_rate); _updating_sample_rate = true; - if (!(gvar_dict = dev_inst->list_config(NULL, SR_CONF_SAMPLERATE))) - { + try { + gvar_dict = device->config_list(ConfigKey::SAMPLERATE); + } catch (Error error) { _sample_rate.show_none(); _updating_sample_rate = false; return; } - if ((gvar_list = g_variant_lookup_value(gvar_dict, + if ((gvar_list = g_variant_lookup_value(gvar_dict.gobj(), "samplerate-steps", G_VARIANT_TYPE("at")))) { elements = (const uint64_t *)g_variant_get_fixed_array( @@ -209,7 +213,7 @@ void SamplingBar::update_sample_rate_selector() _sample_rate.show_min_max_step(min, max, step); } } - else if ((gvar_list = g_variant_lookup_value(gvar_dict, + else if ((gvar_list = g_variant_lookup_value(gvar_dict.gobj(), "samplerates", G_VARIANT_TYPE("at")))) { elements = (const uint64_t *)g_variant_get_fixed_array( @@ -219,44 +223,39 @@ void SamplingBar::update_sample_rate_selector() } _updating_sample_rate = false; - g_variant_unref(gvar_dict); update_sample_rate_selector_value(); } void SamplingBar::update_sample_rate_selector_value() { - GVariant *gvar; - uint64_t samplerate; - if (_updating_sample_rate) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + const shared_ptr device = get_selected_device(); + if (!device) return; - if (!(gvar = dev_inst->get_config(NULL, SR_CONF_SAMPLERATE))) { + try { + auto gvar = device->config_get(ConfigKey::SAMPLERATE); + uint64_t samplerate = + Glib::VariantBase::cast_dynamic>(gvar).get(); + assert(!_updating_sample_rate); + _updating_sample_rate = true; + _sample_rate.set_value(samplerate); + _updating_sample_rate = false; + } catch (Error error) { qDebug() << "WARNING: Failed to get value of sample rate"; return; } - samplerate = g_variant_get_uint64(gvar); - g_variant_unref(gvar); - - assert(!_updating_sample_rate); - _updating_sample_rate = true; - _sample_rate.set_value(samplerate); - _updating_sample_rate = false; } void SamplingBar::update_sample_count_selector() { - GVariant *gvar; - if (_updating_sample_count) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + const shared_ptr device = get_selected_device(); + if (!device) return; assert(!_updating_sample_count); @@ -264,16 +263,18 @@ void SamplingBar::update_sample_count_selector() if (_sample_count_supported) { - uint64_t sample_count = DefaultSampleCount; + uint64_t sample_count = _sample_count.value(); uint64_t min_sample_count = 0; uint64_t max_sample_count = MaxSampleCount; - if ((gvar = dev_inst->list_config(NULL, SR_CONF_LIMIT_SAMPLES))) - { - g_variant_get(gvar, "(tt)", + if (sample_count == 0) + sample_count = DefaultSampleCount; + + try { + auto gvar = device->config_list(ConfigKey::LIMIT_SAMPLES); + g_variant_get(gvar.gobj(), "(tt)", &min_sample_count, &max_sample_count); - g_variant_unref(gvar); - } + } catch (Error error) {} min_sample_count = min(max(min_sample_count, MinSampleCount), max_sample_count); @@ -281,16 +282,14 @@ void SamplingBar::update_sample_count_selector() _sample_count.show_125_list( min_sample_count, max_sample_count); - if ((gvar = dev_inst->get_config(NULL, SR_CONF_LIMIT_SAMPLES))) - { - sample_count = g_variant_get_uint64(gvar); + try { + auto gvar = device->config_get(ConfigKey::LIMIT_SAMPLES); + sample_count = g_variant_get_uint64(gvar.gobj()); if (sample_count == 0) sample_count = DefaultSampleCount; sample_count = min(max(sample_count, MinSampleCount), max_sample_count); - - g_variant_unref(gvar); - } + } catch (Error error) {} _sample_count.set_value(sample_count); } @@ -300,6 +299,61 @@ void SamplingBar::update_sample_count_selector() _updating_sample_count = false; } +void SamplingBar::update_device_config_widgets() +{ + using namespace pv::popups; + + const shared_ptr device = get_selected_device(); + if (!device) + return; + + // Update the configure popup + DeviceOptions *const opts = new DeviceOptions(device, this); + _configure_button_action->setVisible( + !opts->binding().properties().empty()); + _configure_button.set_popup(opts); + + // Update the channels popup + Channels *const channels = new Channels(_session, this); + _channels_button.set_popup(channels); + + // Update supported options. + _sample_count_supported = false; + + try { + for (auto entry : device->config_keys(ConfigKey::DEVICE_OPTIONS)) + { + auto key = entry.first; + auto capabilities = entry.second; + switch (key->id()) { + case SR_CONF_LIMIT_SAMPLES: + if (capabilities.count(Capability::SET)) + _sample_count_supported = true; + break; + case SR_CONF_LIMIT_FRAMES: + if (capabilities.count(Capability::SET)) + { + device->config_set(ConfigKey::LIMIT_FRAMES, + Glib::Variant::create(1)); + on_config_changed(); + } + break; + default: + break; + } + } + } catch (Error error) {} + + // Add notification of reconfigure events + disconnect(this, SLOT(on_config_changed())); + connect(&opts->binding(), SIGNAL(config_changed()), + this, SLOT(on_config_changed())); + + // Update sweep timing widgets. + update_sample_count_selector(); + update_sample_rate_selector(); +} + void SamplingBar::commit_sample_count() { uint64_t sample_count = 0; @@ -307,8 +361,8 @@ void SamplingBar::commit_sample_count() if (_updating_sample_count) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + const shared_ptr device = get_selected_device(); + if (!device) return; sample_count = _sample_count.value(); @@ -316,10 +370,16 @@ void SamplingBar::commit_sample_count() // Set the sample count assert(!_updating_sample_count); _updating_sample_count = true; - if (!dev_inst->set_config(NULL, SR_CONF_LIMIT_SAMPLES, - g_variant_new_uint64(sample_count))) { - qDebug() << "Failed to configure sample count."; - return; + if (_sample_count_supported) + { + try { + device->config_set(ConfigKey::LIMIT_SAMPLES, + Glib::Variant::create(sample_count)); + on_config_changed(); + } catch (Error error) { + qDebug() << "Failed to configure sample count."; + return; + } } _updating_sample_count = false; } @@ -331,8 +391,8 @@ void SamplingBar::commit_sample_rate() if (_updating_sample_rate) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + const shared_ptr device = get_selected_device(); + if (!device) return; sample_rate = _sample_rate.value(); @@ -342,8 +402,11 @@ void SamplingBar::commit_sample_rate() // Set the samplerate assert(!_updating_sample_rate); _updating_sample_rate = true; - if (!dev_inst->set_config(NULL, SR_CONF_SAMPLERATE, - g_variant_new_uint64(sample_rate))) { + try { + device->config_set(ConfigKey::SAMPLERATE, + Glib::Variant::create(sample_rate)); + on_config_changed(); + } catch (Error error) { qDebug() << "Failed to configure samplerate."; return; } @@ -352,60 +415,16 @@ void SamplingBar::commit_sample_rate() void SamplingBar::on_device_selected() { - GVariant *gvar; - - using namespace pv::popups; - if (_updating_device_selector) return; - const shared_ptr dev_inst = get_selected_device(); - if (!dev_inst) + shared_ptr device = get_selected_device(); + if (!device) return; - _session.set_device(dev_inst); + _session.set_device(device); - // Update the configure popup - DeviceOptions *const opts = new DeviceOptions(dev_inst, this); - _configure_button_action->setVisible( - !opts->binding().properties().empty()); - _configure_button.set_popup(opts); - - // Update the probes popup - Probes *const probes = new Probes(_session, this); - _probes_button.set_popup(probes); - - // Update supported options. - _sample_count_supported = false; - - if ((gvar = dev_inst->list_config(NULL, SR_CONF_DEVICE_OPTIONS))) - { - gsize num_opts; - const int *const options = - (const int32_t *)g_variant_get_fixed_array( - gvar, &num_opts, sizeof(int32_t)); - for (unsigned int i = 0; i < num_opts; i++) - { - switch (options[i]) { - case SR_CONF_LIMIT_SAMPLES: - _sample_count_supported = true; - break; - case SR_CONF_LIMIT_FRAMES: - dev_inst->set_config(NULL, SR_CONF_LIMIT_FRAMES, - g_variant_new_uint64(1)); - break; - } - } - } - - // Add notification of reconfigure events - disconnect(this, SLOT(on_config_changed())); - connect(dev_inst.get(), SIGNAL(config_changed()), - this, SLOT(on_config_changed())); - - // Update sweep timing widgets. - update_sample_count_selector(); - update_sample_rate_selector(); + update_device_config_widgets(); } void SamplingBar::on_sample_count_changed() @@ -433,5 +452,21 @@ void SamplingBar::on_config_changed() update_sample_rate_selector(); } +bool SamplingBar::eventFilter(QObject *watched, QEvent *event) +{ + if ((watched == &_sample_count || watched == &_sample_rate) && + (event->type() == QEvent::ToolTip)) { + double sec = (double)_sample_count.value() / _sample_rate.value(); + QHelpEvent *help_event = static_cast(event); + + QString str = tr("Total sampling time: %1").arg(pv::util::format_second(sec)); + QToolTip::showText(help_event->globalPos(), str); + + return true; + } + + return false; +} + } // namespace toolbars } // namespace pv