X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fstoresession.cpp;h=eaa17ea5f98096519f88f44be1373a8a697c171c;hp=309fa1b37062c8facf922bccbc5f433418cd23bb;hb=09f55d9665efb3b17ba7de4bae47be6989e884fe;hpb=d2fc6be9af3ba409032da6dcabc4630c657bb56c

diff --git a/pv/storesession.cpp b/pv/storesession.cpp
index 309fa1b3..eaa17ea5 100644
--- a/pv/storesession.cpp
+++ b/pv/storesession.cpp
@@ -14,8 +14,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <cassert>
@@ -32,10 +31,12 @@
 
 #include <pv/devicemanager.hpp>
 #include <pv/session.hpp>
+#include <pv/data/analog.hpp>
+#include <pv/data/analogsegment.hpp>
 #include <pv/data/logic.hpp>
 #include <pv/data/logicsegment.hpp>
+#include <pv/data/signalbase.hpp>
 #include <pv/devices/device.hpp>
-#include <pv/view/signal.hpp>
 
 #include <libsigrokcxx/libsigrokcxx.hpp>
 
@@ -60,6 +61,7 @@ using std::vector;
 
 using Glib::VariantBase;
 
+using sigrok::ChannelType;
 using sigrok::ConfigKey;
 using sigrok::Error;
 using sigrok::OutputFormat;
@@ -103,54 +105,73 @@ const QString& StoreSession::error() const
 
 bool StoreSession::start()
 {
-	const unordered_set< shared_ptr<view::Signal> > sigs(session_.signals());
+	const unordered_set< shared_ptr<data::SignalBase> > sigs(session_.signalbases());
 
-	// Add enabled channels to the data set
-	set< shared_ptr<data::SignalData> > data_set;
+	shared_ptr<data::Segment> any_segment;
+	shared_ptr<data::LogicSegment> lsegment;
+	vector< shared_ptr<data::SignalBase> > achannel_list;
+	vector< shared_ptr<data::AnalogSegment> > asegment_list;
 
-	for (shared_ptr<view::Signal> signal : sigs)
-		if (signal->enabled())
-			data_set.insert(signal->data());
+	for (shared_ptr<data::SignalBase> signal : sigs) {
+		if (!signal->enabled())
+			continue;
 
-	// Check we have logic data
-	if (data_set.empty() || sigs.empty()) {
-		error_ = tr("No data to save.");
-		return false;
-	}
+		if (signal->type() == ChannelType::LOGIC) {
+			// All logic channels share the same data segments
+			shared_ptr<data::Logic> ldata = signal->logic_data();
 
-	if (data_set.size() > 1) {
-		error_ = tr("PulseView currently only has support for "
-			"storing a single data stream.");
-		return false;
-	}
+			const deque< shared_ptr<data::LogicSegment> > &lsegments =
+				ldata->logic_segments();
 
-	// Get the logic data
-	shared_ptr<data::Logic> data;
-	if (!(data = dynamic_pointer_cast<data::Logic>(*data_set.begin()))) {
-		error_ = tr("PulseView currently only has support for "
-			"storing logic data.");
-		return false;
-	}
+			if (lsegments.empty()) {
+				error_ = tr("Can't save logic channel without data.");
+				return false;
+			}
 
-	// Get the segment
-	const deque< shared_ptr<data::LogicSegment> > &segments =
-		data->logic_segments();
+			lsegment = lsegments.front();
+			any_segment = lsegment;
+		}
 
-	if (segments.empty()) {
-		error_ = tr("No segments to save.");
-		return false;
+		if (signal->type() == ChannelType::ANALOG) {
+			// Each analog channel has its own segments
+			shared_ptr<data::Analog> adata = signal->analog_data();
+
+			const deque< shared_ptr<data::AnalogSegment> > &asegments =
+				adata->analog_segments();
+
+			if (asegments.empty()) {
+				error_ = tr("Can't save analog channel without data.");
+				return false;
+			}
+
+			asegment_list.push_back(asegments.front());
+			any_segment = asegments.front();
+
+			achannel_list.push_back(signal);
+		}
 	}
 
-	const shared_ptr<data::LogicSegment> segment(segments.front());
-	assert(segment);
+	if (!any_segment) {
+		error_ = tr("No channels enabled.");
+		return false;
+	}
 
 	// Check whether the user wants to export a certain sample range
+	uint64_t end_sample;
+
 	if (sample_range_.first == sample_range_.second) {
 		start_sample_ = 0;
-		sample_count_ = segment->get_sample_count();
+		sample_count_ =	any_segment->get_sample_count();
 	} else {
-		start_sample_ = std::min(sample_range_.first, sample_range_.second);
-		sample_count_ = std::abs(sample_range_.second - sample_range_.first);
+		if (sample_range_.first > sample_range_.second) {
+			start_sample_ = sample_range_.second;
+			end_sample = min(sample_range_.first, any_segment->get_sample_count());
+			sample_count_ = end_sample - start_sample_;
+		} else {
+			start_sample_ = sample_range_.first;
+			end_sample = min(sample_range_.second, any_segment->get_sample_count());
+			sample_count_ = end_sample - start_sample_;
+		}
 	}
 
 	// Begin storing
@@ -167,14 +188,15 @@ bool StoreSession::start()
 		output_ = output_format_->create_output(file_name_, device, options);
 		auto meta = context->create_meta_packet(
 			{{ConfigKey::SAMPLERATE, Glib::Variant<guint64>::create(
-				segment->samplerate())}});
+				any_segment->samplerate())}});
 		output_->receive(meta);
 	} catch (Error error) {
-		error_ = tr("Error while saving.");
+		error_ = tr("Error while saving: ") + error.what();
 		return false;
 	}
 
-	thread_ = std::thread(&StoreSession::store_proc, this, segment);
+	thread_ = std::thread(&StoreSession::store_proc, this,
+		achannel_list, asegment_list, lsegment);
 	return true;
 }
 
@@ -189,47 +211,84 @@ void StoreSession::cancel()
 	interrupt_ = true;
 }
 
-void StoreSession::store_proc(shared_ptr<data::LogicSegment> segment)
+void StoreSession::store_proc(vector< shared_ptr<data::SignalBase> > achannel_list,
+	vector< shared_ptr<data::AnalogSegment> > asegment_list,
+	shared_ptr<data::LogicSegment> lsegment)
 {
-	assert(segment);
-
 	unsigned progress_scale = 0;
 
 	/// TODO: Wrap this in a std::unique_ptr when we transition to C++11
-	uint8_t *const data = new uint8_t[BlockSize];
-	assert(data);
-
-	const int unit_size = segment->unit_size();
-	assert(unit_size != 0);
+	uint8_t *const ldata = new uint8_t[BlockSize];
+	assert(ldata);
+
+	int aunit_size = 0;
+	int lunit_size = 0;
+	unsigned int lsamples_per_block = INT_MAX;
+	unsigned int asamples_per_block = INT_MAX;
+
+	if (!asegment_list.empty()) {
+		// We assume all analog channels use the sample unit size
+		aunit_size = asegment_list.front()->unit_size();
+		asamples_per_block = BlockSize / aunit_size;
+	}
+	if (lsegment) {
+		lunit_size = lsegment->unit_size();
+		lsamples_per_block = BlockSize / lunit_size;
+	}
 
-	// Qt needs the progress values to fit inside an int.  If they would
+	// Qt needs the progress values to fit inside an int. If they would
 	// not, scale the current and max values down until they do.
 	while ((sample_count_ >> progress_scale) > INT_MAX)
 		progress_scale ++;
 
 	unit_count_ = sample_count_ >> progress_scale;
 
-	const unsigned int samples_per_block = BlockSize / unit_size;
+	const unsigned int samples_per_block =
+		std::min(asamples_per_block, lsamples_per_block);
 
-	while (!interrupt_ && sample_count_)
-	{
+	while (!interrupt_ && sample_count_) {
 		progress_updated();
 
 		const uint64_t packet_len =
 			std::min((uint64_t)samples_per_block, sample_count_);
 
-		segment->get_samples(data, start_sample_, start_sample_ + packet_len);
-
-		size_t length = packet_len * unit_size;
-
 		try {
 			const auto context = session_.device_manager().context();
-			auto logic = context->create_logic_packet(data, length, unit_size);
-			const string data = output_->receive(logic);
-			if (output_stream_.is_open())
-				output_stream_ << data;
+
+			for (unsigned int i = 0; i < achannel_list.size(); i++) {
+				shared_ptr<sigrok::Channel> achannel = (achannel_list.at(i))->channel();
+				shared_ptr<data::AnalogSegment> asegment = asegment_list.at(i);
+
+				const float *adata =
+					asegment->get_samples(start_sample_, start_sample_ + packet_len);
+
+				// The srzip format currently only supports packets with one
+				// analog channel. See zip_append_analog() in srzip.c
+				auto analog = context->create_analog_packet(
+					vector<shared_ptr<sigrok::Channel> >{achannel},
+					(float *)adata, packet_len,
+					sigrok::Quantity::VOLTAGE, sigrok::Unit::VOLT,
+					vector<const sigrok::QuantityFlag *>());
+				const string adata_str = output_->receive(analog);
+
+				if (output_stream_.is_open())
+					output_stream_ << adata_str;
+
+				delete[] adata;
+			}
+
+			if (lsegment) {
+				lsegment->get_samples(ldata, start_sample_, start_sample_ + packet_len);
+
+				const size_t length = packet_len * lunit_size;
+				auto logic = context->create_logic_packet(ldata, length, lunit_size);
+				const string ldata_str = output_->receive(logic);
+
+				if (output_stream_.is_open())
+					output_stream_ << ldata_str;
+			}
 		} catch (Error error) {
-			error_ = tr("Error while saving.");
+			error_ = tr("Error while saving: ") + error.what();
 			break;
 		}
 
@@ -241,12 +300,13 @@ void StoreSession::store_proc(shared_ptr<data::LogicSegment> segment)
 	// Zeroing the progress variables indicates completion
 	units_stored_ = unit_count_ = 0;
 
+	store_successful();
 	progress_updated();
 
 	output_.reset();
 	output_stream_.close();
 
-	delete[] data;
+	delete[] ldata;
 }
 
 } // pv