X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fsigsession.cpp;h=abe9b2dae0f7176f33c3d95726f6a5554f1a03de;hp=81ccca720a0b38ca7d5d0a2b58b926f8e91c51ed;hb=c19bccc8c0ce0f788f06258e3cec12c85517e026;hpb=8d634081d8b0cc741dd34d8c646474ff6754aea8

diff --git a/pv/sigsession.cpp b/pv/sigsession.cpp
index 81ccca72..abe9b2da 100644
--- a/pv/sigsession.cpp
+++ b/pv/sigsession.cpp
@@ -44,6 +44,10 @@ SigSession::SigSession()
 
 SigSession::~SigSession()
 {
+	if(_sampling_thread.get())
+		_sampling_thread->join();
+	_sampling_thread.reset();
+
 	// TODO: This should not be necessary
 	_session = NULL;
 }
@@ -61,6 +65,29 @@ void SigSession::load_file(const std::string &name)
 
 void SigSession::start_capture(struct sr_dev_inst *sdi,
 	uint64_t record_length, uint64_t sample_rate)
+{
+	// Check sampling isn't already active
+	if(_sampling_thread.get())
+		_sampling_thread->join();
+
+	_sampling_thread.reset(new boost::thread(
+		&SigSession::sample_thread_proc, this, sdi,
+		record_length, sample_rate));
+}
+
+vector< shared_ptr<view::Signal> > SigSession::get_signals()
+{
+	lock_guard<mutex> lock(_signals_mutex);
+	return _signals;
+}
+
+boost::shared_ptr<LogicData> SigSession::get_data()
+{
+	return _logic_data;
+}
+
+void SigSession::sample_thread_proc(struct sr_dev_inst *sdi,
+	uint64_t record_length, uint64_t sample_rate)
 {
 	sr_session_new();
 	sr_session_datafeed_callback_add(data_feed_in_proc);
@@ -94,16 +121,6 @@ void SigSession::start_capture(struct sr_dev_inst *sdi,
 	sr_session_destroy();
 }
 
-vector< shared_ptr<view::Signal> >& SigSession::get_signals()
-{
-	return _signals;
-}
-
-boost::shared_ptr<LogicData> SigSession::get_data()
-{
-	return _logic_data;
-}
-
 void SigSession::data_feed_in(const struct sr_dev_inst *sdi,
 	struct sr_datafeed_packet *packet)
 {
@@ -114,43 +131,55 @@ void SigSession::data_feed_in(const struct sr_dev_inst *sdi,
 
 	switch (packet->type) {
 	case SR_DF_HEADER:
+	{
+		lock_guard<mutex> lock(_signals_mutex);
 		_signals.clear();
 		break;
+	}
 
 	case SR_DF_META_LOGIC:
-		{
-			assert(packet->payload);
+	{
+		assert(packet->payload);
+		const sr_datafeed_meta_logic &meta_logic =
+			*(sr_datafeed_meta_logic*)packet->payload;
 
-			const sr_datafeed_meta_logic &meta_logic =
-				*(sr_datafeed_meta_logic*)packet->payload;
+	{
+		lock_guard<mutex> lock(_data_mutex);
 
-			// Create an empty LogiData for coming data snapshots
-			_logic_data.reset(new LogicData(meta_logic));
-			assert(_logic_data);
-			if(!_logic_data)
-				break;
+		// Create an empty LogiData for coming data snapshots
+		_logic_data.reset(new LogicData(meta_logic));
+		assert(_logic_data);
+		if(!_logic_data)
+			break;
+	}
+
+	{
+		lock_guard<mutex> lock(_signals_mutex);
 
-			// Add the signals
-			for (int i = 0; i < meta_logic.num_probes; i++)
+		// Add the signals
+		for (int i = 0; i < meta_logic.num_probes; i++)
+		{
+			const sr_probe *const probe =
+				(const sr_probe*)g_slist_nth_data(
+					sdi->probes, i);
+			if(probe->enabled)
 			{
-				const sr_probe *const probe =
-					(const sr_probe*)g_slist_nth_data(
-						sdi->probes, i);
-				if(probe->enabled)
-				{
-					shared_ptr<LogicSignal> signal(
-						new LogicSignal(probe->name,
-							_logic_data,
-							probe->index));
-					_signals.push_back(signal);
-				}
+				shared_ptr<LogicSignal> signal(
+					new LogicSignal(probe->name,
+						_logic_data,
+						probe->index));
+				_signals.push_back(signal);
 			}
-
-			break;
 		}
 
-	case SR_DF_LOGIC:
+		signals_changed();
+		break;
+	}
+	}
 
+	case SR_DF_LOGIC:
+	{
+		lock_guard<mutex> lock(_data_mutex);
 		assert(packet->payload);
 		if(!_cur_logic_snapshot)
 		{
@@ -167,13 +196,20 @@ void SigSession::data_feed_in(const struct sr_dev_inst *sdi,
 				*(sr_datafeed_logic*)packet->payload);
 		}
 
+		data_updated();
 		break;
+	}
 
 	case SR_DF_END:
-		_cur_logic_snapshot.reset();
+	{
+		{
+			lock_guard<mutex> lock(_data_mutex);
+			_cur_logic_snapshot.reset();
+		}
 		data_updated();
 		break;
 	}
+	}
 }
 
 void SigSession::data_feed_in_proc(const struct sr_dev_inst *sdi,