X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fsession.cpp;h=08bec08e4a5f664b87c0c30f2333c603861ce9fd;hp=2a4814f807e2be19fe0c4aeef93d5abfb982e13f;hb=5237f0c50352b523c6a0c3d7f931081ecdbdecaa;hpb=4365a4406b5a81a12c6a7d0fbaed01f6d59df882 diff --git a/pv/session.cpp b/pv/session.cpp index 2a4814f8..08bec08e 100644 --- a/pv/session.cpp +++ b/pv/session.cpp @@ -169,15 +169,15 @@ void Session::start_capture(function error_handler) // Check that at least one channel is enabled assert(device_); - const std::shared_ptr device = device_->device(); - assert(device); - auto channels = device->channels(); - bool enabled = std::any_of(channels.begin(), channels.end(), - [](shared_ptr channel) { return channel->enabled(); }); - - if (!enabled) { - error_handler(tr("No channels enabled.")); - return; + const shared_ptr sr_dev = device_->device(); + if (sr_dev) { + const auto channels = sr_dev->channels(); + if (!std::any_of(channels.begin(), channels.end(), + [](shared_ptr channel) { + return channel->enabled(); })) { + error_handler(tr("No channels enabled.")); + return; + } } // Begin the session @@ -305,7 +305,8 @@ void Session::set_capture_state(capture_state state) void Session::update_signals() { assert(device_); - assert(capture_state_ == Stopped); + + lock_guard lock(data_mutex_); const shared_ptr sr_dev = device_->device(); if (!sr_dev) { @@ -414,7 +415,7 @@ void Session::sample_thread_proc(shared_ptr device, cur_samplerate_ = device_->read_config(ConfigKey::SAMPLERATE); try { - device_->session()->start(); + device_->start(); } catch(Error e) { error_handler(e.what()); return; @@ -467,8 +468,10 @@ void Session::feed_in_logic(shared_ptr logic) if (!logic_data_) { - qDebug() << "Unexpected logic packet"; - return; + // The only reason logic_data_ would not have been created is + // if it was not possible to determine the signals when the + // device was created. + update_signals(); } if (!cur_logic_segment_)