X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fprop%2Fenum.cpp;h=412a31b0827854d01d103d5f110325b7717faaad;hp=54fe5fedca8284b15dc2f051a44a7f5e3e1dba22;hb=b1fe148e0dce6e369c9d4770ca935a6a9ec94b59;hpb=793f8096c486d0fba871227d9772a510f7496c08

diff --git a/pv/prop/enum.cpp b/pv/prop/enum.cpp
index 54fe5fed..412a31b0 100644
--- a/pv/prop/enum.cpp
+++ b/pv/prop/enum.cpp
@@ -31,35 +31,41 @@ namespace pv {
 namespace prop {
 
 Enum::Enum(QString name,
-	vector<pair<const void*, QString> > values,
-	function<const void* ()> getter,
-	function<void (const void*)> setter) :
-	Property(name),
+	vector<pair<GVariant*, QString> > values,
+	Getter getter, Setter setter) :
+	Property(name, getter, setter),
 	_values(values),
-	_getter(getter),
-	_setter(setter),
 	_selector(NULL)
 {
 }
 
-QWidget* Enum::get_widget(QWidget *parent)
+Enum::~Enum()
+{
+	for (unsigned int i = 0; i < _values.size(); i++)
+		g_variant_unref(_values[i].first);
+}
+
+QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
 {
 	if (_selector)
 		return _selector;
 
-	const void *value = NULL;
-	if (_getter)
-		value = _getter();
+	GVariant *const value = _getter ? _getter() : NULL;
 
 	_selector = new QComboBox(parent);
 	for (unsigned int i = 0; i < _values.size(); i++) {
-		const pair<const void*, QString> &v = _values[i];
-		_selector->addItem(v.second,
-			qVariantFromValue((void*)v.first));
-		if (v.first == value)
+		const pair<GVariant*, QString> &v = _values[i];
+		_selector->addItem(v.second, qVariantFromValue((void*)v.first));
+		if (value && g_variant_equal(v.first, value))
 			_selector->setCurrentIndex(i);
 	}
 
+	g_variant_unref(value);
+
+	if (auto_commit)
+		connect(_selector, SIGNAL(currentIndexChanged(int)),
+			this, SLOT(on_current_item_changed(int)));
+
 	return _selector;
 }
 
@@ -74,7 +80,12 @@ void Enum::commit()
 	if (index < 0)
 		return;
 
-	_setter(_selector->itemData(index).value<void*>());
+	_setter((GVariant*)_selector->itemData(index).value<void*>());
+}
+
+void Enum::on_current_item_changed(int)
+{
+	commit();
 }
 
 } // prop