X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fprop%2Fdouble.cpp;h=f4e6e443a5bb6f2e7dcf27fe29053f6daed50090;hp=fa5e5688148bc8f07fe089f88ed3be161a1fab11;hb=cc9a7898ee7afc32e03dbcc991ed7ba722ed8f1b;hpb=819f4c25391a9c74d3d2f528d462142d5c4aad4d diff --git a/pv/prop/double.cpp b/pv/prop/double.cpp index fa5e5688..f4e6e443 100644 --- a/pv/prop/double.cpp +++ b/pv/prop/double.cpp @@ -22,7 +22,7 @@ #include -#include "double.h" +#include "double.hpp" using boost::optional; using std::pair; @@ -38,53 +38,54 @@ Double::Double(QString name, Getter getter, Setter setter) : Property(name, getter, setter), - _decimals(decimals), - _suffix(suffix), - _range(range), - _step(step), - _spin_box(NULL) -{ -} - -Double::~Double() + decimals_(decimals), + suffix_(suffix), + range_(range), + step_(step), + spin_box_(nullptr) { } QWidget* Double::get_widget(QWidget *parent, bool auto_commit) { - if (_spin_box) - return _spin_box; + if (spin_box_) + return spin_box_; + + if (!getter_) + return nullptr; + + Glib::VariantBase variant = getter_(); + if (!variant.gobj()) + return nullptr; - _spin_box = new QDoubleSpinBox(parent); - _spin_box->setDecimals(_decimals); - _spin_box->setSuffix(_suffix); - if (_range) - _spin_box->setRange(_range->first, _range->second); - if (_step) - _spin_box->setSingleStep(*_step); + double value = Glib::VariantBase::cast_dynamic>( + variant).get(); - GVariant *const value = _getter ? _getter() : NULL; + spin_box_ = new QDoubleSpinBox(parent); + spin_box_->setDecimals(decimals_); + spin_box_->setSuffix(suffix_); + if (range_) + spin_box_->setRange(range_->first, range_->second); + if (step_) + spin_box_->setSingleStep(*step_); - if (value) { - _spin_box->setValue(g_variant_get_double(value)); - g_variant_unref(value); - } + spin_box_->setValue(value); if (auto_commit) - connect(_spin_box, SIGNAL(valueChanged(double)), + connect(spin_box_, SIGNAL(valueChanged(double)), this, SLOT(on_value_changed(double))); - return _spin_box; + return spin_box_; } void Double::commit() { - assert(_setter); + assert(setter_); - if (!_spin_box) + if (!spin_box_) return; - _setter(g_variant_new_double(_spin_box->value())); + setter_(Glib::Variant::create(spin_box_->value())); } void Double::on_value_changed(double)