X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fprop%2Fdouble.cpp;h=c5ab1db4e28b5a83b98f33f030fc0124b4bef727;hp=c1e776e1f6c890c21d9d435cbc66316d8976e528;hb=765e7d335ab693f587d47b4242e6d72b679d683d;hpb=793f8096c486d0fba871227d9772a510f7496c08

diff --git a/pv/prop/double.cpp b/pv/prop/double.cpp
index c1e776e1..c5ab1db4 100644
--- a/pv/prop/double.cpp
+++ b/pv/prop/double.cpp
@@ -22,10 +22,10 @@
 
 #include <QDoubleSpinBox>
 
-#include "double.h"
+#include "double.hpp"
 
-using namespace std;
-using namespace boost;
+using boost::optional;
+using std::pair;
 
 namespace pv {
 namespace prop {
@@ -35,45 +35,66 @@ Double::Double(QString name,
 	QString suffix,
 	optional< pair<double, double> > range,
 	optional<double> step,
-	function<double ()> getter,
-	function<void (double)> setter) :
-	Property(name),
-	_decimals(decimals),
-	_suffix(suffix),
-	_range(range),
-	_step(step),
-	_getter(getter),
-	_setter(setter),
-	_spin_box(NULL)
+	Getter getter,
+	Setter setter) :
+	Property(name, getter, setter),
+	decimals_(decimals),
+	suffix_(suffix),
+	range_(range),
+	step_(step),
+	spin_box_(nullptr)
 {
 }
 
-QWidget* Double::get_widget(QWidget *parent)
+Double::~Double()
 {
-	if (_spin_box)
-		return _spin_box;
+}
+
+QWidget* Double::get_widget(QWidget *parent, bool auto_commit)
+{
+	if (spin_box_)
+		return spin_box_;
+
+	if (!getter_)
+		return nullptr;
+
+	Glib::VariantBase variant = getter_();
+	if (!variant.gobj())
+		return nullptr;
 
-	_spin_box = new QDoubleSpinBox(parent);
-	_spin_box->setDecimals(_decimals);
-	_spin_box->setSuffix(_suffix);
-	if (_range)
-		_spin_box->setRange(_range->first, _range->second);
-	if (_step)
-		_spin_box->setSingleStep(*_step);
+	double value = Glib::VariantBase::cast_dynamic<Glib::Variant<double>>(
+		variant).get();
 
-	_spin_box->setValue(_getter ? _getter() : 0.0);
+	spin_box_ = new QDoubleSpinBox(parent);
+	spin_box_->setDecimals(decimals_);
+	spin_box_->setSuffix(suffix_);
+	if (range_)
+		spin_box_->setRange(range_->first, range_->second);
+	if (step_)
+		spin_box_->setSingleStep(*step_);
 
-	return _spin_box;
+	spin_box_->setValue(value);
+
+	if (auto_commit)
+		connect(spin_box_, SIGNAL(valueChanged(double)),
+			this, SLOT(on_value_changed(double)));
+
+	return spin_box_;
 }
 
 void Double::commit()
 {
-	assert(_setter);
+	assert(setter_);
 
-	if (!_spin_box)
+	if (!spin_box_)
 		return;
 
-	_setter(_spin_box->value());
+	setter_(Glib::Variant<double>::create(spin_box_->value()));
+}
+
+void Double::on_value_changed(double)
+{
+	commit();
 }
 
 } // prop