X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fmainwindow.cpp;h=37b7bfcd3854792a40e639e8b5c8ab9a05baa05e;hp=183e841e804c3c6f48d37949268ec3227a0c70be;hb=4b53a1edfa2309a5b1f40f4adc78eff814fb0d15;hpb=3045c869ada2e32bf55cbb68633b5213b9b11e28

diff --git a/pv/mainwindow.cpp b/pv/mainwindow.cpp
index 183e841e..37b7bfcd 100644
--- a/pv/mainwindow.cpp
+++ b/pv/mainwindow.cpp
@@ -39,10 +39,10 @@
 #include "devicemanager.h"
 #include "dialogs/about.h"
 #include "dialogs/connect.h"
-#include "dialogs/decoder.h"
 #include "toolbars/samplingbar.h"
 #include "view/logicsignal.h"
 #include "view/view.h"
+#include "widgets/decodermenu.h"
 
 /* __STDC_FORMAT_MACROS is required for PRIu64 and friends (in C++). */
 #define __STDC_FORMAT_MACROS
@@ -66,8 +66,7 @@ MainWindow::MainWindow(DeviceManager &device_manager,
 	QWidget *parent) :
 	QMainWindow(parent),
 	_device_manager(device_manager),
-	_session(device_manager),
-	_decoders_add_mapper(this)
+	_session(device_manager)
 {
 	setup_ui();
 	if (open_file_name) {
@@ -178,14 +177,13 @@ void MainWindow::setup_ui()
 	_menu_decoders->setTitle(QApplication::translate(
 		"MainWindow", "&Decoders", 0, QApplication::UnicodeUTF8));
 
-	_menu_decoders_add = new QMenu(_menu_decoders);
+	_menu_decoders_add = new pv::widgets::DecoderMenu(_menu_decoders);
 	_menu_decoders_add->setTitle(QApplication::translate(
 		"MainWindow", "&Add", 0, QApplication::UnicodeUTF8));
-	setup_add_decoders(_menu_decoders_add);
+	connect(_menu_decoders_add, SIGNAL(decoder_selected(srd_decoder*)),
+		this, SLOT(add_decoder(srd_decoder*)));
 
 	_menu_decoders->addMenu(_menu_decoders_add);
-	connect(&_decoders_add_mapper, SIGNAL(mapped(QObject*)),
-		this, SLOT(add_decoder(QObject*)));
 
 	// Help Menu
 	_menu_help = new QMenu(_menu_bar);
@@ -287,28 +285,6 @@ void MainWindow::show_session_error(
 	msg.exec();
 }
 
-gint MainWindow::decoder_name_cmp(gconstpointer a, gconstpointer b)
-{
-	return strcmp(((const srd_decoder*)a)->name,
-		((const srd_decoder*)b)->name);
-}
-
-void MainWindow::setup_add_decoders(QMenu *parent)
-{
-	GSList *l = g_slist_sort(g_slist_copy(
-		(GSList*)srd_decoder_list()), decoder_name_cmp);
-	for(; l; l = l->next)
-	{
-		QAction *const action = parent->addAction(QString(
-			((srd_decoder*)l->data)->name));
-		action->setData(qVariantFromValue(l->data));
-		_decoders_add_mapper.setMapping(action, action);
-		connect(action, SIGNAL(triggered()),
-			&_decoders_add_mapper, SLOT(map()));
-	}
-	g_slist_free(l);
-}
-
 void MainWindow::on_actionOpen_triggered()
 {
 	// Enumerate the file formats
@@ -369,34 +345,10 @@ void MainWindow::on_actionAbout_triggered()
 	dlg.exec();
 }
 
-void MainWindow::add_decoder(QObject *action)
+void MainWindow::add_decoder(srd_decoder *decoder)
 {
-	assert(action);
-	srd_decoder *const dec =
-		(srd_decoder*)((QAction*)action)->data().value<void*>();
-	assert(dec);
-
-	vector< shared_ptr<view::LogicSignal> > logic_sigs;
-	const vector< shared_ptr<view::Signal> > &sigs =
-		_session.get_signals();
-	BOOST_FOREACH(shared_ptr<view::Signal> s, sigs) {
-		assert(s);
-		shared_ptr<view::LogicSignal> l =
-			dynamic_pointer_cast<view::LogicSignal>(s);
-		if (l)
-			logic_sigs.push_back(l);
-	}
-
-	GHashTable *const options = g_hash_table_new_full(g_str_hash,
-		g_str_equal, g_free, (GDestroyNotify)g_variant_unref);
-
-	dialogs::Decoder dlg(this, dec, logic_sigs, options);
-	if(dlg.exec() != QDialog::Accepted) {
-		g_hash_table_destroy(options);
-		return;
-	}
-
-	_session.add_decoder(dec, dlg.get_probes(), options);
+	assert(decoder);
+	_session.add_decoder(decoder);
 }
 
 void MainWindow::run_stop()