X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fdata%2Fsignalbase.cpp;h=6bcacd734a94f7e15e91d46fc285c6a2424f68d3;hp=949c8237572de2f09dfb0c9dbd162ba51bf1e735;hb=489953884c0d7692fa20748314751e114ae54cf2;hpb=12ea3616767553ee0a615f14bbcb8ec614589e34

diff --git a/pv/data/signalbase.cpp b/pv/data/signalbase.cpp
index 949c8237..6bcacd73 100644
--- a/pv/data/signalbase.cpp
+++ b/pv/data/signalbase.cpp
@@ -20,14 +20,14 @@
 
 #include "analog.hpp"
 #include "analogsegment.hpp"
+#include "decode/row.hpp"
 #include "logic.hpp"
 #include "logicsegment.hpp"
 #include "signalbase.hpp"
 #include "signaldata.hpp"
-#include "decode/row.hpp"
 
-#include <pv/session.hpp>
 #include <pv/binding/decoder.hpp>
+#include <pv/session.hpp>
 
 using std::dynamic_pointer_cast;
 using std::make_shared;
@@ -37,7 +37,7 @@ using std::tie;
 namespace pv {
 namespace data {
 
-const int SignalBase::ColourBGAlpha = 8*256/100;
+const int SignalBase::ColourBGAlpha = 8 * 256 / 100;
 
 SignalBase::SignalBase(shared_ptr<sigrok::Channel> channel, ChannelType channel_type) :
 	channel_(channel),
@@ -240,10 +240,9 @@ uint8_t SignalBase::convert_a2l_threshold(float threshold, float value)
 	return (value >= threshold) ? 1 : 0;
 }
 
-uint8_t SignalBase::convert_a2l_schmitt_trigger(float lo_thr, float hi_thr, float value)
+uint8_t SignalBase::convert_a2l_schmitt_trigger(float lo_thr, float hi_thr,
+	float value, uint8_t &state)
 {
-	static uint8_t state = 0;
-
 	if (value < lo_thr)
 		state = 0;
 	else if (value > hi_thr)
@@ -325,12 +324,13 @@ void SignalBase::conversion_thread_proc(QObject* segment, uint64_t start_sample,
 			const float amplitude = max_v - min_v;
 			const float lo_thr = min_v + (amplitude * 0.1);  // 10% above min
 			const float hi_thr = max_v - (amplitude * 0.1);  // 10% below max
+			uint8_t state = 0;  // TODO Use value of logic sample n-1 instead of 0
 
 			// Convert as many sample blocks as we can
 			while ((end_sample - i) > block_size) {
 				const float* asamples = asegment->get_samples(i, i + block_size);
 				for (uint32_t j = 0; j < block_size; j++)
-					lsamples.push_back(convert_a2l_schmitt_trigger(lo_thr, hi_thr, asamples[j]));
+					lsamples.push_back(convert_a2l_schmitt_trigger(lo_thr, hi_thr, asamples[j], state));
 				lsegment->append_payload(lsamples.data(), lsamples.size());
 				i += block_size;
 				lsamples.clear();
@@ -340,7 +340,7 @@ void SignalBase::conversion_thread_proc(QObject* segment, uint64_t start_sample,
 			// Convert remaining samples
 			const float* asamples = asegment->get_samples(i, end_sample);
 			for (uint32_t j = 0; j < (end_sample - i); j++)
-				lsamples.push_back(convert_a2l_schmitt_trigger(lo_thr, hi_thr, asamples[j]));
+				lsamples.push_back(convert_a2l_schmitt_trigger(lo_thr, hi_thr, asamples[j], state));
 			lsegment->append_payload(lsamples.data(), lsamples.size());
 			delete[] asamples;
 		}
@@ -398,6 +398,5 @@ void SignalBase::on_capture_state_changed(int state)
 	}
 }
 
-
 } // namespace data
 } // namespace pv