X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fbinding%2Finputoutput.cpp;h=9ba387fbc0cb01a01854010463848ae0dbf3c3ce;hp=9d2299afaf95fd767a5d7142fb71a606e3d97f0f;hb=HEAD;hpb=bb19aac49414cc772a2a1e52730cbb2ca24b425c

diff --git a/pv/binding/inputoutput.cpp b/pv/binding/inputoutput.cpp
index 9d2299af..9ba387fb 100644
--- a/pv/binding/inputoutput.cpp
+++ b/pv/binding/inputoutput.cpp
@@ -35,7 +35,6 @@
 
 using boost::none;
 
-using std::make_pair;
 using std::map;
 using std::pair;
 using std::shared_ptr;
@@ -60,12 +59,13 @@ namespace binding {
 InputOutput::InputOutput(
 	const map<string, shared_ptr<Option>> &options)
 {
-	for (pair<string, shared_ptr<Option>> o : options) {
+	for (const pair<const string, shared_ptr<Option>>& o : options) {
 		const shared_ptr<Option> &opt = o.second;
 		assert(opt);
 
 		const QString name = QString::fromStdString(opt->name());
 		const QString desc = QString::fromStdString(opt->description());
+
 		const VariantBase def_val = opt->default_value();
 		const vector<VariantBase> values = opt->values();
 
@@ -111,7 +111,7 @@ shared_ptr<Property> InputOutput::bind_enum(
 {
 	vector< pair<VariantBase, QString> > enum_vals;
 	for (VariantBase var : values)
-		enum_vals.push_back(make_pair(var, print_gvariant(var)));
+		enum_vals.emplace_back(var, print_gvariant(var));
 	return shared_ptr<Property>(new Enum(name, desc, enum_vals, getter, setter));
 }