X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fbinding%2Finputoutput.cpp;h=9ba387fbc0cb01a01854010463848ae0dbf3c3ce;hp=42ebf06263539bc582f16a7b1d27e2fbcf128bec;hb=HEAD;hpb=0c9136370d062b08e47657e12f77518197d89339

diff --git a/pv/binding/inputoutput.cpp b/pv/binding/inputoutput.cpp
index 42ebf062..9ba387fb 100644
--- a/pv/binding/inputoutput.cpp
+++ b/pv/binding/inputoutput.cpp
@@ -14,8 +14,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <cassert>
@@ -26,6 +25,7 @@
 
 #include <libsigrokcxx/libsigrokcxx.hpp>
 
+#include <pv/prop/bool.hpp>
 #include <pv/prop/double.hpp>
 #include <pv/prop/enum.hpp>
 #include <pv/prop/int.hpp>
@@ -35,7 +35,6 @@
 
 using boost::none;
 
-using std::make_pair;
 using std::map;
 using std::pair;
 using std::shared_ptr;
@@ -47,6 +46,7 @@ using Glib::VariantType;
 
 using sigrok::Option;
 
+using pv::prop::Bool;
 using pv::prop::Double;
 using pv::prop::Enum;
 using pv::prop::Int;
@@ -59,17 +59,18 @@ namespace binding {
 InputOutput::InputOutput(
 	const map<string, shared_ptr<Option>> &options)
 {
-	for (pair<string, shared_ptr<Option>> o : options)
-	{
+	for (const pair<const string, shared_ptr<Option>>& o : options) {
 		const shared_ptr<Option> &opt = o.second;
 		assert(opt);
 
 		const QString name = QString::fromStdString(opt->name());
+		const QString desc = QString::fromStdString(opt->description());
+
 		const VariantBase def_val = opt->default_value();
 		const vector<VariantBase> values = opt->values();
 
 		options_[opt->id()] = def_val;
- 
+
 		const Property::Getter get = [&, opt]() {
 			return options_[opt->id()]; };
 		const Property::Setter set = [&, opt](VariantBase value) {
@@ -78,16 +79,20 @@ InputOutput::InputOutput(
 		shared_ptr<Property> prop;
 
 		if (!opt->values().empty())
-			prop = bind_enum(name, values, get, set);
+			prop = bind_enum(name, desc, values, get, set);
+		else if (def_val.is_of_type(VariantType("b")))
+			prop = shared_ptr<Property>(new Bool(name, desc, get, set));
 		else if (def_val.is_of_type(VariantType("d")))
-			prop = shared_ptr<Property>(new Double(name, 2, "",
-				nullptr, nullptr, get, set));
-		else if (def_val.is_of_type(VariantType("u")))
+			prop = shared_ptr<Property>(new Double(name, desc, 2, "",
+				none, none, get, set));
+		else if (def_val.is_of_type(VariantType("i")) ||
+			def_val.is_of_type(VariantType("t")) ||
+			def_val.is_of_type(VariantType("u")))
 			prop = shared_ptr<Property>(
-				new Int(name, "", none, get, set));
+				new Int(name, desc, "", none, get, set));
 		else if (def_val.is_of_type(VariantType("s")))
 			prop = shared_ptr<Property>(
-				new String(name, get, set));
+				new String(name, desc, get, set));
 		else
 			continue;
 
@@ -101,13 +106,13 @@ const map<string, VariantBase>& InputOutput::options() const
 }
 
 shared_ptr<Property> InputOutput::bind_enum(
-	const QString &name, const vector<VariantBase> &values,
+	const QString &name, const QString &desc, const vector<VariantBase> &values,
 	Property::Getter getter, Property::Setter setter)
 {
 	vector< pair<VariantBase, QString> > enum_vals;
 	for (VariantBase var : values)
-		enum_vals.push_back(make_pair(var, print_gvariant(var)));
-	return shared_ptr<Property>(new Enum(name, enum_vals, getter, setter));
+		enum_vals.emplace_back(var, print_gvariant(var));
+	return shared_ptr<Property>(new Enum(name, desc, enum_vals, getter, setter));
 }
 
 } // namespace binding