X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=HACKING;h=d539681c38026150e448da04f490c4e64fca3790;hp=d1edc8715673d26f5d6dc7a858a7137d7fbaf724;hb=de060a86f27bea5d459d4d2d1fc097815cefcd8a;hpb=8df906e5b0da130f104e67eeb15b379c12a1916b diff --git a/HACKING b/HACKING index d1edc871..d539681c 100644 --- a/HACKING +++ b/HACKING @@ -38,7 +38,7 @@ Random notes glib's g_try_malloc()/g_try_malloc0() was used, use g_free() to free the memory. Otherwise use standard free(). Never use the wrong function! - - Never use g_malloc() or g_malloc0(). These functions do not return NULL + - Never use g_malloc() or g_malloc0(). These functions do not return nullptr if not enough memory is available but rather lead to an exit() or segfault instead. This behaviour is not acceptable. Use g_try_malloc()/g_try_malloc0() instead and check the return value. @@ -67,6 +67,9 @@ Random notes and the final @return line. The @param lines themselves (if there is more than one) are not separated by empty lines. + - Use QIcon::fromTheme() for icons that are included in the freedesktop.org + icon naming specification. Do NOT use it for all other icons. + Release engineering -------------------