]> sigrok.org Git - pulseview.git/blobdiff - pv/view/view.cpp
Refactoring in View and SigSession
[pulseview.git] / pv / view / view.cpp
index 3137dd0c6686b4b9a947e7a708ba14868c16d631..a437918d9f2a88f3001f35ae9eb33b854530924c 100644 (file)
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#ifdef ENABLE_DECODE
 #include <libsigrokdecode/libsigrokdecode.h>
+#endif
 
 #include <assert.h>
 #include <limits.h>
 #include <math.h>
 
-#include <set>
-
 #include <boost/foreach.hpp>
 
 #include <QEvent>
 #include "pv/data/logic.h"
 #include "pv/data/logicsnapshot.h"
 
-using namespace boost;
-using namespace std;
+using boost::shared_ptr;
+using boost::weak_ptr;
+using pv::data::SignalData;
+using std::deque;
+using std::list;
+using std::max;
+using std::make_pair;
+using std::min;
+using std::pair;
+using std::set;
+using std::vector;
 
 namespace pv {
 namespace view {
@@ -52,9 +61,6 @@ namespace view {
 const double View::MaxScale = 1e9;
 const double View::MinScale = 1e-15;
 
-const int View::LabelMarginWidth = 70;
-const int View::RulerHeight = 30;
-
 const int View::MaxScrollValue = INT_MAX / 2;
 
 const int View::SignalHeight = 30;
@@ -71,7 +77,6 @@ View::View(SigSession &session, QWidget *parent) :
        _viewport(new Viewport(*this)),
        _ruler(new Ruler(*this)),
        _header(new Header(*this)),
-       _data_length(0),
        _scale(1e-6),
        _offset(0),
        _v_offset(0),
@@ -95,6 +100,8 @@ View::View(SigSession &session, QWidget *parent) :
        connect(_cursors.second().get(), SIGNAL(time_changed()),
                this, SLOT(marker_time_changed()));
 
+       connect(_header, SIGNAL(geometry_updated()),
+               this, SLOT(on_geometry_updated()));
        connect(_header, SIGNAL(signals_moved()),
                this, SLOT(on_signals_moved()));
 
@@ -108,7 +115,6 @@ View::View(SigSession &session, QWidget *parent) :
        connect(_ruler, SIGNAL(selection_changed()),
                this, SIGNAL(selection_changed()));
 
-       setViewportMargins(LabelMarginWidth, RulerHeight, 0, 0);
        setViewport(_viewport);
 
        _viewport->installEventFilter(this);
@@ -155,31 +161,9 @@ void View::zoom(double steps, int offset)
 
 void View::zoom_fit()
 {
-       using pv::data::SignalData;
-
-       const vector< shared_ptr<Signal> > sigs(
-               session().get_signals());
-
-       // Make a set of all the visible data objects
-       set< shared_ptr<SignalData> > visible_data;
-       BOOST_FOREACH(const shared_ptr<Signal> sig, sigs)
-               if (sig->enabled())
-                       visible_data.insert(sig->data());
-
-       if (visible_data.empty())
-               return;
-
-       double left_time = DBL_MAX, right_time = DBL_MIN;
-       BOOST_FOREACH(const shared_ptr<SignalData> d, visible_data)
-       {
-               const double start_time = d->get_start_time();
-               left_time = min(left_time, start_time);
-               right_time = max(right_time, start_time +
-                       d->get_max_sample_count() / d->samplerate());
-       }
-
-       assert(left_time < right_time);
-       if (right_time - left_time < 1e-12)
+       const pair<double, double> extents = get_time_extents();
+       const double delta = extents.second - extents.first;
+       if (delta < 1e-12)
                return;
 
        assert(_viewport);
@@ -187,7 +171,7 @@ void View::zoom_fit()
        if (w <= 0)
                return;
 
-       set_scale_offset((right_time - left_time) / w, left_time);      
+       set_scale_offset(delta / w, extents.first);
 }
 
 void View::zoom_one_to_one()
@@ -238,14 +222,20 @@ vector< shared_ptr<Trace> > View::get_traces() const
 {
        const vector< shared_ptr<Signal> > sigs(
                session().get_signals());
+#ifdef ENABLE_DECODE
        const vector< shared_ptr<DecodeTrace> > decode_sigs(
                session().get_decode_signals());
        vector< shared_ptr<Trace> > traces(
                sigs.size() + decode_sigs.size());
+#else
+       vector< shared_ptr<Trace> > traces(sigs.size());
+#endif
 
        vector< shared_ptr<Trace> >::iterator i = traces.begin();
        i = copy(sigs.begin(), sigs.end(), i);
+#ifdef ENABLE_DECODE
        i = copy(decode_sigs.begin(), decode_sigs.end(), i);
+#endif
 
        stable_sort(traces.begin(), traces.end(), compare_trace_v_offsets);
        return traces;
@@ -272,6 +262,39 @@ list<weak_ptr<SelectableItem> > View::selected_items() const
        return items;
 }
 
+set< shared_ptr<SignalData> > View::get_visible_data() const
+{
+       const vector< shared_ptr<Signal> > sigs(
+               session().get_signals());
+
+       // Make a set of all the visible data objects
+       set< shared_ptr<SignalData> > visible_data;
+       BOOST_FOREACH(const shared_ptr<Signal> sig, sigs)
+               if (sig->enabled())
+                       visible_data.insert(sig->data());
+
+       return visible_data;
+}
+
+pair<double, double> View::get_time_extents() const
+{
+       const set< shared_ptr<SignalData> > visible_data = get_visible_data();
+       if (visible_data.empty())
+               return make_pair(0.0, 0.0);
+
+       double left_time = DBL_MAX, right_time = DBL_MIN;
+       BOOST_FOREACH(const shared_ptr<SignalData> d, visible_data)
+       {
+               const double start_time = d->get_start_time();
+               left_time = min(left_time, start_time);
+               right_time = max(right_time, start_time +
+                       d->get_max_sample_count() / d->samplerate());
+       }
+
+       assert(left_time < right_time);
+       return make_pair(left_time, right_time);
+}
+
 bool View::cursors_shown() const
 {
        return _show_cursors;
@@ -332,11 +355,8 @@ void View::update_viewport()
 
 void View::get_scroll_layout(double &length, double &offset) const
 {
-       const shared_ptr<data::SignalData> sig_data = _session.get_data();
-       if (!sig_data)
-               return;
-
-       length = _data_length / (sig_data->samplerate() * _scale);
+       const pair<double, double> extents = get_time_extents();
+       length = (extents.second - extents.first) / _scale;
        offset = _offset / _scale;
 }
 
@@ -381,6 +401,17 @@ void View::update_scroll()
                areaSize.height());
 }
 
+void View::update_layout()
+{
+       setViewportMargins(_header->sizeHint().width(),
+               _ruler->sizeHint().height(), 0, 0);
+       _ruler->setGeometry(_viewport->x(), 0,
+               _viewport->width(), _viewport->y());
+       _header->setGeometry(0, _viewport->y(),
+               _viewport->x(), _viewport->height());
+       update_scroll();
+}
+
 bool View::compare_trace_v_offsets(const shared_ptr<Trace> &a,
        const shared_ptr<Trace> &b)
 {
@@ -432,11 +463,7 @@ bool View::viewportEvent(QEvent *e)
 
 void View::resizeEvent(QResizeEvent*)
 {
-       _ruler->setGeometry(_viewport->x(), 0,
-               _viewport->width(), _viewport->y());
-       _header->setGeometry(0, _viewport->y(),
-               _viewport->x(), _viewport->height());
-       update_scroll();
+       update_layout();
 }
 
 void View::h_scroll_value_changed(int value)
@@ -474,23 +501,12 @@ void View::signals_changed()
                offset += SignalHeight + 2 * SignalMargin;
        }
 
+       update_layout();
        normalize_layout();
 }
 
 void View::data_updated()
 {
-       // Get the new data length
-       _data_length = 0;
-       shared_ptr<data::Logic> sig_data = _session.get_data();
-       if (sig_data) {
-               deque< shared_ptr<data::LogicSnapshot> > &snapshots =
-                       sig_data->get_snapshots();
-               BOOST_FOREACH(shared_ptr<data::LogicSnapshot> s, snapshots)
-                       if (s)
-                               _data_length = max(_data_length,
-                                       s->get_sample_count());
-       }
-
        // Update the scroll bars
        update_scroll();
 
@@ -510,5 +526,10 @@ void View::on_signals_moved()
        signals_moved();
 }
 
+void View::on_geometry_updated()
+{
+       update_layout();
+}
+
 } // namespace view
 } // namespace pv