]> sigrok.org Git - pulseview.git/blobdiff - pv/view/view.cpp
Remove Header::BaselineOffset and move arrows as needed instead
[pulseview.git] / pv / view / view.cpp
index 0e3fa98fffc4b91b8f94af291c179ed20314724c..6c3f896cfd9ff94f77cdc9c5a992af281514f969 100644 (file)
@@ -38,9 +38,9 @@
 #include <QApplication>
 #include <QEvent>
 #include <QFontMetrics>
-#include <QHBoxLayout>
 #include <QMouseEvent>
 #include <QScrollBar>
+#include <QVBoxLayout>
 
 #include <libsigrokcxx/libsigrokcxx.hpp>
 
@@ -96,22 +96,16 @@ const Timestamp View::MaxScale("1e9");
 const Timestamp View::MinScale("1e-12");
 
 const int View::MaxScrollValue = INT_MAX / 2;
-const int View::MaxViewAutoUpdateRate = 25; // No more than 25 Hz with sticky scrolling
 
 const int View::ScaleUnits[3] = {1, 2, 5};
 
 
-CustomAbstractScrollArea::CustomAbstractScrollArea(QWidget *parent) :
+CustomScrollArea::CustomScrollArea(QWidget *parent) :
        QAbstractScrollArea(parent)
 {
 }
 
-void CustomAbstractScrollArea::setViewportMargins(int left, int top, int right, int bottom)
-{
-       QAbstractScrollArea::setViewportMargins(left, top, right, bottom);
-}
-
-bool CustomAbstractScrollArea::viewportEvent(QEvent *event)
+bool CustomScrollArea::viewportEvent(QEvent *event)
 {
        switch (event->type()) {
        case QEvent::Paint:
@@ -131,10 +125,7 @@ bool CustomAbstractScrollArea::viewportEvent(QEvent *event)
 
 View::View(Session &session, bool is_main_view, QWidget *parent) :
        ViewBase(session, is_main_view, parent),
-       viewport_(new Viewport(*this)),
-       ruler_(new Ruler(*this)),
-       header_(new Header(*this)),
-       scrollarea_(this),
+       splitter_(new QSplitter()),
        scale_(1e-3),
        offset_(0),
        updating_scroll_(false),
@@ -150,15 +141,57 @@ View::View(Session &session, bool is_main_view, QWidget *parent) :
        trigger_markers_(),
        hover_point_(-1, -1),
        scroll_needs_defaults_(false),
-       saved_v_offset_(0),
-       size_finalized_(false)
-{
+       saved_v_offset_(0)
+{
+       QVBoxLayout *root_layout = new QVBoxLayout(this);
+       root_layout->setContentsMargins(0, 0, 0, 0);
+       root_layout->addWidget(splitter_);
+
+       viewport_ = new Viewport(*this);
+       scrollarea_ = new CustomScrollArea(splitter_);
+       scrollarea_->setViewport(viewport_);
+       scrollarea_->setFrameShape(QFrame::NoFrame);
+
+       ruler_ = new Ruler(*this);
+
+       header_ = new Header(*this);
+       header_->setMinimumWidth(10);  // So that the arrow tips show at least
+
+       // We put the header into a simple layout so that we can add the top margin,
+       // allowing us to make it line up with the bottom of the ruler
+       QWidget *header_container = new QWidget();
+       header_container->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+       QVBoxLayout *header_layout = new QVBoxLayout(header_container);
+       header_layout->setContentsMargins(0, ruler_->sizeHint().height(), 0, 0);
+       header_layout->addWidget(header_);
+
+       // To let the ruler and scrollarea be on the same split pane, we need a layout
+       QWidget *trace_container = new QWidget();
+       trace_container->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+       QVBoxLayout *trace_layout = new QVBoxLayout(trace_container);
+       trace_layout->setSpacing(0);  // We don't want space between the ruler and scrollarea
+       trace_layout->setContentsMargins(0, 0, 0, 0);
+       trace_layout->addWidget(ruler_);
+       trace_layout->addWidget(scrollarea_);
+
+       splitter_->addWidget(header_container);
+       splitter_->addWidget(trace_container);
+       splitter_->setHandleWidth(1);  // Don't show a visible rubber band
+       splitter_->setCollapsible(0, false);  // Prevent the header from collapsing
+       splitter_->setCollapsible(1, false);  // Prevent the traces from collapsing
+       splitter_->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
+
+       viewport_->installEventFilter(this);
+       ruler_->installEventFilter(this);
+       header_->installEventFilter(this);
+
+       // Set up settings and event handlers
        GlobalSettings settings;
        coloured_bg_ = settings.value(GlobalSettings::Key_View_ColouredBG).toBool();
 
-       connect(scrollarea_.horizontalScrollBar(), SIGNAL(valueChanged(int)),
+       connect(scrollarea_->horizontalScrollBar(), SIGNAL(valueChanged(int)),
                this, SLOT(h_scroll_value_changed(int)));
-       connect(scrollarea_.verticalScrollBar(), SIGNAL(valueChanged(int)),
+       connect(scrollarea_->verticalScrollBar(), SIGNAL(valueChanged(int)),
                this, SLOT(v_scroll_value_changed()));
 
        connect(header_, SIGNAL(selection_changed()),
@@ -178,23 +211,6 @@ View::View(Session &session, bool is_main_view, QWidget *parent) :
                this, SLOT(process_sticky_events()));
        lazy_event_handler_.setSingleShot(true);
 
-       connect(&delayed_view_updater_, SIGNAL(timeout()),
-               this, SLOT(perform_delayed_view_update()));
-       delayed_view_updater_.setSingleShot(true);
-       delayed_view_updater_.setInterval(1000 / MaxViewAutoUpdateRate);
-
-       /* To let the scroll area fill up the parent QWidget (this), we need a layout */
-       QHBoxLayout *layout = new QHBoxLayout(this);
-       setLayout(layout);
-       layout->setContentsMargins(0, 0, 0, 0);
-       layout->addWidget(&scrollarea_);
-
-       scrollarea_.setViewport(viewport_);
-
-       viewport_->installEventFilter(this);
-       ruler_->installEventFilter(this);
-       header_->installEventFilter(this);
-
        // Trigger the initial event manually. The default device has signals
        // which were created before this object came into being
        signals_changed();
@@ -224,11 +240,13 @@ unordered_set< shared_ptr<Signal> > View::signals() const
 
 void View::clear_signals()
 {
+       ViewBase::clear_signalbases();
        signals_.clear();
 }
 
 void View::add_signal(const shared_ptr<Signal> signal)
 {
+       ViewBase::add_signalbase(signal->base());
        signals_.insert(signal);
 }
 
@@ -280,7 +298,7 @@ void View::save_settings(QSettings &settings) const
 {
        settings.setValue("scale", scale_);
        settings.setValue("v_offset",
-               scrollarea_.verticalScrollBar()->sliderPosition());
+               scrollarea_->verticalScrollBar()->sliderPosition());
 
        stringstream ss;
        boost::archive::text_oarchive oa(ss);
@@ -323,7 +341,7 @@ void View::restore_settings(QSettings &settings)
                saved_v_offset_ = settings.value("v_offset").toInt();
                set_v_offset(saved_v_offset_);
                scroll_needs_defaults_ = false;
-               // Note: see resizeEvent() for additional information
+               // Note: see eventFilter() for additional information
        }
 }
 
@@ -369,12 +387,12 @@ void View::set_offset(const pv::util::Timestamp& offset)
 
 int View::owner_visual_v_offset() const
 {
-       return -scrollarea_.verticalScrollBar()->sliderPosition();
+       return -scrollarea_->verticalScrollBar()->sliderPosition();
 }
 
 void View::set_v_offset(int offset)
 {
-       scrollarea_.verticalScrollBar()->setSliderPosition(offset);
+       scrollarea_->verticalScrollBar()->setSliderPosition(offset);
        header_->update();
        viewport_->update();
 }
@@ -561,33 +579,24 @@ void View::enable_show_sampling_points(bool state)
        viewport_->update();
 }
 
-void View::enable_coloured_bg(bool state)
+void View::enable_show_analog_minor_grid(bool state)
 {
-       const vector<shared_ptr<TraceTreeItem>> items(
-               list_by_type<TraceTreeItem>());
-
-       for (shared_ptr<TraceTreeItem> i : items) {
-               // Can't cast to Trace because it's abstract, so we need to
-               // check for any derived classes individually
-
-               shared_ptr<AnalogSignal> a = dynamic_pointer_cast<AnalogSignal>(i);
-               if (a)
-                       a->set_coloured_bg(state);
-
-               shared_ptr<LogicSignal> l = dynamic_pointer_cast<LogicSignal>(i);
-               if (l)
-                       l->set_coloured_bg(state);
+       (void)state;
 
-#ifdef ENABLE_DECODE
-               shared_ptr<DecodeTrace> d = dynamic_pointer_cast<DecodeTrace>(i);
-               if (d)
-                       d->set_coloured_bg(state);
-#endif
-       }
+       viewport_->update();
+}
 
+void View::enable_coloured_bg(bool state)
+{
+       coloured_bg_ = state;
        viewport_->update();
 }
 
+bool View::coloured_bg() const
+{
+       return coloured_bg_;
+}
+
 bool View::cursors_shown() const
 {
        return show_cursors_;
@@ -664,12 +673,6 @@ void View::restack_all_trace_tree_items()
        for (auto &o : sorted_owners)
                o->restack_items();
 
-       // Re-assign background colors
-       bool next_bgcolour_state = false;
-
-       for (auto &o : sorted_owners)
-               next_bgcolour_state = o->reassign_bgcolour_states(next_bgcolour_state);
-
        // Animate the items to their destination
        for (const auto &i : items)
                i->animate_to_layout_v_offset();
@@ -766,11 +769,35 @@ void View::calculate_tick_spacing()
        set_tick_precision(tick_precision);
 }
 
+void View::adjust_top_margin()
+{
+       assert(viewport_);
+
+       const QSize areaSize = viewport_->size();
+
+       const pair<int, int> extents = v_extents();
+       const int top_margin = owner_visual_v_offset() + extents.first;
+       const int trace_bottom = owner_visual_v_offset() + extents.first + extents.second;
+
+       // Do we have empty space at the top while the last trace goes out of screen?
+       if ((top_margin > 0) && (trace_bottom > areaSize.height())) {
+               const int trace_height = extents.second - extents.first;
+
+               // Center everything vertically if there is enough space
+               if (areaSize.height() >= trace_height)
+                       set_v_offset(extents.first -
+                               ((areaSize.height() - trace_height) / 2));
+               else
+                       // Remove the top margin to make as many traces fit on screen as possible
+                       set_v_offset(extents.first);
+       }
+}
+
 void View::update_scroll()
 {
        assert(viewport_);
-       QScrollBar *hscrollbar = scrollarea_.horizontalScrollBar();
-       QScrollBar *vscrollbar = scrollarea_.verticalScrollBar();
+       QScrollBar *hscrollbar = scrollarea_->horizontalScrollBar();
+       QScrollBar *vscrollbar = scrollarea_->verticalScrollBar();
 
        const QSize areaSize = viewport_->size();
 
@@ -815,7 +842,7 @@ void View::update_scroll()
 
 void View::reset_scroll()
 {
-       scrollarea_.verticalScrollBar()->setRange(0, 0);
+       scrollarea_->verticalScrollBar()->setRange(0, 0);
 }
 
 void View::set_scroll_default()
@@ -835,22 +862,31 @@ void View::set_scroll_default()
        else
                // Put the first trace at the top, letting the bottom ones overflow
                set_v_offset(extents.first);
+}
+
+bool View::header_fully_visible() const
+{
+       const int header_pane_width = splitter_->sizes().front();
+       const int header_width = header_->extended_size_hint().width();
 
-       // If we're not sure whether setting the defaults worked as
-       // the window wasn't set up entirely yet, we want to be called
-       // again later to make sure
-       scroll_needs_defaults_ = !size_finalized_;
+       return (header_pane_width >= header_width);
 }
 
 void View::update_layout()
 {
-       scrollarea_.setViewportMargins(
-               header_->sizeHint().width() - Header::BaselineOffset,
-               ruler_->sizeHint().height(), 0, 0);
-       ruler_->setGeometry(viewport_->x(), 0,
-               viewport_->width(), ruler_->extended_size_hint().height());
-       header_->setGeometry(0, viewport_->y(),
-               header_->extended_size_hint().width(), viewport_->height());
+       // Only adjust pane sizes if the header hasn't been partially hidden by the user
+       if (header_fully_visible()) {
+               int splitter_area_width = 0;
+               for (int w : splitter_->sizes())
+                       splitter_area_width += w;
+
+               // Make sure the header has enough horizontal space to show all labels fully
+               QList<int> pane_sizes;
+               pane_sizes.push_back(header_->extended_size_hint().width());
+               pane_sizes.push_back(splitter_area_width - header_->extended_size_hint().width());
+               splitter_->setSizes(pane_sizes);
+       }
+
        update_scroll();
 }
 
@@ -955,35 +991,38 @@ bool View::eventFilter(QObject *object, QEvent *event)
        } else if (type == QEvent::Leave) {
                hover_point_ = QPoint(-1, -1);
                hover_point_changed();
+       } else if (type == QEvent::Show) {
+
+               // This is somewhat of a hack, unfortunately. We cannot use
+               // set_v_offset() from within restore_settings() as the view
+               // at that point is neither visible nor properly sized.
+               // This is the least intrusive workaround I could come up
+               // with: set the vertical offset (or scroll defaults) when
+               // the view is shown, which happens after all widgets were
+               // resized to their final sizes.
+               update_layout();
+
+               if (scroll_needs_defaults_) {
+                       set_scroll_default();
+                       scroll_needs_defaults_ = false;
+               }
+
+               if (saved_v_offset_) {
+                       set_v_offset(saved_v_offset_);
+                       saved_v_offset_ = 0;
+               }
        }
 
        return QObject::eventFilter(object, event);
 }
 
-void View::resizeEvent(QResizeEvent*)
+void View::resizeEvent(QResizeEvent* event)
 {
-       update_layout();
-
-       // This is somewhat of a hack, unfortunately. We cannot use
-       // set_v_offset() from within restore_settings() as the view
-       // at that point is neither visible nor properly sized.
-       // This is the least intrusive workaround I could come up
-       // with: set the vertical offset (or scroll defaults) when
-       // the view is visible and resized to its final size.
-       // Resize events that are sent when the view is not visible
-       // must be ignored as they have wrong sizes, potentially
-       // preventing the v offset from being set successfully.
+       // Only adjust the top margin if we shrunk vertically
+       if (event->size().height() < event->oldSize().height())
+               adjust_top_margin();
 
-       if (isVisible())
-               size_finalized_ = true;
-
-       if (size_finalized_ && saved_v_offset_) {
-               set_v_offset(saved_v_offset_);
-               saved_v_offset_ = 0;
-       }
-
-       if (size_finalized_ && scroll_needs_defaults_)
-               set_scroll_default();
+       update_layout();
 }
 
 void View::row_item_appearance_changed(bool label, bool content)
@@ -1007,6 +1046,7 @@ void View::extents_changed(bool horz, bool vert)
        sticky_events_ |=
                (horz ? TraceTreeItemHExtentsChanged : 0) |
                (vert ? TraceTreeItemVExtentsChanged : 0);
+
        lazy_event_handler_.start();
 }
 
@@ -1022,7 +1062,7 @@ void View::h_scroll_value_changed(int value)
                sticky_scrolling_changed(false);
        }
 
-       const int range = scrollarea_.horizontalScrollBar()->maximum();
+       const int range = scrollarea_->horizontalScrollBar()->maximum();
        if (range < MaxScrollValue)
                set_offset(scale_ * value);
        else {
@@ -1052,8 +1092,8 @@ void View::signals_changed()
        // Do we need to set the vertical scrollbar to its default position later?
        // We do if there are no traces, i.e. the scroll bar has no range set
        bool reset_scrollbar =
-               (scrollarea_.verticalScrollBar()->minimum() ==
-                       scrollarea_.verticalScrollBar()->maximum());
+               (scrollarea_->verticalScrollBar()->minimum() ==
+                       scrollarea_->verticalScrollBar()->maximum());
 
        if (!session_.device()) {
                reset_scroll();
@@ -1250,19 +1290,6 @@ void View::capture_state_updated(int state)
        }
 }
 
-void View::data_updated()
-{
-       if (always_zoom_to_fit_ || sticky_scrolling_) {
-               if (!delayed_view_updater_.isActive())
-                       delayed_view_updater_.start();
-       } else {
-               determine_time_unit();
-               update_scroll();
-               ruler_->update();
-               viewport_->update();
-       }
-}
-
 void View::perform_delayed_view_update()
 {
        if (always_zoom_to_fit_) {