Change namespace for the trace view and implement ViewBase

[pulseview.git] / pv / view / flag.cpp

diff --git a/pv/view/flag.cpp b/pv/view/flag.cpp
index 2ee8ced4972413439d67ba938014c2dee5617e46..3afd255fc7ac05eba350c331d0731a129c4277e1 100644 (file)
--- a/pv/view/flag.cpp
+++ b/pv/view/flag.cpp
@@ -24,19 +24,21 @@
 #include <QColor>
 #include <QFormLayout>
 #include <QLineEdit>
+#include <QMenu>
 
-#include <libsigrok/libsigrok.hpp>
+#include <libsigrokcxx/libsigrokcxx.hpp>
 
 #include <pv/widgets/popup.hpp>
 
 using std::shared_ptr;
 
 namespace pv {
-namespace view {
+namespace views {
+namespace TraceView {
 
 const QColor Flag::FillColour(0x73, 0xD2, 0x16);
 
-Flag::Flag(View &view, double time, const QString &text) :
+Flag::Flag(View &view, const pv::util::Timestamp& time, const QString &text) :
        TimeMarker(view, FillColour, time),
        text_(text)
 {
@@ -44,7 +46,7 @@ Flag::Flag(View &view, double time, const QString &text) :
 
 Flag::Flag(const Flag &flag) :
        TimeMarker(flag.view_, FillColour, flag.time_),
-       std::enable_shared_from_this<pv::view::Flag>(flag)
+       std::enable_shared_from_this<Flag>(flag)
 {
 }
 
@@ -60,7 +62,12 @@ QString Flag::get_text() const
 
 pv::widgets::Popup* Flag::create_popup(QWidget *parent)
 {
-       pv::widgets::Popup *const popup = TimeMarker::create_popup(parent);
+       using pv::widgets::Popup;
+
+       Popup *const popup = TimeMarker::create_popup(parent);
+       popup->set_position(parent->mapToGlobal(
+               point(parent->rect())), Popup::Bottom);
+
        QFormLayout *const form = (QFormLayout*)popup->layout();
 
        QLineEdit *const text_edit = new QLineEdit(popup);
@@ -74,7 +81,24 @@ pv::widgets::Popup* Flag::create_popup(QWidget *parent)
        return popup;
 }
 
+QMenu* Flag::create_context_menu(QWidget *parent)
+{
+       QMenu *const menu = new QMenu(parent);
+
+       QAction *const del = new QAction(tr("Delete"), this);
+       del->setShortcuts(QKeySequence::Delete);
+       connect(del, SIGNAL(triggered()), this, SLOT(on_delete()));
+       menu->addAction(del);
+
+       return menu;
+}
+
 void Flag::delete_pressed()
+{
+       on_delete();
+}
+
+void Flag::on_delete()
 {
        view_.remove_flag(shared_ptr<Flag>(shared_from_this()));
 }
@@ -85,5 +109,6 @@ void Flag::on_text_changed(const QString &text)
        view_.time_item_appearance_changed(true, false);
 }
 
-} // namespace view
+} // namespace TraceView
+} // namespace views
 } // namespace pv