#include <algorithm>
+#include <QApplication>
#include <QDebug>
+#include <QFontMetrics>
#include <QInputDialog>
#include <QLabel>
#include <QLineEdit>
#include <QPushButton>
+#include <QScrollArea>
#include <QVBoxLayout>
#include "pv/session.hpp"
namespace subwindows {
namespace decoder_selector {
+const QString initial_notice = QApplication::tr("Select a decoder to see its description here.");
+const int min_width_margin = 75;
+
bool QCustomSortFilterProxyModel::filterAcceptsRow(int source_row,
const QModelIndex& source_parent) const
// Hide the columns that hold the detailed item information
tree_view_->hideColumn(2); // ID
+ // Ensure that all decoder tag names are fully visible by default
+ tree_view_->resizeColumnToContents(0);
+
+ tree_view_->setIndentation(10);
+
+ QScrollArea* info_label_body_container = new QScrollArea();
+ info_label_body_container->setWidget(info_label_body_);
+ info_label_body_container->setWidgetResizable(true);
+
info_box_->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
QVBoxLayout* info_box_layout = new QVBoxLayout(info_box_);
info_box_layout->addWidget(info_label_header_);
- info_box_layout->addWidget(info_label_body_);
+ info_box_layout->addWidget(info_label_body_container);
info_box_layout->addWidget(info_label_footer_);
+ info_box_layout->setAlignment(Qt::AlignTop);
+ Qt::TextInteractionFlags flags = Qt::TextSelectableByMouse | Qt::TextSelectableByKeyboard;
+ info_label_header_->setWordWrap(true);
+ info_label_header_->setTextInteractionFlags(flags);
info_label_body_->setWordWrap(true);
- info_label_body_->setText(tr("Select a decoder to see its description here."));
+ info_label_body_->setTextInteractionFlags(flags);
+ info_label_body_->setText(initial_notice);
+ info_label_footer_->setWordWrap(true);
+ info_label_footer_->setTextInteractionFlags(flags);
connect(filter, SIGNAL(textChanged(const QString&)),
this, SLOT(on_filter_changed(const QString&)));
return toolbar;
}
-const srd_decoder* SubWindow::get_srd_decoder_from_id(QString id) const
+int SubWindow::minimum_width() const
{
- const srd_decoder* ret_val = nullptr;
+ QFontMetrics m(info_label_body_->font());
+ const int label_width = m.width(initial_notice);
- GSList* l = g_slist_copy((GSList*)srd_decoder_list());
- for (GSList* li = l; li; li = li->next) {
- const srd_decoder* d = (srd_decoder*)li->data;
- assert(d);
-
- if (QString::fromUtf8(d->id) == id)
- ret_val = d;
- }
- g_slist_free(l);
-
- return ret_val;
+ return label_width + min_width_margin;
}
-vector<const char*> SubWindow::decoder_inputs(const srd_decoder* d) const
+vector<const char*> SubWindow::get_decoder_inputs(const srd_decoder* d) const
{
vector<const char*> ret_val;
- GSList* l = g_slist_copy(d->inputs);
- for (GSList* li = l; li; li = li->next) {
- const char* input = (const char*)li->data;
- ret_val.push_back(input);
- }
- g_slist_free(l);
+ for (GSList* li = d->inputs; li; li = li->next)
+ ret_val.push_back((const char*)li->data);
return ret_val;
}
-vector<const srd_decoder*> SubWindow::decoders_providing(const char* output) const
+vector<const srd_decoder*> SubWindow::get_decoders_providing(const char* output) const
{
vector<const srd_decoder*> ret_val;
- GSList* l = g_slist_copy((GSList*)srd_decoder_list());
- for (GSList* li = l; li; li = li->next) {
+ for (GSList* li = (GSList*)srd_decoder_list(); li; li = li->next) {
const srd_decoder* d = (srd_decoder*)li->data;
assert(d);
if (strncmp((char*)(d->outputs->data), output, strlen(output)) == 0)
ret_val.push_back(d);
}
- g_slist_free(l);
return ret_val;
}
if (decoder_name.isEmpty())
return;
- const srd_decoder* d = get_srd_decoder_from_id(decoder_name);
+ const srd_decoder* d = srd_decoder_get_by_id(decoder_name.toUtf8());
const QString id = QString::fromUtf8(d->id);
const QString longname = QString::fromUtf8(d->longname);
const QString desc = QString::fromUtf8(d->desc);
- const QString doc = QString::fromUtf8(srd_decoder_doc_get(d));
+ const QString doc = QString::fromUtf8(srd_decoder_doc_get(d)).trimmed();
QString tags;
- GSList* l = g_slist_copy((GSList*)d->tags);
- for (GSList* li = l; li; li = li->next) {
- QString s = (li == l) ?
+ for (GSList* li = (GSList*)d->tags; li; li = li->next) {
+ QString s = (li == (GSList*)d->tags) ?
tr((char*)li->data) :
QString(tr(", %1")).arg(tr((char*)li->data));
tags.append(s);
}
- g_slist_free(l);
- info_label_header_->setText(QString("<span style='font-size:large;font-weight:bold'>%1 (%2)</span><br>%3")
+ info_label_header_->setText(QString("<span style='font-size:large'><b>%1 (%2)</b></span><br><i>%3</i>")
.arg(longname, id, desc));
info_label_body_->setText(doc);
info_label_footer_->setText(tr("<p align='right'>Tags: %1</p>").arg(tags));
QModelIndex id_index = index.model()->index(index.row(), 2, index.parent());
QString decoder_name = index.model()->data(id_index, Qt::DisplayRole).toString();
- const srd_decoder* chosen_decoder = get_srd_decoder_from_id(decoder_name);
+ const srd_decoder* chosen_decoder = srd_decoder_get_by_id(decoder_name.toUtf8());
if (chosen_decoder == nullptr)
return;
decoders.push_back(chosen_decoder);
// If the decoder only depends on logic inputs, we add it and are done
- vector<const char*> inputs = decoder_inputs(decoders.front());
+ vector<const char*> inputs = get_decoder_inputs(decoders.front());
if (inputs.size() == 0) {
qWarning() << "Protocol decoder" << decoder_name << "cannot have 0 inputs!";
return;
// Check if we can automatically fulfill the stacking requirements
while (strncmp(inputs.at(0), "logic", 5) != 0) {
- vector<const srd_decoder*> prov_decoders = decoders_providing(inputs.at(0));
+ vector<const srd_decoder*> prov_decoders = get_decoders_providing(inputs.at(0));
if (prov_decoders.size() == 0) {
// Emit warning and add the stack that we could gather so far
return;
QString d = item.section(' ', 0, 0);
- decoders.push_back(get_srd_decoder_from_id(d));
+ decoders.push_back(srd_decoder_get_by_id(d.toUtf8()));
}
- inputs = decoder_inputs(decoders.back());
+ inputs = get_decoder_inputs(decoders.back());
}
// Reverse decoder list and add the stack
projects / pulseview.git / blobdiff