]> sigrok.org Git - pulseview.git/blobdiff - pv/sigsession.cpp
Don't join with non-threads. Fixes 323
[pulseview.git] / pv / sigsession.cpp
index 80802e5c7123d395edd16fcf46d8515e27c05b2c..b5387877dda0a73a513f7cb5f066e030f3b17539 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the PulseView project.
  *
- * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
+ * Copyright (C) 2012-14 Joel Holdsworth <joel@airwebreathe.org.uk>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#ifdef ENABLE_DECODE
+#include <libsigrokdecode/libsigrokdecode.h>
+#endif
+
 #include "sigsession.h"
 
 #include "devicemanager.h"
+#include "devinst.h"
+
 #include "data/analog.h"
 #include "data/analogsnapshot.h"
+#include "data/decoderstack.h"
 #include "data/logic.h"
 #include "data/logicsnapshot.h"
+#include "data/decode/decoder.h"
+
 #include "view/analogsignal.h"
+#include "view/decodetrace.h"
 #include "view/logicsignal.h"
 
 #include <assert.h>
 
+#include <stdexcept>
+
+#include <boost/foreach.hpp>
+
 #include <sys/stat.h>
 
 #include <QDebug>
 
-using namespace boost;
-using namespace std;
+using boost::dynamic_pointer_cast;
+using boost::function;
+using boost::lock_guard;
+using boost::mutex;
+using boost::shared_ptr;
+using std::map;
+using std::set;
+using std::string;
+using std::vector;
 
 namespace pv {
 
@@ -44,7 +65,6 @@ SigSession* SigSession::_session = NULL;
 
 SigSession::SigSession(DeviceManager &device_manager) :
        _device_manager(device_manager),
-       _sdi(NULL),
        _capture_state(Stopped)
 {
        // TODO: This should not be necessary
@@ -55,47 +75,84 @@ SigSession::~SigSession()
 {
        stop_capture();
 
-       if (_sampling_thread.get())
-               _sampling_thread->join();
-       _sampling_thread.reset();
+       if (_sampling_thread.joinable())
+               _sampling_thread.join();
 
-       if (_sdi)
-               _device_manager.release_device(_sdi);
-       _sdi = NULL;
+       if (_dev_inst)
+               _device_manager.release_device(_dev_inst);
 
        // TODO: This should not be necessary
        _session = NULL;
 }
 
-struct sr_dev_inst* SigSession::get_device() const
+shared_ptr<DevInst> SigSession::get_device() const
 {
-       return _sdi;
+       return _dev_inst;
 }
 
-void SigSession::set_device(struct sr_dev_inst *sdi)
+void SigSession::set_device(shared_ptr<DevInst> dev_inst)
 {
-       if (_sdi)
-               _device_manager.release_device(_sdi);
-       if (sdi)
-               _device_manager.use_device(sdi, this);
-       _sdi = sdi;
+       // Ensure we are not capturing before setting the device
+       stop_capture();
+
+       if (_dev_inst)
+               _device_manager.release_device(_dev_inst);
+       if (dev_inst)
+               _device_manager.use_device(dev_inst, this);
+       _dev_inst = dev_inst;
+       update_signals(dev_inst);
 }
 
-void SigSession::release_device(struct sr_dev_inst *sdi)
+void SigSession::release_device(shared_ptr<DevInst> dev_inst)
 {
-       (void)sdi;
+       (void)dev_inst;
 
        assert(_capture_state == Stopped);
-       _sdi = NULL;
+       _dev_inst = shared_ptr<DevInst>();
 }
 
 void SigSession::load_file(const string &name,
        function<void (const QString)> error_handler)
 {
        stop_capture();
-       _sampling_thread.reset(new boost::thread(
-               &SigSession::load_thread_proc, this, name,
-               error_handler));
+
+       if (sr_session_load(name.c_str()) == SR_OK) {
+               GSList *devlist = NULL;
+               sr_session_dev_list(&devlist);
+
+               if (!devlist || !devlist->data ||
+                       sr_session_start() != SR_OK) {
+                       error_handler(tr("Failed to start session."));
+                       return;
+               }
+
+               shared_ptr<DevInst> dev_inst(
+                       new DevInst((sr_dev_inst*)devlist->data));
+               g_slist_free(devlist);
+
+               _decode_traces.clear();
+               update_signals(dev_inst);
+               read_sample_rate(dev_inst->dev_inst());
+
+               _sampling_thread = boost::thread(
+                       &SigSession::load_session_thread_proc, this,
+                       error_handler);
+
+       } else {
+               sr_input *in = NULL;
+
+               if (!(in = load_input_file_format(name.c_str(),
+                       error_handler)))
+                       return;
+
+               _decode_traces.clear();
+               update_signals(shared_ptr<DevInst>(new DevInst(in->sdi)));
+               read_sample_rate(in->sdi);
+
+               _sampling_thread = boost::thread(
+                       &SigSession::load_input_thread_proc, this,
+                       name, in, error_handler);
+       }
 }
 
 SigSession::capture_state SigSession::get_capture_state() const
@@ -104,20 +161,21 @@ SigSession::capture_state SigSession::get_capture_state() const
        return _capture_state;
 }
 
-void SigSession::start_capture(uint64_t record_length,
-       function<void (const QString)> error_handler)
+void SigSession::start_capture(function<void (const QString)> error_handler)
 {
        stop_capture();
 
        // Check that a device instance has been selected.
-       if (!_sdi) {
+       if (!_dev_inst) {
                qDebug() << "No device selected";
                return;
        }
 
+       assert(_dev_inst->dev_inst());
+
        // Check that at least one probe is enabled
        const GSList *l;
-       for (l = _sdi->probes; l; l = l->next) {
+       for (l = _dev_inst->dev_inst()->probes; l; l = l->next) {
                sr_probe *const probe = (sr_probe*)l->data;
                assert(probe);
                if (probe->enabled)
@@ -130,9 +188,9 @@ void SigSession::start_capture(uint64_t record_length,
        }
 
        // Begin the session
-       _sampling_thread.reset(new boost::thread(
-               &SigSession::sample_thread_proc, this, _sdi,
-               record_length, error_handler));
+       _sampling_thread = boost::thread(
+               &SigSession::sample_thread_proc, this, _dev_inst,
+                       error_handler);
 }
 
 void SigSession::stop_capture()
@@ -143,27 +201,113 @@ void SigSession::stop_capture()
        sr_session_stop();
 
        // Check that sampling stopped
-       if (_sampling_thread.get())
-               _sampling_thread->join();
-       _sampling_thread.reset();
+       if (_sampling_thread.joinable())
+               _sampling_thread.join();
 }
 
-vector< shared_ptr<view::Signal> > SigSession::get_signals()
+set< shared_ptr<data::SignalData> > SigSession::get_data() const
+{
+       lock_guard<mutex> lock(_signals_mutex);
+       set< shared_ptr<data::SignalData> > data;
+       BOOST_FOREACH(const shared_ptr<view::Signal> sig, _signals) {
+               assert(sig);
+               data.insert(sig->data());
+       }
+
+       return data;
+}
+
+vector< shared_ptr<view::Signal> > SigSession::get_signals() const
 {
        lock_guard<mutex> lock(_signals_mutex);
        return _signals;
 }
 
-boost::shared_ptr<data::Logic> SigSession::get_data()
+#ifdef ENABLE_DECODE
+bool SigSession::add_decoder(srd_decoder *const dec)
 {
-       return _logic_data;
+       map<const srd_probe*, shared_ptr<view::LogicSignal> > probes;
+       shared_ptr<data::DecoderStack> decoder_stack;
+
+       try
+       {
+               lock_guard<mutex> lock(_signals_mutex);
+
+               // Create the decoder
+               decoder_stack = shared_ptr<data::DecoderStack>(
+                       new data::DecoderStack(dec));
+
+               // Make a list of all the probes
+               std::vector<const srd_probe*> all_probes;
+               for(const GSList *i = dec->probes; i; i = i->next)
+                       all_probes.push_back((const srd_probe*)i->data);
+               for(const GSList *i = dec->opt_probes; i; i = i->next)
+                       all_probes.push_back((const srd_probe*)i->data);
+
+               // Auto select the initial probes
+               BOOST_FOREACH(const srd_probe *probe, all_probes)
+                       BOOST_FOREACH(shared_ptr<view::Signal> s, _signals)
+                       {
+                               shared_ptr<view::LogicSignal> l =
+                                       dynamic_pointer_cast<view::LogicSignal>(s);
+                               if (l && QString::fromUtf8(probe->name).
+                                       toLower().contains(
+                                       l->get_name().toLower()))
+                                       probes[probe] = l;
+                       }
+
+               assert(decoder_stack);
+               assert(!decoder_stack->stack().empty());
+               assert(decoder_stack->stack().front());
+               decoder_stack->stack().front()->set_probes(probes);
+
+               // Create the decode signal
+               shared_ptr<view::DecodeTrace> d(
+                       new view::DecodeTrace(*this, decoder_stack,
+                               _decode_traces.size()));
+               _decode_traces.push_back(d);
+       }
+       catch(std::runtime_error e)
+       {
+               return false;
+       }
+
+       signals_changed();
+
+       // Do an initial decode
+       decoder_stack->begin_decode();
+
+       return true;
 }
 
+vector< shared_ptr<view::DecodeTrace> > SigSession::get_decode_signals() const
+{
+       lock_guard<mutex> lock(_signals_mutex);
+       return _decode_traces;
+}
+
+void SigSession::remove_decode_signal(view::DecodeTrace *signal)
+{
+       for (vector< shared_ptr<view::DecodeTrace> >::iterator i =
+               _decode_traces.begin();
+               i != _decode_traces.end();
+               i++)
+               if ((*i).get() == signal)
+               {
+                       _decode_traces.erase(i);
+                       signals_changed();
+                       return;
+               }
+}
+#endif
+
 void SigSession::set_capture_state(capture_state state)
 {
        lock_guard<mutex> lock(_sampling_mutex);
+       const bool changed = _capture_state != state;
        _capture_state = state;
-       capture_state_changed(state);
+       if(changed)
+               capture_state_changed(state);
 }
 
 /**
@@ -242,71 +386,210 @@ sr_input* SigSession::load_input_file_format(const string &filename,
        return in;
 }
 
-void SigSession::load_thread_proc(const string name,
-       function<void (const QString)> error_handler)
+void SigSession::update_signals(shared_ptr<DevInst> dev_inst)
 {
-       sr_input *in = NULL;
+       assert(dev_inst);
+       assert(_capture_state == Stopped);
 
-       if (sr_session_load(name.c_str()) == SR_OK) {
-               if (sr_session_start() != SR_OK) {
-                       error_handler(tr("Failed to start session."));
+       unsigned int logic_probe_count = 0;
+
+       // Clear the decode traces
+       _decode_traces.clear();
+
+       // Detect what data types we will receive
+       if(dev_inst) {
+               assert(dev_inst->dev_inst());
+               for (const GSList *l = dev_inst->dev_inst()->probes;
+                       l; l = l->next) {
+                       const sr_probe *const probe = (const sr_probe *)l->data;
+                       if (!probe->enabled)
+                               continue;
+
+                       switch(probe->type) {
+                       case SR_PROBE_LOGIC:
+                               logic_probe_count++;
+                               break;
+                       }
+               }
+       }
+
+       // Create data containers for the logic data snapshots
+       {
+               lock_guard<mutex> data_lock(_data_mutex);
+
+               _logic_data.reset();
+               if (logic_probe_count != 0) {
+                       _logic_data.reset(new data::Logic(
+                               logic_probe_count));
+                       assert(_logic_data);
+               }
+       }
+
+       // Make the Signals list
+       do {
+               lock_guard<mutex> lock(_signals_mutex);
+
+               _signals.clear();
+
+               if(!dev_inst)
+                       break;
+
+               assert(dev_inst->dev_inst());
+               for (const GSList *l = dev_inst->dev_inst()->probes;
+                       l; l = l->next) {
+                       shared_ptr<view::Signal> signal;
+                       sr_probe *const probe = (sr_probe *)l->data;
+                       assert(probe);
+
+                       switch(probe->type) {
+                       case SR_PROBE_LOGIC:
+                               signal = shared_ptr<view::Signal>(
+                                       new view::LogicSignal(dev_inst,
+                                               probe, _logic_data));
+                               break;
+
+                       case SR_PROBE_ANALOG:
+                       {
+                               shared_ptr<data::Analog> data(
+                                       new data::Analog());
+                               signal = shared_ptr<view::Signal>(
+                                       new view::AnalogSignal(dev_inst,
+                                               probe, data));
+                               break;
+                       }
+
+                       default:
+                               assert(0);
+                               break;
+                       }
+
+                       assert(signal);
+                       _signals.push_back(signal);
+               }
+
+       } while(0);
+
+       signals_changed();
+}
+
+bool SigSession::is_trigger_enabled() const
+{
+       assert(_dev_inst);
+       assert(_dev_inst->dev_inst());
+       for (const GSList *l = _dev_inst->dev_inst()->probes; l; l = l->next) {
+               const sr_probe *const p = (const sr_probe *)l->data;
+               assert(p);
+               if (p->trigger && p->trigger[0] != '\0')
+                       return true;
+       }
+
+       return false;
+}
+
+shared_ptr<view::Signal> SigSession::signal_from_probe(
+       const sr_probe *probe) const
+{
+       lock_guard<mutex> lock(_signals_mutex);
+       BOOST_FOREACH(shared_ptr<view::Signal> sig, _signals) {
+               assert(sig);
+               if (sig->probe() == probe)
+                       return sig;
+       }
+       return shared_ptr<view::Signal>();
+}
+
+void SigSession::read_sample_rate(const sr_dev_inst *const sdi)
+{
+       GVariant *gvar;
+       uint64_t sample_rate = 0;
+
+       // Read out the sample rate
+       if(sdi->driver)
+       {
+               const int ret = sr_config_get(sdi->driver, sdi, NULL,
+                       SR_CONF_SAMPLERATE, &gvar);
+               if (ret != SR_OK) {
+                       qDebug("Failed to get samplerate\n");
                        return;
                }
+
+               sample_rate = g_variant_get_uint64(gvar);
+               g_variant_unref(gvar);
        }
-       else if(!(in = load_input_file_format(name.c_str(), error_handler)))
-               return;
+
+       // Set the sample rate of all data
+       const set< shared_ptr<data::SignalData> > data_set = get_data();
+       BOOST_FOREACH(shared_ptr<data::SignalData> data, data_set) {
+               assert(data);
+               data->set_samplerate(sample_rate);
+       }
+}
+
+void SigSession::load_session_thread_proc(
+       function<void (const QString)> error_handler)
+{
+       (void)error_handler;
 
        sr_session_datafeed_callback_add(data_feed_in_proc, NULL);
 
        set_capture_state(Running);
 
-       if(in) {
-               assert(in->format);
-               in->format->loadfile(in, name.c_str());
-       } else
-               sr_session_run();
+       sr_session_run();
 
        sr_session_destroy();
        set_capture_state(Stopped);
 
        // Confirm that SR_DF_END was received
        assert(!_cur_logic_snapshot);
-       assert(!_cur_analog_snapshot);
+       assert(_cur_analog_snapshots.empty());
+}
+
+void SigSession::load_input_thread_proc(const string name,
+       sr_input *in, function<void (const QString)> error_handler)
+{
+       (void)error_handler;
+
+       assert(in);
+       assert(in->format);
+
+       sr_session_datafeed_callback_add(data_feed_in_proc, NULL);
+
+       set_capture_state(Running);
+
+       in->format->loadfile(in, name.c_str());
+
+       sr_session_destroy();
+       set_capture_state(Stopped);
+
+       // Confirm that SR_DF_END was received
+       assert(!_cur_logic_snapshot);
+       assert(_cur_analog_snapshots.empty());
 
        delete in;
 }
 
-void SigSession::sample_thread_proc(struct sr_dev_inst *sdi,
-       uint64_t record_length,
+void SigSession::sample_thread_proc(shared_ptr<DevInst> dev_inst,
        function<void (const QString)> error_handler)
 {
-       assert(sdi);
+       assert(dev_inst);
+       assert(dev_inst->dev_inst());
        assert(error_handler);
 
        sr_session_new();
        sr_session_datafeed_callback_add(data_feed_in_proc, NULL);
 
-       if (sr_session_dev_add(sdi) != SR_OK) {
+       if (sr_session_dev_add(dev_inst->dev_inst()) != SR_OK) {
                error_handler(tr("Failed to use device."));
                sr_session_destroy();
                return;
        }
 
-       // Set the sample limit
-       if (sr_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
-               g_variant_new_uint64(record_length)) != SR_OK) {
-               error_handler(tr("Failed to configure "
-                       "time-based sample limit."));
-               sr_session_destroy();
-               return;
-       }
-
        if (sr_session_start() != SR_OK) {
                error_handler(tr("Failed to start session."));
                return;
        }
 
-       set_capture_state(Running);
+       set_capture_state(is_trigger_enabled() ? AwaitingTrigger : Running);
 
        sr_session_run();
        sr_session_destroy();
@@ -314,97 +597,16 @@ void SigSession::sample_thread_proc(struct sr_dev_inst *sdi,
        set_capture_state(Stopped);
 
        // Confirm that SR_DF_END was received
-       assert(!_cur_logic_snapshot);
-       assert(!_cur_analog_snapshot);
+       if (_cur_logic_snapshot)
+       {
+               qDebug("SR_DF_END was not received.");
+               assert(0);
+       }
 }
 
 void SigSession::feed_in_header(const sr_dev_inst *sdi)
 {
-       shared_ptr<view::Signal> signal;
-       GVariant *gvar;
-       uint64_t sample_rate = 0;
-       unsigned int logic_probe_count = 0;
-       unsigned int analog_probe_count = 0;
-
-       // Detect what data types we will receive
-       for (const GSList *l = sdi->probes; l; l = l->next) {
-               const sr_probe *const probe = (const sr_probe *)l->data;
-               if (!probe->enabled)
-                       continue;
-
-               switch(probe->type) {
-               case SR_PROBE_LOGIC:
-                       logic_probe_count++;
-                       break;
-
-               case SR_PROBE_ANALOG:
-                       analog_probe_count++;
-                       break;
-               }
-       }
-
-       // Read out the sample rate
-       if(sdi->driver)
-       {
-               const int ret = sr_config_get(sdi->driver,
-                       SR_CONF_SAMPLERATE, &gvar, sdi);
-               if (ret != SR_OK) {
-                       qDebug("Failed to get samplerate\n");
-                       return;
-               }
-
-               sample_rate = g_variant_get_uint64(gvar);
-               g_variant_unref(gvar);
-       }
-
-       // Create data containers for the coming data snapshots
-       {
-               lock_guard<mutex> data_lock(_data_mutex);
-
-               if (logic_probe_count != 0) {
-                       _logic_data.reset(new data::Logic(
-                               logic_probe_count, sample_rate));
-                       assert(_logic_data);
-               }
-
-               if (analog_probe_count != 0) {
-                       _analog_data.reset(new data::Analog(sample_rate));
-                       assert(_analog_data);
-               }
-       }
-
-       // Make the logic probe list
-       {
-               lock_guard<mutex> lock(_signals_mutex);
-
-               _signals.clear();
-
-               for (const GSList *l = sdi->probes; l; l = l->next) {
-                       const sr_probe *const probe =
-                               (const sr_probe *)l->data;
-                       assert(probe);
-                       if (!probe->enabled)
-                               continue;
-
-                       switch(probe->type) {
-                       case SR_PROBE_LOGIC:
-                               signal = shared_ptr<view::Signal>(
-                                       new view::LogicSignal(probe->name,
-                                               _logic_data, probe->index));
-                               break;
-
-                       case SR_PROBE_ANALOG:
-                               signal = shared_ptr<view::Signal>(
-                                       new view::AnalogSignal(probe->name,
-                                               _analog_data, probe->index));
-                               break;
-                       }
-
-                       _signals.push_back(signal);
-               }
-
-               signals_changed();
-       }
+       read_sample_rate(sdi);
 }
 
 void SigSession::feed_in_meta(const sr_dev_inst *sdi,
@@ -424,6 +626,8 @@ void SigSession::feed_in_meta(const sr_dev_inst *sdi,
                        break;
                }
        }
+
+       signals_changed();
 }
 
 void SigSession::feed_in_logic(const sr_datafeed_logic &logic)
@@ -438,9 +642,12 @@ void SigSession::feed_in_logic(const sr_datafeed_logic &logic)
 
        if (!_cur_logic_snapshot)
        {
+               // This could be the first packet after a trigger
+               set_capture_state(Running);
+
                // Create a new data snapshot
                _cur_logic_snapshot = shared_ptr<data::LogicSnapshot>(
-                       new data::LogicSnapshot(logic));
+                       new data::LogicSnapshot(logic, _dev_inst->get_sample_limit()));
                _logic_data->push_snapshot(_cur_logic_snapshot);
        }
        else
@@ -456,23 +663,58 @@ void SigSession::feed_in_analog(const sr_datafeed_analog &analog)
 {
        lock_guard<mutex> lock(_data_mutex);
 
-       if(!_analog_data)
-       {
-               qDebug() << "Unexpected analog packet";
-               return; // This analog packet was not expected.
-       }
+       const unsigned int probe_count = g_slist_length(analog.probes);
+       const size_t sample_count = analog.num_samples / probe_count;
+       const float *data = analog.data;
+       bool sweep_beginning = false;
 
-       if (!_cur_analog_snapshot)
+       for (GSList *p = analog.probes; p; p = p->next)
        {
-               // Create a new data snapshot
-               _cur_analog_snapshot = shared_ptr<data::AnalogSnapshot>(
-                       new data::AnalogSnapshot(analog));
-               _analog_data->push_snapshot(_cur_analog_snapshot);
+               shared_ptr<data::AnalogSnapshot> snapshot;
+
+               sr_probe *const probe = (sr_probe*)p->data;
+               assert(probe);
+
+               // Try to get the snapshot of the probe
+               const map< const sr_probe*, shared_ptr<data::AnalogSnapshot> >::
+                       iterator iter = _cur_analog_snapshots.find(probe);
+               if (iter != _cur_analog_snapshots.end())
+                       snapshot = (*iter).second;
+               else
+               {
+                       // If no snapshot was found, this means we havn't
+                       // created one yet. i.e. this is the first packet
+                       // in the sweep containing this snapshot.
+                       sweep_beginning = true;
+
+                       // Create a snapshot, keep it in the maps of probes
+                       snapshot = shared_ptr<data::AnalogSnapshot>(
+                               new data::AnalogSnapshot(_dev_inst->get_sample_limit()));
+                       _cur_analog_snapshots[probe] = snapshot;
+
+                       // Find the annalog data associated with the probe
+                       shared_ptr<view::AnalogSignal> sig =
+                               dynamic_pointer_cast<view::AnalogSignal>(
+                                       signal_from_probe(probe));
+                       assert(sig);
+
+                       shared_ptr<data::Analog> data(sig->analog_data());
+                       assert(data);
+
+                       // Push the snapshot into the analog data.
+                       data->push_snapshot(snapshot);
+               }
+
+               assert(snapshot);
+
+               // Append the samples in the snapshot
+               snapshot->append_interleaved_samples(data++, sample_count,
+                       probe_count);
        }
-       else
-       {
-               // Append to the existing data snapshot
-               _cur_analog_snapshot->append_payload(analog);
+
+       if (sweep_beginning) {
+               // This could be the first packet after a trigger
+               set_capture_state(Running);
        }
 
        data_updated();
@@ -510,7 +752,7 @@ void SigSession::data_feed_in(const struct sr_dev_inst *sdi,
                {
                        lock_guard<mutex> lock(_data_mutex);
                        _cur_logic_snapshot.reset();
-                       _cur_analog_snapshot.reset();
+                       _cur_analog_snapshots.clear();
                }
                data_updated();
                break;