]> sigrok.org Git - pulseview.git/blobdiff - pv/session.cpp
Only show sampling points when zoomed in far enough.
[pulseview.git] / pv / session.cpp
index 34ed26b8fada81a4468868e94447610f78754a03..0077ccfd00d0d36d6de0a401d8f71347e24a4d08 100644 (file)
@@ -14,8 +14,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifdef _WIN32
@@ -26,6 +25,8 @@
 #include <boost/thread/locks.hpp>
 #include <boost/thread/shared_mutex.hpp>
 
+#include <QFileInfo>
+
 #include <cassert>
 #include <mutex>
 #include <stdexcept>
@@ -44,6 +45,7 @@
 #include "data/decode/decoder.hpp"
 
 #include "devices/hardwaredevice.hpp"
+#include "devices/inputfile.hpp"
 #include "devices/sessionfile.hpp"
 
 #include "toolbars/mainbar.hpp"
@@ -70,9 +72,11 @@ using std::lock_guard;
 using std::list;
 using std::map;
 using std::mutex;
+using std::pair;
 using std::recursive_mutex;
 using std::set;
 using std::shared_ptr;
+using std::make_shared;
 using std::string;
 using std::unordered_set;
 using std::vector;
@@ -84,8 +88,10 @@ using sigrok::ConfigKey;
 using sigrok::DatafeedCallbackFunction;
 using sigrok::Error;
 using sigrok::Header;
+using sigrok::InputFormat;
 using sigrok::Logic;
 using sigrok::Meta;
+using sigrok::OutputFormat;
 using sigrok::Packet;
 using sigrok::PacketPayload;
 using sigrok::Session;
@@ -97,9 +103,11 @@ using Glib::Variant;
 namespace pv {
 Session::Session(DeviceManager &device_manager, QString name) :
        device_manager_(device_manager),
+       default_name_(name),
        name_(name),
        capture_state_(Stopped),
-       cur_samplerate_(0)
+       cur_samplerate_(0),
+       data_saved_(true)
 {
 }
 
@@ -146,7 +154,12 @@ void Session::set_name(QString name)
        name_changed();
 }
 
-std::shared_ptr<pv::view::View> Session::main_view() const
+const std::list< std::shared_ptr<views::ViewBase> > Session::views() const
+{
+       return views_;
+}
+
+std::shared_ptr<views::ViewBase> Session::main_view() const
 {
        return main_view_;
 }
@@ -161,28 +174,53 @@ shared_ptr<pv::toolbars::MainBar> Session::main_bar() const
        return main_bar_;
 }
 
+bool Session::data_saved() const
+{
+       return data_saved_;
+}
+
 void Session::save_settings(QSettings &settings) const
 {
        map<string, string> dev_info;
        list<string> key_list;
-       int stacks = 0;
+       int stacks = 0, views = 0;
 
        if (device_) {
-               settings.beginGroup("Device");
-               key_list.push_back("vendor");
-               key_list.push_back("model");
-               key_list.push_back("version");
-               key_list.push_back("serial_num");
-               key_list.push_back("connection_id");
+               shared_ptr<devices::HardwareDevice> hw_device =
+                       dynamic_pointer_cast< devices::HardwareDevice >(device_);
+
+               if (hw_device) {
+                       settings.setValue("device_type", "hardware");
+                       settings.beginGroup("device");
+
+                       key_list.emplace_back("vendor");
+                       key_list.emplace_back("model");
+                       key_list.emplace_back("version");
+                       key_list.emplace_back("serial_num");
+                       key_list.emplace_back("connection_id");
+
+                       dev_info = device_manager_.get_device_info(device_);
+
+                       for (string key : key_list) {
+                               if (dev_info.count(key))
+                                       settings.setValue(QString::fromUtf8(key.c_str()),
+                                                       QString::fromUtf8(dev_info.at(key).c_str()));
+                               else
+                                       settings.remove(QString::fromUtf8(key.c_str()));
+                       }
 
-               dev_info = device_manager_.get_device_info(device_);
+                       settings.endGroup();
+               }
 
-               for (string key : key_list) {
-                       if (dev_info.count(key))
-                               settings.setValue(QString::fromUtf8(key.c_str()),
-                                               QString::fromUtf8(dev_info.at(key).c_str()));
-                       else
-                               settings.remove(QString::fromUtf8(key.c_str()));
+               shared_ptr<devices::SessionFile> sessionfile_device =
+                       dynamic_pointer_cast< devices::SessionFile >(device_);
+
+               if (sessionfile_device) {
+                       settings.setValue("device_type", "sessionfile");
+                       settings.beginGroup("device");
+                       settings.setValue("filename", QString::fromStdString(
+                               sessionfile_device->full_name()));
+                       settings.endGroup();
                }
 
                // Save channels and decoders
@@ -202,54 +240,90 @@ void Session::save_settings(QSettings &settings) const
 #endif
                        {
                                settings.beginGroup(base->internal_name());
-                               settings.setValue("name", base->name());
-                               settings.setValue("enabled", base->enabled());
-                               settings.setValue("colour", base->colour());
+                               base->save_settings(settings);
                                settings.endGroup();
                        }
                }
 
                settings.setValue("decoder_stacks", stacks);
+
+               // Save view states and their signal settings
+               // Note: main_view must be saved as view0
+               settings.beginGroup("view" + QString::number(views++));
+               main_view_->save_settings(settings);
                settings.endGroup();
+
+               for (shared_ptr<views::ViewBase> view : views_) {
+                       if (view != main_view_) {
+                               settings.beginGroup("view" + QString::number(views++));
+                               view->save_settings(settings);
+                               settings.endGroup();
+                       }
+               }
+
+               settings.setValue("views", views);
        }
 }
 
 void Session::restore_settings(QSettings &settings)
 {
-       map<string, string> dev_info;
-       list<string> key_list;
-       shared_ptr<devices::HardwareDevice> device;
+       shared_ptr<devices::Device> device;
+
+       QString device_type = settings.value("device_type").toString();
+
+       if (device_type == "hardware") {
+               map<string, string> dev_info;
+               list<string> key_list;
+
+               // Re-select last used device if possible but only if it's not demo
+               settings.beginGroup("device");
+               key_list.emplace_back("vendor");
+               key_list.emplace_back("model");
+               key_list.emplace_back("version");
+               key_list.emplace_back("serial_num");
+               key_list.emplace_back("connection_id");
+
+               for (string key : key_list) {
+                       const QString k = QString::fromStdString(key);
+                       if (!settings.contains(k))
+                               continue;
+
+                       const string value = settings.value(k).toString().toStdString();
+                       if (!value.empty())
+                               dev_info.insert(std::make_pair(key, value));
+               }
 
-       // Re-select last used device if possible but only if it's not demo
-       settings.beginGroup("Device");
-       key_list.push_back("vendor");
-       key_list.push_back("model");
-       key_list.push_back("version");
-       key_list.push_back("serial_num");
-       key_list.push_back("connection_id");
+               if (dev_info.count("model") > 0)
+                       device = device_manager_.find_device_from_info(dev_info);
 
-       for (string key : key_list) {
-               const QString k = QString::fromStdString(key);
-               if (!settings.contains(k))
-                       continue;
+               if (device)
+                       set_device(device);
 
-               const string value = settings.value(k).toString().toStdString();
-               if (!value.empty())
-                       dev_info.insert(std::make_pair(key, value));
+               settings.endGroup();
        }
 
-       if (dev_info.count("model") > 0)
-               device = device_manager_.find_device_from_info(dev_info);
+       if (device_type == "sessionfile") {
+               settings.beginGroup("device");
+               QString filename = settings.value("filename").toString();
+               settings.endGroup();
 
-       if (device) {
-               set_device(device);
+               if (QFileInfo(filename).isReadable()) {
+                       device = make_shared<devices::SessionFile>(device_manager_.context(),
+                               filename.toStdString());
+                       set_device(device);
+
+                       // TODO Perform error handling
+                       start_capture([](QString infoMessage) { (void)infoMessage; });
+
+                       set_name(QFileInfo(filename).fileName());
+               }
+       }
 
+       if (device) {
                // Restore channels
                for (shared_ptr<data::SignalBase> base : signalbases_) {
                        settings.beginGroup(base->internal_name());
-                       base->set_name(settings.value("name").toString());
-                       base->set_enabled(settings.value("enabled").toBool());
-                       base->set_colour(settings.value("colour").value<QColor>());
+                       base->restore_settings(settings);
                        settings.endGroup();
                }
 
@@ -266,9 +340,36 @@ void Session::restore_settings(QSettings &settings)
                        settings.endGroup();
                }
 #endif
+
+               // Restore views
+               int views = settings.value("views").toInt();
+
+               for (int i = 0; i < views; i++) {
+                       settings.beginGroup("view" + QString::number(i));
+
+                       if (i > 0) {
+                               views::ViewType type = (views::ViewType)settings.value("type").toInt();
+                               add_view(name_, type, this);
+                               views_.back()->restore_settings(settings);
+                       } else
+                               main_view_->restore_settings(settings);
+
+                       settings.endGroup();
+               }
        }
+}
 
-       settings.endGroup();
+void Session::select_device(shared_ptr<devices::Device> device)
+{
+       try {
+               if (device)
+                       set_device(device);
+               else
+                       set_default_device();
+       } catch (const QString &e) {
+               main_bar_->session_error(tr("Failed to Select Device"),
+                       tr("Failed to Select Device"));
+       }
 }
 
 void Session::set_device(shared_ptr<devices::Device> device)
@@ -283,15 +384,15 @@ void Session::set_device(shared_ptr<devices::Device> device)
 
        device_.reset();
 
-       // Revert name back to default name (e.g. "Untitled-1") as the data is gone
+       // Revert name back to default name (e.g. "Session 1") as the data is gone
        name_ = default_name_;
        name_changed();
 
        // Remove all stored data
-       for (std::shared_ptr<pv::view::View> view : views_) {
+       for (std::shared_ptr<views::ViewBase> view : views_) {
                view->clear_signals();
 #ifdef ENABLE_DECODE
-               view->clear_decode_traces();
+               view->clear_decode_signals();
 #endif
        }
        for (const shared_ptr<data::SignalData> d : all_signal_data_)
@@ -315,16 +416,17 @@ void Session::set_device(shared_ptr<devices::Device> device)
                device_->open();
        } catch (const QString &e) {
                device_.reset();
-               device_changed();
-               throw;
        }
 
-       device_->session()->add_datafeed_callback([=]
-               (shared_ptr<sigrok::Device> device, shared_ptr<Packet> packet) {
-                       data_feed_in(device, packet);
-               });
+       if (device_) {
+               device_->session()->add_datafeed_callback([=]
+                       (shared_ptr<sigrok::Device> device, shared_ptr<Packet> packet) {
+                               data_feed_in(device, packet);
+                       });
+
+               update_signals();
+       }
 
-       update_signals();
        device_changed();
 }
 
@@ -344,6 +446,63 @@ void Session::set_default_device()
        set_device((iter == devices.end()) ? devices.front() : *iter);
 }
 
+void Session::load_init_file(const std::string &file_name,
+       const std::string &format)
+{
+       shared_ptr<InputFormat> input_format;
+
+       if (!format.empty()) {
+               const map<string, shared_ptr<InputFormat> > formats =
+                       device_manager_.context()->input_formats();
+               const auto iter = find_if(formats.begin(), formats.end(),
+                       [&](const pair<string, shared_ptr<InputFormat> > f) {
+                               return f.first == format; });
+               if (iter == formats.end()) {
+                       main_bar_->session_error(tr("Error"),
+                               tr("Unexpected input format: %s").arg(QString::fromStdString(format)));
+                       return;
+               }
+
+               input_format = (*iter).second;
+       }
+
+       load_file(QString::fromStdString(file_name), input_format);
+}
+
+void Session::load_file(QString file_name,
+       std::shared_ptr<sigrok::InputFormat> format,
+       const std::map<std::string, Glib::VariantBase> &options)
+{
+       const QString errorMessage(
+               QString("Failed to load file %1").arg(file_name));
+
+       try {
+               if (format)
+                       set_device(shared_ptr<devices::Device>(
+                               new devices::InputFile(
+                                       device_manager_.context(),
+                                       file_name.toStdString(),
+                                       format, options)));
+               else
+                       set_device(shared_ptr<devices::Device>(
+                               new devices::SessionFile(
+                                       device_manager_.context(),
+                                       file_name.toStdString())));
+       } catch (Error e) {
+               main_bar_->session_error(tr("Failed to load ") + file_name, e.what());
+               set_default_device();
+               main_bar_->update_device_list();
+               return;
+       }
+
+       main_bar_->update_device_list();
+
+       start_capture([&, errorMessage](QString infoMessage) {
+               main_bar_->session_error(errorMessage, infoMessage); });
+
+       set_name(QFileInfo(file_name).fileName());
+}
+
 Session::capture_state Session::get_capture_state() const
 {
        lock_guard<mutex> lock(sampling_mutex_);
@@ -375,9 +534,15 @@ void Session::start_capture(function<void (const QString)> error_handler)
        for (const shared_ptr<data::SignalData> d : all_signal_data_)
                d->clear();
 
-       // Revert name back to default name (e.g. "Untitled-1") as the data is gone
-       name_ = default_name_;
-       name_changed();
+       // Revert name back to default name (e.g. "Session 1") for real devices
+       // as the (possibly saved) data is gone. File devices keep their name.
+       shared_ptr<devices::HardwareDevice> hw_device =
+               dynamic_pointer_cast< devices::HardwareDevice >(device_);
+
+       if (hw_device) {
+               name_ = default_name_;
+               name_changed();
+       }
 
        // Begin the session
        sampling_thread_ = std::thread(
@@ -394,18 +559,21 @@ void Session::stop_capture()
                sampling_thread_.join();
 }
 
-void Session::register_view(std::shared_ptr<pv::view::View> view)
+void Session::register_view(std::shared_ptr<views::ViewBase> view)
 {
        if (views_.empty()) {
                main_view_ = view;
        }
 
-       views_.insert(view);
+       views_.push_back(view);
+
+       update_signals();
 }
 
-void Session::deregister_view(std::shared_ptr<pv::view::View> view)
+void Session::deregister_view(std::shared_ptr<views::ViewBase> view)
 {
-       views_.erase(view);
+       views_.remove_if([&](std::shared_ptr<views::ViewBase> v) {
+               return v == view; });
 
        if (views_.empty()) {
                main_view_.reset();
@@ -415,9 +583,13 @@ void Session::deregister_view(std::shared_ptr<pv::view::View> view)
        }
 }
 
-bool Session::has_view(std::shared_ptr<pv::view::View> view)
+bool Session::has_view(std::shared_ptr<views::ViewBase> view)
 {
-       return views_.find(view) != views_.end();
+       for (std::shared_ptr<views::ViewBase> v : views_)
+               if (v == view)
+                       return true;
+
+       return false;
 }
 
 double Session::get_samplerate() const
@@ -452,8 +624,7 @@ bool Session::add_decoder(srd_decoder *const dec)
 
        try {
                // Create the decoder
-               decoder_stack = shared_ptr<data::DecoderStack>(
-                       new data::DecoderStack(*this, dec));
+               decoder_stack = make_shared<data::DecoderStack>(*this, dec);
 
                // Make a list of all the channels
                std::vector<const srd_channel*> all_channels;
@@ -479,13 +650,13 @@ bool Session::add_decoder(srd_decoder *const dec)
 
                // Create the decode signal
                shared_ptr<data::SignalBase> signalbase =
-                       shared_ptr<data::SignalBase>(new data::SignalBase(nullptr));
+                       make_shared<data::SignalBase>(nullptr);
 
                signalbase->set_decoder_stack(decoder_stack);
                signalbases_.insert(signalbase);
 
-               for (std::shared_ptr<pv::view::View> view : views_)
-                       view->add_decode_trace(signalbase);
+               for (std::shared_ptr<views::ViewBase> view : views_)
+                       view->add_decode_signal(signalbase);
        } catch (std::runtime_error e) {
                return false;
        }
@@ -500,8 +671,12 @@ bool Session::add_decoder(srd_decoder *const dec)
 
 void Session::remove_decode_signal(shared_ptr<data::SignalBase> signalbase)
 {
-       for (std::shared_ptr<pv::view::View> view : views_)
-               view->remove_decode_trace(signalbase);
+       signalbases_.erase(signalbase);
+
+       for (std::shared_ptr<views::ViewBase> view : views_)
+               view->remove_decode_signal(signalbase);
+
+       signals_changed();
 }
 #endif
 
@@ -524,10 +699,10 @@ void Session::update_signals()
        if (!device_) {
                signalbases_.clear();
                logic_data_.reset();
-               for (std::shared_ptr<pv::view::View> view : views_) {
+               for (std::shared_ptr<views::ViewBase> view : views_) {
                        view->clear_signals();
 #ifdef ENABLE_DECODE
-                       view->clear_decode_traces();
+                       view->clear_decode_signals();
 #endif
                }
                return;
@@ -539,10 +714,10 @@ void Session::update_signals()
        if (!sr_dev) {
                signalbases_.clear();
                logic_data_.reset();
-               for (std::shared_ptr<pv::view::View> view : views_) {
+               for (std::shared_ptr<views::ViewBase> view : views_) {
                        view->clear_signals();
 #ifdef ENABLE_DECODE
-                       view->clear_decode_traces();
+                       view->clear_decode_signals();
 #endif
                }
                return;
@@ -570,69 +745,74 @@ void Session::update_signals()
        }
 
        // Make the signals list
-       for (std::shared_ptr<pv::view::View> view : views_) {
-               unordered_set< shared_ptr<view::Signal> > prev_sigs(view->signals());
-               view->clear_signals();
-
-               for (auto channel : sr_dev->channels()) {
-                       shared_ptr<data::SignalBase> signalbase;
-                       shared_ptr<view::Signal> signal;
-
-                       // Find the channel in the old signals
-                       const auto iter = std::find_if(
-                               prev_sigs.cbegin(), prev_sigs.cend(),
-                               [&](const shared_ptr<view::Signal> &s) {
-                                       return s->base()->channel() == channel;
-                               });
-                       if (iter != prev_sigs.end()) {
-                               // Copy the signal from the old set to the new
-                               signal = *iter;
-                       } else {
-                               // Find the signalbase for this channel if possible
-                               signalbase.reset();
-                               for (const shared_ptr<data::SignalBase> b : signalbases_)
-                                       if (b->channel() == channel)
-                                               signalbase = b;
-
-                               switch(channel->type()->id()) {
-                               case SR_CHANNEL_LOGIC:
-                                       if (!signalbase) {
-                                               signalbase = shared_ptr<data::SignalBase>(
-                                                       new data::SignalBase(channel));
-                                               signalbases_.insert(signalbase);
-
-                                               all_signal_data_.insert(logic_data_);
-                                               signalbase->set_data(logic_data_);
+       for (std::shared_ptr<views::ViewBase> viewbase : views_) {
+               views::TraceView::View *trace_view =
+                       qobject_cast<views::TraceView::View*>(viewbase.get());
+
+               if (trace_view) {
+                       unordered_set< shared_ptr<views::TraceView::Signal> >
+                               prev_sigs(trace_view->signals());
+                       trace_view->clear_signals();
+
+                       for (auto channel : sr_dev->channels()) {
+                               shared_ptr<data::SignalBase> signalbase;
+                               shared_ptr<views::TraceView::Signal> signal;
+
+                               // Find the channel in the old signals
+                               const auto iter = std::find_if(
+                                       prev_sigs.cbegin(), prev_sigs.cend(),
+                                       [&](const shared_ptr<views::TraceView::Signal> &s) {
+                                               return s->base()->channel() == channel;
+                                       });
+                               if (iter != prev_sigs.end()) {
+                                       // Copy the signal from the old set to the new
+                                       signal = *iter;
+                                       trace_view->add_signal(signal);
+                               } else {
+                                       // Find the signalbase for this channel if possible
+                                       signalbase.reset();
+                                       for (const shared_ptr<data::SignalBase> b : signalbases_)
+                                               if (b->channel() == channel)
+                                                       signalbase = b;
+
+                                       switch(channel->type()->id()) {
+                                       case SR_CHANNEL_LOGIC:
+                                               if (!signalbase) {
+                                                       signalbase = make_shared<data::SignalBase>(channel);
+                                                       signalbases_.insert(signalbase);
+
+                                                       all_signal_data_.insert(logic_data_);
+                                                       signalbase->set_data(logic_data_);
+                                               }
+
+                                               signal = shared_ptr<views::TraceView::Signal>(
+                                                       new views::TraceView::LogicSignal(*this,
+                                                               device_, signalbase));
+                                               trace_view->add_signal(signal);
+                                               break;
+
+                                       case SR_CHANNEL_ANALOG:
+                                       {
+                                               if (!signalbase) {
+                                                       signalbase = make_shared<data::SignalBase>(channel);
+                                                       signalbases_.insert(signalbase);
+
+                                                       shared_ptr<data::Analog> data(new data::Analog());
+                                                       all_signal_data_.insert(data);
+                                                       signalbase->set_data(data);
+                                               }
+
+                                               signal = shared_ptr<views::TraceView::Signal>(
+                                                       new views::TraceView::AnalogSignal(
+                                                               *this, signalbase));
+                                               trace_view->add_signal(signal);
+                                               break;
                                        }
 
-                                       signal = shared_ptr<view::Signal>(
-                                               new view::LogicSignal(*this,
-                                                       device_, signalbase));
-                                       view->add_signal(signal);
-                                       break;
-
-                               case SR_CHANNEL_ANALOG:
-                               {
-                                       if (!signalbase) {
-                                               signalbase = shared_ptr<data::SignalBase>(
-                                                       new data::SignalBase(channel));
-                                               signalbases_.insert(signalbase);
-
-                                               shared_ptr<data::Analog> data(new data::Analog());
-                                               all_signal_data_.insert(data);
-                                               signalbase->set_data(data);
+                                       default:
+                                               assert(0);
+                                               break;
                                        }
-
-                                       signal = shared_ptr<view::Signal>(
-                                               new view::AnalogSignal(
-                                                       *this, signalbase));
-                                       view->add_signal(signal);
-                                       break;
-                               }
-
-                               default:
-                                       assert(0);
-                                       break;
                                }
                        }
                }
@@ -682,10 +862,31 @@ void Session::sample_thread_proc(function<void (const QString)> error_handler)
                assert(0);
        }
 
+       // Optimize memory usage
+       free_unused_memory();
+
+       // We now have unsaved data unless we just "captured" from a file
+       shared_ptr<devices::File> file_device =
+               dynamic_pointer_cast<devices::File>(device_);
+
+       if (!file_device)
+               data_saved_ = false;
+
        if (out_of_memory_)
                error_handler(tr("Out of memory, acquisition stopped."));
 }
 
+void Session::free_unused_memory()
+{
+       for (shared_ptr<data::SignalData> data : all_signal_data_) {
+               const vector< shared_ptr<data::Segment> > segments = data->segments();
+
+               for (shared_ptr<data::Segment> segment : segments) {
+                       segment->free_unused_memory();
+               }
+       }
+}
+
 void Session::feed_in_header()
 {
        cur_samplerate_ = device_->read_config<uint64_t>(ConfigKey::SAMPLERATE);
@@ -745,8 +946,6 @@ void Session::feed_in_logic(shared_ptr<Logic> logic)
 {
        lock_guard<recursive_mutex> lock(data_mutex_);
 
-       const size_t sample_count = logic->data_length() / logic->unit_size();
-
        if (!logic_data_) {
                // The only reason logic_data_ would not have been created is
                // if it was not possible to determine the signals when the
@@ -759,9 +958,8 @@ void Session::feed_in_logic(shared_ptr<Logic> logic)
                set_capture_state(Running);
 
                // Create a new data segment
-               cur_logic_segment_ = shared_ptr<data::LogicSegment>(
-                       new data::LogicSegment(
-                               logic, cur_samplerate_, sample_count));
+               cur_logic_segment_ = make_shared<data::LogicSegment>(
+                       *logic_data_, logic, cur_samplerate_);
                logic_data_->push_segment(cur_logic_segment_);
 
                // @todo Putting this here means that only listeners querying
@@ -804,12 +1002,6 @@ void Session::feed_in_analog(shared_ptr<Analog> analog)
                        // in the sweep containing this segment.
                        sweep_beginning = true;
 
-                       // Create a segment, keep it in the maps of channels
-                       segment = shared_ptr<data::AnalogSegment>(
-                               new data::AnalogSegment(
-                                       cur_samplerate_, sample_count));
-                       cur_analog_segments_[channel] = segment;
-
                        // Find the analog data associated with the channel
                        shared_ptr<data::SignalBase> base = signalbase_from_channel(channel);
                        assert(base);
@@ -817,6 +1009,11 @@ void Session::feed_in_analog(shared_ptr<Analog> analog)
                        shared_ptr<data::Analog> data(base->analog_data());
                        assert(data);
 
+                       // Create a segment, keep it in the maps of channels
+                       segment = make_shared<data::AnalogSegment>(
+                               *data, cur_samplerate_);
+                       cur_analog_segments_[channel] = segment;
+
                        // Push the segment into the analog data.
                        data->push_segment(segment);
                }
@@ -839,6 +1036,8 @@ void Session::feed_in_analog(shared_ptr<Analog> analog)
 void Session::data_feed_in(shared_ptr<sigrok::Device> device,
        shared_ptr<Packet> packet)
 {
+       static bool frame_began=false;
+
        (void)device;
 
        assert(device);
@@ -860,6 +1059,7 @@ void Session::data_feed_in(shared_ptr<sigrok::Device> device,
 
        case SR_DF_FRAME_BEGIN:
                feed_in_frame_begin();
+               frame_began = true;
                break;
 
        case SR_DF_LOGIC:
@@ -880,6 +1080,7 @@ void Session::data_feed_in(shared_ptr<sigrok::Device> device,
                }
                break;
 
+       case SR_DF_FRAME_END:
        case SR_DF_END:
        {
                {
@@ -887,7 +1088,10 @@ void Session::data_feed_in(shared_ptr<sigrok::Device> device,
                        cur_logic_segment_.reset();
                        cur_analog_segments_.clear();
                }
-               frame_ended();
+               if (frame_began) {
+                       frame_began = false;
+                       frame_ended();
+               }
                break;
        }
        default:
@@ -895,4 +1099,9 @@ void Session::data_feed_in(shared_ptr<sigrok::Device> device,
        }
 }
 
+void Session::on_data_saved()
+{
+       data_saved_ = true;
+}
+
 } // namespace pv