Don't use deprecated headers.

[pulseview.git] / pv / prop / enum.cpp

diff --git a/pv/prop/enum.cpp b/pv/prop/enum.cpp
index 894ba9f8e2754ded46f9e07b783484871d25eade..9e4fcd0e35dd706baf15bb65e463a5e5e5bdb8da 100644 (file)
--- a/pv/prop/enum.cpp
+++ b/pv/prop/enum.cpp
@@ -14,68 +14,74 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <assert.h>
+#include <cassert>
 
-#include <glib-2.0/glib.h>
 #include <QComboBox>
 
-#include "enum.h"
+#include "enum.hpp"
 
-using namespace boost;
-using namespace std;
+using std::pair;
+using std::vector;
 
 namespace pv {
 namespace prop {
 
 Enum::Enum(QString name,
-       vector<pair<const void*, QString> > values,
-       function<GVariant* ()> getter,
-       function<void (GVariant*)> setter) :
-       Property(name),
-       _values(values),
-       _getter(getter),
-       _setter(setter),
-       _selector(NULL)
+       vector<pair<Glib::VariantBase, QString> > values,
+       Getter getter, Setter setter) :
+       Property(name, getter, setter),
+       values_(values),
+       selector_(nullptr)
 {
 }
 
-QWidget* Enum::get_widget(QWidget *parent)
+QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
 {
-       if (_selector)
-               return _selector;
-
-       const void *value = NULL;
-       if (_getter)
-               value = _getter();
-
-       _selector = new QComboBox(parent);
-       for (unsigned int i = 0; i < _values.size(); i++) {
-               const pair<const void*, QString> &v = _values[i];
-               _selector->addItem(v.second,
-                       qVariantFromValue((void*)v.first));
-               if (v.first == value)
-                       _selector->setCurrentIndex(i);
+       if (selector_)
+               return selector_;
+
+       if (!getter_)
+               return nullptr;
+
+       Glib::VariantBase variant = getter_();
+       if (!variant.gobj())
+               return nullptr;
+
+       selector_ = new QComboBox(parent);
+       for (unsigned int i = 0; i < values_.size(); i++) {
+               const pair<Glib::VariantBase, QString> &v = values_[i];
+               selector_->addItem(v.second, qVariantFromValue(v.first));
+               if (v.first.equal(variant))
+                       selector_->setCurrentIndex(i);
        }
 
-       return _selector;
+       if (auto_commit)
+               connect(selector_, SIGNAL(currentIndexChanged(int)),
+                       this, SLOT(on_current_item_changed(int)));
+
+       return selector_;
 }
 
 void Enum::commit()
 {
-       assert(_setter);
+       assert(setter_);
 
-       if (!_selector)
+       if (!selector_)
                return;
 
-       const int index = _selector->currentIndex();
+       const int index = selector_->currentIndex();
        if (index < 0)
                return;
 
-       _setter(_selector->itemData(index).value<GVariant*>());
+       setter_(selector_->itemData(index).value<Glib::VariantBase>());
+}
+
+void Enum::on_current_item_changed(int)
+{
+       commit();
 }
 
 } // prop