]> sigrok.org Git - pulseview.git/blobdiff - pv/data/decodesignal.cpp
Implement MathSignal
[pulseview.git] / pv / data / decodesignal.cpp
index 4a9c139bb039a90627960d35c6a24a4f64ae7b3f..a17ea693aaa89d67ca3859751529e84b75b42eb2 100644 (file)
@@ -17,6 +17,8 @@
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <cstring>
+#include <forward_list>
 #include <limits>
 
 #include <QDebug>
 #include "decodesignal.hpp"
 #include "signaldata.hpp"
 
-#include <pv/binding/decoder.hpp>
 #include <pv/data/decode/decoder.hpp>
 #include <pv/data/decode/row.hpp>
+#include <pv/globalsettings.hpp>
 #include <pv/session.hpp>
 
 using std::lock_guard;
-using std::make_pair;
 using std::make_shared;
 using std::min;
+using std::out_of_range;
 using std::shared_ptr;
 using std::unique_lock;
-using pv::data::decode::Annotation;
-using pv::data::decode::Decoder;
-using pv::data::decode::Row;
+using pv::data::decode::AnnotationClass;
+using pv::data::decode::DecodeChannel;
 
 namespace pv {
 namespace data {
@@ -48,28 +49,23 @@ const double DecodeSignal::DecodeMargin = 1.0;
 const double DecodeSignal::DecodeThreshold = 0.2;
 const int64_t DecodeSignal::DecodeChunkLength = 256 * 1024;
 
-mutex DecodeSignal::global_srd_mutex_;
-
 
 DecodeSignal::DecodeSignal(pv::Session &session) :
        SignalBase(nullptr, SignalBase::DecodeChannel),
        session_(session),
        srd_session_(nullptr),
        logic_mux_data_invalid_(false),
-       start_time_(0),
-       samplerate_(0),
-       samples_decoded_(0),
-       frame_complete_(false)
+       stack_config_changed_(true),
+       current_segment_id_(0),
+       error_message_("")
 {
        connect(&session_, SIGNAL(capture_state_changed(int)),
                this, SLOT(on_capture_state_changed(int)));
-
-       set_name(tr("Empty decoder signal"));
 }
 
 DecodeSignal::~DecodeSignal()
 {
-       reset_decode();
+       reset_decode(true);
 }
 
 const vector< shared_ptr<Decoder> >& DecodeSignal::decoder_stack() const
@@ -77,21 +73,34 @@ const vector< shared_ptr<Decoder> >& DecodeSignal::decoder_stack() const
        return stack_;
 }
 
-void DecodeSignal::stack_decoder(const srd_decoder *decoder)
+void DecodeSignal::stack_decoder(const srd_decoder *decoder, bool restart_decode)
 {
        assert(decoder);
-       stack_.push_back(make_shared<decode::Decoder>(decoder));
 
-       // Set name if this decoder is the first in the list
-       if (stack_.size() == 1)
+       // Set name if this decoder is the first in the list or the name is unchanged
+       const srd_decoder* prev_dec = stack_.empty() ? nullptr : stack_.back()->get_srd_decoder();
+       const QString prev_dec_name = prev_dec ? QString::fromUtf8(prev_dec->name) : QString();
+
+       if ((stack_.empty()) || ((stack_.size() > 0) && (name() == prev_dec_name)))
                set_name(QString::fromUtf8(decoder->name));
 
+       const shared_ptr<Decoder> dec = make_shared<Decoder>(decoder, stack_.size());
+       stack_.push_back(dec);
+
+       connect(dec.get(), SIGNAL(annotation_visibility_changed()),
+               this, SLOT(on_annotation_visibility_changed()));
+
        // Include the newly created decode channels in the channel lists
        update_channel_list();
 
-       auto_assign_signals();
+       stack_config_changed_ = true;
+       auto_assign_signals(dec);
        commit_decoder_channels();
-       begin_decode();
+
+       decoder_stacked((void*)dec.get());
+
+       if (restart_decode)
+               begin_decode();
 }
 
 void DecodeSignal::remove_decoder(int index)
@@ -100,14 +109,18 @@ void DecodeSignal::remove_decoder(int index)
        assert(index < (int)stack_.size());
 
        // Find the decoder in the stack
-       auto iter = stack_.begin();
-       for (int i = 0; i < index; i++, iter++)
-               assert(iter != stack_.end());
+       auto iter = stack_.begin() + index;
+       assert(iter != stack_.end());
+
+       shared_ptr<Decoder> dec = *iter;
+
+       decoder_removed(dec.get());
 
        // Delete the element
        stack_.erase(iter);
 
        // Update channels and decoded data
+       stack_config_changed_ = true;
        update_channel_list();
        begin_decode();
 }
@@ -123,15 +136,22 @@ bool DecodeSignal::toggle_decoder_visibility(int index)
        // Toggle decoder visibility
        bool state = false;
        if (dec) {
-               state = !dec->shown();
-               dec->show(state);
+               state = !dec->visible();
+               dec->set_visible(state);
        }
 
        return state;
 }
 
-void DecodeSignal::reset_decode()
+void DecodeSignal::reset_decode(bool shutting_down)
 {
+       resume_decode();  // Make sure the decode thread isn't blocked by pausing
+
+       if (stack_config_changed_ || shutting_down)
+               stop_srd_session();
+       else
+               terminate_srd_session();
+
        if (decode_thread_.joinable()) {
                decode_interrupt_ = true;
                decode_input_cond_.notify_one();
@@ -144,17 +164,19 @@ void DecodeSignal::reset_decode()
                logic_mux_thread_.join();
        }
 
-       stop_srd_session();
-
-       frame_complete_ = false;
-       samples_decoded_ = 0;
-       error_message_ = QString();
-
-       rows_.clear();
-       class_rows_.clear();
+       current_segment_id_ = 0;
+       segments_.clear();
 
        logic_mux_data_.reset();
        logic_mux_data_invalid_ = true;
+
+       if (!error_message_.isEmpty()) {
+               error_message_ = QString();
+               // TODO Emulate noquote()
+               qDebug().nospace() << name() << ": Error cleared";
+       }
+
+       decode_reset();
 }
 
 void DecodeSignal::begin_decode()
@@ -174,71 +196,48 @@ void DecodeSignal::begin_decode()
        reset_decode();
 
        if (stack_.size() == 0) {
-               error_message_ = tr("No decoders");
+               set_error_message(tr("No decoders"));
                return;
        }
 
        assert(channels_.size() > 0);
 
        if (get_assigned_signal_count() == 0) {
-               error_message_ = tr("There are no channels assigned to this decoder");
+               set_error_message(tr("There are no channels assigned to this decoder"));
                return;
        }
 
        // Make sure that all assigned channels still provide logic data
        // (can happen when a converted signal was assigned but the
        // conversion removed in the meanwhile)
-       for (data::DecodeChannel &ch : channels_)
+       for (decode::DecodeChannel& ch : channels_)
                if (ch.assigned_signal && !(ch.assigned_signal->logic_data() != nullptr))
                        ch.assigned_signal = nullptr;
 
        // Check that all decoders have the required channels
-       for (const shared_ptr<decode::Decoder> &dec : stack_)
+       for (const shared_ptr<Decoder>& dec : stack_)
                if (!dec->have_required_channels()) {
-                       error_message_ = tr("One or more required channels "
-                               "have not been specified");
+                       set_error_message(tr("One or more required channels "
+                               "have not been specified"));
                        return;
                }
 
-       // Add annotation classes
-       for (const shared_ptr<decode::Decoder> &dec : stack_) {
-               assert(dec);
-               const srd_decoder *const decc = dec->decoder();
-               assert(dec->decoder());
-
-               // Add a row for the decoder if it doesn't have a row list
-               if (!decc->annotation_rows)
-                       rows_[Row(decc)] = decode::RowData();
-
-               // Add the decoder rows
-               for (const GSList *l = decc->annotation_rows; l; l = l->next) {
-                       const srd_decoder_annotation_row *const ann_row =
-                               (srd_decoder_annotation_row *)l->data;
-                       assert(ann_row);
-
-                       const Row row(decc, ann_row);
-
-                       // Add a new empty row data object
-                       rows_[row] = decode::RowData();
-
-                       // Map out all the classes
-                       for (const GSList *ll = ann_row->ann_classes;
-                               ll; ll = ll->next)
-                               class_rows_[make_pair(decc,
-                                       GPOINTER_TO_INT(ll->data))] = row;
-               }
-       }
-
        // Free the logic data and its segment(s) if it needs to be updated
        if (logic_mux_data_invalid_)
                logic_mux_data_.reset();
 
        if (!logic_mux_data_) {
-               const int64_t ch_count = get_assigned_signal_count();
-               const int64_t unit_size = (ch_count + 7) / 8;
+               const uint32_t ch_count = get_assigned_signal_count();
+               logic_mux_unit_size_ = (ch_count + 7) / 8;
                logic_mux_data_ = make_shared<Logic>(ch_count);
-               segment_ = make_shared<LogicSegment>(*logic_mux_data_, unit_size, samplerate_);
-               logic_mux_data_->push_segment(segment_);
+       }
+
+       // Receive notifications when new sample data is available
+       connect_input_notifiers();
+
+       if (get_input_segment_count() == 0) {
+               set_error_message(tr("No input data"));
+               return;
        }
 
        // Make sure the logic output data is complete and up-to-date
@@ -248,9 +247,25 @@ void DecodeSignal::begin_decode()
        // Decode the muxed logic data
        decode_interrupt_ = false;
        decode_thread_ = std::thread(&DecodeSignal::decode_proc, this);
+}
 
-       // Receive notifications when new sample data is available
-       connect_input_notifiers();
+void DecodeSignal::pause_decode()
+{
+       decode_paused_ = true;
+}
+
+void DecodeSignal::resume_decode()
+{
+       // Manual unlocking is done before notifying, to avoid waking up the
+       // waiting thread only to block again (see notify_one for details)
+       decode_pause_mutex_.unlock();
+       decode_pause_cond_.notify_one();
+       decode_paused_ = false;
+}
+
+bool DecodeSignal::is_paused() const
+{
+       return decode_paused_;
 }
 
 QString DecodeSignal::error_message() const
@@ -259,34 +274,58 @@ QString DecodeSignal::error_message() const
        return error_message_;
 }
 
-const vector<data::DecodeChannel> DecodeSignal::get_channels() const
+const vector<decode::DecodeChannel> DecodeSignal::get_channels() const
 {
        return channels_;
 }
 
-void DecodeSignal::auto_assign_signals()
+void DecodeSignal::auto_assign_signals(const shared_ptr<Decoder> dec)
 {
        bool new_assignment = false;
 
        // Try to auto-select channels that don't have signals assigned yet
-       for (data::DecodeChannel &ch : channels_) {
+       for (decode::DecodeChannel& ch : channels_) {
+               // If a decoder is given, auto-assign only its channels
+               if (dec && (ch.decoder_ != dec))
+                       continue;
+
                if (ch.assigned_signal)
                        continue;
 
-               for (shared_ptr<data::SignalBase> s : session_.signalbases()) {
-                       const QString ch_name = ch.name.toLower();
-                       const QString s_name = s->name().toLower();
+               QString ch_name = ch.name.toLower();
+               ch_name = ch_name.replace(QRegExp("[-_.]"), " ");
+
+               shared_ptr<data::SignalBase> match;
+               for (const shared_ptr<data::SignalBase>& s : session_.signalbases()) {
+                       if (!s->enabled())
+                               continue;
+
+                       QString s_name = s->name().toLower();
+                       s_name = s_name.replace(QRegExp("[-_.]"), " ");
 
                        if (s->logic_data() &&
                                ((ch_name.contains(s_name)) || (s_name.contains(ch_name)))) {
-                               ch.assigned_signal = s.get();
-                               new_assignment = true;
+                               if (!match)
+                                       match = s;
+                               else {
+                                       // Only replace an existing match if it matches more characters
+                                       int old_unmatched = ch_name.length() - match->name().length();
+                                       int new_unmatched = ch_name.length() - s->name().length();
+                                       if (abs(new_unmatched) < abs(old_unmatched))
+                                               match = s;
+                               }
                        }
                }
+
+               if (match) {
+                       ch.assigned_signal = match.get();
+                       new_assignment = true;
+               }
        }
 
        if (new_assignment) {
                logic_mux_data_invalid_ = true;
+               stack_config_changed_ = true;
                commit_decoder_channels();
                channels_updated();
        }
@@ -294,12 +333,13 @@ void DecodeSignal::auto_assign_signals()
 
 void DecodeSignal::assign_signal(const uint16_t channel_id, const SignalBase *signal)
 {
-       for (data::DecodeChannel &ch : channels_)
+       for (decode::DecodeChannel& ch : channels_)
                if (ch.id == channel_id) {
                        ch.assigned_signal = signal;
                        logic_mux_data_invalid_ = true;
                }
 
+       stack_config_changed_ = true;
        commit_decoder_channels();
        channels_updated();
        begin_decode();
@@ -309,104 +349,307 @@ int DecodeSignal::get_assigned_signal_count() const
 {
        // Count all channels that have a signal assigned to them
        return count_if(channels_.begin(), channels_.end(),
-               [](data::DecodeChannel ch) { return ch.assigned_signal; });
+               [](decode::DecodeChannel ch) { return ch.assigned_signal; });
 }
 
 void DecodeSignal::set_initial_pin_state(const uint16_t channel_id, const int init_state)
 {
-       for (data::DecodeChannel &ch : channels_)
+       for (decode::DecodeChannel& ch : channels_)
                if (ch.id == channel_id)
                        ch.initial_pin_state = init_state;
 
+       stack_config_changed_ = true;
        channels_updated();
-
        begin_decode();
 }
 
-double DecodeSignal::samplerate() const
+double DecodeSignal::get_samplerate() const
 {
-       return samplerate_;
+       double result = 0;
+
+       // TODO For now, we simply return the first samplerate that we have
+       if (segments_.size() > 0)
+               result = segments_.front().samplerate;
+
+       return result;
 }
 
-const pv::util::Timestamp& DecodeSignal::start_time() const
+const pv::util::Timestamp DecodeSignal::start_time() const
 {
-       return start_time_;
+       pv::util::Timestamp result;
+
+       // TODO For now, we simply return the first start time that we have
+       if (segments_.size() > 0)
+               result = segments_.front().start_time;
+
+       return result;
 }
 
-int64_t DecodeSignal::get_working_sample_count() const
+int64_t DecodeSignal::get_working_sample_count(uint32_t segment_id) const
 {
        // The working sample count is the highest sample number for
-       // which all used signals have data available, so go through
-       // all channels and use the lowest overall sample count of the
-       // current segment
-
-       // TODO Currently, we assume only a single segment exists
+       // which all used signals have data available, so go through all
+       // channels and use the lowest overall sample count of the segment
 
        int64_t count = std::numeric_limits<int64_t>::max();
        bool no_signals_assigned = true;
 
-       for (const data::DecodeChannel &ch : channels_)
+       for (const decode::DecodeChannel& ch : channels_)
                if (ch.assigned_signal) {
+                       if (!ch.assigned_signal->logic_data())
+                               return 0;
+
                        no_signals_assigned = false;
 
                        const shared_ptr<Logic> logic_data = ch.assigned_signal->logic_data();
-                       if (!logic_data || logic_data->logic_segments().empty())
+                       if (logic_data->logic_segments().empty())
+                               return 0;
+
+                       if (segment_id >= logic_data->logic_segments().size())
                                return 0;
 
-                       const shared_ptr<LogicSegment> segment = logic_data->logic_segments().front();
+                       const shared_ptr<LogicSegment> segment = logic_data->logic_segments()[segment_id];
                        count = min(count, (int64_t)segment->get_sample_count());
                }
 
        return (no_signals_assigned ? 0 : count);
 }
 
-int64_t DecodeSignal::get_decoded_sample_count() const
+int64_t DecodeSignal::get_decoded_sample_count(uint32_t segment_id,
+       bool include_processing) const
 {
        lock_guard<mutex> decode_lock(output_mutex_);
-       return samples_decoded_;
+
+       int64_t result = 0;
+
+       if (segment_id >= segments_.size())
+               return result;
+
+       if (include_processing)
+               result = segments_[segment_id].samples_decoded_incl;
+       else
+               result = segments_[segment_id].samples_decoded_excl;
+
+       return result;
 }
 
-vector<Row> DecodeSignal::visible_rows() const
+vector<Row*> DecodeSignal::get_rows(bool visible_only)
 {
-       lock_guard<mutex> lock(output_mutex_);
+       vector<Row*> rows;
 
-       vector<Row> rows;
-
-       for (const shared_ptr<decode::Decoder> &dec : stack_) {
+       for (const shared_ptr<Decoder>& dec : stack_) {
                assert(dec);
-               if (!dec->shown())
+               if (visible_only && !dec->visible())
                        continue;
 
-               const srd_decoder *const decc = dec->decoder();
-               assert(dec->decoder());
+               for (Row* row : dec->get_rows())
+                       rows.push_back(row);
+       }
+
+       return rows;
+}
 
-               // Add a row for the decoder if it doesn't have a row list
-               if (!decc->annotation_rows)
-                       rows.emplace_back(decc);
+vector<const Row*> DecodeSignal::get_rows(bool visible_only) const
+{
+       vector<const Row*> rows;
 
-               // Add the decoder rows
-               for (const GSList *l = decc->annotation_rows; l; l = l->next) {
-                       const srd_decoder_annotation_row *const ann_row =
-                               (srd_decoder_annotation_row *)l->data;
-                       assert(ann_row);
-                       rows.emplace_back(decc, ann_row);
-               }
+       for (const shared_ptr<Decoder>& dec : stack_) {
+               assert(dec);
+               if (visible_only && !dec->visible())
+                       continue;
+
+               for (const Row* row : dec->get_rows())
+                       rows.push_back(row);
        }
 
        return rows;
 }
 
-void DecodeSignal::get_annotation_subset(
-       vector<pv::data::decode::Annotation> &dest,
-       const decode::Row &row, uint64_t start_sample,
+
+uint64_t DecodeSignal::get_annotation_count(const Row* row, uint32_t segment_id) const
+{
+       if (segment_id >= segments_.size())
+               return 0;
+
+       const DecodeSegment* segment = &(segments_.at(segment_id));
+
+       auto row_it = segment->annotation_rows.find(row);
+
+       const RowData* rd;
+       if (row_it == segment->annotation_rows.end())
+               return 0;
+       else
+               rd = &(row_it->second);
+
+       return rd->get_annotation_count();
+}
+
+void DecodeSignal::get_annotation_subset(deque<const Annotation*> &dest,
+       const Row* row, uint32_t segment_id, uint64_t start_sample,
        uint64_t end_sample) const
 {
        lock_guard<mutex> lock(output_mutex_);
 
-       const auto iter = rows_.find(row);
-       if (iter != rows_.end())
-               (*iter).second.get_annotation_subset(dest,
-                       start_sample, end_sample);
+       if (segment_id >= segments_.size())
+               return;
+
+       const DecodeSegment* segment = &(segments_.at(segment_id));
+
+       auto row_it = segment->annotation_rows.find(row);
+
+       const RowData* rd;
+       if (row_it == segment->annotation_rows.end())
+               return;
+       else
+               rd = &(row_it->second);
+
+       rd->get_annotation_subset(dest, start_sample, end_sample);
+}
+
+void DecodeSignal::get_annotation_subset(deque<const Annotation*> &dest,
+       uint32_t segment_id, uint64_t start_sample, uint64_t end_sample) const
+{
+       for (const Row* row : get_rows())
+               get_annotation_subset(dest, row, segment_id, start_sample, end_sample);
+}
+
+uint32_t DecodeSignal::get_binary_data_chunk_count(uint32_t segment_id,
+       const Decoder* dec, uint32_t bin_class_id) const
+{
+       if ((segments_.size() == 0) || (segment_id >= segments_.size()))
+               return 0;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       for (const DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder == dec) && (bc.info->bin_class_id == bin_class_id))
+                       return bc.chunks.size();
+
+       return 0;
+}
+
+void DecodeSignal::get_binary_data_chunk(uint32_t segment_id,
+       const  Decoder* dec, uint32_t bin_class_id, uint32_t chunk_id,
+       const vector<uint8_t> **dest, uint64_t *size)
+{
+       if (segment_id >= segments_.size())
+               return;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       for (const DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder == dec) && (bc.info->bin_class_id == bin_class_id)) {
+                       if (dest) *dest = &(bc.chunks.at(chunk_id).data);
+                       if (size) *size = bc.chunks.at(chunk_id).data.size();
+                       return;
+               }
+}
+
+void DecodeSignal::get_merged_binary_data_chunks_by_sample(uint32_t segment_id,
+       const Decoder* dec, uint32_t bin_class_id, uint64_t start_sample,
+       uint64_t end_sample, vector<uint8_t> *dest) const
+{
+       assert(dest != nullptr);
+
+       if (segment_id >= segments_.size())
+               return;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       const DecodeBinaryClass* bin_class = nullptr;
+       for (const DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder == dec) && (bc.info->bin_class_id == bin_class_id))
+                       bin_class = &bc;
+
+       // Determine overall size before copying to resize dest vector only once
+       uint64_t size = 0;
+       uint64_t matches = 0;
+       for (const DecodeBinaryDataChunk& chunk : bin_class->chunks)
+               if ((chunk.sample >= start_sample) && (chunk.sample < end_sample)) {
+                       size += chunk.data.size();
+                       matches++;
+               }
+       dest->resize(size);
+
+       uint64_t offset = 0;
+       uint64_t matches2 = 0;
+       for (const DecodeBinaryDataChunk& chunk : bin_class->chunks)
+               if ((chunk.sample >= start_sample) && (chunk.sample < end_sample)) {
+                       memcpy(dest->data() + offset, chunk.data.data(), chunk.data.size());
+                       offset += chunk.data.size();
+                       matches2++;
+
+                       // Make sure we don't overwrite memory if the array grew in the meanwhile
+                       if (matches2 == matches)
+                               break;
+               }
+}
+
+void DecodeSignal::get_merged_binary_data_chunks_by_offset(uint32_t segment_id,
+       const Decoder* dec, uint32_t bin_class_id, uint64_t start, uint64_t end,
+       vector<uint8_t> *dest) const
+{
+       assert(dest != nullptr);
+
+       if (segment_id >= segments_.size())
+               return;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       const DecodeBinaryClass* bin_class = nullptr;
+       for (const DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder == dec) && (bc.info->bin_class_id == bin_class_id))
+                       bin_class = &bc;
+
+       // Determine overall size before copying to resize dest vector only once
+       uint64_t size = 0;
+       uint64_t offset = 0;
+       for (const DecodeBinaryDataChunk& chunk : bin_class->chunks) {
+               if (offset >= start)
+                       size += chunk.data.size();
+               offset += chunk.data.size();
+               if (offset >= end)
+                       break;
+       }
+       dest->resize(size);
+
+       offset = 0;
+       uint64_t dest_offset = 0;
+       for (const DecodeBinaryDataChunk& chunk : bin_class->chunks) {
+               if (offset >= start) {
+                       memcpy(dest->data() + dest_offset, chunk.data.data(), chunk.data.size());
+                       dest_offset += chunk.data.size();
+               }
+               offset += chunk.data.size();
+               if (offset >= end)
+                       break;
+       }
+}
+
+const DecodeBinaryClass* DecodeSignal::get_binary_data_class(uint32_t segment_id,
+       const Decoder* dec, uint32_t bin_class_id) const
+{
+       if (segment_id >= segments_.size())
+               return nullptr;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       for (const DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder == dec) && (bc.info->bin_class_id == bin_class_id))
+                       return &bc;
+
+       return nullptr;
+}
+
+const deque<const Annotation*>* DecodeSignal::get_all_annotations_by_segment(
+       uint32_t segment_id) const
+{
+       if (segment_id >= segments_.size())
+               return nullptr;
+
+       const DecodeSegment *segment = &(segments_[segment_id]);
+
+       return &(segment->all_annotations);
 }
 
 void DecodeSignal::save_settings(QSettings &settings) const
@@ -415,22 +658,80 @@ void DecodeSignal::save_settings(QSettings &settings) const
 
        settings.setValue("decoders", (int)(stack_.size()));
 
+       // Save decoder stack
        int decoder_idx = 0;
-       for (shared_ptr<decode::Decoder> decoder : stack_) {
+       for (const shared_ptr<Decoder>& decoder : stack_) {
                settings.beginGroup("decoder" + QString::number(decoder_idx++));
 
-               settings.setValue("id", decoder->decoder()->id);
+               settings.setValue("id", decoder->get_srd_decoder()->id);
+               settings.setValue("visible", decoder->visible());
+
+               // Save decoder options
+               const map<string, GVariant*>& options = decoder->options();
+
+               settings.setValue("options", (int)options.size());
+
+               // Note: Decoder::options() returns only the options
+               // that differ from the default. See binding::Decoder::getter()
+               int i = 0;
+               for (auto& option : options) {
+                       settings.beginGroup("option" + QString::number(i));
+                       settings.setValue("name", QString::fromStdString(option.first));
+                       GlobalSettings::store_gvariant(settings, option.second);
+                       settings.endGroup();
+                       i++;
+               }
+
+               // Save row properties
+               i = 0;
+               for (const Row* row : decoder->get_rows()) {
+                       settings.beginGroup("row" + QString::number(i));
+                       settings.setValue("visible", row->visible());
+                       settings.endGroup();
+                       i++;
+               }
+
+               // Save class properties
+               i = 0;
+               for (const AnnotationClass* ann_class : decoder->ann_classes()) {
+                       settings.beginGroup("ann_class" + QString::number(i));
+                       settings.setValue("visible", ann_class->visible());
+                       settings.endGroup();
+                       i++;
+               }
 
                settings.endGroup();
        }
 
-       // TODO Save channel mapping and decoder options
+       // Save channel mapping
+       settings.setValue("channels", (int)channels_.size());
+
+       for (unsigned int channel_id = 0; channel_id < channels_.size(); channel_id++) {
+               auto channel = find_if(channels_.begin(), channels_.end(),
+                       [&](decode::DecodeChannel ch) { return ch.id == channel_id; });
+
+               if (channel == channels_.end()) {
+                       qDebug() << "ERROR: Gap in channel index:" << channel_id;
+                       continue;
+               }
+
+               settings.beginGroup("channel" + QString::number(channel_id));
+
+               settings.setValue("name", channel->name);  // Useful for debugging
+               settings.setValue("initial_pin_state", channel->initial_pin_state);
+
+               if (channel->assigned_signal)
+                       settings.setValue("assigned_signal_name", channel->assigned_signal->name());
+
+               settings.endGroup();
+       }
 }
 
 void DecodeSignal::restore_settings(QSettings &settings)
 {
        SignalBase::restore_settings(settings);
 
+       // Restore decoder stack
        GSList *dec_list = g_slist_copy((GSList*)srd_decoder_list());
 
        int decoders = settings.value("decoders").toInt();
@@ -446,39 +747,168 @@ void DecodeSignal::restore_settings(QSettings &settings)
                                continue;
 
                        if (QString::fromUtf8(dec->id) == id) {
-                               stack_.push_back(make_shared<decode::Decoder>(dec));
+                               shared_ptr<Decoder> decoder = make_shared<Decoder>(dec, stack_.size());
+
+                               connect(decoder.get(), SIGNAL(annotation_visibility_changed()),
+                                       this, SLOT(on_annotation_visibility_changed()));
+
+                               stack_.push_back(decoder);
+                               decoder->set_visible(settings.value("visible", true).toBool());
+
+                               // Restore decoder options that differ from their default
+                               int options = settings.value("options").toInt();
+
+                               for (int i = 0; i < options; i++) {
+                                       settings.beginGroup("option" + QString::number(i));
+                                       QString name = settings.value("name").toString();
+                                       GVariant *value = GlobalSettings::restore_gvariant(settings);
+                                       decoder->set_option(name.toUtf8(), value);
+                                       settings.endGroup();
+                               }
 
                                // Include the newly created decode channels in the channel lists
                                update_channel_list();
+
+                               // Restore row properties
+                               int i = 0;
+                               for (Row* row : decoder->get_rows()) {
+                                       settings.beginGroup("row" + QString::number(i));
+                                       row->set_visible(settings.value("visible", true).toBool());
+                                       settings.endGroup();
+                                       i++;
+                               }
+
+                               // Restore class properties
+                               i = 0;
+                               for (AnnotationClass* ann_class : decoder->ann_classes()) {
+                                       settings.beginGroup("ann_class" + QString::number(i));
+                                       ann_class->set_visible(settings.value("visible", true).toBool());
+                                       settings.endGroup();
+                                       i++;
+                               }
+
                                break;
                        }
                }
 
+               settings.endGroup();
+               channels_updated();
+       }
+
+       // Restore channel mapping
+       unsigned int channels = settings.value("channels").toInt();
+
+       const vector< shared_ptr<data::SignalBase> > signalbases =
+               session_.signalbases();
+
+       for (unsigned int channel_id = 0; channel_id < channels; channel_id++) {
+               auto channel = find_if(channels_.begin(), channels_.end(),
+                       [&](decode::DecodeChannel ch) { return ch.id == channel_id; });
+
+               if (channel == channels_.end()) {
+                       qDebug() << "ERROR: Non-existant channel index:" << channel_id;
+                       continue;
+               }
+
+               settings.beginGroup("channel" + QString::number(channel_id));
+
+               QString assigned_signal_name = settings.value("assigned_signal_name").toString();
+
+               for (const shared_ptr<data::SignalBase>& signal : signalbases)
+                       if ((signal->name() == assigned_signal_name) && (signal->type() != SignalBase::DecodeChannel))
+                               channel->assigned_signal = signal.get();
+
+               channel->initial_pin_state = settings.value("initial_pin_state").toInt();
+
                settings.endGroup();
        }
 
-       // TODO Restore channel mapping and decoder options
+       // Update the internal structures
+       stack_config_changed_ = true;
+       update_channel_list();
+       commit_decoder_channels();
+
+       begin_decode();
+}
+
+void DecodeSignal::set_error_message(QString msg)
+{
+       error_message_ = msg;
+       // TODO Emulate noquote()
+       qDebug().nospace() << name() << ": " << msg;
+}
+
+uint32_t DecodeSignal::get_input_segment_count() const
+{
+       uint64_t count = std::numeric_limits<uint64_t>::max();
+       bool no_signals_assigned = true;
+
+       for (const decode::DecodeChannel& ch : channels_)
+               if (ch.assigned_signal) {
+                       no_signals_assigned = false;
+
+                       const shared_ptr<Logic> logic_data = ch.assigned_signal->logic_data();
+                       if (!logic_data || logic_data->logic_segments().empty())
+                               return 0;
+
+                       // Find the min value of all segment counts
+                       if ((uint64_t)(logic_data->logic_segments().size()) < count)
+                               count = logic_data->logic_segments().size();
+               }
+
+       return (no_signals_assigned ? 0 : count);
+}
+
+double DecodeSignal::get_input_samplerate(uint32_t segment_id) const
+{
+       double samplerate = 0;
+
+       for (const decode::DecodeChannel& ch : channels_)
+               if (ch.assigned_signal) {
+                       const shared_ptr<Logic> logic_data = ch.assigned_signal->logic_data();
+                       if (!logic_data || logic_data->logic_segments().empty())
+                               continue;
+
+                       try {
+                               const shared_ptr<LogicSegment> segment = logic_data->logic_segments().at(segment_id);
+                               samplerate = segment->samplerate();
+                       } catch (out_of_range&) {
+                               // Do nothing
+                       }
+                       break;
+               }
+
+       return samplerate;
+}
+
+Decoder* DecodeSignal::get_decoder_by_instance(const srd_decoder *const srd_dec)
+{
+       for (shared_ptr<Decoder>& d : stack_)
+               if (d->get_srd_decoder() == srd_dec)
+                       return d.get();
+
+       return nullptr;
 }
 
 void DecodeSignal::update_channel_list()
 {
-       vector<data::DecodeChannel> prev_channels = channels_;
+       vector<decode::DecodeChannel> prev_channels = channels_;
        channels_.clear();
 
        uint16_t id = 0;
 
        // Copy existing entries, create new as needed
-       for (shared_ptr<Decoder> decoder : stack_) {
-               const srd_decoder* srd_d = decoder->decoder();
+       for (shared_ptr<Decoder>& decoder : stack_) {
+               const srd_decoder* srd_dec = decoder->get_srd_decoder();
                const GSList *l;
 
                // Mandatory channels
-               for (l = srd_d->channels; l; l = l->next) {
+               for (l = srd_dec->channels; l; l = l->next) {
                        const struct srd_channel *const pdch = (struct srd_channel *)l->data;
                        bool ch_added = false;
 
                        // Copy but update ID if this channel was in the list before
-                       for (data::DecodeChannel &ch : prev_channels)
+                       for (decode::DecodeChannel& ch : prev_channels)
                                if (ch.pdch_ == pdch) {
                                        ch.id = id++;
                                        channels_.push_back(ch);
@@ -488,7 +918,7 @@ void DecodeSignal::update_channel_list()
 
                        if (!ch_added) {
                                // Create new entry without a mapped signal
-                               data::DecodeChannel ch = {id++, false, nullptr,
+                               decode::DecodeChannel ch = {id++, 0, false, nullptr,
                                        QString::fromUtf8(pdch->name), QString::fromUtf8(pdch->desc),
                                        SRD_INITIAL_PIN_SAME_AS_SAMPLE0, decoder, pdch};
                                channels_.push_back(ch);
@@ -496,12 +926,12 @@ void DecodeSignal::update_channel_list()
                }
 
                // Optional channels
-               for (l = srd_d->opt_channels; l; l = l->next) {
+               for (l = srd_dec->opt_channels; l; l = l->next) {
                        const struct srd_channel *const pdch = (struct srd_channel *)l->data;
                        bool ch_added = false;
 
                        // Copy but update ID if this channel was in the list before
-                       for (data::DecodeChannel &ch : prev_channels)
+                       for (decode::DecodeChannel& ch : prev_channels)
                                if (ch.pdch_ == pdch) {
                                        ch.id = id++;
                                        channels_.push_back(ch);
@@ -511,7 +941,7 @@ void DecodeSignal::update_channel_list()
 
                        if (!ch_added) {
                                // Create new entry without a mapped signal
-                               data::DecodeChannel ch = {id++, true, nullptr,
+                               decode::DecodeChannel ch = {id++, 0, true, nullptr,
                                        QString::fromUtf8(pdch->name), QString::fromUtf8(pdch->desc),
                                        SRD_INITIAL_PIN_SAME_AS_SAMPLE0, decoder, pdch};
                                channels_.push_back(ch);
@@ -526,8 +956,8 @@ void DecodeSignal::update_channel_list()
        } else {
                // Same number but assignment may still differ, so compare all channels
                for (size_t i = 0; i < channels_.size(); i++) {
-                       const data::DecodeChannel &p_ch = prev_channels[i];
-                       const data::DecodeChannel &ch = channels_[i];
+                       const decode::DecodeChannel& p_ch = prev_channels[i];
+                       const decode::DecodeChannel& ch = channels_[i];
 
                        if ((p_ch.pdch_ != ch.pdch_) ||
                                (p_ch.assigned_signal != ch.assigned_signal)) {
@@ -544,52 +974,81 @@ void DecodeSignal::update_channel_list()
 void DecodeSignal::commit_decoder_channels()
 {
        // Submit channel list to every decoder, containing only the relevant channels
-       for (shared_ptr<decode::Decoder> dec : stack_) {
-               vector<data::DecodeChannel*> channel_list;
+       for (shared_ptr<Decoder> dec : stack_) {
+               vector<decode::DecodeChannel*> channel_list;
 
-               for (data::DecodeChannel &ch : channels_)
+               for (decode::DecodeChannel& ch : channels_)
                        if (ch.decoder_ == dec)
                                channel_list.push_back(&ch);
 
                dec->set_channels(channel_list);
        }
+
+       // Channel bit IDs must be in sync with the channel's apperance in channels_
+       int id = 0;
+       for (decode::DecodeChannel& ch : channels_)
+               if (ch.assigned_signal)
+                       ch.bit_id = id++;
 }
 
-void DecodeSignal::mux_logic_samples(const int64_t start, const int64_t end)
+void DecodeSignal::mux_logic_samples(uint32_t segment_id, const int64_t start, const int64_t end)
 {
        // Enforce end to be greater than start
        if (end <= start)
                return;
 
-       // Fetch all segments and their data
-       // TODO Currently, we assume only a single segment exists
+       // Fetch the channel segments and their data
        vector<shared_ptr<LogicSegment> > segments;
        vector<const uint8_t*> signal_data;
        vector<uint8_t> signal_in_bytepos;
        vector<uint8_t> signal_in_bitpos;
 
-       for (data::DecodeChannel &ch : channels_)
+       for (decode::DecodeChannel& ch : channels_)
                if (ch.assigned_signal) {
                        const shared_ptr<Logic> logic_data = ch.assigned_signal->logic_data();
-                       const shared_ptr<LogicSegment> segment = logic_data->logic_segments().front();
+
+                       shared_ptr<LogicSegment> segment;
+                       try {
+                               segment = logic_data->logic_segments().at(segment_id);
+                       } catch (out_of_range&) {
+                               qDebug() << "Muxer error for" << name() << ":" << ch.assigned_signal->name() \
+                                       << "has no logic segment" << segment_id;
+                               return;
+                       }
                        segments.push_back(segment);
-                       signal_data.push_back(segment->get_samples(start, end));
+
+                       uint8_t* data = new uint8_t[(end - start) * segment->unit_size()];
+                       segment->get_samples(start, end, data);
+                       signal_data.push_back(data);
 
                        const int bitpos = ch.assigned_signal->logic_bit_index();
                        signal_in_bytepos.push_back(bitpos / 8);
                        signal_in_bitpos.push_back(bitpos % 8);
                }
 
+
+       shared_ptr<LogicSegment> output_segment;
+       try {
+               output_segment = logic_mux_data_->logic_segments().at(segment_id);
+       } catch (out_of_range&) {
+               qDebug() << "Muxer error for" << name() << ": no logic mux segment" \
+                       << segment_id << "in mux_logic_samples(), mux segments size is" \
+                       << logic_mux_data_->logic_segments().size();
+               return;
+       }
+
        // Perform the muxing of signal data into the output data
-       uint8_t* output = new uint8_t[(end - start) * segment_->unit_size()];
+       uint8_t* output = new uint8_t[(end - start) * output_segment->unit_size()];
        unsigned int signal_count = signal_data.size();
 
-       for (int64_t sample_cnt = 0; sample_cnt < (end - start); sample_cnt++) {
+       for (int64_t sample_cnt = 0; !logic_mux_interrupt_ && (sample_cnt < (end - start));
+               sample_cnt++) {
+
                int bitpos = 0;
                uint8_t bytepos = 0;
 
-               const int out_sample_pos = sample_cnt * segment_->unit_size();
-               for (unsigned int i = 0; i < segment_->unit_size(); i++)
+               const int out_sample_pos = sample_cnt * output_segment->unit_size();
+               for (unsigned int i = 0; i < output_segment->unit_size(); i++)
                        output[out_sample_pos + i] = 0;
 
                for (unsigned int i = 0; i < signal_count; i++) {
@@ -609,7 +1068,7 @@ void DecodeSignal::mux_logic_samples(const int64_t start, const int64_t end)
                }
        }
 
-       segment_->append_payload(output, (end - start) * segment_->unit_size());
+       output_segment->append_payload(output, (end - start) * output_segment->unit_size());
        delete[] output;
 
        for (const uint8_t* data : signal_data)
@@ -618,9 +1077,21 @@ void DecodeSignal::mux_logic_samples(const int64_t start, const int64_t end)
 
 void DecodeSignal::logic_mux_proc()
 {
+       uint32_t segment_id = 0;
+
+       assert(logic_mux_data_);
+
+       // Create initial logic mux segment
+       shared_ptr<LogicSegment> output_segment =
+               make_shared<LogicSegment>(*logic_mux_data_, segment_id,
+                       logic_mux_unit_size_, 0);
+       logic_mux_data_->push_segment(output_segment);
+
+       output_segment->set_samplerate(get_input_samplerate(0));
+
        do {
-               const uint64_t input_sample_count = get_working_sample_count();
-               const uint64_t output_sample_count = segment_->get_sample_count();
+               const uint64_t input_sample_count = get_working_sample_count(segment_id);
+               const uint64_t output_sample_count = output_segment->get_sample_count();
 
                const uint64_t samples_to_process =
                        (input_sample_count > output_sample_count) ?
@@ -628,7 +1099,7 @@ void DecodeSignal::logic_mux_proc()
 
                // Process the samples if necessary...
                if (samples_to_process > 0) {
-                       const uint64_t unit_size = segment_->unit_size();
+                       const uint64_t unit_size = output_segment->unit_size();
                        const uint64_t chunk_sample_count = DecodeChunkLength / unit_size;
 
                        uint64_t processed_samples = 0;
@@ -637,138 +1108,192 @@ void DecodeSignal::logic_mux_proc()
                                const uint64_t sample_count =
                                        min(samples_to_process - processed_samples,     chunk_sample_count);
 
-                               mux_logic_samples(start_sample, start_sample + sample_count);
+                               mux_logic_samples(segment_id, start_sample, start_sample + sample_count);
                                processed_samples += sample_count;
 
                                // ...and process the newly muxed logic data
                                decode_input_cond_.notify_one();
-                       } while (processed_samples < samples_to_process);
+                       } while (!logic_mux_interrupt_ && (processed_samples < samples_to_process));
                }
 
                if (samples_to_process == 0) {
-                       // Wait for more input
-                       unique_lock<mutex> logic_mux_lock(logic_mux_mutex_);
-                       logic_mux_cond_.wait(logic_mux_lock);
-               }
-       } while (!logic_mux_interrupt_);
-
-       // No more input data and session is stopped, let the decode thread
-       // process any pending data, terminate and release the global SRD mutex
-       // in order to let other decoders run
-       decode_input_cond_.notify_one();
-}
-
-void DecodeSignal::query_input_metadata()
-{
-       // Update the samplerate and start time because we cannot start
-       // the libsrd session without the current samplerate
-
-       // TODO Currently we assume all channels have the same sample rate
-       // and start time
-       bool samplerate_valid = false;
-
-       auto any_channel = find_if(channels_.begin(), channels_.end(),
-               [](data::DecodeChannel ch) { return ch.assigned_signal; });
-
-       shared_ptr<Logic> logic_data =
-               any_channel->assigned_signal->logic_data();
-
-       do {
-               if (!logic_data->logic_segments().empty()) {
-                       shared_ptr<LogicSegment> first_segment =
-                               any_channel->assigned_signal->logic_data()->logic_segments().front();
-                       start_time_ = first_segment->start_time();
-                       samplerate_ = first_segment->samplerate();
-                       if (samplerate_ > 0)
-                               samplerate_valid = true;
+                       // TODO Optimize this by caching the input segment count and only
+                       // querying it when the cached value was reached
+                       if (segment_id < get_input_segment_count() - 1) {
+                               // Process next segment
+                               segment_id++;
+
+                               output_segment =
+                                       make_shared<LogicSegment>(*logic_mux_data_, segment_id,
+                                               logic_mux_unit_size_, 0);
+                               logic_mux_data_->push_segment(output_segment);
+
+                               output_segment->set_samplerate(get_input_samplerate(segment_id));
+                       } else {
+                               // All segments have been processed
+                               logic_mux_data_invalid_ = false;
+
+                               // Wait for more input
+                               unique_lock<mutex> logic_mux_lock(logic_mux_mutex_);
+                               logic_mux_cond_.wait(logic_mux_lock);
+                       }
                }
 
-               if (!samplerate_valid) {
-                       // Wait until input data is available or an interrupt was requested
-                       unique_lock<mutex> input_wait_lock(input_mutex_);
-                       decode_input_cond_.wait(input_wait_lock);
-               }
-       } while (!samplerate_valid && !decode_interrupt_);
+       } while (!logic_mux_interrupt_);
 }
 
 void DecodeSignal::decode_data(
-       const int64_t abs_start_samplenum, const int64_t sample_count)
+       const int64_t abs_start_samplenum, const int64_t sample_count,
+       const shared_ptr<LogicSegment> input_segment)
 {
-       const int64_t unit_size = segment_->unit_size();
+       const int64_t unit_size = input_segment->unit_size();
        const int64_t chunk_sample_count = DecodeChunkLength / unit_size;
 
        for (int64_t i = abs_start_samplenum;
-               !decode_interrupt_ && (i < (abs_start_samplenum + sample_count));
+               error_message_.isEmpty() && !decode_interrupt_ &&
+                       (i < (abs_start_samplenum + sample_count));
                i += chunk_sample_count) {
 
                const int64_t chunk_end = min(i + chunk_sample_count,
                        abs_start_samplenum + sample_count);
 
-               const uint8_t* chunk = segment_->get_samples(i, chunk_end);
+               {
+                       lock_guard<mutex> lock(output_mutex_);
+                       // Update the sample count showing the samples including currently processed ones
+                       segments_.at(current_segment_id_).samples_decoded_incl = chunk_end;
+               }
+
+               int64_t data_size = (chunk_end - i) * unit_size;
+               uint8_t* chunk = new uint8_t[data_size];
+               input_segment->get_samples(i, chunk_end, chunk);
 
                if (srd_session_send(srd_session_, i, chunk_end, chunk,
-                               (chunk_end - i) * unit_size, unit_size) != SRD_OK) {
-                       error_message_ = tr("Decoder reported an error");
-                       delete[] chunk;
-                       break;
-               }
+                               data_size, unit_size) != SRD_OK)
+                       set_error_message(tr("Decoder reported an error"));
 
                delete[] chunk;
 
                {
                        lock_guard<mutex> lock(output_mutex_);
-                       samples_decoded_ = chunk_end;
+                       // Now that all samples are processed, the exclusive sample count catches up
+                       segments_.at(current_segment_id_).samples_decoded_excl = chunk_end;
                }
 
                // Notify the frontend that we processed some data and
                // possibly have new annotations as well
                new_annotations();
+
+               if (decode_paused_) {
+                       unique_lock<mutex> pause_wait_lock(decode_pause_mutex_);
+                       decode_pause_cond_.wait(pause_wait_lock);
+               }
        }
 }
 
 void DecodeSignal::decode_proc()
 {
-       query_input_metadata();
+       current_segment_id_ = 0;
+
+       // If there is no input data available yet, wait until it is or we're interrupted
+       if (logic_mux_data_->logic_segments().size() == 0) {
+               unique_lock<mutex> input_wait_lock(input_mutex_);
+               decode_input_cond_.wait(input_wait_lock);
+       }
 
        if (decode_interrupt_)
                return;
 
+       shared_ptr<LogicSegment> input_segment = logic_mux_data_->logic_segments().front();
+       assert(input_segment);
+
+       // Create the initial segment and set its sample rate so that we can pass it to SRD
+       create_decode_segment();
+       segments_.at(current_segment_id_).samplerate = input_segment->samplerate();
+       segments_.at(current_segment_id_).start_time = input_segment->start_time();
+
        start_srd_session();
 
-       uint64_t sample_count;
+       uint64_t sample_count = 0;
        uint64_t abs_start_samplenum = 0;
        do {
                // Keep processing new samples until we exhaust the input data
                do {
-                       // Prevent any other decode threads from accessing libsigrokdecode
-                       lock_guard<mutex> srd_lock(global_srd_mutex_);
-
-                       {
-                               lock_guard<mutex> input_lock(input_mutex_);
-                               sample_count = segment_->get_sample_count() - abs_start_samplenum;
-                       }
+                       lock_guard<mutex> input_lock(input_mutex_);
+                       sample_count = input_segment->get_sample_count() - abs_start_samplenum;
 
                        if (sample_count > 0) {
-                               decode_data(abs_start_samplenum, sample_count);
+                               decode_data(abs_start_samplenum, sample_count, input_segment);
                                abs_start_samplenum += sample_count;
                        }
                } while (error_message_.isEmpty() && (sample_count > 0) && !decode_interrupt_);
 
-               if (error_message_.isEmpty() && !decode_interrupt_) {
-                       if (sample_count == 0)
+               if (error_message_.isEmpty() && !decode_interrupt_ && sample_count == 0) {
+                       if (current_segment_id_ < logic_mux_data_->logic_segments().size() - 1) {
+                               // Process next segment
+                               current_segment_id_++;
+
+                               try {
+                                       input_segment = logic_mux_data_->logic_segments().at(current_segment_id_);
+                               } catch (out_of_range&) {
+                                       qDebug() << "Decode error for" << name() << ": no logic mux segment" \
+                                               << current_segment_id_ << "in decode_proc(), mux segments size is" \
+                                               << logic_mux_data_->logic_segments().size();
+                                       return;
+                               }
+                               abs_start_samplenum = 0;
+
+                               // Create the next segment and set its metadata
+                               create_decode_segment();
+                               segments_.at(current_segment_id_).samplerate = input_segment->samplerate();
+                               segments_.at(current_segment_id_).start_time = input_segment->start_time();
+
+                               // Reset decoder state but keep the decoder stack intact
+                               terminate_srd_session();
+                       } else {
+                               // All segments have been processed
                                decode_finished();
 
-                       // Wait for new input data or an interrupt was requested
-                       unique_lock<mutex> input_wait_lock(input_mutex_);
-                       decode_input_cond_.wait(input_wait_lock);
+                               // Wait for new input data or an interrupt was requested
+                               unique_lock<mutex> input_wait_lock(input_mutex_);
+                               decode_input_cond_.wait(input_wait_lock);
+                       }
                }
        } while (error_message_.isEmpty() && !decode_interrupt_);
+
+       // Potentially reap decoders when the application no longer is
+       // interested in their (pending) results.
+       if (decode_interrupt_)
+               terminate_srd_session();
 }
 
 void DecodeSignal::start_srd_session()
 {
-       if (srd_session_)
-               stop_srd_session();
+       // If there were stack changes, the session has been destroyed by now, so if
+       // it hasn't been destroyed, we can just reset and re-use it
+       if (srd_session_) {
+               // When a decoder stack was created before, re-use it
+               // for the next stream of input data, after terminating
+               // potentially still executing operations, and resetting
+               // internal state. Skip the rather expensive (teardown
+               // and) construction of another decoder stack.
+
+               // TODO Reduce redundancy, use a common code path for
+               // the meta/start sequence?
+               terminate_srd_session();
+
+               // Metadata is cleared also, so re-set it
+               uint64_t samplerate = 0;
+               if (segments_.size() > 0)
+                       samplerate = segments_.at(current_segment_id_).samplerate;
+               if (samplerate)
+                       srd_session_metadata_set(srd_session_, SRD_CONF_SAMPLERATE,
+                               g_variant_new_uint64(samplerate));
+               for (const shared_ptr<Decoder>& dec : stack_)
+                       dec->apply_all_options();
+               srd_session_start(srd_session_);
+
+               return;
+       }
 
        // Create the session
        srd_session_new(&srd_session_);
@@ -776,12 +1301,13 @@ void DecodeSignal::start_srd_session()
 
        // Create the decoders
        srd_decoder_inst *prev_di = nullptr;
-       for (const shared_ptr<decode::Decoder> &dec : stack_) {
+       for (const shared_ptr<Decoder>& dec : stack_) {
                srd_decoder_inst *const di = dec->create_decoder_inst(srd_session_);
 
                if (!di) {
-                       error_message_ = tr("Failed to create decoder instance");
+                       set_error_message(tr("Failed to create decoder instance"));
                        srd_session_destroy(srd_session_);
+                       srd_session_ = nullptr;
                        return;
                }
 
@@ -792,13 +1318,42 @@ void DecodeSignal::start_srd_session()
        }
 
        // Start the session
-       srd_session_metadata_set(srd_session_, SRD_CONF_SAMPLERATE,
-               g_variant_new_uint64(samplerate_));
+       if (segments_.size() > 0)
+               srd_session_metadata_set(srd_session_, SRD_CONF_SAMPLERATE,
+                       g_variant_new_uint64(segments_.at(current_segment_id_).samplerate));
 
        srd_pd_output_callback_add(srd_session_, SRD_OUTPUT_ANN,
                DecodeSignal::annotation_callback, this);
 
+       srd_pd_output_callback_add(srd_session_, SRD_OUTPUT_BINARY,
+               DecodeSignal::binary_callback, this);
+
        srd_session_start(srd_session_);
+
+       // We just recreated the srd session, so all stack changes are applied now
+       stack_config_changed_ = false;
+}
+
+void DecodeSignal::terminate_srd_session()
+{
+       // Call the "terminate and reset" routine for the decoder stack
+       // (if available). This does not harm those stacks which already
+       // have completed their operation, and reduces response time for
+       // those stacks which still are processing data while the
+       // application no longer wants them to.
+       if (srd_session_) {
+               srd_session_terminate_reset(srd_session_);
+
+               // Metadata is cleared also, so re-set it
+               uint64_t samplerate = 0;
+               if (segments_.size() > 0)
+                       samplerate = segments_.at(current_segment_id_).samplerate;
+               if (samplerate)
+                       srd_session_metadata_set(srd_session_, SRD_CONF_SAMPLERATE,
+                               g_variant_new_uint64(samplerate));
+               for (const shared_ptr<Decoder>& dec : stack_)
+                       dec->apply_all_options();
+       }
 }
 
 void DecodeSignal::stop_srd_session()
@@ -807,6 +1362,10 @@ void DecodeSignal::stop_srd_session()
                // Destroy the session
                srd_session_destroy(srd_session_);
                srd_session_ = nullptr;
+
+               // Mark the decoder instances as non-existant since they were deleted
+               for (const shared_ptr<Decoder>& dec : stack_)
+                       dec->invalidate_decoder_inst();
        }
 }
 
@@ -817,64 +1376,199 @@ void DecodeSignal::connect_input_notifiers()
        disconnect(this, SLOT(on_data_received()));
 
        // Connect the currently used signals to our slot
-       for (data::DecodeChannel &ch : channels_) {
+       for (decode::DecodeChannel& ch : channels_) {
                if (!ch.assigned_signal)
                        continue;
 
                const data::SignalBase *signal = ch.assigned_signal;
                connect(signal, SIGNAL(samples_cleared()),
                        this, SLOT(on_data_cleared()));
-               connect(signal, SIGNAL(samples_added(QObject*, uint64_t, uint64_t)),
+               connect(signal, SIGNAL(samples_added(uint64_t, uint64_t, uint64_t)),
                        this, SLOT(on_data_received()));
        }
 }
 
+void DecodeSignal::create_decode_segment()
+{
+       // Create annotation segment
+       segments_.emplace_back();
+
+       // Add annotation classes
+       for (const shared_ptr<Decoder>& dec : stack_)
+               for (Row* row : dec->get_rows())
+                       segments_.back().annotation_rows.emplace(row, RowData(row));
+
+       // Prepare our binary output classes
+       for (const shared_ptr<Decoder>& dec : stack_) {
+               uint32_t n = dec->get_binary_class_count();
+
+               for (uint32_t i = 0; i < n; i++)
+                       segments_.back().binary_classes.push_back(
+                               {dec.get(), dec->get_binary_class(i), deque<DecodeBinaryDataChunk>()});
+       }
+}
+
 void DecodeSignal::annotation_callback(srd_proto_data *pdata, void *decode_signal)
 {
        assert(pdata);
-       assert(decoder);
+       assert(decode_signal);
 
        DecodeSignal *const ds = (DecodeSignal*)decode_signal;
        assert(ds);
 
+       if (ds->decode_interrupt_)
+               return;
+
+       if (ds->segments_.empty())
+               return;
+
        lock_guard<mutex> lock(ds->output_mutex_);
 
-       const decode::Annotation a(pdata);
+       // Get the decoder and the annotation data
+       assert(pdata->pdo);
+       assert(pdata->pdo->di);
+       const srd_decoder *const srd_dec = pdata->pdo->di->decoder;
+       assert(srd_dec);
+
+       const srd_proto_data_annotation *const pda = (const srd_proto_data_annotation*)pdata->data;
+       assert(pda);
 
        // Find the row
+       Decoder* dec = ds->get_decoder_by_instance(srd_dec);
+       assert(dec);
+
+       AnnotationClass* ann_class = dec->get_ann_class_by_id(pda->ann_class);
+       if (!ann_class) {
+               qWarning() << "Decoder" << ds->display_name() << "wanted to add annotation" <<
+                       "with class ID" << pda->ann_class << "but there are only" <<
+                       dec->ann_classes().size() << "known classes";
+               return;
+       }
+
+       const Row* row = ann_class->row;
+
+       if (!row)
+               row = dec->get_row_by_id(0);
+
+       RowData& row_data = ds->segments_[ds->current_segment_id_].annotation_rows.at(row);
+
+       // Add the annotation to the row
+       const Annotation* ann = row_data.emplace_annotation(pdata);
+
+       // We insert the annotation into the global annotation list in a way so that
+       // the annotation list is sorted by start sample and length. Otherwise, we'd
+       // have to sort the model, which is expensive
+       deque<const Annotation*>& all_annotations =
+               ds->segments_[ds->current_segment_id_].all_annotations;
+
+       if (all_annotations.empty()) {
+               all_annotations.emplace_back(ann);
+       } else {
+               const uint64_t new_ann_len = (pdata->end_sample - pdata->start_sample);
+               bool ann_has_earlier_start = (pdata->start_sample < all_annotations.back()->start_sample());
+               bool ann_is_longer = (new_ann_len >
+                       (all_annotations.back()->end_sample() - all_annotations.back()->start_sample()));
+
+               if (ann_has_earlier_start && ann_is_longer) {
+                       bool ann_has_same_start;
+                       auto it = all_annotations.end();
+
+                       do {
+                               it--;
+                               ann_has_earlier_start = (pdata->start_sample < (*it)->start_sample());
+                               ann_has_same_start = (pdata->start_sample == (*it)->start_sample());
+                               ann_is_longer = (new_ann_len > (*it)->length());
+                       } while ((ann_has_earlier_start || (ann_has_same_start && ann_is_longer)) && (it != all_annotations.begin()));
+
+                       // Allow inserting at the front
+                       if (it != all_annotations.begin())
+                               it++;
+
+                       all_annotations.emplace(it, ann);
+               } else
+                       all_annotations.emplace_back(ann);
+       }
+
+       // When emplace_annotation() inserts instead of appends an annotation,
+       // the pointers in all_annotations that follow the inserted annotation and
+       // point to annotations for this row are off by one and must be updated
+       if (&(row_data.annotations().back()) != ann) {
+               // Search backwards until we find the annotation we just added
+               auto row_it = row_data.annotations().end();
+               auto all_it = all_annotations.end();
+               do {
+                       all_it--;
+                       if ((*all_it)->row_data() == &row_data)
+                               row_it--;
+               } while (&(*row_it) != ann);
+
+               // Update the annotation addresses for this row's annotations until the end
+               do {
+                       if ((*all_it)->row_data() == &row_data) {
+                               *all_it = &(*row_it);
+                               row_it++;
+                       }
+                       all_it++;
+               } while (all_it != all_annotations.end());
+       }
+}
+
+void DecodeSignal::binary_callback(srd_proto_data *pdata, void *decode_signal)
+{
+       assert(pdata);
+       assert(decode_signal);
+
+       DecodeSignal *const ds = (DecodeSignal*)decode_signal;
+       assert(ds);
+
+       if (ds->decode_interrupt_)
+               return;
+
+       // Get the decoder and the binary data
        assert(pdata->pdo);
        assert(pdata->pdo->di);
-       const srd_decoder *const decc = pdata->pdo->di->decoder;
-       assert(decc);
+       const srd_decoder *const srd_dec = pdata->pdo->di->decoder;
+       assert(srd_dec);
 
-       auto row_iter = ds->rows_.end();
+       const srd_proto_data_binary *const pdb = (const srd_proto_data_binary*)pdata->data;
+       assert(pdb);
 
-       // Try looking up the sub-row of this class
-       const auto r = ds->class_rows_.find(make_pair(decc, a.format()));
-       if (r != ds->class_rows_.end())
-               row_iter = ds->rows_.find((*r).second);
-       else {
-               // Failing that, use the decoder as a key
-               row_iter = ds->rows_.find(Row(decc));
-       }
+       // Find the matching DecodeBinaryClass
+       DecodeSegment* segment = &(ds->segments_.at(ds->current_segment_id_));
+
+       DecodeBinaryClass* bin_class = nullptr;
+       for (DecodeBinaryClass& bc : segment->binary_classes)
+               if ((bc.decoder->get_srd_decoder() == srd_dec) &&
+                       (bc.info->bin_class_id == (uint32_t)pdb->bin_class))
+                       bin_class = &bc;
 
-       assert(row_iter != ds->rows_.end());
-       if (row_iter == ds->rows_.end()) {
-               qDebug() << "Unexpected annotation: decoder = " << decc <<
-                       ", format = " << a.format();
-               assert(false);
+       if (!bin_class) {
+               qWarning() << "Could not find valid DecodeBinaryClass in segment" <<
+                               ds->current_segment_id_ << "for binary class ID" << pdb->bin_class <<
+                               ", segment only knows" << segment->binary_classes.size() << "classes";
                return;
        }
 
-       // Add the annotation
-       (*row_iter).second.push_annotation(a);
+       // Add the data chunk
+       bin_class->chunks.emplace_back();
+       DecodeBinaryDataChunk* chunk = &(bin_class->chunks.back());
+
+       chunk->sample = pdata->start_sample;
+       chunk->data.resize(pdb->size);
+       memcpy(chunk->data.data(), pdb->data, pdb->size);
+
+       Decoder* dec = ds->get_decoder_by_instance(srd_dec);
+
+       ds->new_binary_data(ds->current_segment_id_, (void*)dec, pdb->bin_class);
 }
 
 void DecodeSignal::on_capture_state_changed(int state)
 {
        // If a new acquisition was started, we need to start decoding from scratch
-       if (state == Session::Running)
+       if (state == Session::Running) {
+               logic_mux_data_invalid_ = true;
                begin_decode();
+       }
 }
 
 void DecodeSignal::on_data_cleared()
@@ -884,11 +1578,22 @@ void DecodeSignal::on_data_cleared()
 
 void DecodeSignal::on_data_received()
 {
+       // If we detected a lack of input data when trying to start decoding,
+       // we have set an error message. Only try again if we now have data
+       // to work with
+       if ((!error_message_.isEmpty()) && (get_input_segment_count() == 0))
+               return;
+
        if (!logic_mux_thread_.joinable())
                begin_decode();
        else
                logic_mux_cond_.notify_one();
 }
 
+void DecodeSignal::on_annotation_visibility_changed()
+{
+       annotation_visibility_changed();
+}
+
 } // namespace data
 } // namespace pv