]> sigrok.org Git - pulseview.git/blobdiff - pv/data/analogsegment.cpp
Segment: Do not alter chunks when there are active iterators
[pulseview.git] / pv / data / analogsegment.cpp
index 3703f0d02780e13f86ffc962e93beadea1c5a1ce..b3f310a144c5cd7ce2e18fb83ed242bd10526b6c 100644 (file)
@@ -14,8 +14,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <extdef.h>
@@ -27,6 +26,7 @@
 
 #include <algorithm>
 
+#include "analog.hpp"
 #include "analogsegment.hpp"
 
 using std::lock_guard;
@@ -45,12 +45,12 @@ const float AnalogSegment::LogEnvelopeScaleFactor =
        logf(EnvelopeScaleFactor);
 const uint64_t AnalogSegment::EnvelopeDataUnit = 64*1024;      // bytes
 
-AnalogSegment::AnalogSegment(
-       uint64_t samplerate, const uint64_t expected_num_samples) :
-       Segment(samplerate, sizeof(float))
+AnalogSegment::AnalogSegment(Analog& owner, uint64_t samplerate) :
+       Segment(samplerate, sizeof(float)),
+       owner_(owner),
+       min_value_(0),
+       max_value_(0)
 {
-       set_capacity(expected_num_samples);
-
        lock_guard<recursive_mutex> lock(mutex_);
        memset(envelope_levels_, 0, sizeof(envelope_levels_));
 }
@@ -69,21 +69,22 @@ void AnalogSegment::append_interleaved_samples(const float *data,
 
        lock_guard<recursive_mutex> lock(mutex_);
 
-       // If we're out of memory, this will throw std::bad_alloc
-       data_.resize((sample_count_ + sample_count) * sizeof(float));
+       uint64_t prev_sample_count = sample_count_;
 
-       float *dst = (float*)data_.data() + sample_count_;
-       const float *dst_end = dst + sample_count;
-       while (dst != dst_end)
-       {
-               *dst++ = *data;
+       for (uint32_t i=0; i < sample_count; i++) {
+               append_single_sample((void*)data);
                data += stride;
        }
 
-       sample_count_ += sample_count;
-
        // Generate the first mip-map from the data
        append_payload_to_envelope_levels();
+
+       if (sample_count > 1)
+               owner_.notify_samples_added(this, prev_sample_count + 1,
+                       prev_sample_count + 1 + sample_count);
+       else
+               owner_.notify_samples_added(this, prev_sample_count + 1,
+                       prev_sample_count + 1);
 }
 
 const float* AnalogSegment::get_samples(
@@ -97,10 +98,27 @@ const float* AnalogSegment::get_samples(
 
        lock_guard<recursive_mutex> lock(mutex_);
 
-       float *const data = new float[end_sample - start_sample];
-       memcpy(data, (float*)data_.data() + start_sample, sizeof(float) *
-               (end_sample - start_sample));
-       return data;
+       return (float*)get_raw_samples(start_sample, (end_sample - start_sample));
+}
+
+const std::pair<float, float> AnalogSegment::get_min_max() const
+{
+       return std::make_pair(min_value_, max_value_);
+}
+
+SegmentAnalogDataIterator* AnalogSegment::begin_sample_iteration(uint64_t start)
+{
+       return (SegmentAnalogDataIterator*)begin_raw_sample_iteration(start);
+}
+
+void AnalogSegment::continue_sample_iteration(SegmentAnalogDataIterator* it, uint64_t increase)
+{
+       Segment::continue_raw_sample_iteration((SegmentRawDataIterator*)it, increase);
+}
+
+void AnalogSegment::end_sample_iteration(SegmentAnalogDataIterator* it)
+{
+       Segment::end_raw_sample_iteration((SegmentRawDataIterator*)it);
 }
 
 void AnalogSegment::get_envelope_section(EnvelopeSection &s,
@@ -131,8 +149,7 @@ void AnalogSegment::reallocate_envelope(Envelope &e)
 {
        const uint64_t new_data_length = ((e.length + EnvelopeDataUnit - 1) /
                EnvelopeDataUnit) * EnvelopeDataUnit;
-       if (new_data_length > e.data_length)
-       {
+       if (new_data_length > e.data_length) {
                e.data_length = new_data_length;
                e.samples = (EnvelopeSample*)realloc(e.samples,
                        new_data_length * sizeof(EnvelopeSample));
@@ -144,11 +161,24 @@ void AnalogSegment::append_payload_to_envelope_levels()
        Envelope &e0 = envelope_levels_[0];
        uint64_t prev_length;
        EnvelopeSample *dest_ptr;
+       SegmentRawDataIterator* it;
 
        // Expand the data buffer to fit the new samples
        prev_length = e0.length;
        e0.length = sample_count_ / EnvelopeScaleFactor;
 
+       // Calculate min/max values in case we have too few samples for an envelope
+       if (sample_count_ < EnvelopeScaleFactor) {
+               it = begin_raw_sample_iteration(0);
+               for (uint64_t i = 0; i < sample_count_; i++) {
+                       const float sample = *((float*)it->value);
+                       if (sample < min_value_) min_value_ = sample;
+                       if (sample > max_value_) max_value_ = sample;
+                       continue_raw_sample_iteration(it, 1);
+               }
+               end_raw_sample_iteration(it);
+       }
+
        // Break off if there are no new samples to compute
        if (e0.length == prev_length)
                return;
@@ -158,23 +188,28 @@ void AnalogSegment::append_payload_to_envelope_levels()
        dest_ptr = e0.samples + prev_length;
 
        // Iterate through the samples to populate the first level mipmap
-       const float *const end_src_ptr = (float*)data_.data() +
-               e0.length * EnvelopeScaleFactor;
-       for (const float *src_ptr = (float*)data_.data() +
-               prev_length * EnvelopeScaleFactor;
-               src_ptr < end_src_ptr; src_ptr += EnvelopeScaleFactor)
-       {
+       uint64_t start_sample = prev_length * EnvelopeScaleFactor;
+       uint64_t end_sample   = e0.length * EnvelopeScaleFactor;
+
+       it = begin_raw_sample_iteration(start_sample);
+       for (uint64_t i = start_sample; i < end_sample; i += EnvelopeScaleFactor) {
+               const float* samples = (float*)it->value;
+
                const EnvelopeSample sub_sample = {
-                       *min_element(src_ptr, src_ptr + EnvelopeScaleFactor),
-                       *max_element(src_ptr, src_ptr + EnvelopeScaleFactor),
+                       *min_element(samples, samples + EnvelopeScaleFactor),
+                       *max_element(samples, samples + EnvelopeScaleFactor),
                };
 
+               if (sub_sample.min < min_value_) min_value_ = sub_sample.min;
+               if (sub_sample.max > max_value_) max_value_ = sub_sample.max;
+
+               continue_raw_sample_iteration(it, EnvelopeScaleFactor);
                *dest_ptr++ = sub_sample;
        }
+       end_raw_sample_iteration(it);
 
        // Compute higher level mipmaps
-       for (unsigned int level = 1; level < ScaleStepCount; level++)
-       {
+       for (unsigned int level = 1; level < ScaleStepCount; level++) {
                Envelope &e = envelope_levels_[level];
                const Envelope &el = envelope_levels_[level-1];
 
@@ -182,26 +217,25 @@ void AnalogSegment::append_payload_to_envelope_levels()
                prev_length = e.length;
                e.length = el.length / EnvelopeScaleFactor;
 
-               // Break off if there are no more samples to computed
+               // Break off if there are no more samples to be computed
                if (e.length == prev_length)
                        break;
 
                reallocate_envelope(e);
 
-               // Subsample the level lower level
+               // Subsample the lower level
                const EnvelopeSample *src_ptr =
                        el.samples + prev_length * EnvelopeScaleFactor;
                const EnvelopeSample *const end_dest_ptr = e.samples + e.length;
+
                for (dest_ptr = e.samples + prev_length;
-                       dest_ptr < end_dest_ptr; dest_ptr++)
-               {
+                               dest_ptr < end_dest_ptr; dest_ptr++) {
                        const EnvelopeSample *const end_src_ptr =
                                src_ptr + EnvelopeScaleFactor;
 
                        EnvelopeSample sub_sample = *src_ptr++;
-                       while (src_ptr < end_src_ptr)
-                       {
-                               sub_sample.min = min(sub_sample.min, src_ptr->min);
+                       while (src_ptr < end_src_ptr) {
+                               sub_sample.min = min(sub_sample.min, src_ptr->min);;
                                sub_sample.max = max(sub_sample.max, src_ptr->max);
                                src_ptr++;
                        }