Include suggested changes by clang-tidy

[pulseview.git] / main.cpp

diff --git a/main.cpp b/main.cpp
index cdc750aa80aade18b21916708463189c78a41f9a..dc3f739f25cdac5451502ca2e3462cf7acc93df6 100644 (file)
--- a/main.cpp
+++ b/main.cpp
@@ -155,7 +155,6 @@ void usage()
                "  -i, --input-file                Load input from file\n"
                "  -I, --input-format              Input format\n"
                "  -c, --clean                     Don't restore previous sessions on startup\n"
-               "  -s, --log-to-stdout             Don't use logging, output to stdout instead\n"
                "\n", PV_BIN_NAME);
 }
 
@@ -167,7 +166,6 @@ int main(int argc, char *argv[])
        vector<string> open_files;
        bool restore_sessions = true;
        bool do_scan = true;
-       bool do_logging = true;
 
        Application a(argc, argv);
 
@@ -193,7 +191,7 @@ int main(int argc, char *argv[])
                };
 
                const int c = getopt_long(argc, argv,
-                       "h?VDcsl:d:i:I:", long_options, nullptr);
+                       "h?VDcl:d:i:I:", long_options, nullptr);
                if (c == -1)
                        break;
 
@@ -238,7 +236,7 @@ int main(int argc, char *argv[])
                        break;
 
                case 'i':
-                       open_files.push_back(optarg);
+                       open_files.emplace_back(optarg);
                        break;
 
                case 'I':
@@ -248,24 +246,19 @@ int main(int argc, char *argv[])
                case 'c':
                        restore_sessions = false;
                        break;
-
-               case 's':
-                       do_logging = false;
-                       break;
                }
        }
+       argc -= optind;
+       argv += optind;
 
-       while (argc - optind > 0) {
-               open_files.push_back(argv[optind]);
-               optind++;
-       }
+       for (int i = 0; i < argc; i++)
+               open_files.emplace_back(argv[i]);
 
        // Prepare the global settings since logging needs them early on
        pv::GlobalSettings settings;
        settings.set_defaults_where_needed();
 
-       if (do_logging)
-               pv::logging.init();
+       pv::logging.init();
 
        // Initialise libsigrok
        context = sigrok::Context::create();