]> sigrok.org Git - pulseview.git/blob - pv/views/trace/logicsignal.cpp
Disable antialiasing on high-DPI displays
[pulseview.git] / pv / views / trace / logicsignal.cpp
1 /*
2  * This file is part of the PulseView project.
3  *
4  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <extdef.h>
21
22 #include <cassert>
23 #include <cmath>
24
25 #include <algorithm>
26
27 #include <QApplication>
28 #include <QFormLayout>
29 #include <QToolBar>
30
31 #include "logicsignal.hpp"
32 #include "view.hpp"
33
34 #include <pv/data/logic.hpp>
35 #include <pv/data/logicsegment.hpp>
36 #include <pv/data/signalbase.hpp>
37 #include <pv/devicemanager.hpp>
38 #include <pv/devices/device.hpp>
39 #include <pv/globalsettings.hpp>
40 #include <pv/session.hpp>
41
42 #include <libsigrokcxx/libsigrokcxx.hpp>
43
44 using std::deque;
45 using std::max;
46 using std::make_pair;
47 using std::min;
48 using std::none_of;
49 using std::out_of_range;
50 using std::pair;
51 using std::shared_ptr;
52 using std::vector;
53
54 using sigrok::ConfigKey;
55 using sigrok::Capability;
56 using sigrok::Trigger;
57 using sigrok::TriggerMatch;
58 using sigrok::TriggerMatchType;
59
60 using pv::data::LogicSegment;
61
62 namespace pv {
63 namespace views {
64 namespace trace {
65
66 const float LogicSignal::Oversampling = 2.0f;
67
68 const QColor LogicSignal::EdgeColor(0x80, 0x80, 0x80);
69 const QColor LogicSignal::HighColor(0x00, 0xC0, 0x00);
70 const QColor LogicSignal::LowColor(0xC0, 0x00, 0x00);
71 const QColor LogicSignal::SamplingPointColor(0x77, 0x77, 0x77);
72
73 const QColor LogicSignal::SignalColors[10] = {
74         QColor(0x16, 0x19, 0x1A),       // Black
75         QColor(0x8F, 0x52, 0x02),       // Brown
76         QColor(0xCC, 0x00, 0x00),       // Red
77         QColor(0xF5, 0x79, 0x00),       // Orange
78         QColor(0xED, 0xD4, 0x00),       // Yellow
79         QColor(0x73, 0xD2, 0x16),       // Green
80         QColor(0x34, 0x65, 0xA4),       // Blue
81         QColor(0x75, 0x50, 0x7B),       // Violet
82         QColor(0x88, 0x8A, 0x85),       // Grey
83         QColor(0xEE, 0xEE, 0xEC),       // White
84 };
85
86 QColor LogicSignal::TriggerMarkerBackgroundColor = QColor(0xED, 0xD4, 0x00);
87 const int LogicSignal::TriggerMarkerPadding = 2;
88 const char* LogicSignal::TriggerMarkerIcons[8] = {
89         nullptr,
90         ":/icons/trigger-marker-low.svg",
91         ":/icons/trigger-marker-high.svg",
92         ":/icons/trigger-marker-rising.svg",
93         ":/icons/trigger-marker-falling.svg",
94         ":/icons/trigger-marker-change.svg",
95         nullptr,
96         nullptr
97 };
98
99 QCache<QString, const QIcon> LogicSignal::icon_cache_;
100 QCache<QString, const QPixmap> LogicSignal::pixmap_cache_;
101
102 LogicSignal::LogicSignal(
103         pv::Session &session,
104         shared_ptr<devices::Device> device,
105         shared_ptr<data::SignalBase> base) :
106         Signal(session, base),
107         device_(device),
108         trigger_types_(get_trigger_types()),
109         trigger_none_(nullptr),
110         trigger_rising_(nullptr),
111         trigger_high_(nullptr),
112         trigger_falling_(nullptr),
113         trigger_low_(nullptr),
114         trigger_change_(nullptr)
115 {
116         shared_ptr<Trigger> trigger;
117
118         base_->set_color(SignalColors[base->index() % countof(SignalColors)]);
119
120         GlobalSettings settings;
121         signal_height_ = settings.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt();
122         show_sampling_points_ =
123                 settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool();
124         fill_high_areas_ =
125                 settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool();
126         high_fill_color_ = QColor::fromRgba(settings.value(
127                 GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>());
128
129         /* Populate this channel's trigger setting with whatever we
130          * find in the current session trigger, if anything. */
131         trigger_match_ = nullptr;
132         if ((trigger = session_.session()->trigger()))
133                 for (auto stage : trigger->stages())
134                         for (auto match : stage->matches())
135                                 if (match->channel() == base_->channel())
136                                         trigger_match_ = match->type();
137 }
138
139 shared_ptr<pv::data::SignalData> LogicSignal::data() const
140 {
141         return base_->logic_data();
142 }
143
144 shared_ptr<pv::data::Logic> LogicSignal::logic_data() const
145 {
146         return base_->logic_data();
147 }
148
149 void LogicSignal::save_settings(QSettings &settings) const
150 {
151         settings.setValue("trace_height", signal_height_);
152 }
153
154 void LogicSignal::restore_settings(QSettings &settings)
155 {
156         if (settings.contains("trace_height")) {
157                 const int old_height = signal_height_;
158                 signal_height_ = settings.value("trace_height").toInt();
159
160                 if ((signal_height_ != old_height) && owner_) {
161                         // Call order is important, otherwise the lazy event handler won't work
162                         owner_->extents_changed(false, true);
163                         owner_->row_item_appearance_changed(false, true);
164                 }
165         }
166 }
167
168 pair<int, int> LogicSignal::v_extents() const
169 {
170         const int signal_margin =
171                 QFontMetrics(QApplication::font()).height() / 2;
172         return make_pair(-signal_height_ - signal_margin, signal_margin);
173 }
174
175 void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
176 {
177         QLineF *line;
178
179         vector< pair<int64_t, bool> > edges;
180
181         assert(base_);
182         assert(owner_);
183
184         const int y = get_visual_y();
185
186         if (!base_->enabled())
187                 return;
188
189         const float low_offset = y + 0.5f;
190         const float high_offset = low_offset - signal_height_;
191
192         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
193         if (!segment || (segment->get_sample_count() == 0))
194                 return;
195
196         double samplerate = segment->samplerate();
197
198         // Show sample rate as 1Hz when it is unknown
199         if (samplerate == 0.0)
200                 samplerate = 1.0;
201
202         const double pixels_offset = pp.pixels_offset();
203         const pv::util::Timestamp& start_time = segment->start_time();
204         const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
205         const double samples_per_pixel = samplerate * pp.scale();
206         const double pixels_per_sample = 1 / samples_per_pixel;
207         const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
208         const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
209
210         const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
211                 (int64_t)0), last_sample);
212         const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
213                 (int64_t)0), last_sample);
214
215         segment->get_subsampled_edges(edges, start_sample, end_sample,
216                 samples_per_pixel / Oversampling, base_->index());
217         assert(edges.size() >= 2);
218
219         const float first_sample_x =
220                 pp.left() + (edges.front().first / samples_per_pixel - pixels_offset);
221         const float last_sample_x =
222                 pp.left() + (edges.back().first / samples_per_pixel - pixels_offset);
223
224         // Check whether we need to paint the sampling points
225         const bool show_sampling_points = show_sampling_points_ && (samples_per_pixel < 0.25);
226         vector<QRectF> sampling_points;
227         float sampling_point_x = first_sample_x;
228         int64_t sampling_point_sample = start_sample;
229         const int w = 2;
230
231         if (show_sampling_points)
232                 sampling_points.reserve(end_sample - start_sample + 1);
233
234         vector<QRectF> high_rects;
235         float rising_edge_x;
236         bool rising_edge_seen = false;
237
238         // Paint the edges
239         const unsigned int edge_count = edges.size() - 2;
240         QLineF *const edge_lines = new QLineF[edge_count];
241         line = edge_lines;
242
243         if (edges.front().second) {
244                 // Beginning of trace is high
245                 rising_edge_x = first_sample_x;
246                 rising_edge_seen = true;
247         }
248
249         for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
250                 // Note: multiple edges occupying a single pixel are represented by an edge
251                 // with undefined logic level. This means that only the first falling edge
252                 // after a rising edge corresponds to said rising edge - and vice versa. If
253                 // more edges with the same logic level follow, they denote multiple edges.
254
255                 const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset);
256                 *line++ = QLineF(x, high_offset, x, low_offset);
257
258                 if (fill_high_areas_) {
259                         // Any edge terminates a high area
260                         if (rising_edge_seen) {
261                                 const int width = x - rising_edge_x;
262                                 if (width > 0)
263                                         high_rects.emplace_back(rising_edge_x, high_offset,
264                                                 width, signal_height_);
265                                 rising_edge_seen = false;
266                         }
267
268                         // Only rising edges start high areas
269                         if ((*i).second) {
270                                 rising_edge_x = x;
271                                 rising_edge_seen = true;
272                         }
273                 }
274
275                 if (show_sampling_points)
276                         while (sampling_point_sample < (*i).first) {
277                                 const float y = (*i).second ? low_offset : high_offset;
278                                 sampling_points.emplace_back(
279                                         QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
280                                 sampling_point_sample++;
281                                 sampling_point_x += pixels_per_sample;
282                         };
283         }
284
285         // Calculate the sample points from the last edge to the end of the trace
286         if (show_sampling_points)
287                 while ((uint64_t)sampling_point_sample <= end_sample) {
288                         // Signal changed after the last edge, so the level is inverted
289                         const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
290                         sampling_points.emplace_back(
291                                 QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
292                         sampling_point_sample++;
293                         sampling_point_x += pixels_per_sample;
294                 };
295
296         if (fill_high_areas_) {
297                 // Add last high rectangle if the signal is still high at the end of the trace
298                 if (rising_edge_seen && (edges.cend() - 1)->second)
299                         high_rects.emplace_back(rising_edge_x, high_offset,
300                                 last_sample_x - rising_edge_x, signal_height_);
301
302                 p.setPen(high_fill_color_);
303                 p.setBrush(high_fill_color_);
304                 p.drawRects((const QRectF*)(high_rects.data()), high_rects.size());
305         }
306
307         p.setPen(EdgeColor);
308         p.drawLines(edge_lines, edge_count);
309         delete[] edge_lines;
310
311         // Paint the caps
312         const unsigned int max_cap_line_count = edges.size();
313         QLineF *const cap_lines = new QLineF[max_cap_line_count];
314
315         p.setPen(HighColor);
316         paint_caps(p, cap_lines, edges, true, samples_per_pixel,
317                 pixels_offset, pp.left(), high_offset);
318         p.setPen(LowColor);
319         paint_caps(p, cap_lines, edges, false, samples_per_pixel,
320                 pixels_offset, pp.left(), low_offset);
321
322         delete[] cap_lines;
323
324         // Paint the sampling points
325         if (show_sampling_points) {
326                 p.setPen(SamplingPointColor);
327                 p.drawRects(sampling_points.data(), sampling_points.size());
328         }
329 }
330
331 void LogicSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
332 {
333         if (base_->enabled()) {
334                 if (trigger_match_) {
335                         // Draw the trigger marker
336                         const int y = get_visual_y();
337
338                         for (int32_t type_id : trigger_types_) {
339                                 const TriggerMatchType *const type =
340                                         TriggerMatchType::get(type_id);
341                                 if (trigger_match_ != type || type_id < 0 ||
342                                         (size_t)type_id >= countof(TriggerMarkerIcons) ||
343                                         !TriggerMarkerIcons[type_id])
344                                         continue;
345
346                                 const QPixmap *const pixmap = get_pixmap(
347                                         TriggerMarkerIcons[type_id]);
348                                 if (!pixmap)
349                                         continue;
350
351                                 const float pad = TriggerMarkerPadding - 0.5f;
352                                 const QSize size = pixmap->size();
353                                 const QPoint point(
354                                         pp.right() - size.width() - pad * 2,
355                                         y - (signal_height_ + size.height()) / 2);
356
357                                 p.setPen(QPen(TriggerMarkerBackgroundColor.darker()));
358                                 p.setBrush(TriggerMarkerBackgroundColor);
359                                 p.drawRoundedRect(QRectF(point, size).adjusted(
360                                         -pad, -pad, pad, pad), pad, pad);
361                                 p.drawPixmap(point, *pixmap);
362
363                                 break;
364                         }
365                 }
366
367                 if (show_hover_marker_)
368                         paint_hover_marker(p);
369         }
370 }
371
372 vector<LogicSegment::EdgePair> LogicSignal::get_nearest_level_changes(uint64_t sample_pos)
373 {
374         assert(base_);
375         assert(owner_);
376
377         if (sample_pos == 0)
378                 return vector<LogicSegment::EdgePair>();
379
380         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
381         if (!segment || (segment->get_sample_count() == 0))
382                 return vector<LogicSegment::EdgePair>();
383
384         const View *view = owner_->view();
385         assert(view);
386         const double samples_per_pixel = base_->get_samplerate() * view->scale();
387
388         vector<LogicSegment::EdgePair> edges;
389
390         segment->get_surrounding_edges(edges, sample_pos,
391                 samples_per_pixel / Oversampling, base_->index());
392
393         if (edges.empty())
394                 return vector<LogicSegment::EdgePair>();
395
396         return edges;
397 }
398
399 void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
400         vector< pair<int64_t, bool> > &edges, bool level,
401         double samples_per_pixel, double pixels_offset, float x_offset,
402         float y_offset)
403 {
404         QLineF *line = lines;
405
406         for (auto i = edges.begin(); i != (edges.end() - 1); i++)
407                 if ((*i).second == level) {
408                         *line++ = QLineF(
409                                 ((*i).first / samples_per_pixel -
410                                         pixels_offset) + x_offset, y_offset,
411                                 ((*(i+1)).first / samples_per_pixel -
412                                         pixels_offset) + x_offset, y_offset);
413                 }
414
415         p.drawLines(lines, line - lines);
416 }
417
418 shared_ptr<pv::data::LogicSegment> LogicSignal::get_logic_segment_to_paint() const
419 {
420         shared_ptr<pv::data::LogicSegment> segment;
421
422         const deque< shared_ptr<pv::data::LogicSegment> > &segments =
423                 base_->logic_data()->logic_segments();
424
425         if (!segments.empty()) {
426                 if (segment_display_mode_ == ShowLastSegmentOnly) {
427                         segment = segments.back();
428                 }
429
430         if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
431                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
432                         try {
433                                 segment = segments.at(current_segment_);
434                         } catch (out_of_range&) {
435                                 qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
436                         }
437                 }
438         }
439
440         return segment;
441 }
442
443 void LogicSignal::init_trigger_actions(QWidget *parent)
444 {
445         trigger_none_ = new QAction(*get_icon(":/icons/trigger-none.svg"),
446                 tr("No trigger"), parent);
447         trigger_none_->setCheckable(true);
448         connect(trigger_none_, SIGNAL(triggered()), this, SLOT(on_trigger()));
449
450         trigger_rising_ = new QAction(*get_icon(":/icons/trigger-rising.svg"),
451                 tr("Trigger on rising edge"), parent);
452         trigger_rising_->setCheckable(true);
453         connect(trigger_rising_, SIGNAL(triggered()), this, SLOT(on_trigger()));
454
455         trigger_high_ = new QAction(*get_icon(":/icons/trigger-high.svg"),
456                 tr("Trigger on high level"), parent);
457         trigger_high_->setCheckable(true);
458         connect(trigger_high_, SIGNAL(triggered()), this, SLOT(on_trigger()));
459
460         trigger_falling_ = new QAction(*get_icon(":/icons/trigger-falling.svg"),
461                 tr("Trigger on falling edge"), parent);
462         trigger_falling_->setCheckable(true);
463         connect(trigger_falling_, SIGNAL(triggered()), this, SLOT(on_trigger()));
464
465         trigger_low_ = new QAction(*get_icon(":/icons/trigger-low.svg"),
466                 tr("Trigger on low level"), parent);
467         trigger_low_->setCheckable(true);
468         connect(trigger_low_, SIGNAL(triggered()), this, SLOT(on_trigger()));
469
470         trigger_change_ = new QAction(*get_icon(":/icons/trigger-change.svg"),
471                 tr("Trigger on rising or falling edge"), parent);
472         trigger_change_->setCheckable(true);
473         connect(trigger_change_, SIGNAL(triggered()), this, SLOT(on_trigger()));
474 }
475
476 const vector<int32_t> LogicSignal::get_trigger_types() const
477 {
478         // We may not be associated with a device
479         if (!device_)
480                 return vector<int32_t>();
481
482         const auto sr_dev = device_->device();
483         if (sr_dev->config_check(ConfigKey::TRIGGER_MATCH, Capability::LIST)) {
484                 const Glib::VariantContainerBase gvar =
485                         sr_dev->config_list(ConfigKey::TRIGGER_MATCH);
486
487                 vector<int32_t> ttypes;
488
489                 for (unsigned int i = 0; i < gvar.get_n_children(); i++) {
490                         Glib::VariantBase tmp_vb;
491                         gvar.get_child(tmp_vb, i);
492
493                         Glib::Variant<int32_t> tmp_v =
494                                 Glib::VariantBase::cast_dynamic< Glib::Variant<int32_t> >(tmp_vb);
495
496                         ttypes.push_back(tmp_v.get());
497                 }
498
499                 return ttypes;
500         } else {
501                 return vector<int32_t>();
502         }
503 }
504
505 QAction* LogicSignal::action_from_trigger_type(const TriggerMatchType *type)
506 {
507         QAction *action;
508
509         action = trigger_none_;
510         if (type) {
511                 switch (type->id()) {
512                 case SR_TRIGGER_ZERO:
513                         action = trigger_low_;
514                         break;
515                 case SR_TRIGGER_ONE:
516                         action = trigger_high_;
517                         break;
518                 case SR_TRIGGER_RISING:
519                         action = trigger_rising_;
520                         break;
521                 case SR_TRIGGER_FALLING:
522                         action = trigger_falling_;
523                         break;
524                 case SR_TRIGGER_EDGE:
525                         action = trigger_change_;
526                         break;
527                 default:
528                         assert(false);
529                 }
530         }
531
532         return action;
533 }
534
535 const TriggerMatchType *LogicSignal::trigger_type_from_action(QAction *action)
536 {
537         if (action == trigger_low_)
538                 return TriggerMatchType::ZERO;
539         else if (action == trigger_high_)
540                 return TriggerMatchType::ONE;
541         else if (action == trigger_rising_)
542                 return TriggerMatchType::RISING;
543         else if (action == trigger_falling_)
544                 return TriggerMatchType::FALLING;
545         else if (action == trigger_change_)
546                 return TriggerMatchType::EDGE;
547         else
548                 return nullptr;
549 }
550
551 void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
552 {
553         Signal::populate_popup_form(parent, form);
554
555         signal_height_sb_ = new QSpinBox(parent);
556         signal_height_sb_->setRange(5, 1000);
557         signal_height_sb_->setSingleStep(5);
558         signal_height_sb_->setSuffix(tr(" pixels"));
559         signal_height_sb_->setValue(signal_height_);
560         connect(signal_height_sb_, SIGNAL(valueChanged(int)),
561                 this, SLOT(on_signal_height_changed(int)));
562         form->addRow(tr("Trace height"), signal_height_sb_);
563
564         // Trigger settings
565         const vector<int32_t> trig_types = get_trigger_types();
566
567         if (!trig_types.empty()) {
568                 trigger_bar_ = new QToolBar(parent);
569                 init_trigger_actions(trigger_bar_);
570                 trigger_bar_->addAction(trigger_none_);
571                 trigger_none_->setChecked(!trigger_match_);
572
573                 for (auto type_id : trig_types) {
574                         const TriggerMatchType *const type =
575                                 TriggerMatchType::get(type_id);
576                         QAction *const action = action_from_trigger_type(type);
577                         trigger_bar_->addAction(action);
578                         action->setChecked(trigger_match_ == type);
579                 }
580
581                 // Only allow triggers to be changed when we're stopped
582                 if (session_.get_capture_state() != Session::Stopped)
583                         for (QAction* action : trigger_bar_->findChildren<QAction*>())  // clazy:exclude=range-loop
584                                 action->setEnabled(false);
585
586                 form->addRow(tr("Trigger"), trigger_bar_);
587         }
588 }
589
590 void LogicSignal::modify_trigger()
591 {
592         auto trigger = session_.session()->trigger();
593         auto new_trigger = session_.device_manager().context()->create_trigger("pulseview");
594
595         if (trigger) {
596                 for (auto stage : trigger->stages()) {
597                         const auto &matches = stage->matches();
598                         if (none_of(matches.begin(), matches.end(),
599                             [&](shared_ptr<TriggerMatch> match) {
600                                         return match->channel() != base_->channel(); }))
601                                 continue;
602
603                         auto new_stage = new_trigger->add_stage();
604                         for (auto match : stage->matches()) {
605                                 if (match->channel() == base_->channel())
606                                         continue;
607                                 new_stage->add_match(match->channel(), match->type());
608                         }
609                 }
610         }
611
612         if (trigger_match_) {
613                 // Until we can let the user decide how to group trigger matches
614                 // into stages, put all of the matches into a single stage --
615                 // most devices only support a single trigger stage.
616                 if (new_trigger->stages().empty())
617                         new_trigger->add_stage();
618
619                 new_trigger->stages().back()->add_match(base_->channel(),
620                         trigger_match_);
621         }
622
623         session_.session()->set_trigger(
624                 new_trigger->stages().empty() ? nullptr : new_trigger);
625
626         if (owner_)
627                 owner_->row_item_appearance_changed(false, true);
628 }
629
630 const QIcon* LogicSignal::get_icon(const char *path)
631 {
632         if (!icon_cache_.contains(path)) {
633                 const QIcon *icon = new QIcon(path);
634                 icon_cache_.insert(path, icon);
635         }
636
637         return icon_cache_.take(path);
638 }
639
640 const QPixmap* LogicSignal::get_pixmap(const char *path)
641 {
642         if (!pixmap_cache_.contains(path)) {
643                 const QPixmap *pixmap = new QPixmap(path);
644                 pixmap_cache_.insert(path, pixmap);
645         }
646
647         return pixmap_cache_.take(path);
648 }
649
650 void LogicSignal::on_setting_changed(const QString &key, const QVariant &value)
651 {
652         Signal::on_setting_changed(key, value);
653
654         if (key == GlobalSettings::Key_View_ShowSamplingPoints)
655                 show_sampling_points_ = value.toBool();
656
657         if (key == GlobalSettings::Key_View_FillSignalHighAreas)
658                 fill_high_areas_ = value.toBool();
659
660         if (key == GlobalSettings::Key_View_FillSignalHighAreaColor)
661                 high_fill_color_ = QColor::fromRgba(value.value<uint32_t>());
662 }
663
664 void LogicSignal::on_trigger()
665 {
666         QAction *action;
667
668         action_from_trigger_type(trigger_match_)->setChecked(false);
669
670         action = (QAction *)sender();
671         action->setChecked(true);
672         trigger_match_ = trigger_type_from_action(action);
673
674         modify_trigger();
675 }
676
677 void LogicSignal::on_signal_height_changed(int height)
678 {
679         signal_height_ = height;
680
681         if (owner_) {
682                 // Call order is important, otherwise the lazy event handler won't work
683                 owner_->extents_changed(false, true);
684                 owner_->row_item_appearance_changed(false, true);
685         }
686 }
687
688 } // namespace trace
689 } // namespace views
690 } // namespace pv