]> sigrok.org Git - pulseview.git/blob - pv/views/trace/logicsignal.cpp
f43ac37e7ebf5b4d583ca3862d856ba59763d02e
[pulseview.git] / pv / views / trace / logicsignal.cpp
1 /*
2  * This file is part of the PulseView project.
3  *
4  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <extdef.h>
21
22 #include <cassert>
23 #include <cmath>
24
25 #include <algorithm>
26
27 #include <QApplication>
28 #include <QFormLayout>
29 #include <QToolBar>
30
31 #include "logicsignal.hpp"
32 #include "view.hpp"
33
34 #include <pv/data/logic.hpp>
35 #include <pv/data/logicsegment.hpp>
36 #include <pv/data/signalbase.hpp>
37 #include <pv/devicemanager.hpp>
38 #include <pv/devices/device.hpp>
39 #include <pv/globalsettings.hpp>
40 #include <pv/session.hpp>
41
42 #include <libsigrokcxx/libsigrokcxx.hpp>
43
44 using std::deque;
45 using std::max;
46 using std::make_pair;
47 using std::min;
48 using std::none_of;
49 using std::out_of_range;
50 using std::pair;
51 using std::shared_ptr;
52 using std::vector;
53
54 using sigrok::ConfigKey;
55 using sigrok::Capability;
56 using sigrok::Trigger;
57 using sigrok::TriggerMatch;
58 using sigrok::TriggerMatchType;
59
60 using pv::data::LogicSegment;
61
62 namespace pv {
63 namespace views {
64 namespace trace {
65
66 const float LogicSignal::Oversampling = 2.0f;
67
68 const QColor LogicSignal::EdgeColor(0x80, 0x80, 0x80);
69 const QColor LogicSignal::HighColor(0x00, 0xC0, 0x00);
70 const QColor LogicSignal::LowColor(0xC0, 0x00, 0x00);
71 const QColor LogicSignal::SamplingPointColor(0x77, 0x77, 0x77);
72
73 const QColor LogicSignal::SignalColors[10] = {
74         QColor(0x16, 0x19, 0x1A),       // Black
75         QColor(0x8F, 0x52, 0x02),       // Brown
76         QColor(0xCC, 0x00, 0x00),       // Red
77         QColor(0xF5, 0x79, 0x00),       // Orange
78         QColor(0xED, 0xD4, 0x00),       // Yellow
79         QColor(0x73, 0xD2, 0x16),       // Green
80         QColor(0x34, 0x65, 0xA4),       // Blue
81         QColor(0x75, 0x50, 0x7B),       // Violet
82         QColor(0x88, 0x8A, 0x85),       // Grey
83         QColor(0xEE, 0xEE, 0xEC),       // White
84 };
85
86 QColor LogicSignal::TriggerMarkerBackgroundColor = QColor(0xED, 0xD4, 0x00);
87 const int LogicSignal::TriggerMarkerPadding = 2;
88 const char* LogicSignal::TriggerMarkerIcons[8] = {
89         nullptr,
90         ":/icons/trigger-marker-low.svg",
91         ":/icons/trigger-marker-high.svg",
92         ":/icons/trigger-marker-rising.svg",
93         ":/icons/trigger-marker-falling.svg",
94         ":/icons/trigger-marker-change.svg",
95         nullptr,
96         nullptr
97 };
98
99 QCache<QString, const QIcon> LogicSignal::icon_cache_;
100 QCache<QString, const QPixmap> LogicSignal::pixmap_cache_;
101
102 LogicSignal::LogicSignal(
103         pv::Session &session,
104         shared_ptr<devices::Device> device,
105         shared_ptr<data::SignalBase> base) :
106         Signal(session, base),
107         device_(device),
108         trigger_types_(get_trigger_types()),
109         trigger_none_(nullptr),
110         trigger_rising_(nullptr),
111         trigger_high_(nullptr),
112         trigger_falling_(nullptr),
113         trigger_low_(nullptr),
114         trigger_change_(nullptr)
115 {
116         shared_ptr<Trigger> trigger;
117
118         base_->set_color(SignalColors[base->index() % countof(SignalColors)]);
119
120         GlobalSettings gs;
121         signal_height_ = gs.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt();
122
123         /* Populate this channel's trigger setting with whatever we
124          * find in the current session trigger, if anything. */
125         trigger_match_ = nullptr;
126         if ((trigger = session_.session()->trigger()))
127                 for (auto stage : trigger->stages())
128                         for (auto match : stage->matches())
129                                 if (match->channel() == base_->channel())
130                                         trigger_match_ = match->type();
131 }
132
133 shared_ptr<pv::data::SignalData> LogicSignal::data() const
134 {
135         return base_->logic_data();
136 }
137
138 shared_ptr<pv::data::Logic> LogicSignal::logic_data() const
139 {
140         return base_->logic_data();
141 }
142
143 void LogicSignal::save_settings(QSettings &settings) const
144 {
145         settings.setValue("trace_height", signal_height_);
146 }
147
148 void LogicSignal::restore_settings(QSettings &settings)
149 {
150         if (settings.contains("trace_height")) {
151                 const int old_height = signal_height_;
152                 signal_height_ = settings.value("trace_height").toInt();
153
154                 if ((signal_height_ != old_height) && owner_) {
155                         // Call order is important, otherwise the lazy event handler won't work
156                         owner_->extents_changed(false, true);
157                         owner_->row_item_appearance_changed(false, true);
158                 }
159         }
160 }
161
162 pair<int, int> LogicSignal::v_extents() const
163 {
164         const int signal_margin =
165                 QFontMetrics(QApplication::font()).height() / 2;
166         return make_pair(-signal_height_ - signal_margin, signal_margin);
167 }
168
169 void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
170 {
171         QLineF *line;
172
173         vector< pair<int64_t, bool> > edges;
174
175         assert(base_);
176         assert(owner_);
177
178         const int y = get_visual_y();
179
180         if (!base_->enabled())
181                 return;
182
183         const float low_offset = y + 0.5f;
184         const float high_offset = low_offset - signal_height_;
185
186         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
187         if (!segment || (segment->get_sample_count() == 0))
188                 return;
189
190         double samplerate = segment->samplerate();
191
192         // Show sample rate as 1Hz when it is unknown
193         if (samplerate == 0.0)
194                 samplerate = 1.0;
195
196         const double pixels_offset = pp.pixels_offset();
197         const pv::util::Timestamp& start_time = segment->start_time();
198         const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
199         const double samples_per_pixel = samplerate * pp.scale();
200         const double pixels_per_sample = 1 / samples_per_pixel;
201         const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
202         const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
203
204         const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
205                 (int64_t)0), last_sample);
206         const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
207                 (int64_t)0), last_sample);
208
209         segment->get_subsampled_edges(edges, start_sample, end_sample,
210                 samples_per_pixel / Oversampling, base_->index());
211         assert(edges.size() >= 2);
212
213         const float first_sample_x =
214                 pp.left() + (edges.front().first / samples_per_pixel - pixels_offset);
215         const float last_sample_x =
216                 pp.left() + (edges.back().first / samples_per_pixel - pixels_offset);
217
218         // Check whether we need to paint the sampling points
219         GlobalSettings settings;
220         const bool show_sampling_points =
221                 settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool() &&
222                 (samples_per_pixel < 0.25);
223
224         vector<QRectF> sampling_points;
225         float sampling_point_x = first_sample_x;
226         int64_t sampling_point_sample = start_sample;
227         const int w = 2;
228
229         if (show_sampling_points)
230                 sampling_points.reserve(end_sample - start_sample + 1);
231
232         // Check whether we need to fill the high areas
233         const bool fill_high_areas =
234                 settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool();
235         vector<QRectF> high_rects;
236         float rising_edge_x;
237         bool rising_edge_seen = false;
238
239         // Paint the edges
240         const unsigned int edge_count = edges.size() - 2;
241         QLineF *const edge_lines = new QLineF[edge_count];
242         line = edge_lines;
243
244         if (edges.front().second) {
245                 // Beginning of trace is high
246                 rising_edge_x = first_sample_x;
247                 rising_edge_seen = true;
248         }
249
250         for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
251                 // Note: multiple edges occupying a single pixel are represented by an edge
252                 // with undefined logic level. This means that only the first falling edge
253                 // after a rising edge corresponds to said rising edge - and vice versa. If
254                 // more edges with the same logic level follow, they denote multiple edges.
255
256                 const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset);
257                 *line++ = QLineF(x, high_offset, x, low_offset);
258
259                 if (fill_high_areas) {
260                         // Any edge terminates a high area
261                         const int width = x - rising_edge_x;
262                         if (rising_edge_seen && (width > 0)) {
263                                 high_rects.emplace_back(rising_edge_x, high_offset,
264                                         width, signal_height_);
265                                 rising_edge_seen = false;
266                         }
267
268                         // Only rising edges start high areas
269                         if ((*i).second) {
270                                 rising_edge_x = x;
271                                 rising_edge_seen = true;
272                         }
273                 }
274
275                 if (show_sampling_points)
276                         while (sampling_point_sample < (*i).first) {
277                                 const float y = (*i).second ? low_offset : high_offset;
278                                 sampling_points.emplace_back(
279                                         QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
280                                 sampling_point_sample++;
281                                 sampling_point_x += pixels_per_sample;
282                         };
283         }
284
285         // Calculate the sample points from the last edge to the end of the trace
286         if (show_sampling_points)
287                 while ((uint64_t)sampling_point_sample <= end_sample) {
288                         // Signal changed after the last edge, so the level is inverted
289                         const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
290                         sampling_points.emplace_back(
291                                 QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
292                         sampling_point_sample++;
293                         sampling_point_x += pixels_per_sample;
294                 };
295
296         if (fill_high_areas) {
297                 // Add last high rectangle if the signal is still high at the end of the trace
298                 if (rising_edge_seen && (edges.cend() - 1)->second)
299                         high_rects.emplace_back(rising_edge_x, high_offset,
300                                 last_sample_x - rising_edge_x, signal_height_);
301
302                 const QColor fill_color = QColor::fromRgba(settings.value(
303                         GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>());
304                 p.setPen(fill_color);
305                 p.setBrush(fill_color);
306                 p.drawRects((const QRectF*)(high_rects.data()), high_rects.size());
307         }
308
309         p.setPen(EdgeColor);
310         p.drawLines(edge_lines, edge_count);
311         delete[] edge_lines;
312
313         // Paint the caps
314         const unsigned int max_cap_line_count = edges.size();
315         QLineF *const cap_lines = new QLineF[max_cap_line_count];
316
317         p.setPen(HighColor);
318         paint_caps(p, cap_lines, edges, true, samples_per_pixel,
319                 pixels_offset, pp.left(), high_offset);
320         p.setPen(LowColor);
321         paint_caps(p, cap_lines, edges, false, samples_per_pixel,
322                 pixels_offset, pp.left(), low_offset);
323
324         delete[] cap_lines;
325
326         // Paint the sampling points
327         if (show_sampling_points) {
328                 p.setPen(SamplingPointColor);
329                 p.drawRects(sampling_points.data(), sampling_points.size());
330         }
331 }
332
333 void LogicSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
334 {
335         if (base_->enabled()) {
336                 if (trigger_match_) {
337                         // Draw the trigger marker
338                         const int y = get_visual_y();
339
340                         for (int32_t type_id : trigger_types_) {
341                                 const TriggerMatchType *const type =
342                                         TriggerMatchType::get(type_id);
343                                 if (trigger_match_ != type || type_id < 0 ||
344                                         (size_t)type_id >= countof(TriggerMarkerIcons) ||
345                                         !TriggerMarkerIcons[type_id])
346                                         continue;
347
348                                 const QPixmap *const pixmap = get_pixmap(
349                                         TriggerMarkerIcons[type_id]);
350                                 if (!pixmap)
351                                         continue;
352
353                                 const float pad = TriggerMarkerPadding - 0.5f;
354                                 const QSize size = pixmap->size();
355                                 const QPoint point(
356                                         pp.right() - size.width() - pad * 2,
357                                         y - (signal_height_ + size.height()) / 2);
358
359                                 p.setPen(QPen(TriggerMarkerBackgroundColor.darker()));
360                                 p.setBrush(TriggerMarkerBackgroundColor);
361                                 p.drawRoundedRect(QRectF(point, size).adjusted(
362                                         -pad, -pad, pad, pad), pad, pad);
363                                 p.drawPixmap(point, *pixmap);
364
365                                 break;
366                         }
367                 }
368
369                 if (show_hover_marker_)
370                         paint_hover_marker(p);
371         }
372 }
373
374 vector<LogicSegment::EdgePair> LogicSignal::get_nearest_level_changes(uint64_t sample_pos)
375 {
376         assert(base_);
377         assert(owner_);
378
379         if (sample_pos == 0)
380                 return vector<LogicSegment::EdgePair>();
381
382         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
383         if (!segment || (segment->get_sample_count() == 0))
384                 return vector<LogicSegment::EdgePair>();
385
386         const View *view = owner_->view();
387         assert(view);
388         const double samples_per_pixel = base_->get_samplerate() * view->scale();
389
390         vector<LogicSegment::EdgePair> edges;
391
392         segment->get_surrounding_edges(edges, sample_pos,
393                 samples_per_pixel / Oversampling, base_->index());
394
395         if (edges.empty())
396                 return vector<LogicSegment::EdgePair>();
397
398         return edges;
399 }
400
401 void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
402         vector< pair<int64_t, bool> > &edges, bool level,
403         double samples_per_pixel, double pixels_offset, float x_offset,
404         float y_offset)
405 {
406         QLineF *line = lines;
407
408         for (auto i = edges.begin(); i != (edges.end() - 1); i++)
409                 if ((*i).second == level) {
410                         *line++ = QLineF(
411                                 ((*i).first / samples_per_pixel -
412                                         pixels_offset) + x_offset, y_offset,
413                                 ((*(i+1)).first / samples_per_pixel -
414                                         pixels_offset) + x_offset, y_offset);
415                 }
416
417         p.drawLines(lines, line - lines);
418 }
419
420 shared_ptr<pv::data::LogicSegment> LogicSignal::get_logic_segment_to_paint() const
421 {
422         shared_ptr<pv::data::LogicSegment> segment;
423
424         const deque< shared_ptr<pv::data::LogicSegment> > &segments =
425                 base_->logic_data()->logic_segments();
426
427         if (!segments.empty()) {
428                 if (segment_display_mode_ == ShowLastSegmentOnly) {
429                         segment = segments.back();
430                 }
431
432         if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
433                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
434                         try {
435                                 segment = segments.at(current_segment_);
436                         } catch (out_of_range&) {
437                                 qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
438                         }
439                 }
440         }
441
442         return segment;
443 }
444
445 void LogicSignal::init_trigger_actions(QWidget *parent)
446 {
447         trigger_none_ = new QAction(*get_icon(":/icons/trigger-none.svg"),
448                 tr("No trigger"), parent);
449         trigger_none_->setCheckable(true);
450         connect(trigger_none_, SIGNAL(triggered()), this, SLOT(on_trigger()));
451
452         trigger_rising_ = new QAction(*get_icon(":/icons/trigger-rising.svg"),
453                 tr("Trigger on rising edge"), parent);
454         trigger_rising_->setCheckable(true);
455         connect(trigger_rising_, SIGNAL(triggered()), this, SLOT(on_trigger()));
456
457         trigger_high_ = new QAction(*get_icon(":/icons/trigger-high.svg"),
458                 tr("Trigger on high level"), parent);
459         trigger_high_->setCheckable(true);
460         connect(trigger_high_, SIGNAL(triggered()), this, SLOT(on_trigger()));
461
462         trigger_falling_ = new QAction(*get_icon(":/icons/trigger-falling.svg"),
463                 tr("Trigger on falling edge"), parent);
464         trigger_falling_->setCheckable(true);
465         connect(trigger_falling_, SIGNAL(triggered()), this, SLOT(on_trigger()));
466
467         trigger_low_ = new QAction(*get_icon(":/icons/trigger-low.svg"),
468                 tr("Trigger on low level"), parent);
469         trigger_low_->setCheckable(true);
470         connect(trigger_low_, SIGNAL(triggered()), this, SLOT(on_trigger()));
471
472         trigger_change_ = new QAction(*get_icon(":/icons/trigger-change.svg"),
473                 tr("Trigger on rising or falling edge"), parent);
474         trigger_change_->setCheckable(true);
475         connect(trigger_change_, SIGNAL(triggered()), this, SLOT(on_trigger()));
476 }
477
478 const vector<int32_t> LogicSignal::get_trigger_types() const
479 {
480         // We may not be associated with a device
481         if (!device_)
482                 return vector<int32_t>();
483
484         const auto sr_dev = device_->device();
485         if (sr_dev->config_check(ConfigKey::TRIGGER_MATCH, Capability::LIST)) {
486                 const Glib::VariantContainerBase gvar =
487                         sr_dev->config_list(ConfigKey::TRIGGER_MATCH);
488
489                 vector<int32_t> ttypes;
490
491                 for (unsigned int i = 0; i < gvar.get_n_children(); i++) {
492                         Glib::VariantBase tmp_vb;
493                         gvar.get_child(tmp_vb, i);
494
495                         Glib::Variant<int32_t> tmp_v =
496                                 Glib::VariantBase::cast_dynamic< Glib::Variant<int32_t> >(tmp_vb);
497
498                         ttypes.push_back(tmp_v.get());
499                 }
500
501                 return ttypes;
502         } else {
503                 return vector<int32_t>();
504         }
505 }
506
507 QAction* LogicSignal::action_from_trigger_type(const TriggerMatchType *type)
508 {
509         QAction *action;
510
511         action = trigger_none_;
512         if (type) {
513                 switch (type->id()) {
514                 case SR_TRIGGER_ZERO:
515                         action = trigger_low_;
516                         break;
517                 case SR_TRIGGER_ONE:
518                         action = trigger_high_;
519                         break;
520                 case SR_TRIGGER_RISING:
521                         action = trigger_rising_;
522                         break;
523                 case SR_TRIGGER_FALLING:
524                         action = trigger_falling_;
525                         break;
526                 case SR_TRIGGER_EDGE:
527                         action = trigger_change_;
528                         break;
529                 default:
530                         assert(false);
531                 }
532         }
533
534         return action;
535 }
536
537 const TriggerMatchType *LogicSignal::trigger_type_from_action(QAction *action)
538 {
539         if (action == trigger_low_)
540                 return TriggerMatchType::ZERO;
541         else if (action == trigger_high_)
542                 return TriggerMatchType::ONE;
543         else if (action == trigger_rising_)
544                 return TriggerMatchType::RISING;
545         else if (action == trigger_falling_)
546                 return TriggerMatchType::FALLING;
547         else if (action == trigger_change_)
548                 return TriggerMatchType::EDGE;
549         else
550                 return nullptr;
551 }
552
553 void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
554 {
555         Signal::populate_popup_form(parent, form);
556
557         signal_height_sb_ = new QSpinBox(parent);
558         signal_height_sb_->setRange(5, 1000);
559         signal_height_sb_->setSingleStep(5);
560         signal_height_sb_->setSuffix(tr(" pixels"));
561         signal_height_sb_->setValue(signal_height_);
562         connect(signal_height_sb_, SIGNAL(valueChanged(int)),
563                 this, SLOT(on_signal_height_changed(int)));
564         form->addRow(tr("Trace height"), signal_height_sb_);
565
566         // Trigger settings
567         const vector<int32_t> trig_types = get_trigger_types();
568
569         if (!trig_types.empty()) {
570                 trigger_bar_ = new QToolBar(parent);
571                 init_trigger_actions(trigger_bar_);
572                 trigger_bar_->addAction(trigger_none_);
573                 trigger_none_->setChecked(!trigger_match_);
574
575                 for (auto type_id : trig_types) {
576                         const TriggerMatchType *const type =
577                                 TriggerMatchType::get(type_id);
578                         QAction *const action = action_from_trigger_type(type);
579                         trigger_bar_->addAction(action);
580                         action->setChecked(trigger_match_ == type);
581                 }
582
583                 // Only allow triggers to be changed when we're stopped
584                 if (session_.get_capture_state() != Session::Stopped)
585                         for (QAction* action : trigger_bar_->findChildren<QAction*>())
586                                 action->setEnabled(false);
587
588                 form->addRow(tr("Trigger"), trigger_bar_);
589         }
590 }
591
592 void LogicSignal::modify_trigger()
593 {
594         auto trigger = session_.session()->trigger();
595         auto new_trigger = session_.device_manager().context()->create_trigger("pulseview");
596
597         if (trigger) {
598                 for (auto stage : trigger->stages()) {
599                         const auto &matches = stage->matches();
600                         if (none_of(matches.begin(), matches.end(),
601                             [&](shared_ptr<TriggerMatch> match) {
602                                         return match->channel() != base_->channel(); }))
603                                 continue;
604
605                         auto new_stage = new_trigger->add_stage();
606                         for (auto match : stage->matches()) {
607                                 if (match->channel() == base_->channel())
608                                         continue;
609                                 new_stage->add_match(match->channel(), match->type());
610                         }
611                 }
612         }
613
614         if (trigger_match_) {
615                 // Until we can let the user decide how to group trigger matches
616                 // into stages, put all of the matches into a single stage --
617                 // most devices only support a single trigger stage.
618                 if (new_trigger->stages().empty())
619                         new_trigger->add_stage();
620
621                 new_trigger->stages().back()->add_match(base_->channel(),
622                         trigger_match_);
623         }
624
625         session_.session()->set_trigger(
626                 new_trigger->stages().empty() ? nullptr : new_trigger);
627
628         if (owner_)
629                 owner_->row_item_appearance_changed(false, true);
630 }
631
632 const QIcon* LogicSignal::get_icon(const char *path)
633 {
634         if (!icon_cache_.contains(path)) {
635                 const QIcon *icon = new QIcon(path);
636                 icon_cache_.insert(path, icon);
637         }
638
639         return icon_cache_.take(path);
640 }
641
642 const QPixmap* LogicSignal::get_pixmap(const char *path)
643 {
644         if (!pixmap_cache_.contains(path)) {
645                 const QPixmap *pixmap = new QPixmap(path);
646                 pixmap_cache_.insert(path, pixmap);
647         }
648
649         return pixmap_cache_.take(path);
650 }
651
652 void LogicSignal::on_trigger()
653 {
654         QAction *action;
655
656         action_from_trigger_type(trigger_match_)->setChecked(false);
657
658         action = (QAction *)sender();
659         action->setChecked(true);
660         trigger_match_ = trigger_type_from_action(action);
661
662         modify_trigger();
663 }
664
665 void LogicSignal::on_signal_height_changed(int height)
666 {
667         signal_height_ = height;
668
669         if (owner_) {
670                 // Call order is important, otherwise the lazy event handler won't work
671                 owner_->extents_changed(false, true);
672                 owner_->row_item_appearance_changed(false, true);
673         }
674 }
675
676 } // namespace trace
677 } // namespace views
678 } // namespace pv