]> sigrok.org Git - pulseview.git/blob - pv/views/trace/logicsignal.cpp
Make new views take over the main view's signal settings
[pulseview.git] / pv / views / trace / logicsignal.cpp
1 /*
2  * This file is part of the PulseView project.
3  *
4  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <extdef.h>
21
22 #include <cassert>
23 #include <cmath>
24
25 #include <algorithm>
26
27 #include <QApplication>
28 #include <QFormLayout>
29 #include <QToolBar>
30
31 #include "logicsignal.hpp"
32 #include "view.hpp"
33
34 #include <pv/data/logic.hpp>
35 #include <pv/data/logicsegment.hpp>
36 #include <pv/data/signalbase.hpp>
37 #include <pv/devicemanager.hpp>
38 #include <pv/devices/device.hpp>
39 #include <pv/globalsettings.hpp>
40 #include <pv/session.hpp>
41
42 #include <libsigrokcxx/libsigrokcxx.hpp>
43
44 using std::deque;
45 using std::max;
46 using std::make_pair;
47 using std::min;
48 using std::none_of;
49 using std::out_of_range;
50 using std::pair;
51 using std::shared_ptr;
52 using std::vector;
53
54 using sigrok::ConfigKey;
55 using sigrok::Capability;
56 using sigrok::Trigger;
57 using sigrok::TriggerMatch;
58 using sigrok::TriggerMatchType;
59
60 using pv::data::LogicSegment;
61
62 namespace pv {
63 namespace views {
64 namespace trace {
65
66 const float LogicSignal::Oversampling = 2.0f;
67
68 const QColor LogicSignal::EdgeColor(0x80, 0x80, 0x80);
69 const QColor LogicSignal::HighColor(0x00, 0xC0, 0x00);
70 const QColor LogicSignal::LowColor(0xC0, 0x00, 0x00);
71 const QColor LogicSignal::SamplingPointColor(0x77, 0x77, 0x77);
72
73 const QColor LogicSignal::SignalColors[10] = {
74         QColor(0x16, 0x19, 0x1A),       // Black
75         QColor(0x8F, 0x52, 0x02),       // Brown
76         QColor(0xCC, 0x00, 0x00),       // Red
77         QColor(0xF5, 0x79, 0x00),       // Orange
78         QColor(0xED, 0xD4, 0x00),       // Yellow
79         QColor(0x73, 0xD2, 0x16),       // Green
80         QColor(0x34, 0x65, 0xA4),       // Blue
81         QColor(0x75, 0x50, 0x7B),       // Violet
82         QColor(0x88, 0x8A, 0x85),       // Grey
83         QColor(0xEE, 0xEE, 0xEC),       // White
84 };
85
86 QColor LogicSignal::TriggerMarkerBackgroundColor = QColor(0xED, 0xD4, 0x00);
87 const int LogicSignal::TriggerMarkerPadding = 2;
88 const char* LogicSignal::TriggerMarkerIcons[8] = {
89         nullptr,
90         ":/icons/trigger-marker-low.svg",
91         ":/icons/trigger-marker-high.svg",
92         ":/icons/trigger-marker-rising.svg",
93         ":/icons/trigger-marker-falling.svg",
94         ":/icons/trigger-marker-change.svg",
95         nullptr,
96         nullptr
97 };
98
99 QCache<QString, const QIcon> LogicSignal::icon_cache_;
100 QCache<QString, const QPixmap> LogicSignal::pixmap_cache_;
101
102 LogicSignal::LogicSignal(
103         pv::Session &session,
104         shared_ptr<devices::Device> device,
105         shared_ptr<data::SignalBase> base) :
106         Signal(session, base),
107         device_(device),
108         trigger_types_(get_trigger_types()),
109         trigger_none_(nullptr),
110         trigger_rising_(nullptr),
111         trigger_high_(nullptr),
112         trigger_falling_(nullptr),
113         trigger_low_(nullptr),
114         trigger_change_(nullptr)
115 {
116         shared_ptr<Trigger> trigger;
117
118         base_->set_color(SignalColors[base->index() % countof(SignalColors)]);
119
120         GlobalSettings settings;
121         signal_height_ = settings.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt();
122         show_sampling_points_ =
123                 settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool();
124         fill_high_areas_ =
125                 settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool();
126         high_fill_color_ = QColor::fromRgba(settings.value(
127                 GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>());
128
129         /* Populate this channel's trigger setting with whatever we
130          * find in the current session trigger, if anything. */
131         trigger_match_ = nullptr;
132         if ((trigger = session_.session()->trigger()))
133                 for (auto stage : trigger->stages())
134                         for (auto match : stage->matches())
135                                 if (match->channel() == base_->channel())
136                                         trigger_match_ = match->type();
137 }
138
139 shared_ptr<pv::data::SignalData> LogicSignal::data() const
140 {
141         return base_->logic_data();
142 }
143
144 shared_ptr<pv::data::Logic> LogicSignal::logic_data() const
145 {
146         return base_->logic_data();
147 }
148
149 std::map<QString, QVariant> LogicSignal::save_settings() const
150 {
151         std::map<QString, QVariant> result;
152
153         result["trace_height"] = signal_height_;
154
155         return result;
156 }
157
158 void LogicSignal::restore_settings(std::map<QString, QVariant> settings)
159 {
160         auto entry = settings.find("trace_height");
161         if (entry != settings.end()) {
162                 const int old_height = signal_height_;
163                 signal_height_ = settings["trace_height"].toInt();
164
165                 if ((signal_height_ != old_height) && owner_) {
166                         // Call order is important, otherwise the lazy event handler won't work
167                         owner_->extents_changed(false, true);
168                         owner_->row_item_appearance_changed(false, true);
169                 }
170         }
171 }
172
173 pair<int, int> LogicSignal::v_extents() const
174 {
175         const int signal_margin =
176                 QFontMetrics(QApplication::font()).height() / 2;
177         return make_pair(-signal_height_ - signal_margin, signal_margin);
178 }
179
180 void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
181 {
182         QLineF *line;
183
184         vector< pair<int64_t, bool> > edges;
185
186         assert(base_);
187         assert(owner_);
188
189         const int y = get_visual_y();
190
191         if (!base_->enabled())
192                 return;
193
194         const float low_offset = y + 0.5f;
195         const float high_offset = low_offset - signal_height_;
196
197         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
198         if (!segment || (segment->get_sample_count() == 0))
199                 return;
200
201         double samplerate = segment->samplerate();
202
203         // Show sample rate as 1Hz when it is unknown
204         if (samplerate == 0.0)
205                 samplerate = 1.0;
206
207         const double pixels_offset = pp.pixels_offset();
208         const pv::util::Timestamp& start_time = segment->start_time();
209         const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
210         const double samples_per_pixel = samplerate * pp.scale();
211         const double pixels_per_sample = 1 / samples_per_pixel;
212         const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
213         const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
214
215         const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
216                 (int64_t)0), last_sample);
217         const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
218                 (int64_t)0), last_sample);
219
220         segment->get_subsampled_edges(edges, start_sample, end_sample,
221                 samples_per_pixel / Oversampling, base_->index());
222         assert(edges.size() >= 2);
223
224         const float first_sample_x =
225                 pp.left() + (edges.front().first / samples_per_pixel - pixels_offset);
226         const float last_sample_x =
227                 pp.left() + (edges.back().first / samples_per_pixel - pixels_offset);
228
229         // Check whether we need to paint the sampling points
230         const bool show_sampling_points = show_sampling_points_ && (samples_per_pixel < 0.25);
231         vector<QRectF> sampling_points;
232         float sampling_point_x = first_sample_x;
233         int64_t sampling_point_sample = start_sample;
234         const int w = 2;
235
236         if (show_sampling_points)
237                 sampling_points.reserve(end_sample - start_sample + 1);
238
239         vector<QRectF> high_rects;
240         float rising_edge_x;
241         bool rising_edge_seen = false;
242
243         // Paint the edges
244         const unsigned int edge_count = edges.size() - 2;
245         QLineF *const edge_lines = new QLineF[edge_count];
246         line = edge_lines;
247
248         if (edges.front().second) {
249                 // Beginning of trace is high
250                 rising_edge_x = first_sample_x;
251                 rising_edge_seen = true;
252         }
253
254         for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
255                 // Note: multiple edges occupying a single pixel are represented by an edge
256                 // with undefined logic level. This means that only the first falling edge
257                 // after a rising edge corresponds to said rising edge - and vice versa. If
258                 // more edges with the same logic level follow, they denote multiple edges.
259
260                 const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset);
261                 *line++ = QLineF(x, high_offset, x, low_offset);
262
263                 if (fill_high_areas_) {
264                         // Any edge terminates a high area
265                         if (rising_edge_seen) {
266                                 const int width = x - rising_edge_x;
267                                 if (width > 0)
268                                         high_rects.emplace_back(rising_edge_x, high_offset,
269                                                 width, signal_height_);
270                                 rising_edge_seen = false;
271                         }
272
273                         // Only rising edges start high areas
274                         if ((*i).second) {
275                                 rising_edge_x = x;
276                                 rising_edge_seen = true;
277                         }
278                 }
279
280                 if (show_sampling_points)
281                         while (sampling_point_sample < (*i).first) {
282                                 const float y = (*i).second ? low_offset : high_offset;
283                                 sampling_points.emplace_back(
284                                         QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
285                                 sampling_point_sample++;
286                                 sampling_point_x += pixels_per_sample;
287                         };
288         }
289
290         // Calculate the sample points from the last edge to the end of the trace
291         if (show_sampling_points)
292                 while ((uint64_t)sampling_point_sample <= end_sample) {
293                         // Signal changed after the last edge, so the level is inverted
294                         const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
295                         sampling_points.emplace_back(
296                                 QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
297                         sampling_point_sample++;
298                         sampling_point_x += pixels_per_sample;
299                 };
300
301         if (fill_high_areas_) {
302                 // Add last high rectangle if the signal is still high at the end of the trace
303                 if (rising_edge_seen && (edges.cend() - 1)->second)
304                         high_rects.emplace_back(rising_edge_x, high_offset,
305                                 last_sample_x - rising_edge_x, signal_height_);
306
307                 p.setPen(high_fill_color_);
308                 p.setBrush(high_fill_color_);
309                 p.drawRects((const QRectF*)(high_rects.data()), high_rects.size());
310         }
311
312         p.setPen(EdgeColor);
313         p.drawLines(edge_lines, edge_count);
314         delete[] edge_lines;
315
316         // Paint the caps
317         const unsigned int max_cap_line_count = edges.size();
318         QLineF *const cap_lines = new QLineF[max_cap_line_count];
319
320         p.setPen(HighColor);
321         paint_caps(p, cap_lines, edges, true, samples_per_pixel,
322                 pixels_offset, pp.left(), high_offset);
323         p.setPen(LowColor);
324         paint_caps(p, cap_lines, edges, false, samples_per_pixel,
325                 pixels_offset, pp.left(), low_offset);
326
327         delete[] cap_lines;
328
329         // Paint the sampling points
330         if (show_sampling_points) {
331                 p.setPen(SamplingPointColor);
332                 p.drawRects(sampling_points.data(), sampling_points.size());
333         }
334 }
335
336 void LogicSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
337 {
338         if (base_->enabled()) {
339                 if (trigger_match_) {
340                         // Draw the trigger marker
341                         const int y = get_visual_y();
342
343                         for (int32_t type_id : trigger_types_) {
344                                 const TriggerMatchType *const type =
345                                         TriggerMatchType::get(type_id);
346                                 if (trigger_match_ != type || type_id < 0 ||
347                                         (size_t)type_id >= countof(TriggerMarkerIcons) ||
348                                         !TriggerMarkerIcons[type_id])
349                                         continue;
350
351                                 const QPixmap *const pixmap = get_pixmap(
352                                         TriggerMarkerIcons[type_id]);
353                                 if (!pixmap)
354                                         continue;
355
356                                 const float pad = TriggerMarkerPadding - 0.5f;
357                                 const QSize size = pixmap->size();
358                                 const QPoint point(
359                                         pp.right() - size.width() - pad * 2,
360                                         y - (signal_height_ + size.height()) / 2);
361
362                                 p.setPen(QPen(TriggerMarkerBackgroundColor.darker()));
363                                 p.setBrush(TriggerMarkerBackgroundColor);
364                                 p.drawRoundedRect(QRectF(point, size).adjusted(
365                                         -pad, -pad, pad, pad), pad, pad);
366                                 p.drawPixmap(point, *pixmap);
367
368                                 break;
369                         }
370                 }
371
372                 if (show_hover_marker_)
373                         paint_hover_marker(p);
374         }
375 }
376
377 vector<LogicSegment::EdgePair> LogicSignal::get_nearest_level_changes(uint64_t sample_pos)
378 {
379         assert(base_);
380         assert(owner_);
381
382         if (sample_pos == 0)
383                 return vector<LogicSegment::EdgePair>();
384
385         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
386         if (!segment || (segment->get_sample_count() == 0))
387                 return vector<LogicSegment::EdgePair>();
388
389         const View *view = owner_->view();
390         assert(view);
391         const double samples_per_pixel = base_->get_samplerate() * view->scale();
392
393         vector<LogicSegment::EdgePair> edges;
394
395         segment->get_surrounding_edges(edges, sample_pos,
396                 samples_per_pixel / Oversampling, base_->index());
397
398         if (edges.empty())
399                 return vector<LogicSegment::EdgePair>();
400
401         return edges;
402 }
403
404 void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
405         vector< pair<int64_t, bool> > &edges, bool level,
406         double samples_per_pixel, double pixels_offset, float x_offset,
407         float y_offset)
408 {
409         QLineF *line = lines;
410
411         for (auto i = edges.begin(); i != (edges.end() - 1); i++)
412                 if ((*i).second == level) {
413                         *line++ = QLineF(
414                                 ((*i).first / samples_per_pixel -
415                                         pixels_offset) + x_offset, y_offset,
416                                 ((*(i+1)).first / samples_per_pixel -
417                                         pixels_offset) + x_offset, y_offset);
418                 }
419
420         p.drawLines(lines, line - lines);
421 }
422
423 shared_ptr<pv::data::LogicSegment> LogicSignal::get_logic_segment_to_paint() const
424 {
425         shared_ptr<pv::data::LogicSegment> segment;
426
427         const deque< shared_ptr<pv::data::LogicSegment> > &segments =
428                 base_->logic_data()->logic_segments();
429
430         if (!segments.empty()) {
431                 if (segment_display_mode_ == ShowLastSegmentOnly) {
432                         segment = segments.back();
433                 }
434
435         if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
436                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
437                         try {
438                                 segment = segments.at(current_segment_);
439                         } catch (out_of_range&) {
440                                 qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
441                         }
442                 }
443         }
444
445         return segment;
446 }
447
448 void LogicSignal::init_trigger_actions(QWidget *parent)
449 {
450         trigger_none_ = new QAction(*get_icon(":/icons/trigger-none.svg"),
451                 tr("No trigger"), parent);
452         trigger_none_->setCheckable(true);
453         connect(trigger_none_, SIGNAL(triggered()), this, SLOT(on_trigger()));
454
455         trigger_rising_ = new QAction(*get_icon(":/icons/trigger-rising.svg"),
456                 tr("Trigger on rising edge"), parent);
457         trigger_rising_->setCheckable(true);
458         connect(trigger_rising_, SIGNAL(triggered()), this, SLOT(on_trigger()));
459
460         trigger_high_ = new QAction(*get_icon(":/icons/trigger-high.svg"),
461                 tr("Trigger on high level"), parent);
462         trigger_high_->setCheckable(true);
463         connect(trigger_high_, SIGNAL(triggered()), this, SLOT(on_trigger()));
464
465         trigger_falling_ = new QAction(*get_icon(":/icons/trigger-falling.svg"),
466                 tr("Trigger on falling edge"), parent);
467         trigger_falling_->setCheckable(true);
468         connect(trigger_falling_, SIGNAL(triggered()), this, SLOT(on_trigger()));
469
470         trigger_low_ = new QAction(*get_icon(":/icons/trigger-low.svg"),
471                 tr("Trigger on low level"), parent);
472         trigger_low_->setCheckable(true);
473         connect(trigger_low_, SIGNAL(triggered()), this, SLOT(on_trigger()));
474
475         trigger_change_ = new QAction(*get_icon(":/icons/trigger-change.svg"),
476                 tr("Trigger on rising or falling edge"), parent);
477         trigger_change_->setCheckable(true);
478         connect(trigger_change_, SIGNAL(triggered()), this, SLOT(on_trigger()));
479 }
480
481 const vector<int32_t> LogicSignal::get_trigger_types() const
482 {
483         // We may not be associated with a device
484         if (!device_)
485                 return vector<int32_t>();
486
487         const auto sr_dev = device_->device();
488         if (sr_dev->config_check(ConfigKey::TRIGGER_MATCH, Capability::LIST)) {
489                 const Glib::VariantContainerBase gvar =
490                         sr_dev->config_list(ConfigKey::TRIGGER_MATCH);
491
492                 vector<int32_t> ttypes;
493
494                 for (unsigned int i = 0; i < gvar.get_n_children(); i++) {
495                         Glib::VariantBase tmp_vb;
496                         gvar.get_child(tmp_vb, i);
497
498                         Glib::Variant<int32_t> tmp_v =
499                                 Glib::VariantBase::cast_dynamic< Glib::Variant<int32_t> >(tmp_vb);
500
501                         ttypes.push_back(tmp_v.get());
502                 }
503
504                 return ttypes;
505         } else {
506                 return vector<int32_t>();
507         }
508 }
509
510 QAction* LogicSignal::action_from_trigger_type(const TriggerMatchType *type)
511 {
512         QAction *action;
513
514         action = trigger_none_;
515         if (type) {
516                 switch (type->id()) {
517                 case SR_TRIGGER_ZERO:
518                         action = trigger_low_;
519                         break;
520                 case SR_TRIGGER_ONE:
521                         action = trigger_high_;
522                         break;
523                 case SR_TRIGGER_RISING:
524                         action = trigger_rising_;
525                         break;
526                 case SR_TRIGGER_FALLING:
527                         action = trigger_falling_;
528                         break;
529                 case SR_TRIGGER_EDGE:
530                         action = trigger_change_;
531                         break;
532                 default:
533                         assert(false);
534                 }
535         }
536
537         return action;
538 }
539
540 const TriggerMatchType *LogicSignal::trigger_type_from_action(QAction *action)
541 {
542         if (action == trigger_low_)
543                 return TriggerMatchType::ZERO;
544         else if (action == trigger_high_)
545                 return TriggerMatchType::ONE;
546         else if (action == trigger_rising_)
547                 return TriggerMatchType::RISING;
548         else if (action == trigger_falling_)
549                 return TriggerMatchType::FALLING;
550         else if (action == trigger_change_)
551                 return TriggerMatchType::EDGE;
552         else
553                 return nullptr;
554 }
555
556 void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
557 {
558         Signal::populate_popup_form(parent, form);
559
560         signal_height_sb_ = new QSpinBox(parent);
561         signal_height_sb_->setRange(5, 1000);
562         signal_height_sb_->setSingleStep(5);
563         signal_height_sb_->setSuffix(tr(" pixels"));
564         signal_height_sb_->setValue(signal_height_);
565         connect(signal_height_sb_, SIGNAL(valueChanged(int)),
566                 this, SLOT(on_signal_height_changed(int)));
567         form->addRow(tr("Trace height"), signal_height_sb_);
568
569         // Trigger settings
570         const vector<int32_t> trig_types = get_trigger_types();
571
572         if (!trig_types.empty()) {
573                 trigger_bar_ = new QToolBar(parent);
574                 init_trigger_actions(trigger_bar_);
575                 trigger_bar_->addAction(trigger_none_);
576                 trigger_none_->setChecked(!trigger_match_);
577
578                 for (auto type_id : trig_types) {
579                         const TriggerMatchType *const type =
580                                 TriggerMatchType::get(type_id);
581                         QAction *const action = action_from_trigger_type(type);
582                         trigger_bar_->addAction(action);
583                         action->setChecked(trigger_match_ == type);
584                 }
585
586                 // Only allow triggers to be changed when we're stopped
587                 if (session_.get_capture_state() != Session::Stopped)
588                         for (QAction* action : trigger_bar_->findChildren<QAction*>())  // clazy:exclude=range-loop
589                                 action->setEnabled(false);
590
591                 form->addRow(tr("Trigger"), trigger_bar_);
592         }
593 }
594
595 void LogicSignal::modify_trigger()
596 {
597         auto trigger = session_.session()->trigger();
598         auto new_trigger = session_.device_manager().context()->create_trigger("pulseview");
599
600         if (trigger) {
601                 for (auto stage : trigger->stages()) {
602                         const auto &matches = stage->matches();
603                         if (none_of(matches.begin(), matches.end(),
604                             [&](shared_ptr<TriggerMatch> match) {
605                                         return match->channel() != base_->channel(); }))
606                                 continue;
607
608                         auto new_stage = new_trigger->add_stage();
609                         for (auto match : stage->matches()) {
610                                 if (match->channel() == base_->channel())
611                                         continue;
612                                 new_stage->add_match(match->channel(), match->type());
613                         }
614                 }
615         }
616
617         if (trigger_match_) {
618                 // Until we can let the user decide how to group trigger matches
619                 // into stages, put all of the matches into a single stage --
620                 // most devices only support a single trigger stage.
621                 if (new_trigger->stages().empty())
622                         new_trigger->add_stage();
623
624                 new_trigger->stages().back()->add_match(base_->channel(),
625                         trigger_match_);
626         }
627
628         session_.session()->set_trigger(
629                 new_trigger->stages().empty() ? nullptr : new_trigger);
630
631         if (owner_)
632                 owner_->row_item_appearance_changed(false, true);
633 }
634
635 const QIcon* LogicSignal::get_icon(const char *path)
636 {
637         if (!icon_cache_.contains(path)) {
638                 const QIcon *icon = new QIcon(path);
639                 icon_cache_.insert(path, icon);
640         }
641
642         return icon_cache_.take(path);
643 }
644
645 const QPixmap* LogicSignal::get_pixmap(const char *path)
646 {
647         if (!pixmap_cache_.contains(path)) {
648                 const QPixmap *pixmap = new QPixmap(path);
649                 pixmap_cache_.insert(path, pixmap);
650         }
651
652         return pixmap_cache_.take(path);
653 }
654
655 void LogicSignal::on_setting_changed(const QString &key, const QVariant &value)
656 {
657         Signal::on_setting_changed(key, value);
658
659         if (key == GlobalSettings::Key_View_ShowSamplingPoints)
660                 show_sampling_points_ = value.toBool();
661
662         if (key == GlobalSettings::Key_View_FillSignalHighAreas)
663                 fill_high_areas_ = value.toBool();
664
665         if (key == GlobalSettings::Key_View_FillSignalHighAreaColor)
666                 high_fill_color_ = QColor::fromRgba(value.value<uint32_t>());
667 }
668
669 void LogicSignal::on_trigger()
670 {
671         QAction *action;
672
673         action_from_trigger_type(trigger_match_)->setChecked(false);
674
675         action = (QAction *)sender();
676         action->setChecked(true);
677         trigger_match_ = trigger_type_from_action(action);
678
679         modify_trigger();
680 }
681
682 void LogicSignal::on_signal_height_changed(int height)
683 {
684         signal_height_ = height;
685
686         if (owner_) {
687                 // Call order is important, otherwise the lazy event handler won't work
688                 owner_->extents_changed(false, true);
689                 owner_->row_item_appearance_changed(false, true);
690         }
691 }
692
693 } // namespace trace
694 } // namespace views
695 } // namespace pv