2 years agoAdd decoder for Microchip ATSHA204A crypto module
Michalis Pappas [Thu, 26 Apr 2018 16:35:40 +0000 (19:35 +0300)]
Add decoder for Microchip ATSHA204A crypto module

2 years agoAdd ON Semi CAT24C256, CAT24M01.
whitequark [Mon, 21 May 2018 15:55:19 +0000 (15:55 +0000)]
Add ON Semi CAT24C256, CAT24M01.

2 years agoDecoder_put(): Avoid a g_malloc()/g_free() pair per binary out.
Uwe Hermann [Sat, 19 May 2018 00:37:14 +0000 (02:37 +0200)]
Decoder_put(): Avoid a g_malloc()/g_free() pair per binary out.

2 years agoDecoder_put(): Avoid a g_malloc()/g_free() pair per annotation.
Uwe Hermann [Fri, 18 May 2018 22:19:54 +0000 (00:19 +0200)]
Decoder_put(): Avoid a g_malloc()/g_free() pair per annotation.

2 years agosrd_inst_find_by_obj(): Minor performance improvement.
Uwe Hermann [Fri, 18 May 2018 18:14:19 +0000 (20:14 +0200)]
srd_inst_find_by_obj(): Minor performance improvement.

Handle the most common case of one session and one decoder first so
we can exit early. This has a small, but measurable performance benefit.

2 years agosrd_*inst_find_by_obj(): Suggest inlining for performance reasons.
Uwe Hermann [Fri, 18 May 2018 18:11:38 +0000 (20:11 +0200)]
srd_*inst_find_by_obj(): Suggest inlining for performance reasons.

This has a small, but measurable performance benefit.

2 years agosrd_*inst_find_by_obj(): Move functions, make them static.
Uwe Hermann [Fri, 18 May 2018 17:50:16 +0000 (19:50 +0200)]
srd_*inst_find_by_obj(): Move functions, make them static.

These functions are only used in type_decoder.c. Move them there and
make them static.

2 years agosample_matches(): Force inlining for performance reasons.
Uwe Hermann [Fri, 18 May 2018 07:01:40 +0000 (09:01 +0200)]
sample_matches(): Force inlining for performance reasons.

2 years agoSimplify code by dropping session_is_valid().
Uwe Hermann [Thu, 17 May 2018 23:02:13 +0000 (01:02 +0200)]
Simplify code by dropping session_is_valid().

A simple NULL check is sufficient here, max_session_id is being
properly handled by srd_init(), srd_exit(), srd_session_new().

This might also have a small performance benefit.

2 years agoconvert_meta(): Use g_variant_type_equal().
Uwe Hermann [Thu, 17 May 2018 22:27:57 +0000 (00:27 +0200)]
convert_meta(): Use g_variant_type_equal().

2 years agoDoxyfile: Exclude the build/ directory.
Uwe Hermann [Thu, 17 May 2018 22:17:08 +0000 (00:17 +0200)]
Doxyfile: Exclude the build/ directory.

2 years agoAdd srd_searchpaths_get() API docs.
Uwe Hermann [Thu, 17 May 2018 22:13:42 +0000 (00:13 +0200)]
Add srd_searchpaths_get() API docs.

2 years agoDoxyfile: Update to a more recent Doxygen version.
Uwe Hermann [Thu, 17 May 2018 22:08:34 +0000 (00:08 +0200)]
Doxyfile: Update to a more recent Doxygen version.

2 years agoRandom whitespace/cosmetic/consistency fixes.
Uwe Hermann [Thu, 17 May 2018 22:01:05 +0000 (00:01 +0200)]
Random whitespace/cosmetic/consistency fixes.

2 years agotype_decoder.c: Fix a compiler warning (-Wswitch-default).
Uwe Hermann [Thu, 17 May 2018 21:25:42 +0000 (23:25 +0200)]
type_decoder.c: Fix a compiler warning (-Wswitch-default).

  type_decoder.c: In function ‘get_term_type’:
  type_decoder.c:486:2: warning: switch missing default case [-Wswitch-default]
    switch (v[0]) {

2 years Add some more compiler warning options.
Uwe Hermann [Thu, 17 May 2018 20:50:45 +0000 (22:50 +0200)] Add some more compiler warning options.

Add the -Wshadow -Wformat=2 -Wno-format-nonliteral -Wfloat-equal
compiler options (supported by both gcc and clang) to get notified
of more potential issues in the code.

2 years agosrd_decoder_load_all_zip_path(): Fix a compiler warning (-Wshadow).
Uwe Hermann [Wed, 16 May 2018 20:17:07 +0000 (22:17 +0200)]
srd_decoder_load_all_zip_path(): Fix a compiler warning (-Wshadow).

2 years agosrd_inst_channel_set_all(): Fix a compiler warning (-Wshadow).
Uwe Hermann [Wed, 16 May 2018 20:14:22 +0000 (22:14 +0200)]
srd_inst_channel_set_all(): Fix a compiler warning (-Wshadow).

  instance.c:266:11: warning: declaration of ‘l’ shadows a previous local [-Wshadow]
     GSList *l = g_slist_nth(di->decoder->channels, i);
  instance.c:206:9: note: shadowed declaration is here
    GList *l;

2 years agotype_decoder.c: Drop unneeded g_free() NULL check.
Uwe Hermann [Tue, 15 May 2018 22:28:56 +0000 (00:28 +0200)]
type_decoder.c: Drop unneeded g_free() NULL check.

2 years agoinstance.c: Fix a scan-build warning.
Uwe Hermann [Tue, 15 May 2018 22:24:56 +0000 (00:24 +0200)]
instance.c: Fix a scan-build warning.

  instance.c:278:25: warning: The left operand of '!=' is a garbage value
                  if (new_channelmap[i] != -1)
                      ~~~~~~~~~~~~~~~~~ ^

2 years agodecoder.c: Fix a scan-build warning.
Uwe Hermann [Tue, 15 May 2018 22:21:56 +0000 (00:21 +0200)]
decoder.c: Fix a scan-build warning.

  decoder.c:343:9: warning: Access to field 'ob_type' results in a dereference of a null pointer (loaded from variable 'py_default')
                                  if (Py_TYPE(py_default) != Py_TYPE(py_item)) {
  /usr/include/python3.6m/object.h:118:33: note: expanded from macro 'Py_TYPE'
  #define Py_TYPE(ob)             (((PyObject*)(ob))->ob_type)

2 years agotype_decoder.c: Fix a scan-build warning.
Uwe Hermann [Tue, 15 May 2018 22:09:53 +0000 (00:09 +0200)]
type_decoder.c: Fix a scan-build warning.

  type_decoder.c:836:3: warning: Value stored to 'ret' is never read
                ret = process_samples_until_condition_match(di, &found_match);
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2 years agoinstance.c: Fix a memory leak reported by scan-build.
Uwe Hermann [Tue, 15 May 2018 22:13:07 +0000 (00:13 +0200)]
instance.c: Fix a memory leak reported by scan-build.

  instance.c:280:10: warning: Potential leak of memory pointed to by 'new_channelmap'
                  pdch = g_slist_nth(di->decoder->channels, i)->data;

2 years agotype_decoder.c: Fix a memory leak reported by scan-build.
Uwe Hermann [Tue, 15 May 2018 23:27:30 +0000 (01:27 +0200)]
type_decoder.c: Fix a memory leak reported by scan-build.

  type_decoder.c:206:2: warning: Potential leak of memory pointed to by 'pdb'

2 years agotype_decoder.c: Fix a memory leak reported by scan-build.
Uwe Hermann [Tue, 15 May 2018 22:05:42 +0000 (00:05 +0200)]
type_decoder.c: Fix a memory leak reported by scan-build.

  type_decoder.c:197:10: warning: Potential leak of memory pointed to by 'pdb'
                 return SRD_ERR_MALLOC;

2 years agoConvert some g_malloc0() to g_malloc().
Uwe Hermann [Tue, 15 May 2018 21:57:31 +0000 (23:57 +0200)]
Convert some g_malloc0() to g_malloc().

For the converted calls there's no requirement for all struct fields
being memset()'d to zero, or all struct fields are explicitly set
later anyway.

2 years agoget_current_pinvalues(): Slightly simplify a code chunk.
Uwe Hermann [Tue, 15 May 2018 20:29:49 +0000 (22:29 +0200)]
get_current_pinvalues(): Slightly simplify a code chunk.

2 years agoutil.c: Add two missing PyGILState_Release() calls.
Uwe Hermann [Tue, 15 May 2018 20:29:24 +0000 (22:29 +0200)]
util.c: Add two missing PyGILState_Release() calls.

2 years agost7735: Merge reset_state() into reset().
Uwe Hermann [Sun, 13 May 2018 16:28:05 +0000 (18:28 +0200)]
st7735: Merge reset_state() into reset().

2 years agoSimple decoder for ST7735 TFT controller
Aleksander Alekseev [Sat, 5 May 2018 20:44:16 +0000 (23:44 +0300)]
Simple decoder for ST7735 TFT controller

2 years agomcs48: add reset method, make A12 optional, unassorted adjustment
Gerhard Sittig [Sat, 12 May 2018 20:21:39 +0000 (22:21 +0200)]
mcs48: add reset method, make A12 optional, unassorted adjustment

Add the reset() method which recently has become essential. Make the A12
"memory bank" address line optional. Use more Python idioms. Update

The control signals had to move, to avoid gaps between D7 and A8 as well
as between A11 and A12 in the GUI decoder properties dialog. With
dynamic assignment in the UI and with named references in the CLI this
shall not harm. Unmodified automated tests still pass.

The logic is prepared to handle data, address, and "bank" pin groups at
arbitrary locations, A[11:8] and D[7:0] need not be adjacent any longer.
Support for more than one memory bank pin is prepared, but the number of
bank pins needs to get determined at the start of decode(), when this
feature is to get added in the future.

2 years agoAdd new decoder: Intel MCS-48
fenugrec [Thu, 26 Apr 2018 22:35:39 +0000 (18:35 -0400)]
Add new decoder: Intel MCS-48

Decodes addresses and data read from an external ROM. The MCS-48
processors (8048, 8049, 8039, etc.) have an 8-bit data bus that latches
first the address then the data.

2 years agotype_decoder.c: Drop incorrect Py_DECREF() calls.
Uwe Hermann [Wed, 9 May 2018 00:38:51 +0000 (02:38 +0200)]
type_decoder.c: Drop incorrect Py_DECREF() calls.

2 years agotype_decoder: Fixup memory leak in Decoder.put() (meta, python)
Uwe Hermann [Tue, 8 May 2018 23:31:10 +0000 (01:31 +0200)]
type_decoder: Fixup memory leak in Decoder.put() (meta, python)

This fixes parts of bug #329.

2 years agotype_decoder: fixup memory leak in Decoder.put() (annotation, binary)
Gerhard Sittig [Tue, 8 May 2018 18:44:05 +0000 (20:44 +0200)]
type_decoder: fixup memory leak in Decoder.put() (annotation, binary)

The text presentation of decoder annotations' payload data was allocated
but not freed. As were the byte strings of binary output. Fix it.

This fixes parts of bug #329.

2 years agoDoxyfile: Set CREATE_SUBDIRS to NO.
Uwe Hermann [Sun, 6 May 2018 14:36:34 +0000 (16:36 +0200)]
Doxyfile: Set CREATE_SUBDIRS to NO.

The API docs for libsigrokdecode are relatively small, no need for
the many, many subdirectories this would otherwise create.

2 years agojtag_stm32: Always switch state on new instruction
George Hopkins [Thu, 30 Nov 2017 14:58:05 +0000 (15:58 +0100)]
jtag_stm32: Always switch state on new instruction

2 years agojtag_stm32: Fix handling of boundary scan TAP
George Hopkins [Thu, 30 Nov 2017 14:56:45 +0000 (15:56 +0100)]
jtag_stm32: Fix handling of boundary scan TAP

2 years agojtag: Fix shifting of registers
George Hopkins [Thu, 30 Nov 2017 14:41:02 +0000 (15:41 +0100)]
jtag: Fix shifting of registers

This fixes bug #1066.

2 years agospiflash: Add Adesto AT45DB161E metadata.
Uwe Hermann [Thu, 3 May 2018 13:15:34 +0000 (15:15 +0200)]
spiflash: Add Adesto AT45DB161E metadata.

2 years agospiflash: Add basic Adesto AT45DBxx support (WRITE1/2, STATUS).
Aleksander Alekseev [Thu, 3 May 2018 12:04:47 +0000 (14:04 +0200)]
spiflash: Add basic Adesto AT45DBxx support (WRITE1/2, STATUS).

2 years agodcf77: annotate unexpected bit numbers and values, do not abort execution
Gerhard Sittig [Mon, 16 Apr 2018 19:15:13 +0000 (21:15 +0200)]
dcf77: annotate unexpected bit numbers and values, do not abort execution

Improve robustness of the DCF77 decoder. Cope with "neiter 0 nor 1" bit
values (glitches can break the detection of pulse widths), as well as
unexpected bit numbers (more than 59 pulses per minute, can be a
follow-up error after e.g. glitches break one long pulse into two short
pulses). Do not process this invalid data, do emit error annotations.

2 years agodcf77: annotate invalid dow and month fields, do not abort execution
Gerhard Sittig [Sun, 22 Apr 2018 08:07:07 +0000 (10:07 +0200)]
dcf77: annotate invalid dow and month fields, do not abort execution

Emit error annotations for invalid day of the week or month numbers,
instead of aborting decoder execution with an exception.

Implementation detail: Neither the Python 'in' keyword nor a .get()
method are available. That's why we have to catch the IndexError

This fixes bug #1173.

2 years agodcf77, lpc: rephrase bit string formatting
Gerhard Sittig [Mon, 16 Apr 2018 19:12:16 +0000 (21:12 +0200)]
dcf77, lpc: rephrase bit string formatting

Create the text representation of a bit string by means of the builtin
.format() method and an appropriate specifier. Drop the non-obvious
sequence of bin() and slice and zfill() calls.

2 years agoinstance: return SRD_ERR_TERM_REQ when execution shall terminate
Gerhard Sittig [Mon, 23 Apr 2018 18:42:54 +0000 (20:42 +0200)]
instance: return SRD_ERR_TERM_REQ when execution shall terminate

The previous implementation internally noticed the "want terminate"
request, and skipped decoder execution to faster get to the end of the
input stream. But an OK return code was provided in that code path, and
more input data was sent by applications (sometimes for many seconds or
few minutes).

Do return a new SRD_ERR_TERM_REQ error code, such that applications can
tell failed execution from requested termination.

2 years agoinstance: drop an unneeded "want wait() to terminate" reset assignment
Gerhard Sittig [Mon, 23 Apr 2018 18:40:28 +0000 (20:40 +0200)]
instance: drop an unneeded "want wait() to terminate" reset assignment

It's uncertain why srd_inst_decode() which internally gets called by the
public srd_session_send() routine used to clear the want_wait_terminate
flag. This should be cleared upon decoder instance creation and state
reset, gets raised upon termination request, but shall not get cleared
in other spots, especially not upon the availability of new input data
while the stream shall be considered in the "about to terminate, skip
all subsequent execution" state.

2 years agolog: Move log level check so that it affects all handlers.
Uwe Hermann [Sat, 21 Apr 2018 22:17:49 +0000 (00:17 +0200)]
log: Move log level check so that it affects all handlers.

Before this change, the loglevel check would only be performed for the
default log handler in libsigrokdecode, but not for other handlers set
via srd_log_callback_set().

This fixes bug #698.

2 years agosrd_exception_catch(): Beautify traceback logging output.
Uwe Hermann [Fri, 20 Apr 2018 21:30:58 +0000 (23:30 +0200)]
srd_exception_catch(): Beautify traceback logging output.

2 years agoDecoder_register(): Drop an overly verbose log message.
Uwe Hermann [Fri, 20 Apr 2018 19:46:59 +0000 (21:46 +0200)]
Decoder_register(): Drop an overly verbose log message.

2 years agosrd_logv(): Add an explicit fflush().
Uwe Hermann [Fri, 20 Apr 2018 19:45:04 +0000 (21:45 +0200)]
srd_logv(): Add an explicit fflush().

2 years agoShow backtrace when decode() aborts due to an error.
Uwe Hermann [Fri, 20 Apr 2018 19:40:12 +0000 (21:40 +0200)]
Show backtrace when decode() aborts due to an error.

The backtrace printing was actually already there, but was emitted using
sr_dbg(), which doesn't show up by default for most users. Make it an
srd_err() so that most users will see it.

This fixes bug #1158.

2 years agocan: Fix incorrect stuff bit handling.
Uwe Hermann [Thu, 12 Apr 2018 07:02:38 +0000 (09:02 +0200)]
can: Fix incorrect stuff bit handling.

The decoder assumed a CRC cannot end with a stuffed bit but it actually can,
and the CRC delimiter then comes after the stuffed bit.

Patch by IRC/github user celeron55, wide testing by PeterMortensen, thanks!

2 years agoDrop overly verbose log messages about (un)loading PDs.
Uwe Hermann [Sun, 8 Apr 2018 17:53:56 +0000 (19:53 +0200)]
Drop overly verbose log messages about (un)loading PDs.

2 years agosda2506/qi: Add missing full stop in 'desc' field.
Uwe Hermann [Sun, 8 Apr 2018 17:29:14 +0000 (19:29 +0200)]
sda2506/qi: Add missing full stop in 'desc' field.

2 years agorc_encode: Use different annotation classes for code word addr/data.
Uwe Hermann [Sun, 8 Apr 2018 17:08:39 +0000 (19:08 +0200)]
rc_encode: Use different annotation classes for code word addr/data.

2 years agorc_encode: Use different annotation classes for different bits.
Uwe Hermann [Sun, 8 Apr 2018 17:02:35 +0000 (19:02 +0200)]
rc_encode: Use different annotation classes for different bits.

2 years agorc_encode: Add self.putx() helper.
Uwe Hermann [Sun, 8 Apr 2018 16:55:08 +0000 (18:55 +0200)]
rc_encode: Add self.putx() helper.

2 years agorc_encode: Use common naming.
Uwe Hermann [Sun, 8 Apr 2018 16:47:10 +0000 (18:47 +0200)]
rc_encode: Use common naming.

2 years agorc_encode: Use += operator where possible.
Uwe Hermann [Sun, 8 Apr 2018 16:44:09 +0000 (18:44 +0200)]
rc_encode: Use += operator where possible.

2 years agorc_encode: Drop unneeded casts.
Uwe Hermann [Sun, 8 Apr 2018 16:41:59 +0000 (18:41 +0200)]
rc_encode: Drop unneeded casts.

2 years agoAdd initial rc_encode protocol decoder.
steversig [Mon, 2 Apr 2018 17:12:16 +0000 (18:12 +0100)]
Add initial rc_encode protocol decoder.

2 years agotest: add simple "no data" test case for decoder "terminate and reset"
Gerhard Sittig [Sun, 17 Dec 2017 21:24:10 +0000 (22:24 +0100)]
test: add simple "no data" test case for decoder "terminate and reset"

Introduce a "reset" group of tests. Whip up a first test step which runs
the "terminate and reset" routine for decoder stacks after session
creation, start, and meta data setup. No input data gets processed, no
decoder output is tested yet.

2 years agosession: add "terminate and reset" support for protocol stacks
Gerhard Sittig [Sun, 17 Dec 2017 17:55:46 +0000 (18:55 +0100)]
session: add "terminate and reset" support for protocol stacks

Implement routines which terminate currently pending decoder operations
and reset internal state (on the C and Python sides) for instances as
well as sessions. This allows to re-use previously created stacks for
new input data.

2 years agoDecoder: check for duplicate register() calls in common backend code
Gerhard Sittig [Fri, 26 Jan 2018 20:02:25 +0000 (21:02 +0100)]
Decoder: check for duplicate register() calls in common backend code

Future implementations might call decoders' start() routine several
times, which makes them call register() again. It's desirable that the
common backend code copes with this condition, such that (the multitude
of) decoder implementations need not work around a specific constraint.

2 years agodecoder: rephrase .has_channel() argument parse logic
Gerhard Sittig [Sun, 17 Dec 2017 17:50:25 +0000 (18:50 +0100)]
decoder: rephrase .has_channel() argument parse logic

Have the Python C API check the argument type and do the type conversion
already. Raise an IndexError exception when the range check fails.

2 years agoinstance: make sure oldpins array is available after reset
Gerhard Sittig [Sun, 4 Feb 2018 18:12:48 +0000 (19:12 +0100)]
instance: make sure oldpins array is available after reset

Introduce an oldpins_array_seed() helper routine, to make sure that each
call site which checks previous pin state will find valid data. This was
not always the case after decoder reset, which released the old pin data
while applications would not call srd_inst_new() again.

Preset newly allocated arrays with the default initial pin state, allow
optional application calls to specify differing initial values (when
specified by users), and keep the current state after first data was

2 years agoadns5020: Python style nit, fixup whitespace
Gerhard Sittig [Sat, 13 Jan 2018 18:51:07 +0000 (19:51 +0100)]
adns5020: Python style nit, fixup whitespace

2 years agomax7219: introduce constructor and reset() method
Gerhard Sittig [Sun, 28 Jan 2018 21:59:59 +0000 (22:59 +0100)]
max7219: introduce constructor and reset() method

The "max7219" decoder used to have no constructor, which made me miss
it when reset() got introduced. Implement those two methods (which do
nothing, and thus won't change behaviour).

2 years agomicrowire: introduce constructor and reset() method
Gerhard Sittig [Sat, 13 Jan 2018 18:30:53 +0000 (19:30 +0100)]
microwire: introduce constructor and reset() method

The "microwire" decoder used to have no constructor, which made me miss
it when reset() got introduced. Implement those two methods (which do
nothing, and thus won't change behaviour).

2 years agoprint_searchpaths(): Print decoder and system search paths.
Uwe Hermann [Sun, 18 Mar 2018 16:54:11 +0000 (17:54 +0100)]
print_searchpaths(): Print decoder and system search paths.

2 years agoFix part of #1128 by adding a way to retrieve PD search paths
Soeren Apel [Sat, 17 Mar 2018 20:40:36 +0000 (21:40 +0100)]
Fix part of #1128 by adding a way to retrieve PD search paths

As this uses g_slist_copy_deep(), we now require glib 2.34.

2 years agoAdd support for SDA2506 EEPROM serial protocol.
Max Weller [Tue, 30 Jan 2018 22:22:06 +0000 (23:22 +0100)]
Add support for SDA2506 EEPROM serial protocol.

2 years agoMinor whitespace/typo fixes.
Uwe Hermann [Tue, 6 Mar 2018 22:55:34 +0000 (23:55 +0100)]
Minor whitespace/typo fixes.

2 years agodali: Avoid CamelCase in most places.
Uwe Hermann [Fri, 23 Feb 2018 15:57:22 +0000 (16:57 +0100)]
dali: Avoid CamelCase in most places.

2 years agoir_nec: optionally accept input signals that include the carrier
Gerhard Sittig [Sat, 2 Sep 2017 10:52:32 +0000 (12:52 +0200)]
ir_nec: optionally accept input signals that include the carrier

Introduce optional detection of a carrier signal. Immediately "go active"
when edges are seen. "Go inactive" again in the absence of edges in a
specified period of time. Cope with input signals that already had the
carrier removed.

By default carrier detection is disabled, to remain pixel compatible to
the previous implementation. When a carrier frequency is specified and
thus detection is enabled, edges of already filtered input are shifted
by one carrier period, and thus changes the output of the decoder. For
unfiltered inputs that still contain the carrier, detection of activity
is reliable and immediate, but the active phase is extended by one
period of the carrier frequency (which is considered acceptable).

2 years agoparallel: expand 'wordsize' description (bits vs cycles)
Gerhard Sittig [Thu, 28 Dec 2017 17:08:51 +0000 (18:08 +0100)]
parallel: expand 'wordsize' description (bits vs cycles)

Users may not know which unit the "wordsize" is supposed to get
specified in. Especially when it's not a number of bits, but instead
the number of bus cycles. Expand the description text accordingly.

2 years agostepper_motor: make samplerate meta data optional
Gerhard Sittig [Sun, 17 Dec 2017 22:59:16 +0000 (23:59 +0100)]
stepper_motor: make samplerate meta data optional

Only emit the speed annotations when a sample rate was specified. Cope
with the absence of a sample rate for the input stream. Decoding is
still possible, it's just that no timing information is available.

2 years agoi2s: make samplerate meta data optional
Gerhard Sittig [Sun, 17 Dec 2017 23:05:40 +0000 (00:05 +0100)]
i2s: make samplerate meta data optional

Only emit sound samplerate information when an input stream sample rate
was specified. Cope with the absence of a sample rate for the input
stream. Decoding is still possible, it's just that no timing information
is available.

2 years agoi2c: make input samplerate optional
Gerhard Sittig [Fri, 15 Dec 2017 18:26:29 +0000 (19:26 +0100)]
i2c: make input samplerate optional

Absence of a samplerate for the input stream should not be fatal. The
protocol decodes fine, we just cannot determine a bitrate for frames.

This addresses part of bug 1076.

2 years explicitly require pkg-config related macro
Gerhard Sittig [Sat, 10 Feb 2018 11:24:17 +0000 (12:24 +0100)] explicitly require pkg-config related macro

Make sure the PKG_PROG_PKG_CONFIG macro has become available before it
gets used. This unbreaks configuration in the poky environment (rocko).

2 years agograycode, morse, pwm, usb_request, wiegand: cope with absent sample rate
Gerhard Sittig [Sun, 28 Jan 2018 19:49:48 +0000 (20:49 +0100)]
graycode, morse, pwm, usb_request, wiegand: cope with absent sample rate

Improve robustness of some more protocol decoders. Few of them never
checked for the availability of a sample rate in the first place, others
checked for the presence of a spec but would not cope with a value of 0.
Some checked the value only after processing it, which could result in
runtime errors.

This change is motivated by bug #1118.

2 years agospi: cope when a sample rate of 0 was configured
Gerhard Sittig [Sun, 28 Jan 2018 19:02:09 +0000 (20:02 +0100)]
spi: cope when a sample rate of 0 was configured

The explicit test for None was not good enough. Change test conditions
such that sample rates only get processed when they got specified _and_
were not zero.

This fixes bug #1118.

2 years agoac97: introduce first AC'97 decoder implementation (bits, slots, binary)
Gerhard Sittig [Sat, 2 Sep 2017 16:48:03 +0000 (18:48 +0200)]
ac97: introduce first AC'97 decoder implementation (bits, slots, binary)

Introduce an "audio and modem control for PC systems" protocol decoder
(referred to as AC'97).

This implementation extracts bits and identifies frames, and annotates
the slots of a frame with mere integer values. Bit fields get decoded
depending on the slot numbers. Bit patterns in audio/modem data slots
can get exported as binary streams.

Some TODO items remain. Register access (read/write) gets annotated, but
neither gets interpreted nor affects the decoding of subsequent frames.
The RESET# line status does not get evaluated.

2 years agoi2c: Drop obsolete 10bit slave address TODO.
Uwe Hermann [Sat, 13 Jan 2018 17:07:57 +0000 (18:07 +0100)]
i2c: Drop obsolete 10bit slave address TODO.

Nobody has seen any such slave in the wild, yet. In the very unlikely
case that someone actually sees or needs this, patches are welcome
though (together with sample .sr files).

2 years agocounter: make 'reset' signal polarity an option
Gerhard Sittig [Wed, 3 Jan 2018 18:41:37 +0000 (19:41 +0100)]
counter: make 'reset' signal polarity an option

Allow configuration of the 'reset' signal polarity. Reset counters on
either falling (default) or rising edges.

2 years agocounter: Make "word reset" an explicit annotation class+row.
Uwe Hermann [Wed, 3 Jan 2018 16:20:49 +0000 (17:20 +0100)]
counter: Make "word reset" an explicit annotation class+row.

Also, add long and short annotation string versions.

2 years agoAdd a trivial "counter" decoder
Stefan Brüns [Tue, 2 Jan 2018 01:17:07 +0000 (02:17 +0100)]
Add a trivial "counter" decoder

This decoder just counts the number of falling and/or rising edges. This
is especially useful for diagnosing protocols with a clock signal or a
fixed number of transitions per bit, e.g. pulse length coded.

It also provides a divider, which can be used to e.g. count the number
of words in I²C or SPI transfers.

2 years agoparallel: implement consistent number formatting
Gerhard Sittig [Fri, 22 Dec 2017 20:07:28 +0000 (21:07 +0100)]
parallel: implement consistent number formatting

Print all annotations for individual data bit items and for the
de-multiplexed words in a consistent style with leading zeros and
constant width. This shall lend itself better to quick navigation
during visual inspection, as well as automatic processing.

2 years agoparallel: unbreak and improve "word" de-multiplexing
Gerhard Sittig [Fri, 22 Dec 2017 14:16:27 +0000 (15:16 +0100)]
parallel: unbreak and improve "word" de-multiplexing

The previous implementation prepared but never fully enabled the
accumulation of several multi-bit items into words that span multiple
bus cycles (think: address or data de-multiplexing on memory busses).

Complete the accumulation, and fixup the end samplenumber for word
annotations. Fixup the endianess logic (the condition was inverted).
Rephrase calculation to be more Python idiomatic.

Default to word size zero, and only emit word annotations for non-zero
word size specs. This keeps the implementation backwards compatible and
still passes the test suite. Default behaviour is most appropriate for
interactive use in GUI environments, while automated processing will
find consistent behaviour across all setups (non-multiplexed busses, and
multiplexed busses with "words" that span one or multiple cycles).

2 years agoparallel: cope with sparse input mappings, assume zero for not-connected pins
Gerhard Sittig [Fri, 22 Dec 2017 13:48:37 +0000 (14:48 +0100)]
parallel: cope with sparse input mappings, assume zero for not-connected pins

Cope when users only provide e.g. input lines D0 and D2 to the parallel
decoder. Assume that not-connected pins are "always zero".

Rephrase the .decode() logic which determines .wait() conditions while
we are here, to slightly unobfuscate the implementation.

This fixes bug #1088.

2 years agoparallel: address minor style nits, no change in behaviour
Gerhard Sittig [Fri, 22 Dec 2017 14:12:07 +0000 (15:12 +0100)]
parallel: address minor style nits, no change in behaviour

Remove the redundant .itemcount variable, which exactly corresponds to
the length of the .items array.

Arrange retrieval of options and their evaluation closer to each other
for improved readability.

Use common logic to construct "words" from several multi-bit "items".
Arrange for endianess support by optionally reversing the array before

2 years agoparallel: unify decode() code paths with and without clock signal
Gerhard Sittig [Fri, 22 Dec 2017 12:55:45 +0000 (13:55 +0100)]
parallel: unify decode() code paths with and without clock signal

Instead of implementing two main loops for operation in the presence and
in the absence of a clock line, use a common main loop which operates on
pre-determined wait conditions.

2 years agousb_power_delivery: enforce check order for start-of-packet sequences
Gerhard Sittig [Fri, 22 Dec 2017 17:51:00 +0000 (18:51 +0100)]
usb_power_delivery: enforce check order for start-of-packet sequences

The list of a dictionary's keys need not reproduce in identical order
everywhere. Make sure to run all start-of-packet sequence checks in the
decoder implementation in a specific order on each machine, such that
annotations get emitted with identical content and in the same order for
each execution of the decoder.

This fixes the remaining part of bug #1090.

2 years agousb_power_delivery: fixup a Python style nit (dict lookup fallback)
Gerhard Sittig [Fri, 22 Dec 2017 17:37:29 +0000 (18:37 +0100)]
usb_power_delivery: fixup a Python style nit (dict lookup fallback)

Use the dictionary's .get() method in combination with a default result
parameter, instead of an explicit "k in dictvar" test and a conditional

2 years agousb_power_delivery: enforce numerical order of RDO/PDO flag annotations
Gerhard Sittig [Fri, 22 Dec 2017 17:33:58 +0000 (18:33 +0100)]
usb_power_delivery: enforce numerical order of RDO/PDO flag annotations

Annotations of the USB power delivery decoder contain multiple text
fragments that correspond to several flags in bit fields. The Python
runtime did not guarantee an order of emission and made the test suite

Sort the order in which RDO and PDO flags related text fragments get
constructed and concatenated. Print text for higher bit positions first
as this might feel more intuitive to users.

This fixes part of bug #1090.

2 years agoall decoders: introduce a reset() method
Gerhard Sittig [Mon, 20 Feb 2017 20:37:05 +0000 (21:37 +0100)]
all decoders: introduce a reset() method

Move initialization code of protocol decoders from the constructor to a
new reset() helper method. The libsigrokdecode backend could run this
method several times to clear the decoder's internal state, before new
data from another acquisition gets fed to decode() calls.

2 years agossi32: rename reset() helper method
Gerhard Sittig [Fri, 22 Dec 2017 02:55:16 +0000 (03:55 +0100)]
ssi32: rename reset() helper method

The ssi32 decoder implements a reset() method which clears internally
accumulated data during decoding. Rename the method before all decoders
will grow a new reset() method that will be used for a different purpose.

2 years agomrf24j40: rename reset() helper method
Gerhard Sittig [Fri, 22 Dec 2017 02:54:21 +0000 (03:54 +0100)]
mrf24j40: rename reset() helper method

The mrf24j40 decoder implements a reset() method which clears internally
accumulated data during decoding. Rename the method before all decoders
will grow a new reset() method that will be used for a different purpose.

2 years agoade77xx: rename reset() helper method
Gerhard Sittig [Fri, 22 Dec 2017 02:51:20 +0000 (03:51 +0100)]
ade77xx: rename reset() helper method

The ade77xx decoder implements a reset() method which clears internally
accumulated data during decoding. Rename the method before all decoders
will grow a new reset() method that will be used for a different purpose.

2 years agosdcard_sd: remove unused .reset() method
Gerhard Sittig [Fri, 22 Dec 2017 01:35:12 +0000 (02:35 +0100)]
sdcard_sd: remove unused .reset() method

The decoder's .reset() method seems to partially implement constructor's
assignments, but is not referenced anywhere. There is neither a direct
call site in the remainder of which uses the "reset" name, and
runtime computation only references "handle_*()" methods for commands
and responses.

Drop the unused .reset() method in the individual decoder before the
introduction of a common .reset() method approach for all decoders.