From: Uwe Hermann <redacted>
Date: Thu, 27 Jan 2011 21:13:08 +0000 (+0100)
Subject: Bugfix: Add missing Py_INCREF()s.
X-Git-Tag: libsigrokdecode-0.1.0~302
X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=commitdiff_plain;h=4fa17efc0be6542055476bd7764fc04391bc652d;hp=6b08da24ec79989565e5417cf111a243073cd2fd

Bugfix: Add missing Py_INCREF()s.

This should fix an error/segfault when running a decoder on bigger
datasets.
---

diff --git a/decode.c b/decode.c
index db29494..5289470 100644
--- a/decode.c
+++ b/decode.c
@@ -259,9 +259,9 @@ int sigrokdecode_run_decoder(struct sigrokdecode_decoder *dec,
 
 	/* TODO: Error handling. */
 	py_mod = dec->py_mod;
+	Py_INCREF(py_mod);
 	py_func = dec->py_func;
-
-	/* TODO: Really run Py_DECREF on py_mod/py_func? */
+	Py_INCREF(py_func);
 
 	/* Create a Python tuple of size 1. */
 	if (!(py_args = PyTuple_New(1))) { /* NEWREF */