From: Uwe Hermann Date: Sat, 21 Jul 2012 19:58:20 +0000 (+0200) Subject: srd: onewire_link: Annotations shouldn't be ALLCAPS. X-Git-Tag: libsigrokdecode-0.1.1~36 X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=commitdiff_plain;h=1fe967f266313f26f76f5b94800aad64dfdb3f5b srd: onewire_link: Annotations shouldn't be ALLCAPS. While states in the PD should be ALLCAPS per guidelines (for consistency), the annotations that a PD outputs (and are shown in a console via sigrok-cli or in a GUI) should be "normal" human-readable text/formatting usually, i.e. not ALLCAPS. --- diff --git a/decoders/onewire_network/onewire_network.py b/decoders/onewire_network/onewire_network.py index 2dba54a..ab11ea4 100644 --- a/decoders/onewire_network/onewire_network.py +++ b/decoders/onewire_network/onewire_network.py @@ -24,14 +24,14 @@ import sigrokdecode as srd # Dictionary of ROM commands and their names, next state. command = { - 0x33: ['READ ROM' , 'GET ROM' ], - 0x0f: ['CONDITIONAL READ ROM' , 'GET ROM' ], - 0xcc: ['SKIP ROM' , 'TRANSPORT' ], - 0x55: ['MATCH ROM' , 'GET ROM' ], - 0xf0: ['SEARCH ROM' , 'SEARCH ROM'], - 0xec: ['CONDITIONAL SEARCH ROM', 'SEARCH ROM'], - 0x3c: ['OVERDRIVE SKIP ROM' , 'TRANSPORT' ], - 0x69: ['OVERDRIVE MATCH ROM' , 'GET ROM' ], + 0x33: ['Read ROM' , 'GET ROM' ], + 0x0f: ['Conditional read ROM' , 'GET ROM' ], + 0xcc: ['Skip ROM' , 'TRANSPORT' ], + 0x55: ['Match ROM' , 'GET ROM' ], + 0xf0: ['Search ROM' , 'SEARCH ROM'], + 0xec: ['Conditional search ROM', 'SEARCH ROM'], + 0x3c: ['Overdrive skip ROM' , 'TRANSPORT' ], + 0x69: ['Overdrive match ROM' , 'GET ROM' ], } class Decoder(srd.Decoder):