Various PDs: Minor option related fixes.

diff --git a/decoders/can/pd.py b/decoders/can/pd.py
index 51b7a72ce452326f09bcf3024cc494c9f2cf14d4..af8168ce5eb3f48da403e1b9b4153bc35b75c9ed 100644 (file)
--- a/decoders/can/pd.py
+++ b/decoders/can/pd.py
@@ -33,8 +33,8 @@ class Decoder(srd.Decoder):
         {'id': 'can_rx', 'name': 'CAN RX', 'desc': 'CAN bus line'},
     )
     options = (
-        {'id': 'bitrate', 'desc': 'Bitrate', 'default': 1000000}, # 1Mbit/s
-        {'id': 'sample_point', 'desc': 'Sample point', 'default': 70.0}, # 70%
+        {'id': 'bitrate', 'desc': 'Bitrate (bits/s)', 'default': 1000000},
+        {'id': 'sample_point', 'desc': 'Sample point (%)', 'default': 70.0},
     )
     annotations = (
         ('data', 'CAN payload data'),

diff --git a/decoders/lm75/pd.py b/decoders/lm75/pd.py
index bdd8cb0a43317298e37aa6f00ace9b2a9a10561c..449916a4d9d98d0b66789d34ab20e5ce1a31257f 100644 (file)
--- a/decoders/lm75/pd.py
+++ b/decoders/lm75/pd.py
@@ -49,8 +49,9 @@ class Decoder(srd.Decoder):
     inputs = ['i2c']
     outputs = ['lm75']
     options = (
-        {'id': 'sensor', 'desc': 'Sensor type', 'default': 'lm75'},
-        {'id': 'resolution', 'desc': 'Resolution', 'default': 9,
+        {'id': 'sensor', 'desc': 'Sensor type', 'default': 'lm75',
+            'values': ('lm75',)},
+        {'id': 'resolution', 'desc': 'Resolution (bits)', 'default': 9,
             'values': (9, 10, 11, 12)},
     )
     annotations = (

diff --git a/decoders/onewire_link/pd.py b/decoders/onewire_link/pd.py
index d603dba30af8af3a0733b5655d5a4ee1c5bedb1d..ceb5da20e203f6334448e125e852ce567f302e45 100644 (file)
--- a/decoders/onewire_link/pd.py
+++ b/decoders/onewire_link/pd.py
@@ -37,33 +37,24 @@ class Decoder(srd.Decoder):
     )
     options = (
         {'id': 'overdrive',
-            'desc': 'Overdrive mode',
-            'default': 'no'},
+            'desc': 'Overdrive mode', 'default': 'no', 'values': ('yes', 'no')},
         # Time options (specified in microseconds):
         {'id': 'cnt_normal_bit',
-            'desc': 'Normal mode sample bit time (μs)',
-            'default': 15},
+            'desc': 'Normal mode sample bit time (μs)', 'default': 15},
         {'id': 'cnt_normal_slot',
-            'desc': 'Normal mode data slot time (μs)',
-            'default': 60},
+            'desc': 'Normal mode data slot time (μs)', 'default': 60},
         {'id': 'cnt_normal_presence',
-            'desc': 'Normal mode sample presence time (μs)',
-            'default': 75},
+            'desc': 'Normal mode sample presence time (μs)', 'default': 75},
         {'id': 'cnt_normal_reset',
-            'desc': 'Normal mode reset time (μs)',
-            'default': 480},
+            'desc': 'Normal mode reset time (μs)', 'default': 480},
         {'id': 'cnt_overdrive_bit',
-            'desc': 'Overdrive mode sample bit time (μs)',
-            'default': 2},
+            'desc': 'Overdrive mode sample bit time (μs)', 'default': 2},
         {'id': 'cnt_overdrive_slot',
-            'desc': 'Overdrive mode data slot time (μs)',
-            'default': 7.3},
+            'desc': 'Overdrive mode data slot time (μs)', 'default': 7.3},
         {'id': 'cnt_overdrive_presence',
-            'desc': 'Overdrive mode sample presence time (μs)',
-            'default': 10},
+            'desc': 'Overdrive mode sample presence time (μs)', 'default': 10},
         {'id': 'cnt_overdrive_reset',
-            'desc': 'Overdrive mode reset time (μs)',
-            'default': 48},
+            'desc': 'Overdrive mode reset time (μs)', 'default': 48},
     )
     annotations = (
         ('bit', 'Bit'),

diff --git a/decoders/parallel/pd.py b/decoders/parallel/pd.py
index cae269f8d524c5bf403164f8ac0e048ee28edf34..330d5142facb20c579257f23293076abd4a66eeb 100644 (file)
--- a/decoders/parallel/pd.py
+++ b/decoders/parallel/pd.py
@@ -74,9 +74,8 @@ class Decoder(srd.Decoder):
     options = (
         {'id': 'clock_edge', 'desc': 'Clock edge to sample on',
             'default': 'rising', 'values': ('rising', 'falling')},
-        {'id': 'wordsize', 'desc': 'Word size of the data',
-            'default': 1},
-        {'id': 'endianness', 'desc': 'Endianness of the data',
+        {'id': 'wordsize', 'desc': 'Data wordsize', 'default': 1},
+        {'id': 'endianness', 'desc': 'Data endianness',
             'default': 'little', 'values': ('little', 'big')},
     )
     annotations = (

diff --git a/decoders/spi/pd.py b/decoders/spi/pd.py
index d0e3409a6c8241eafe32001f496720f3180bdfba..7d84b3d53c123aaff8d3ae5e12099fea6e8e5868 100644 (file)
--- a/decoders/spi/pd.py
+++ b/decoders/spi/pd.py
@@ -84,9 +84,9 @@ class Decoder(srd.Decoder):
             'values': (0, 1)},
         {'id': 'cpha', 'desc': 'Clock phase', 'default': 0,
             'values': (0, 1)},
-        {'id': 'bitorder', 'desc': 'Bit order within the SPI data',
+        {'id': 'bitorder', 'desc': 'Bit order',
             'default': 'msb-first', 'values': ('msb-first', 'lsb-first')},
-        {'id': 'wordsize', 'desc': 'Word size of SPI data', 'default': 8},
+        {'id': 'wordsize', 'desc': 'Word size', 'default': 8},
     )
     annotations = (
         ('miso-data', 'MISO data'),

diff --git a/decoders/usb_packet/pd.py b/decoders/usb_packet/pd.py
index 61acd4f68154e1f8004f351d0044f52034be21e8..5dbbcdb2a1cd4956dcdaa6a8dc8a0486e5b931c9 100644 (file)
--- a/decoders/usb_packet/pd.py
+++ b/decoders/usb_packet/pd.py
@@ -152,7 +152,8 @@ class Decoder(srd.Decoder):
     inputs = ['usb_signalling']
     outputs = ['usb_packet']
     options = (
-        {'id': 'signalling', 'desc': 'Signalling', 'default': 'full-speed'},
+        {'id': 'signalling', 'desc': 'Signalling',
+            'default': 'full-speed', 'values': ('full-speed', 'low-speed')},
     )
     annotations = (
         ('sync-ok', 'SYNC'),