X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=blobdiff_plain;f=exception.c;h=96546f7d5537797bf45049159be70787e68aeaf5;hp=07ffab35969770851f941cc0d1bd0a8effac81f1;hb=4916b17368e8ed06f4bfd045052ab0f891c33954;hpb=ec871a279893cfe0ab378eddc0a9f9bcccc44925

diff --git a/exception.c b/exception.c
index 07ffab3..96546f7 100644
--- a/exception.c
+++ b/exception.c
@@ -1,5 +1,5 @@
 /*
- * This file is part of the sigrok project.
+ * This file is part of the libsigrokdecode project.
  *
  * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
  *
@@ -17,15 +17,15 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "sigrokdecode.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
-#include "sigrokdecode-internal.h"
+#include "libsigrokdecode-internal.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
+#include "libsigrokdecode.h"
 #include "config.h"
 #include <stdarg.h>
 #include <glib.h>
 #include <frameobject.h> /* Python header not pulled in by default. */
 
-
-void catch_exception(const char *format, ...)
+/** @private */
+SRD_PRIV void srd_exception_catch(const char *format, ...)
 {
 	PyObject *etype, *evalue, *etb, *py_str;
 	PyTracebackObject *py_tb;
@@ -41,42 +41,41 @@ void catch_exception(const char *format, ...)
 	PyErr_NormalizeException(&etype, &evalue, &etb);
 
 	if (!(py_str = PyObject_Str(evalue))) {
-		/* Shouldn't happen */
-		srd_dbg("srd: failed to convert exception value to string");
+		/* Shouldn't happen. */
+		srd_dbg("Failed to convert exception value to string.");
 		return;
 	}
 
-	msg = g_string_sized_new(128);
-	va_start(args, format);
-	g_string_vprintf(msg, format, args);
-	va_end(args);
-
-	/* Can be NULL. */
+	/* Send the exception error message(s) to srd_err(). */
 	if (evalue)
 		ename = (char *)Py_TYPE(evalue)->tp_name;
 	else
+		/* Can be NULL. */
 		ename = "(unknown exception)";
 
-	/* Send the exception error message(s) to srd_err(). */
-	py_str_as_str(py_str, &str);
+	msg = g_string_sized_new(128);
 	g_string_append(msg, ename);
 	g_string_append(msg, ": ");
+	va_start(args, format);
+	g_string_append_vprintf(msg, format, args);
+	va_end(args);
+	py_str_as_str(py_str, &str);
 	g_string_append(msg, str);
 	Py_DecRef(py_str);
-	srd_err(msg->str);
+	srd_err("%s", msg->str);
 
 	/* Send a more precise error location to srd_dbg(), if we have it. */
 	if (etb && etb != Py_None) {
 		tracestr = NULL;
-		py_tb = (PyTracebackObject *) etb;
+		py_tb = (PyTracebackObject *)etb;
 		py_str = PyUnicode_FromFormat("%U:%d in %U",
-				py_tb->tb_frame->f_code->co_filename, py_tb->tb_frame->f_lineno,
-				py_tb->tb_frame->f_code->co_name);
+					py_tb->tb_frame->f_code->co_filename,
+					py_tb->tb_frame->f_lineno,
+					py_tb->tb_frame->f_code->co_name);
 		py_str_as_str(py_str, &tracestr);
 		Py_DecRef(py_str);
-		g_string_printf(msg, "srd: %s in %s: %s", ename,
-				tracestr, str);
-		srd_dbg(msg->str);
+		g_string_printf(msg, "%s in %s: %s", ename, tracestr, str);
+		srd_dbg("%s", msg->str);
 		g_free(tracestr);
 	}
 	g_free(str);
@@ -88,8 +87,4 @@ void catch_exception(const char *format, ...)
 
 	/* Just in case. */
 	PyErr_Clear();
-
-	return;
 }
-
-