X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=blobdiff_plain;f=decoders%2Fspi.py;h=5b97cd410d8888cdac7fb9199fcceba3cbd47e70;hp=457abb5bde2f962cdd2c325023944eb6e9017aa9;hb=01329e88ee576eb511528e691ddee23998d2de21;hpb=0db89774dee57db500f270985f73f3bb2dcdbb42

diff --git a/decoders/spi.py b/decoders/spi.py
index 457abb5..5b97cd4 100644
--- a/decoders/spi.py
+++ b/decoders/spi.py
@@ -37,6 +37,13 @@ CPHA_1 = 1 # Data is valid on the falling clock edge
 MSB_FIRST = 0
 LSB_FIRST = 1
 
+spi_mode = {
+    (0, 0): 0, # Mode 0
+    (0, 1): 1, # Mode 1
+    (1, 0): 2, # Mode 2
+    (1, 1): 3, # Mode 3
+}
+
 # Annotation formats
 ANN_HEX = 0
 
@@ -61,10 +68,10 @@ class Decoder(srd.Decoder):
     ]
     options = {
         'cs_active_low': ['CS# active low', ACTIVE_LOW],
-        'clock_polarity': ['Clock polarity', CPOL_0],
-        'clock_phase': ['Clock phase', CPHA_0],
-        'bit_order': ['Bit order within the SPI data', MSB_FIRST],
-        'word_size': ['Word size of SPI data', 8], # 1-64?
+        'cpol': ['Clock polarity', CPOL_0],
+        'cpha': ['Clock phase', CPHA_0],
+        'bitorder': ['Bit order within the SPI data', MSB_FIRST],
+        'wordsize': ['Word size of SPI data', 8], # 1-64?
     }
     annotations = [
         ['Hex', 'SPI data bytes in hex format'],
@@ -77,13 +84,14 @@ class Decoder(srd.Decoder):
         self.misodata = 0
         self.bytesreceived = 0
         self.samplenum = -1
+        self.cs_was_deasserted_during_data_word = 0
 
         # Set protocol decoder option defaults.
         self.cs_active_low = Decoder.options['cs_active_low'][1]
-        self.clock_polarity = Decoder.options['clock_polarity'][1]
-        self.clock_phase = Decoder.options['clock_phase'][1]
-        self.bit_order = Decoder.options['bit_order'][1]
-        self.word_size = Decoder.options['word_size'][1]
+        self.cpol = Decoder.options['cpol'][1]
+        self.cpha = Decoder.options['cpha'][1]
+        self.bitorder = Decoder.options['bitorder'][1]
+        self.wordsize = Decoder.options['wordsize'][1]
 
     def start(self, metadata):
         self.out_proto = self.add(srd.OUTPUT_PROTO, 'spi')
@@ -101,27 +109,45 @@ class Decoder(srd.Decoder):
 
             self.samplenum += 1 # FIXME
 
-            # Sample data on rising SCK edges.
+            # Ignore sample if the clock pin hasn't changed.
             if sck == self.oldsck:
                 continue
+
             self.oldsck = sck
-            if sck == 0:
-                continue
+
+            # Sample data on rising/falling clock edge (depends on mode).
+            mode = spi_mode[self.cpol, self.cpha]
+            if mode == 0 and sck == 0:   # Sample on rising clock edge
+                    continue
+            elif mode == 1 and sck == 1: # Sample on falling clock edge
+                    continue
+            elif mode == 2 and sck == 1: # Sample on falling clock edge
+                    continue
+            elif mode == 3 and sck == 0: # Sample on rising clock edge
+                    continue
 
             # If this is the first bit, save its sample number.
             if self.bitcount == 0:
                 self.start_sample = samplenum
+                if cs:
+                    self.cs_was_deasserted_during_data_word = 1
+
+            # Receive MOSI bit into our shift register.
+            if self.bitorder == MSB_FIRST:
+                self.mosidata |= mosi << (self.wordsize - 1 - self.bitcount)
+            else:
+                self.mosidata |= mosi << self.bitcount
 
-            # Receive bit into our shift register.
-            if mosi == 1:
-                self.mosidata |= 1 << (7 - self.bitcount)
-            if miso == 1:
-                self.misodata |= 1 << (7 - self.bitcount)
+            # Receive MISO bit into our shift register.
+            if self.bitorder == MSB_FIRST:
+                self.misodata |= miso << (self.wordsize - 1 - self.bitcount)
+            else:
+                self.misodata |= miso << self.bitcount
 
             self.bitcount += 1
 
             # Continue to receive if not a byte yet.
-            if self.bitcount != 8:
+            if self.bitcount != self.wordsize:
                 continue
 
             self.put(self.start_sample, self.samplenum, self.out_proto,
@@ -130,6 +156,10 @@ class Decoder(srd.Decoder):
                      [ANN_HEX, ['MOSI: 0x%02x, MISO: 0x%02x' % (self.mosidata,
                      self.misodata)]])
 
+            if self.cs_was_deasserted_during_data_word:
+                self.put(self.start_sample, self.samplenum, self.out_ann,
+                         [ANN_HEX, ['WARNING: CS# was deasserted!']])
+
             # Reset decoder state.
             self.mosidata = 0
             self.misodata = 0