X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=blobdiff_plain;f=decoders%2Fmidi%2Fpd.py;fp=decoders%2Fmidi%2Fpd.py;h=989ada76d89186376e44002b85a62cf37c6bf7fc;hp=ccbca34c7ef726dfe673bc4cdcc90a50b0daa610;hb=9cc1ddf98e97ce7dc3f968cfe5dd5b121c475a88;hpb=a1f66576f4b5e6d13edeb7319cae9c09679aafa4

diff --git a/decoders/midi/pd.py b/decoders/midi/pd.py
index ccbca34..989ada7 100644
--- a/decoders/midi/pd.py
+++ b/decoders/midi/pd.py
@@ -67,7 +67,11 @@ class Decoder(srd.Decoder):
         msg, chan, note, velocity = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[1], c[2]
         note_name = self.get_note_name(chan, note)
         self.putx([0, ['Channel %d: %s (note = %d \'%s\', velocity = %d)' % \
-                  (chan, status_bytes[msg], note, note_name, velocity)]])
+                  (chan, status_bytes[msg][0], note, note_name, velocity),
+                  'ch %d: %s %d, velocity = %d' % \
+                  (chan, status_bytes[msg][1], note, velocity),
+                  '%d: %s %d, vel %d' % \
+                  (chan, status_bytes[msg][2], note, velocity)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_0x90(self):
@@ -79,10 +83,14 @@ class Decoder(srd.Decoder):
             return
         self.es_block = self.es
         msg, chan, note, velocity = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[1], c[2]
-        s = 'note off' if (velocity == 0) else status_bytes[msg]
+        s = status_bytes[0x80] if (velocity == 0) else status_bytes[msg]
         note_name = self.get_note_name(chan, note)
         self.putx([0, ['Channel %d: %s (note = %d \'%s\', velocity = %d)' % \
-                  (chan, s, note, note_name, velocity)]])
+                  (chan, s[0], note, note_name, velocity),
+                  'ch %d: %s %d, velocity = %d' % \
+                  (chan, s[1], note, velocity),
+                  '%d: %s %d, vel %d' % \
+                  (chan, s[2], note, velocity)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_0xa0(self):
@@ -94,61 +102,91 @@ class Decoder(srd.Decoder):
         self.es_block = self.es
         msg, chan, note, pressure = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[1], c[2]
         note_name = self.get_note_name(chan, note)
-        self.putx([0, ['Channel %d: %s (note = %d \'%s\', pressure = %d)' % \
-                  (chan, status_bytes[msg], note, note_name, pressure)]])
+        self.putx([0, ['Channel %d: %s of %d for note = %d \'%s\'' % \
+                  (chan, status_bytes[msg][0], pressure, note, note_name),
+                  'ch %d: %s %d for note %d' % \
+                  (chan, status_bytes[msg][1], pressure, note),
+                  '%d: %s %d, N %d' % \
+                  (chan, status_bytes[msg][2], pressure, note)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_controller_0x44(self):
         # Legato footswitch: Bn 44 vv
         # n = channel, vv = value (<= 0x3f: normal, > 0x3f: legato)
-        chan, vv = (self.cmd[0] & 0x0f) + 1, self.cmd[2]
-        t = 'normal' if vv <= 0x3f else 'legato'
-        self.putx([0, ['Channel %d: control function \'%s\' = %s' % \
-                  (chan, control_functions[0x44], t)]])
+        c = self.cmd
+        msg, chan, vv = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[2]
+        t = ('normal', 'no') if vv <= 0x3f else ('legato', 'yes')
+        self.putx([0, ['Channel %d: %s \'%s\' = %s' % \
+                  (chan, status_bytes[msg][0],
+                  control_functions[0x44][0], t[0]),
+                  'ch %d: %s \'%s\' = %s' % \
+                  (chan, status_bytes[msg][1],
+                  control_functions[0x44][1], t[0]),
+                  '%d: %s \'%s\' = %s' % \
+                  (chan, status_bytes[msg][2],
+                  control_functions[0x44][2], t[1])]])
 
     def handle_controller_0x54(self):
         # Portamento control (PTC): Bn 54 kk
         # n = channel, kk = source note for pitch reference
-        chan, kk = (self.cmd[0] & 0x0f) + 1, self.cmd[2]
+        c = self.cmd
+        msg, chan, kk = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[2]
         kk_name = self.get_note_name(chan, kk)
-        self.putx([0, ['Channel %d: control function \'%s\' (source note ' \
-                  '= %d / %s)' % \
-                  (chan, control_functions[0x54], kk, kk_name)]])
+        self.putx([0, ['Channel %d: %s \'%s\' (source note = %d / %s)' % \
+                  (chan, status_bytes[msg][0],
+                  control_functions[0x54][0], kk, kk_name),
+                  'ch %d: %s \'%s\' (source note = %d)' % \
+                  (chan, status_bytes[msg][1],
+                  control_functions[0x54][1], kk),
+                  '%d: %s \'%s\' (src N %d)' % \
+                  (chan, status_bytes[msg][2],
+                  control_functions[0x54][2], kk)]])
 
     def handle_controller_generic(self):
         c = self.cmd
-        chan, fn, param = (c[0] & 0x0f) + 1, c[1], c[2]
+        msg, chan, fn, param = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[1], c[2]
         default_name = 'undefined'
         ctrl_fn = control_functions.get(fn, default_name)
         if ctrl_fn == default_name:
-            ctrl_fn = '%s 0x%02x' % (default_name, fn)
-        self.putx([0, ['Channel %d: control change to function \'%s\' ' \
-                  '(param = 0x%02x)' % (chan, ctrl_fn, param)]])
+            ctrl_fn = ('undefined 0x%02x' % fn, 'undef 0x%02x' % fn, '0x%02x' % fn)
+        self.putx([0, ['Channel %d: %s \'%s\' (param = 0x%02x)' % \
+                  (chan, status_bytes[msg][0], ctrl_fn[0], param),
+                  'ch %d: %s \'%s\' (param = 0x%02x)' % \
+                  (chan, status_bytes[msg][1], ctrl_fn[1], param),
+                  '%d: %s \'%s\' is 0x%02x' % \
+                  (chan, status_bytes[msg][2], ctrl_fn[2], param)]])
 
     def handle_channel_mode(self):
         # Channel Mode: Bn mm vv
         # n = channel, mm = mode number (120 - 127), vv = value
         c = self.cmd
-        chan, mm, vv = (c[0] & 0x0f) + 1, c[1], c[2]
-        mode_fn = control_functions.get(mm, 'undefined')
+        msg, chan, mm, vv = c[0] & 0xf0, (c[0] & 0x0f) + 1, c[1], c[2]
+        mode_fn = control_functions.get(mm, ('undefined', 'undef', 'undef'))
         # Decode the value based on the mode number.
-        vv_string = ''
+        vv_string = ('', '')
         if mm == 122:           # mode = local control?
             if vv == 0:
-                vv_string = 'off'
+                vv_string = ('off', 'off')
             elif vv == 127:     # mode = poly mode on?
-                vv_string = 'on'
+                vv_string = ('on', 'on')
             else:
-                vv_string = '(non-standard param value of 0x%02x)' % vv
+                vv_string = ('(non-standard param value of 0x%02x)' % vv,
+                            '0x%02x' % vv)
         elif mm == 126:         # mode = mono mode on?
             if vv != 0:
-                vv_string = '(%d channels)' % vv
+                vv_string = ('(%d channels)' % vv, '(%d ch)' % vv)
             else:
-                vv_string = '(channels \'basic\' through 16)'
+                vv_string = ('(channels \'basic\' through 16)',
+                            '(ch \'basic\' thru 16)')
         elif vv != 0: # All other channel mode messages expect vv == 0.
-            vv_string = '(non-standard param value of 0x%02x)' % vv
-        self.putx([0, ['Channel %d: mode message \'%s\' %s' % \
-            (chan, mode_fn, vv_string)]])
+            vv_string = ('(non-standard param value of 0x%02x)' % vv,
+                        '0x%02x' % vv)
+        self.putx([0, ['Channel %d: %s \'%s\' %s' % \
+                      (chan, status_bytes[msg][0], mode_fn[0], vv_string[0]),
+                      'ch %d: %s \'%s\' %s' % \
+                      (chan, status_bytes[msg][1], mode_fn[1], vv_string[1]),
+                      '%d: %s \'%s\' %s' % \
+                      (chan, status_bytes[msg][2], mode_fn[2], vv_string[1])]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_0xb0(self):
@@ -183,7 +221,11 @@ class Decoder(srd.Decoder):
             change_type = 'drum kit'
             name = drum_kit.get(pp, 'undefined')
         self.putx([0, ['Channel %d: %s to %s %d (assuming %s)' % \
-            (chan, status_bytes[msg], change_type, pp, name)]])
+            (chan, status_bytes[msg][0], change_type, pp, name),
+            'ch %d: %s to %s %d' % \
+            (chan, status_bytes[msg][1], change_type, pp),
+            '%d: %s %d' % \
+            (chan, status_bytes[msg][2], pp)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_0xd0(self):
@@ -193,8 +235,11 @@ class Decoder(srd.Decoder):
         if len(c) < 2:
             return
         self.es_block = self.es
-        msg, chan, vv = self.cmd[0] & 0xf0, (self.cmd[0] & 0x0f) + 1, self.cmd[1]
-        self.putx([0, ['Channel %d: %s %d' % (chan, status_bytes[msg], vv)]])
+        msg, chan, vv = self.cmd[0] & 0xf0, (self.cmd[0] & 0x0f) + 1, \
+                        self.cmd[1]
+        self.putx([0, ['Channel %d: %s %d' % (chan, status_bytes[msg][0], vv),
+                      'ch %d: %s %d' % (chan, status_bytes[msg][1], vv),
+                      '%d: %s %d' % (chan, status_bytes[msg][2], vv)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_0xe0(self):
@@ -208,7 +253,11 @@ class Decoder(srd.Decoder):
                             self.cmd[1], self.cmd[2]
         decimal = (mm << 7) + ll
         self.putx([0, ['Channel %d: %s 0x%02x 0x%02x (%d)' % \
-            (chan, status_bytes[msg], ll, mm, decimal)]])
+                      (chan, status_bytes[msg][0], ll, mm, decimal),
+                      'ch %d: %s 0x%02x 0x%02x (%d)' % \
+                      (chan, status_bytes[msg][1], ll, mm, decimal),
+                      '%d: %s (%d)' % \
+                      (chan, status_bytes[msg][2], decimal)]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_channel_msg_generic(self):
@@ -236,7 +285,11 @@ class Decoder(srd.Decoder):
         # to isolate the data.
         msg, eox = self.cmd.pop(0), self.cmd.pop()
         if len(self.cmd) < 1:
-            self.putx([0, ['SysEx: truncated manufacturer code (<1 bytes)']])
+            self.putx([0, ['%s: truncated manufacturer code (<1 bytes)' % \
+                          status_bytes[msg][0],
+                          '%s: truncated manufacturer (<1 bytes)' % \
+                          status_bytes[msg][1],
+                          '%s: trunc. manu.' % status_bytes[msg][2]]])
             self.cmd, self.state = [], 'IDLE'
             return
         # Extract the manufacturer name (or SysEx realtime or non-realtime).
@@ -244,7 +297,11 @@ class Decoder(srd.Decoder):
         manu = (m1,)
         if m1 == 0x00:  # If byte == 0, then 2 more manufacturer bytes follow.
             if len(self.cmd) < 2:
-                self.putx([0, ['SysEx: truncated manufacturer code (<3 bytes)']])
+                self.putx([0, ['%s: truncated manufacturer code (<3 bytes)' % \
+                          status_bytes[msg][0],
+                          '%s: truncated manufacturer (<3 bytes)' % \
+                          status_bytes[msg][1],
+                          '%s: trunc. manu.' % status_bytes[msg][2]]])
                 self.cmd, self.state = [], 'IDLE'
                 return
             manu = (m1, self.cmd.pop(0), self.cmd.pop(0))
@@ -252,19 +309,32 @@ class Decoder(srd.Decoder):
         manu_name = sysex_manufacturer_ids.get(manu, default_name)
         if manu_name == default_name:
             if len(manu) == 3:
-                manu_name = '%s (0x%02x 0x%02x 0x%02x)' % \
-                            (default_name, manu[0], manu[1], manu[2])
+                manu_name = ('%s (0x%02x 0x%02x 0x%02x)' % \
+                            (default_name, manu[0], manu[1], manu[2]),
+                            default_name)
             else:
-                manu_name = '%s (0x%02x)' % (default_name, manu[0])
-        # Extract the payload.
+                manu_name = ('%s (0x%02x)' % (default_name, manu[0]),
+                            default_name)
+        else:
+            manu_name = (manu_name, manu_name)
+        # Extract the payload, display in 1 of 2 formats
         # TODO: Write methods to decode SysEx realtime & non-realtime payloads.
-        payload = ''
+        payload0 = ''
+        payload1 = ''
         while len(self.cmd) > 0:
-            payload += '0x%02x ' % (self.cmd.pop(0))
-        if payload == '':
-            payload = '<empty>'
-        self.putx([0, ['SysEx: for \'%s\' with payload %s' % \
-                       (manu_name, payload)]])
+            byte = self.cmd.pop(0)
+            payload0 += '0x%02x ' % (byte)
+            payload1 += '%02x ' % (byte)
+        if payload0 == '':
+            payload0 = '<empty>'
+            payload1 = '<>'
+        payload = (payload0, payload1)
+        self.putx([0, ['%s: for \'%s\' with payload %s' % \
+                      (status_bytes[msg][0], manu_name[0], payload[0]),
+                      '%s: \'%s\', payload %s' % \
+                      (status_bytes[msg][1], manu_name[1], payload[1]),
+                      '%s: \'%s\', payload %s' % \
+                      (status_bytes[msg][2], manu_name[1], payload[1])]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_syscommon_midi_time_code_quarter_frame_msg(self, newbyte):
@@ -276,17 +346,30 @@ class Decoder(srd.Decoder):
             return
         msg = self.cmd[0]
         nn, dd = (self.cmd[1] & 0x70) >> 4, self.cmd[1] & 0x0f
-        group = 'System Common'
+        group = ('System Common', 'SysCom', 'SC')
         self.es_block = self.es
         if nn != 7: # If message type does not contain SMPTE type.
             self.putx([0, ['%s: %s of %s, value 0x%01x' % \
-                (group, status_bytes[msg], quarter_frame_type[nn], dd)]])
+                          (group[0], status_bytes[msg][0],
+                          quarter_frame_type[nn][0], dd),
+                          '%s: %s of %s, value 0x%01x' % \
+                          (group[1], status_bytes[msg][1],
+                          quarter_frame_type[nn][1], dd),
+                          '%s: %s of %s, value 0x%01x' % \
+                          (group[2], status_bytes[msg][2],
+                          quarter_frame_type[nn][1], dd)]])
             self.cmd, self.state = [], 'IDLE'
             return
         tt = (dd & 0x6) >> 1
         self.putx([0, ['%s: %s of %s, value 0x%01x for %s' % \
-                       (group, status_bytes[msg], quarter_frame_type[nn], \
-                       dd, smpte_type[tt])]])
+                      (group[0], status_bytes[msg][0], \
+                      quarter_frame_type[nn][0], dd, smpte_type[tt]),
+                      '%s: %s of %s, value 0x%01x for %s' % \
+                      (group[1], status_bytes[msg][1], \
+                      quarter_frame_type[nn][1], dd, smpte_type[tt]),
+                      '%s: %s of %s, value 0x%01x for %s' % \
+                      (group[2], status_bytes[msg][2], \
+                      quarter_frame_type[nn][1], dd, smpte_type[tt])]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_syscommon_msg(self, newbyte):
@@ -300,7 +383,7 @@ class Decoder(srd.Decoder):
         self.cmd.append(newbyte)
         msg = self.cmd[0]
         c = self.cmd
-        group = 'System Common'
+        group = ('System Common', 'SysCom', 'SC')
         if msg == 0xf1:
             # MIDI time code quarter frame
             self.handle_syscommon_midi_time_code_quarter_frame_msg(newbyte)
@@ -314,7 +397,11 @@ class Decoder(srd.Decoder):
             decimal = (mm << 7) + ll
             self.es_block = self.es
             self.putx([0, ['%s: %s 0x%02x 0x%02x (%d)' % \
-                (group, status_bytes[msg], ll, mm, decimal)]])
+                          (group[0], status_bytes[msg][0], ll, mm, decimal),
+                          '%s: %s 0x%02x 0x%02x (%d)' % \
+                          (group[1], status_bytes[msg][1], ll, mm, decimal),
+                          '%s: %s (%d)' % \
+                          (group[2], status_bytes[msg][2], decimal)]])
         elif msg == 0xf3:
             # Song select: F3 ss
             # ss = song selection number
@@ -322,18 +409,28 @@ class Decoder(srd.Decoder):
                 return
             ss = self.cmd[1]
             self.es_block = self.es
-            self.putx([0, ['%s: %s number %d' % (group, status_bytes[msg], ss)]])
+            self.putx([0, ['%s: %s number %d' % \
+                          (group[0], status_bytes[msg][0], ss),
+                          '%s: %s number %d' % \
+                          (group[1], status_bytes[msg][1], ss),
+                          '%s: %s # %d' % \
+                          (group[2], status_bytes[msg][2], ss)]])
         elif msg == 0xf4 or msg == 0xf5 or msg == 0xf6:
             # Undefined 0xf4, Undefined 0xf5, and Tune Request (respectively).
             # All are only 1 byte long with no data bytes.
             self.es_block = self.es
-            self.putx([0, ['%s: %s' % (group, status_bytes[msg])]])
+            self.putx([0, ['%s: %s' % (group[0], status_bytes[msg][0]),
+                          '%s: %s' % (group[1], status_bytes[msg][1]),
+                          '%s: %s' % (group[2], status_bytes[msg][2])]])
         self.cmd, self.state = [], 'IDLE'
 
     def handle_sysrealtime_msg(self, newbyte):
         # System realtime message: 0b11111ttt (t = message type)
         self.es_block = self.es
-        self.putx([0, ['System realtime message: %s' % status_bytes[newbyte]]])
+        group = ('System Realtime', 'SysReal', 'SR')
+        self.putx([0, ['%s: %s' % (group[0], status_bytes[newbyte][0]),
+                      '%s: %s' % (group[1], status_bytes[newbyte][1]),
+                      '%s: %s' % (group[2], status_bytes[newbyte][2])]])
         self.cmd, self.state = [], 'IDLE'
 
     def decode(self, ss, es, data):