X-Git-Url: https://sigrok.org/gitweb/?p=libsigrokdecode.git;a=blobdiff_plain;f=decoders%2Fi2c.py;h=23b12c34f4791720067d068f82627aa42dd60972;hp=9ff89c9755993c797fc54ee9e34f475c92a525e0;hb=0ee4dd54ce134158cd2068866ddc7d32c692d457;hpb=e508088229e96423854ba6db63084c9bb18eeb34 diff --git a/decoders/i2c.py b/decoders/i2c.py index 9ff89c9..23b12c3 100644 --- a/decoders/i2c.py +++ b/decoders/i2c.py @@ -89,26 +89,9 @@ # 'data': (actual data as integer ???) TODO: This can be very variable... # 'ann': (string; additional annotations / comments) # -# Example output: -# [{'type': 'S', 'range': (150, 160), 'data': None, 'ann': 'Foobar'}, -# {'type': 'AW', 'range': (200, 300), 'data': 0x50, 'ann': 'Slave 4'}, -# {'type': 'DW', 'range': (310, 370), 'data': 0x00, 'ann': 'Init cmd'}, -# {'type': 'AR', 'range': (500, 560), 'data': 0x50, 'ann': 'Get stat'}, -# {'type': 'DR', 'range': (580, 640), 'data': 0xfe, 'ann': 'OK'}, -# {'type': 'P', 'range': (650, 660), 'data': None, 'ann': None}] -# -# Possible other events: -# - Error event in case protocol looks broken: -# [{'type': 'ERROR', 'range': (min, max), -# 'data': TODO, 'ann': 'This is not a Microchip 24XX64 EEPROM'}, -# [{'type': 'ERROR', 'range': (min, max), -# 'data': TODO, 'ann': 'TODO'}, -# - TODO: Make list of possible errors accessible as metadata? -# # TODO: I2C address of slaves. # TODO: Handle multiple different I2C devices on same bus # -> we need to decode multiple protocols at the same time. -# TODO: range: Always contiguous? Splitted ranges? Multiple per event? # # @@ -126,36 +109,35 @@ # 'signals': [{'SCL': }]} # -import sigrok - -# symbols for i2c decoders up the stack -START = 1 -START_REPEAT = 2 -STOP = 3 -ACK = 4 -NACK = 5 -ADDRESS_READ = 6 -ADDRESS_WRITE = 7 -DATA_READ = 8 -DATA_WRITE = 9 +import sigrokdecode + +# values are verbose and short annotation, respectively +protocol = { + 'START': ['START', 'S'], + 'START_REPEAT': ['START REPEAT', 'Sr'], + 'STOP': ['STOP', 'P'], + 'ACK': ['ACK', 'A'], + 'NACK': ['NACK', 'N'], + 'ADDRESS_READ': ['ADDRESS READ', 'AR'], + 'ADDRESS_WRITE': ['ADDRESS WRITE','AW'], + 'DATA_READ': ['DATA READ', 'DR'], + 'DATA_WRITE': ['DATA WRITE', 'DW'], +} +# export protocol keys as symbols for i2c decoders up the stack +EXPORT = [ protocol.keys() ] # States FIND_START = 0 FIND_ADDRESS = 1 FIND_DATA = 2 -class Sample(): - def __init__(self, data): - self.data = data - def probe(self, probe): - s = ord(self.data[probe / 8]) & (1 << (probe % 8)) - return True if s else False +# annotation feed formats +ANN_SHIFTED = 0 +ANN_SHIFTED_SHORT = 1 +ANN_RAW = 2 -def sampleiter(data, unitsize): - for i in range(0, len(data), unitsize): - yield(Sample(data[i:i+unitsize])) -class Decoder(sigrok.Decoder): +class Decoder(sigrokdecode.Decoder): id = 'i2c' name = 'I2C' longname = 'Inter-Integrated Circuit (I2C) bus' @@ -166,42 +148,40 @@ class Decoder(sigrok.Decoder): license = 'gplv2+' inputs = ['logic'] outputs = ['i2c'] - probes = { - 'scl': {'ch': 0, 'name': 'SCL', 'desc': 'Serial clock line'}, - 'sda': {'ch': 1, 'name': 'SDA', 'desc': 'Serial data line'}, - } + probes = [ + {'id': 'scl', 'name': 'SCL', 'desc': 'Serial clock line'}, + {'id': 'sda', 'name': 'SDA', 'desc': 'Serial data line'}, + ] options = { 'address-space': ['Address space (in bits)', 7], } + annotation = [ + # ANN_SHIFTED + ["7-bit shifted hex", + "Read/Write bit shifted out from the 8-bit i2c slave address"], + # ANN_SHIFTED_SHORT + ["7-bit shifted hex (short)", + "Read/Write bit shifted out from the 8-bit i2c slave address"], + # ANN_RAW + ["Raw hex", "Unaltered raw data"] + ] def __init__(self, **kwargs): - self.probes = Decoder.probes.copy() self.output_protocol = None self.output_annotation = None - - # TODO: Don't hardcode the number of channels. - self.channels = 8 - - self.samplenum = 0 + self.samplecnt = 0 self.bitcount = 0 self.databyte = 0 self.wr = -1 self.startsample = -1 self.is_repeat_start = 0 - self.state = FIND_START - - # Get the channel/probe number of the SCL/SDA signals. - self.scl_bit = self.probes['scl']['ch'] - self.sda_bit = self.probes['sda']['ch'] - self.oldscl = None self.oldsda = None def start(self, metadata): - self.unitsize = metadata["unitsize"] - self.output_protocol = self.output_new(2) - self.output_annotation = self.output_new(1) + self.output_protocol = self.output_new(1, 'i2c') + self.output_annotation = self.output_new(0, 'i2c') def report(self): pass @@ -226,13 +206,12 @@ class Decoder(sigrok.Decoder): def found_start(self, scl, sda): if self.is_repeat_start == 1: - out_proto = [ START_REPEAT ] - out_ann = [ "START REPEAT" ] + cmd = 'START_REPEAT' else: - out_proto = [ START ] - out_ann = [ "START" ] - self.put(self.output_protocol, out_proto) - self.put(self.output_annotation, out_ann) + cmd = 'START' + self.put(self.output_protocol, [ cmd ]) + self.put(self.output_annotation, [ ANN_SHIFTED, [protocol[cmd][0]] ]) + self.put(self.output_annotation, [ ANN_SHIFTED_SHORT, [protocol[cmd][1]] ]) self.state = FIND_ADDRESS self.bitcount = self.databyte = 0 @@ -243,7 +222,8 @@ class Decoder(sigrok.Decoder): """Gather 8 bits of data plus the ACK/NACK bit.""" if self.startsample == -1: - self.startsample = self.samplenum + # TODO: should be samplenum, as received from the feed + self.startsample = self.samplecnt self.bitcount += 1 # Address and data are transmitted MSB-first. @@ -254,6 +234,10 @@ class Decoder(sigrok.Decoder): if self.bitcount != 9: return [] + # send raw output annotation before we start shifting out + # read/write and ack/nack bits + self.put(self.output_annotation, [ANN_RAW, ["0x%.2x" % self.databyte]]) + # We received 8 address/data bits and the ACK/NACK bit. self.databyte >>= 1 # Shift out unwanted ACK/NACK bit here. @@ -267,33 +251,32 @@ class Decoder(sigrok.Decoder): # TODO: Error? pass - out_proto = [] - out_ann = [] + # last bit that came in was the ACK/NACK bit (1 = NACK) + if sda == 1: + ack_bit = 'NACK' + else: + ack_bit = 'ACK' + # TODO: Simplify. if self.state == FIND_ADDRESS and self.wr == 1: - cmd = ADDRESS_WRITE - ann = 'ADDRESS WRITE' + cmd = 'ADDRESS_WRITE' elif self.state == FIND_ADDRESS and self.wr == 0: - cmd = ADDRESS_READ - ann = 'ADDRESS READ' + cmd = 'ADDRESS_READ' elif self.state == FIND_DATA and self.wr == 1: - cmd = DATA_WRITE - ann = 'DATA WRITE' + cmd = 'DATA_WRITE' elif self.state == FIND_DATA and self.wr == 0: - cmd = DATA_READ - ann = 'DATA READ' - out_proto.append( [cmd, d] ) - out_ann.append( ["%s" % ann, "0x%02x" % d] ) - - if sda == 1: - out_proto.append( [NACK] ) - out_ann.append( ["NACK"] ) - else: - out_proto.append( [ACK] ) - out_ann.append( ["ACK"] ) - - self.put(self.output_protocol, out_proto) - self.put(self.output_annotation, out_ann) + cmd = 'DATA_READ' + self.put(self.output_protocol, [ [cmd, d], [ack_bit] ] ) + self.put(self.output_annotation, [ANN_SHIFTED, [ + "%s" % protocol[cmd][0], + "0x%02x" % d, + "%s" % protocol[ack_bit][0]] + ] ) + self.put(self.output_annotation, [ANN_SHIFTED_SHORT, [ + "%s" % protocol[cmd][1], + "0x%02x" % d, + "%s" % protocol[ack_bit][1]] + ] ) self.bitcount = self.databyte = 0 self.startsample = -1 @@ -306,36 +289,29 @@ class Decoder(sigrok.Decoder): pass def found_stop(self, scl, sda): - self.put(self.output_protocol, [ STOP ]) - self.put(self.output_annotation, [ "STOP" ]) + self.put(self.output_protocol, [ 'STOP' ]) + self.put(self.output_annotation, [ ANN_SHIFTED, [protocol['STOP'][0]] ]) + self.put(self.output_annotation, [ ANN_SHIFTED_SHORT, [protocol['STOP'][1]] ]) self.state = FIND_START self.is_repeat_start = 0 self.wr = -1 - def decode(self, data): - """I2C protocol decoder""" - - # We should accept a list of samples and iterate... - for sample in sampleiter(data['data'], self.unitsize): - - # TODO: Eliminate the need for ord(). - s = ord(sample.data) + def put(self, output_id, data): + # inject sample range into the call up to sigrok + # TODO: 0-0 sample range for now + super(Decoder, self).put(0, 0, output_id, data) - # TODO: Start counting at 0 or 1? - self.samplenum += 1 + def decode(self, timeoffset, duration, data): + for samplenum, (scl, sda) in data: + self.samplecnt += 1 # First sample: Save SCL/SDA value. if self.oldscl == None: - # Get SCL/SDA bit values (0/1 for low/high) of the first sample. - self.oldscl = (s & (1 << self.scl_bit)) >> self.scl_bit - self.oldsda = (s & (1 << self.sda_bit)) >> self.sda_bit + self.oldscl = scl + self.oldsda = sda continue - # Get SCL/SDA bit values (0/1 for low/high). - scl = (s & (1 << self.scl_bit)) >> self.scl_bit - sda = (s & (1 << self.sda_bit)) >> self.sda_bit - # TODO: Wait until the bus is idle (SDA = SCL = 1) first? # State machine. @@ -360,4 +336,3 @@ class Decoder(sigrok.Decoder): self.oldscl = scl self.oldsda = sda -