]> sigrok.org Git - libsigrokdecode.git/blobdiff - instance.c
Drop support for PD API version 2.
[libsigrokdecode.git] / instance.c
index b716f2fa1fe1b29339558903a1dcc5271f2ac14c..3327926d70e10db917174dda878ee0019789c19a 100644 (file)
@@ -30,9 +30,6 @@
 
 extern SRD_PRIV GSList *sessions;
 
-/* module_sigrokdecode.c */
-extern SRD_PRIV PyObject *srd_logic_type;
-
 static void srd_inst_join_decode_thread(struct srd_decoder_inst *di);
 static void srd_inst_reset_state(struct srd_decoder_inst *di);
 SRD_PRIV void oldpins_array_free(struct srd_decoder_inst *di);
@@ -743,8 +740,7 @@ SRD_PRIV int srd_inst_start(struct srd_decoder_inst *di)
  */
 static gboolean sample_matches(uint8_t old_sample, uint8_t sample, struct srd_term *term)
 {
-       if (!term)
-               return FALSE;
+       /* Caller ensures term != NULL. */
 
        switch (term->type) {
        case SRD_TERM_HIGH:
@@ -871,19 +867,16 @@ static gboolean term_matches(const struct srd_decoder_inst *di,
        uint8_t old_sample, sample;
        int byte_offset, bit_offset, ch;
 
-       if (!di || !di->dec_channelmap || !term || !sample_pos)
-               return FALSE;
+       /* Caller ensures di, di->dec_channelmap, term, sample_pos != NULL. */
 
-       /* Overwritten below (or ignored for SRD_TERM_SKIP). */
-       old_sample = sample = 0;
+       if (term->type == SRD_TERM_SKIP)
+               return sample_matches(0, 0, term);
 
-       if (term->type != SRD_TERM_SKIP) {
-               ch = term->channel;
-               byte_offset = di->dec_channelmap[ch] / 8;
-               bit_offset = di->dec_channelmap[ch] % 8;
-               sample = *(sample_pos + byte_offset) & (1 << bit_offset) ? 1 : 0;
-               old_sample = di->old_pins_array->data[ch];
-       }
+       ch = term->channel;
+       byte_offset = di->dec_channelmap[ch] / 8;
+       bit_offset = di->dec_channelmap[ch] % 8;
+       sample = *(sample_pos + byte_offset) & (1 << bit_offset) ? 1 : 0;
+       old_sample = di->old_pins_array->data[ch];
 
        return sample_matches(old_sample, sample, term);
 }
@@ -894,8 +887,7 @@ static gboolean all_terms_match(const struct srd_decoder_inst *di,
        const GSList *l;
        struct srd_term *term;
 
-       if (!di || !cond || !sample_pos)
-               return FALSE;
+       /* Caller ensures di, cond, sample_pos != NULL. */
 
        for (l = cond; l; l = l->next) {
                term = l->data;
@@ -911,8 +903,7 @@ static gboolean at_least_one_condition_matched(
 {
        unsigned int i;
 
-       if (!di)
-               return FALSE;
+       /* Caller ensures di != NULL. */
 
        for (i = 0; i < num_conditions; i++) {
                if (di->match_array->data[i])
@@ -930,6 +921,8 @@ static gboolean find_match(struct srd_decoder_inst *di)
        const uint8_t *sample_pos;
        unsigned int num_conditions;
 
+       /* Caller ensures di != NULL. */
+
        /* Check whether the condition list is NULL/empty. */
        if (!di->condition_list) {
                srd_dbg("NULL/empty condition list, automatic match.");
@@ -1165,10 +1158,6 @@ SRD_PRIV int srd_inst_decode(struct srd_decoder_inst *di,
                uint64_t abs_start_samplenum, uint64_t abs_end_samplenum,
                const uint8_t *inbuf, uint64_t inbuflen, uint64_t unitsize)
 {
-       PyObject *py_res;
-       srd_logic *logic;
-       long apiver;
-
        /* Return an error upon unusable input. */
        if (!di) {
                srd_dbg("empty decoder instance");
@@ -1203,61 +1192,33 @@ SRD_PRIV int srd_inst_decode(struct srd_decoder_inst *di,
                abs_end_samplenum - abs_start_samplenum, inbuflen, di->data_unitsize,
                di->inst_id);
 
-       apiver = srd_decoder_apiver(di->decoder);
+       /* If this is the first call, start the worker thread. */
+       if (!di->thread_handle) {
+               srd_dbg("No worker thread for this decoder stack "
+                       "exists yet, creating one: %s.", di->inst_id);
+               di->thread_handle = g_thread_new(di->inst_id,
+                                                di_thread, di);
+       }
 
-       if (apiver == 2) {
-               /*
-                * Create new srd_logic object. Each iteration around the PD's
-                * loop will fill one sample into this object.
-                */
-               logic = PyObject_New(srd_logic, (PyTypeObject *)srd_logic_type);
-               Py_INCREF(logic);
-               logic->di = (struct srd_decoder_inst *)di;
-               logic->abs_start_samplenum = abs_start_samplenum;
-               logic->itercnt = 0;
-               logic->inbuf = (uint8_t *)inbuf;
-               logic->inbuflen = inbuflen;
-               logic->sample = PyList_New(2);
-               Py_INCREF(logic->sample);
-
-               Py_IncRef(di->py_inst);
-               if (!(py_res = PyObject_CallMethod(di->py_inst, "decode",
-                       "KKO", abs_start_samplenum, abs_end_samplenum, logic))) {
-                       srd_exception_catch("Protocol decoder instance %s",
-                                       di->inst_id);
-                       return SRD_ERR_PYTHON;
-               }
-               di->abs_cur_samplenum = abs_end_samplenum;
-               Py_DecRef(py_res);
-       } else {
-               /* If this is the first call, start the worker thread. */
-               if (!di->thread_handle) {
-                       srd_dbg("No worker thread for this decoder stack "
-                               "exists yet, creating one: %s.", di->inst_id);
-                       di->thread_handle = g_thread_new(di->inst_id,
-                                                        di_thread, di);
-               }
+       /* Push the new sample chunk to the worker thread. */
+       g_mutex_lock(&di->data_mutex);
+       di->abs_start_samplenum = abs_start_samplenum;
+       di->abs_end_samplenum = abs_end_samplenum;
+       di->inbuf = inbuf;
+       di->inbuflen = inbuflen;
+       di->got_new_samples = TRUE;
+       di->handled_all_samples = FALSE;
+       di->want_wait_terminate = FALSE;
 
-               /* Push the new sample chunk to the worker thread. */
-               g_mutex_lock(&di->data_mutex);
-               di->abs_start_samplenum = abs_start_samplenum;
-               di->abs_end_samplenum = abs_end_samplenum;
-               di->inbuf = inbuf;
-               di->inbuflen = inbuflen;
-               di->got_new_samples = TRUE;
-               di->handled_all_samples = FALSE;
-               di->want_wait_terminate = FALSE;
-
-               /* Signal the thread that we have new data. */
-               g_cond_signal(&di->got_new_samples_cond);
-               g_mutex_unlock(&di->data_mutex);
-
-               /* When all samples in this chunk were handled, return. */
-               g_mutex_lock(&di->data_mutex);
-               while (!di->handled_all_samples && !di->want_wait_terminate)
-                       g_cond_wait(&di->handled_all_samples_cond, &di->data_mutex);
-               g_mutex_unlock(&di->data_mutex);
-       }
+       /* Signal the thread that we have new data. */
+       g_cond_signal(&di->got_new_samples_cond);
+       g_mutex_unlock(&di->data_mutex);
+
+       /* When all samples in this chunk were handled, return. */
+       g_mutex_lock(&di->data_mutex);
+       while (!di->handled_all_samples && !di->want_wait_terminate)
+               g_cond_wait(&di->handled_all_samples_cond, &di->data_mutex);
+       g_mutex_unlock(&di->data_mutex);
 
        return SRD_OK;
 }