From 4da62209ddfa3aad12678c7141c19e9c3e8419c1 Mon Sep 17 00:00:00 2001 From: Gerhard Sittig Date: Sun, 16 May 2021 19:42:53 +0200 Subject: [PATCH] hameg-hmo: free memory that was allocated by SCPI get routines The SCPI get routines may allocate memory for response data which callers have to free after use. Move an existing assigment such that the initial assignment, the memory allocation, use of response data, and resource release are in closer proximity, and thus are easier to reason about during maintenance. Behaviour does not change. This is motivated by bug #1683. --- src/hardware/hameg-hmo/protocol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hardware/hameg-hmo/protocol.c b/src/hardware/hameg-hmo/protocol.c index 3e15d376..26dac0cb 100644 --- a/src/hardware/hameg-hmo/protocol.c +++ b/src/hardware/hameg-hmo/protocol.c @@ -1380,8 +1380,6 @@ SR_PRIV int hmo_receive_data(int fd, int revents, void *cb_data) (void)fd; (void)revents; - data = NULL; - if (!(sdi = cb_data)) return TRUE; @@ -1410,6 +1408,7 @@ SR_PRIV int hmo_receive_data(int fd, int revents, void *cb_data) */ switch (ch->type) { case SR_CHANNEL_ANALOG: + data = NULL; if (sr_scpi_get_block(sdi->conn, NULL, &data) != SR_OK) { if (data) g_byte_array_free(data, TRUE); @@ -1442,6 +1441,7 @@ SR_PRIV int hmo_receive_data(int fd, int revents, void *cb_data) data = NULL; break; case SR_CHANNEL_LOGIC: + data = NULL; if (sr_scpi_get_block(sdi->conn, NULL, &data) != SR_OK) { if (data) g_byte_array_free(data, TRUE); -- 2.30.2