From: Gerhard Sittig <redacted>
Date: Thu, 5 Oct 2017 21:26:38 +0000 (+0200)
Subject: uni-t-ut32x: comment on the "T1-T2" channel name (looks like a range)
X-Git-Url: https://sigrok.org/gitweb/?p=libsigrok.git;a=commitdiff_plain;h=2631d9320d757675abfaa30f8f2f287be79fa2fd

uni-t-ut32x: comment on the "T1-T2" channel name (looks like a range)
---

diff --git a/src/hardware/uni-t-ut32x/api.c b/src/hardware/uni-t-ut32x/api.c
index fe543503..47211fa4 100644
--- a/src/hardware/uni-t-ut32x/api.c
+++ b/src/hardware/uni-t-ut32x/api.c
@@ -36,6 +36,15 @@ static const uint32_t devopts[] = {
 	SR_CONF_DATA_SOURCE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
 };
 
+/*
+ * BEWARE! "T1-T2" looks like a range, and is probably not a good
+ * channel name. Using it in sigrok-cli -C specs is troublesome. Use
+ * "delta" instead? -- But OTOH channels are not selected by the
+ * software. Instead received packets just reflect the one channel
+ * that manually was selected by the user via the device's buttons.
+ * So the name is not a blocker, and it matches the labels on the
+ * device and in the manual. So we can get away with it.
+ */
 static const char *channel_names[] = {
 	"T1", "T2", "T1-T2",
 };