Document if or why sometimes digits/spec_digits is 0.

diff --git a/src/hardware/atten-pps3xxx/protocol.c b/src/hardware/atten-pps3xxx/protocol.c
index 0102adbd9a33b731cd021f7b6d7e632b3067be01..7cf0f9342e3d8bf8447e8d920672e5863a98f79b 100644 (file)
--- a/src/hardware/atten-pps3xxx/protocol.c
+++ b/src/hardware/atten-pps3xxx/protocol.c
@@ -47,6 +47,7 @@ static void handle_packet(const struct sr_dev_inst *sdi)
        devc = sdi->priv;
        dump_packet("received", devc->packet);
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        packet.type = SR_DF_ANALOG;

diff --git a/src/hardware/brymen-bm86x/protocol.c b/src/hardware/brymen-bm86x/protocol.c
index adf0e0f6ed010c74368901fee9d0f818521cb88b..f6ccc3068fe6445fbd7f0e249d1434afa0494524 100644 (file)
--- a/src/hardware/brymen-bm86x/protocol.c
+++ b/src/hardware/brymen-bm86x/protocol.c
@@ -218,6 +218,7 @@ static void brymen_bm86x_handle_packet(const struct sr_dev_inst *sdi,
 
        devc = sdi->priv;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog[0], &encoding[0], &meaning[0], &spec[0], 0);
        sr_analog_init(&analog[1], &encoding[1], &meaning[1], &spec[1], 0);
 

diff --git a/src/hardware/center-3xx/protocol.c b/src/hardware/center-3xx/protocol.c
index fba88f645e2184f55292d3eca9e008141c46ce2c..b4d9ed5ba834162cc063e2bc47a9a3579ef0acce 100644 (file)
--- a/src/hardware/center-3xx/protocol.c
+++ b/src/hardware/center-3xx/protocol.c
@@ -139,6 +139,7 @@ static int handle_packet(const uint8_t *buf, struct sr_dev_inst *sdi, int idx)
 
        devc = sdi->priv;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
        memset(&info, 0, sizeof(struct center_info));
 

diff --git a/src/hardware/kern-scale/protocol.c b/src/hardware/kern-scale/protocol.c
index 01838e3d55da75bbe230a9e20dfe733a729e0ac2..354f1e8429fd3398afd75ad505e50210fdd00178 100644 (file)
--- a/src/hardware/kern-scale/protocol.c
+++ b/src/hardware/kern-scale/protocol.c
@@ -43,6 +43,7 @@ static void handle_packet(const uint8_t *buf, struct sr_dev_inst *sdi,
 
        devc = sdi->priv;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        analog.meaning->channels = sdi->channels;

diff --git a/src/hardware/korad-kaxxxxp/protocol.c b/src/hardware/korad-kaxxxxp/protocol.c
index e22ec341b2486c7bfd1e6eaa9e3395dccac794b6..4705403fb2c7e8d50ecc6974d9cdf041aa24b091 100644 (file)
--- a/src/hardware/korad-kaxxxxp/protocol.c
+++ b/src/hardware/korad-kaxxxxp/protocol.c
@@ -348,6 +348,7 @@ SR_PRIV int korad_kaxxxxp_receive_data(int fd, int revents, void *cb_data)
                /* Get the value. */
                korad_kaxxxxp_get_reply(serial, devc);
 
+               /* Note: digits/spec_digits will be overridden later. */
                sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
                /* Send the value forward. */

diff --git a/src/hardware/lascar-el-usb/protocol.c b/src/hardware/lascar-el-usb/protocol.c
index 96beb5a1ed876553f32c49ed752b156b88af4690..fc24fbe77cd81780201ea786afdbc61d33a526f7 100644 (file)
--- a/src/hardware/lascar-el-usb/protocol.c
+++ b/src/hardware/lascar-el-usb/protocol.c
@@ -398,6 +398,7 @@ static void lascar_el_usb_dispatch(struct sr_dev_inst *sdi, unsigned char *buf,
 
        devc = sdi->priv;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        samples = buflen / devc->sample_size;

diff --git a/src/hardware/motech-lps-30x/protocol.c b/src/hardware/motech-lps-30x/protocol.c
index beb2bcdef3b2ea60c5c1aa22758282275dfff8fd..0681eed630a800ad0463eea93ec5ce851b77c4d2 100644 (file)
--- a/src/hardware/motech-lps-30x/protocol.c
+++ b/src/hardware/motech-lps-30x/protocol.c
@@ -44,6 +44,7 @@ static void send_data(struct sr_dev_inst *sdi)
        packet.type = SR_DF_ANALOG;
        packet.payload = &analog;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        analog.meaning->channels = sdi->channels;

diff --git a/src/hardware/scpi-pps/protocol.c b/src/hardware/scpi-pps/protocol.c
index 1cd157598e2461331515685d394bf55266d22a87..4c7a649cda1f2aec73c8756b69b6af82123c3d10 100644 (file)
--- a/src/hardware/scpi-pps/protocol.c
+++ b/src/hardware/scpi-pps/protocol.c
@@ -87,6 +87,7 @@ SR_PRIV int scpi_pps_receive_data(int fd, int revents, void *cb_data)
                ch_spec = &devc->device->channels[pch->hw_output_idx];
                packet.type = SR_DF_ANALOG;
                packet.payload = &analog;
+               /* Note: digits/spec_digits will be overridden later. */
                sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
                analog.meaning->channels = g_slist_append(NULL, devc->cur_channel);
                analog.num_samples = 1;

diff --git a/src/hardware/serial-dmm/protocol.c b/src/hardware/serial-dmm/protocol.c
index 9c626a8a118fc14cc1e0cd58a7c4ec14090a30e8..1d1ca4823208c5aaa86c1ac8495d6806d44779a2 100644 (file)
--- a/src/hardware/serial-dmm/protocol.c
+++ b/src/hardware/serial-dmm/protocol.c
@@ -55,6 +55,7 @@ static void handle_packet(const uint8_t *buf, struct sr_dev_inst *sdi,
        log_dmm_packet(buf);
        devc = sdi->priv;
 
+       /* Note: digits/spec_digits will be overridden by the DMM parsers. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        analog.meaning->channels = sdi->channels;

diff --git a/src/hardware/teleinfo/protocol.c b/src/hardware/teleinfo/protocol.c
index 54be6252a75e340b535b48972d983fa60b666413..88fbfac36838280303eaa2e2b2afa4c4d10276c2 100644 (file)
--- a/src/hardware/teleinfo/protocol.c
+++ b/src/hardware/teleinfo/protocol.c
@@ -70,6 +70,7 @@ static void teleinfo_send_value(struct sr_dev_inst *sdi, const char *channel_nam
        if (!ch || !ch->enabled)
                return;
 
+       /* Note: digits/spec_digits is actually really 0 for this device! */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
        analog.meaning->channels = g_slist_append(analog.meaning->channels, ch);
        analog.num_samples = 1;

diff --git a/src/hardware/uni-t-dmm/protocol.c b/src/hardware/uni-t-dmm/protocol.c
index 15cdb0c234660548e714fc2e0b343fdf41845297..79dcc747b3aef52504237f3a7b09d2333341a09e 100644 (file)
--- a/src/hardware/uni-t-dmm/protocol.c
+++ b/src/hardware/uni-t-dmm/protocol.c
@@ -67,6 +67,7 @@ static void decode_packet(struct sr_dev_inst *sdi, const uint8_t *buf)
 
        devc = sdi->priv;
        dmm = (struct dmm_info *)sdi->driver;
+       /* Note: digits/spec_digits will be overridden by the DMM parsers. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
        info = g_malloc(dmm->info_size);
 

diff --git a/src/lcr/es51919.c b/src/lcr/es51919.c
index d093770e62a44a1ed9210b46d7e91131474a2927..cd901366841b3dfe1a53495dac64786bf2a2cfa0 100644 (file)
--- a/src/lcr/es51919.c
+++ b/src/lcr/es51919.c
@@ -644,6 +644,7 @@ static void handle_packet(struct sr_dev_inst *sdi, const uint8_t *pkt)
 
        frame = FALSE;
 
+       /* Note: digits/spec_digits will be overridden later. */
        sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
 
        analog.num_samples = 1;