X-Git-Url: https://sigrok.org/gitweb/?p=libsigrok.git;a=blobdiff_plain;f=HACKING;h=9d71c55c11d0fa240b7eb3b5f32b83e0b20a095c;hp=2c73e3297e40d48c4a82b903cb709a942c62e289;hb=22fdb67fa0714c11cc0a58ee1423f55d18a4f080;hpb=8626feaeb57aa50d68293f1706593fa8269a3b2e diff --git a/HACKING b/HACKING index 2c73e329..9d71c55c 100644 --- a/HACKING +++ b/HACKING @@ -5,8 +5,9 @@ HACKING Coding style ------------ -This project is programmed using the Linux kernel coding style, see -http://lxr.linux.no/linux/Documentation/CodingStyle for details. +This project is programmed using the Linux kernel coding style: + + https://www.kernel.org/doc/html/latest/process/coding-style.html Please use the same style for any code contributions, thanks! @@ -60,8 +61,9 @@ This is a rough overview of what you need to do in order to add a new driver (using the Tondaj SL-814 device as example). It's basically what the 'new-driver' script (see above) does for you: - - Makefile.am: Add HW_TONDAJ_SL_814 and add to libsigrok_la_SOURCES. - - configure.ac: Add a DRIVER() and DRIVER2() call. + - Makefile.am: Add to src_libdrivers_la_SOURCES under the HW_TONDAJ_SL_814 + condition. + - configure.ac: Add an SR_DRIVER() call. - src/drivers.c: Add a tondaj_sl_814_driver_info entry in two places. - src/hardware/tondaj-sl-814/ directory: Add api.c, protocol.c, protocol.h. @@ -162,7 +164,9 @@ Doxygen - Mark private functions (SR_PRIV) with /** @private */, so that Doxygen doesn't include them in the output. Functions that are "static" anyway - don't need to be marked like this. + don't need to be marked like this. Functions in non-public files that + are explicitly excluded in Doxyfile don't need to be marked either. + Don't use @internal, always use @private instead. - Mark private variables/#defines with /** @cond PRIVATE */ and /** @endcond */, so that Doxygen doesn't include them in the output.