src/hardware/scpi-dmm/api.c

   1 /*
   2  * This file is part of the libsigrok project.
   3  *
   4  * Copyright (C) 2018 Gerhard Sittig <gerhard.sittig@gmx.net>
   5  *
   6  * This program is free software: you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation, either version 3 of the License, or
   9  * (at your option) any later version.
  10  *
  11  * This program is distributed in the hope that it will be useful,
  12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  14  * GNU General Public License for more details.
  15  *
  16  * You should have received a copy of the GNU General Public License
  17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  18  */
  19
  20 #include <string.h>
  21 #include "protocol.h"
  22
  23 static struct sr_dev_driver scpi_dmm_driver_info;
  24
  25 static const uint32_t scanopts[] = {
  26         SR_CONF_CONN,
  27         SR_CONF_SERIALCOMM,
  28 };
  29
  30 static const uint32_t drvopts[] = {
  31         SR_CONF_MULTIMETER,
  32 };
  33
  34 static const uint32_t devopts_generic[] = {
  35         SR_CONF_CONTINUOUS,
  36         SR_CONF_CONN | SR_CONF_GET,
  37         SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
  38         SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
  39         SR_CONF_MEASURED_QUANTITY | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
  40 };
  41
  42 static const struct scpi_command cmdset_agilent[] = {
  43         { DMM_CMD_SETUP_REMOTE, "\n", },
  44         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  45         { DMM_CMD_QUERY_FUNC, "CONF?", },
  46         { DMM_CMD_START_ACQ, "MEAS", },
  47         { DMM_CMD_STOP_ACQ, "ABORT", },
  48         { DMM_CMD_QUERY_VALUE, "READ?", },
  49         { DMM_CMD_QUERY_PREC, "CONF?", },
  50         ALL_ZERO,
  51 };
  52
  53 /*
  54  * cmdset_hp is used for the 34401A, which was added to this code after the
  55  * 34405A and 34465A. It differs in starting the measurement with INIT: using
  56  * MEAS without a trailing '?' (as used for the 34405A) is not valid for the
  57  * 34401A and gives an error.
  58  * I'm surprised the same instruction sequence doesn't work and INIT may
  59  * work for both, but I don't have the others to re-test.
  60  *
  61  * cmdset_hp also works well for the 34410A, using cmdset_agilent throws an
  62  * error on 'MEAS' without a '?'.
  63  *
  64  * On the 34401A,
  65  *  MEAS <optional parameters> ? configures, arms, triggers and waits
  66  *       for a reading
  67  *  CONF <parameters> configures
  68  *  INIT prepares for triggering (trigger mode is not set, assumed
  69  *       internal - external might time out)
  70  *  *OPC waits for completion, and
  71  *  READ? retrieves the result
  72  */
  73 static const struct scpi_command cmdset_hp[] = {
  74         { DMM_CMD_SETUP_REMOTE, "\n", },
  75         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  76         { DMM_CMD_QUERY_FUNC, "CONF?", },
  77         { DMM_CMD_START_ACQ, "INIT", },
  78         { DMM_CMD_STOP_ACQ, "ABORT", },
  79         { DMM_CMD_QUERY_VALUE, "READ?", },
  80         { DMM_CMD_QUERY_PREC, "CONF?", },
  81         ALL_ZERO,
  82 };
  83
  84 static const struct scpi_command cmdset_gwinstek[] = {
  85         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
  86         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
  87         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  88         { DMM_CMD_QUERY_FUNC, "CONF:STAT:FUNC?", },
  89         { DMM_CMD_START_ACQ, "*CLS;SYST:REM", },
  90         { DMM_CMD_QUERY_VALUE, "VAL1?", },
  91         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
  92         ALL_ZERO,
  93 };
  94
  95 static const struct scpi_command cmdset_gwinstek_906x[] = {
  96         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
  97         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
  98         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  99         { DMM_CMD_QUERY_FUNC, "CONF?", },
 100         { DMM_CMD_START_ACQ, "INIT", },
 101         { DMM_CMD_STOP_ACQ, "ABORT", },
 102         { DMM_CMD_QUERY_VALUE, "VAL1?", },
 103         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
 104         ALL_ZERO,
 105 };
 106
 107 static const struct mqopt_item mqopts_agilent_34405a[] = {
 108         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, },
 109         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, },
 110         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, },
 111         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, },
 112         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, },
 113         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, },
 114         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP ", NO_DFLT_PREC, },
 115         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, },
 116         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP ", NO_DFLT_PREC, },
 117         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, },
 118 };
 119
 120 static const struct mqopt_item mqopts_agilent_34401a[] = {
 121         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, },
 122         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, },
 123         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, },
 124         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, },
 125         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, },
 126         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES ", NO_DFLT_PREC, },
 127         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, },
 128         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, },
 129         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, },
 130         { SR_MQ_TIME, 0, "PER", "PER ", NO_DFLT_PREC, },
 131 };
 132
 133 static const struct mqopt_item mqopts_gwinstek_gdm8200a[] = {
 134         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "01", NO_DFLT_PREC, },
 135         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "02", NO_DFLT_PREC, },
 136         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "03", NO_DFLT_PREC, },
 137         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "04", NO_DFLT_PREC, },
 138         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "05", NO_DFLT_PREC, }, /* mA */
 139         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "06", NO_DFLT_PREC, }, /* mA */
 140         { SR_MQ_RESISTANCE, 0, "RES", "07", NO_DFLT_PREC, },
 141         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "16", NO_DFLT_PREC, },
 142         { SR_MQ_CONTINUITY, 0, "CONT", "13", -1, },
 143         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "17", -4, },
 144         { SR_MQ_TEMPERATURE, 0, "TEMP", "09", NO_DFLT_PREC, }, /* Celsius */
 145         { SR_MQ_TEMPERATURE, 0, "TEMP", "15", NO_DFLT_PREC, }, /* Fahrenheit */
 146         { SR_MQ_FREQUENCY, 0, "FREQ", "08", NO_DFLT_PREC, },
 147         { SR_MQ_TIME, 0, "PER", "14", NO_DFLT_PREC, },
 148 };
 149
 150 static const struct mqopt_item mqopts_gwinstek_gdm906x[] = {
 151         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, },
 152         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC", NO_DFLT_PREC, },
 153         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, },
 154         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC", NO_DFLT_PREC, },
 155         { SR_MQ_RESISTANCE, 0, "RES", "RES", NO_DFLT_PREC, },
 156         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES", NO_DFLT_PREC, },
 157         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, },
 158         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, },
 159         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP", NO_DFLT_PREC, },
 160         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ", NO_DFLT_PREC, },
 161         { SR_MQ_TIME, 0, "PER", "PER", NO_DFLT_PREC, },
 162         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, },
 163 };
 164
 165 SR_PRIV const struct scpi_dmm_model models[] = {
 166         {
 167                 "Agilent", "34405A",
 168                 1, 5, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 169                 scpi_dmm_get_meas_agilent,
 170                 ARRAY_AND_SIZE(devopts_generic),
 171                 0, 0,
 172         },
 173         {
 174                 "Agilent", "34410A",
 175                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 176                 scpi_dmm_get_meas_agilent,
 177                 ARRAY_AND_SIZE(devopts_generic),
 178                 0, 0,
 179         },
 180         {
 181                 "GW", "GDM8251A",
 182                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
 183                 scpi_dmm_get_meas_gwinstek,
 184                 ARRAY_AND_SIZE(devopts_generic),
 185                 1000 * 2500, 0,
 186         },
 187         {
 188                 "GW", "GDM8255A",
 189                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
 190                 scpi_dmm_get_meas_gwinstek,
 191                 ARRAY_AND_SIZE(devopts_generic),
 192                 1000 * 2500, 0,
 193         },
 194         {
 195                 "GWInstek", "GDM9060",
 196                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
 197                 scpi_dmm_get_meas_agilent,
 198                 ARRAY_AND_SIZE(devopts_generic),
 199                 0, 0,
 200         },
 201         {
 202                 "GWInstek", "GDM9061",
 203                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
 204                 scpi_dmm_get_meas_agilent,
 205                 ARRAY_AND_SIZE(devopts_generic),
 206                 0, 0,
 207         },
 208         {
 209                 "HP", "34401A",
 210                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34401a),
 211                 scpi_dmm_get_meas_agilent,
 212                 ARRAY_AND_SIZE(devopts_generic),
 213                 /* 34401A: typ. 1020ms for AC readings (default is 1000ms). */
 214                 1000 * 1500, 0,
 215         },
 216         {
 217                 "Keysight", "34465A",
 218                 1, 5, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 219                 scpi_dmm_get_meas_agilent,
 220                 ARRAY_AND_SIZE(devopts_generic),
 221                 0, 0,
 222         },
 223 };
 224
 225 static const struct scpi_dmm_model *is_compatible(const char *vendor, const char *model)
 226 {
 227         size_t i;
 228         const struct scpi_dmm_model *entry;
 229
 230         for (i = 0; i < ARRAY_SIZE(models); i++) {
 231                 entry = &models[i];
 232                 if (!entry->vendor || !entry->model)
 233                         continue;
 234                 if (strcmp(vendor, entry->vendor) != 0)
 235                         continue;
 236                 if (strcmp(model, entry->model) != 0)
 237                         continue;
 238                 return entry;
 239         }
 240
 241         return NULL;
 242 }
 243
 244 /*
 245  * Some devices (such as Owon XDM2041) do not support the standard
 246  * OPeration Complete? command. This function tests the command with
 247  * a short timeout, and returns TRUE if any reply (busy or not) is received.
 248  */
 249 static gboolean probe_opc_support(struct sr_scpi_dev_inst *scpi)
 250 {
 251         gboolean result;
 252         GString *response;
 253
 254         response = g_string_sized_new(128);
 255         result = TRUE;
 256         if (sr_scpi_get_data(scpi, SCPI_CMD_OPC, &response) != SR_OK)
 257                 result = FALSE;
 258         g_string_free(response, TRUE);
 259
 260         return result;
 261 }
 262
 263 static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
 264 {
 265         struct sr_scpi_hw_info *hw_info;
 266         int ret;
 267         const char *vendor;
 268         const struct scpi_dmm_model *model;
 269         struct sr_dev_inst *sdi;
 270         struct dev_context *devc;
 271         size_t i;
 272         gchar *channel_name;
 273         const char *command;
 274
 275         if (!probe_opc_support(scpi))
 276                 scpi->no_opc_command = TRUE;
 277
 278         scpi_dmm_cmd_delay(scpi);
 279         ret = sr_scpi_get_hw_id(scpi, &hw_info);
 280         if (ret != SR_OK) {
 281                 sr_info("Could not get IDN response.");
 282                 return NULL;
 283         }
 284         vendor = sr_vendor_alias(hw_info->manufacturer);
 285         model = is_compatible(vendor, hw_info->model);
 286         if (!model) {
 287                 sr_scpi_hw_info_free(hw_info);
 288                 return NULL;
 289         }
 290
 291         sdi = g_malloc0(sizeof(*sdi));
 292         sdi->vendor = g_strdup(hw_info->manufacturer);
 293         sdi->model = g_strdup(hw_info->model);
 294         sdi->version = g_strdup(hw_info->firmware_version);
 295         sdi->serial_num = g_strdup(hw_info->serial_number);
 296         sdi->conn = scpi;
 297         sdi->driver = &scpi_dmm_driver_info;
 298         sdi->inst_type = SR_INST_SCPI;
 299         ret = sr_scpi_connection_id(scpi, &sdi->connection_id);
 300         if (ret != SR_OK) {
 301                 g_free(sdi->connection_id);
 302                 sdi->connection_id = NULL;
 303         }
 304         sr_scpi_hw_info_free(hw_info);
 305         if (model->read_timeout_us)  /* non-default read timeout */
 306                 scpi->read_timeout_us = model->read_timeout_us;
 307         devc = g_malloc0(sizeof(*devc));
 308         sdi->priv = devc;
 309         devc->num_channels = model->num_channels;
 310         devc->cmdset = model->cmdset;
 311         devc->model = model;
 312
 313         for (i = 0; i < devc->num_channels; i++) {
 314                 channel_name = g_strdup_printf("P%zu", i + 1);
 315                 sr_channel_new(sdi, 0, SR_CHANNEL_ANALOG, TRUE, channel_name);
 316         }
 317
 318         /*
 319          * If device has DMM_CMD_SETUP_LOCAL command, send it now. To avoid
 320          * leaving device in remote mode (if only a "scan" is run).
 321          */
 322         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
 323         if (command && *command) {
 324                 scpi_dmm_cmd_delay(scpi);
 325                 sr_scpi_send(scpi, command);
 326         }
 327
 328         return sdi;
 329 }
 330
 331 static GSList *scan(struct sr_dev_driver *di, GSList *options)
 332 {
 333         return sr_scpi_scan(di->context, options, probe_device);
 334 }
 335
 336 static int dev_open(struct sr_dev_inst *sdi)
 337 {
 338         struct sr_scpi_dev_inst *scpi;
 339         int ret;
 340
 341         scpi = sdi->conn;
 342         ret = sr_scpi_open(scpi);
 343         if (ret < 0) {
 344                 sr_err("Failed to open SCPI device: %s.", sr_strerror(ret));
 345                 return SR_ERR;
 346         }
 347
 348         return SR_OK;
 349 }
 350
 351 static int dev_close(struct sr_dev_inst *sdi)
 352 {
 353         struct dev_context *devc;
 354         struct sr_scpi_dev_inst *scpi;
 355         const char *command;
 356
 357         devc = sdi->priv;
 358         scpi = sdi->conn;
 359         if (!scpi)
 360                 return SR_ERR_BUG;
 361
 362         sr_dbg("DIAG: sdi->status %d.", sdi->status - SR_ST_NOT_FOUND);
 363         if (sdi->status <= SR_ST_INACTIVE)
 364                 return SR_OK;
 365
 366         /*
 367          * If device has DMM_CMD_SETUP_LOCAL command, send it now
 368          * to avoid leaving device in remote mode.
 369          */
 370         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
 371         if (command && *command) {
 372                 scpi_dmm_cmd_delay(scpi);
 373                 sr_scpi_send(scpi, command);
 374         }
 375
 376         return sr_scpi_close(scpi);
 377 }
 378
 379 static int config_get(uint32_t key, GVariant **data,
 380         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 381 {
 382         struct dev_context *devc;
 383         enum sr_mq mq;
 384         enum sr_mqflag mqflag;
 385         GVariant *arr[2];
 386         int ret;
 387
 388         (void)cg;
 389
 390         devc = sdi->priv;
 391
 392         switch (key) {
 393         case SR_CONF_CONN:
 394                 if (!sdi || !sdi->connection_id)
 395                         return SR_ERR_NA;
 396                 *data = g_variant_new_string(sdi->connection_id);
 397                 return SR_OK;
 398         case SR_CONF_LIMIT_SAMPLES:
 399         case SR_CONF_LIMIT_MSEC:
 400                 return sr_sw_limits_config_get(&devc->limits, key, data);
 401         case SR_CONF_MEASURED_QUANTITY:
 402                 ret = scpi_dmm_get_mq(sdi, &mq, &mqflag, NULL, NULL);
 403                 if (ret != SR_OK)
 404                         return ret;
 405                 arr[0] = g_variant_new_uint32(mq);
 406                 arr[1] = g_variant_new_uint64(mqflag);
 407                 *data = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
 408                 return SR_OK;
 409         default:
 410                 return SR_ERR_NA;
 411         }
 412 }
 413
 414 static int config_set(uint32_t key, GVariant *data,
 415         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 416 {
 417         struct dev_context *devc;
 418         enum sr_mq mq;
 419         enum sr_mqflag mqflag;
 420         GVariant *tuple_child;
 421
 422         (void)cg;
 423
 424         devc = sdi->priv;
 425
 426         switch (key) {
 427         case SR_CONF_LIMIT_SAMPLES:
 428         case SR_CONF_LIMIT_MSEC:
 429                 return sr_sw_limits_config_set(&devc->limits, key, data);
 430         case SR_CONF_MEASURED_QUANTITY:
 431                 tuple_child = g_variant_get_child_value(data, 0);
 432                 mq = g_variant_get_uint32(tuple_child);
 433                 g_variant_unref(tuple_child);
 434                 tuple_child = g_variant_get_child_value(data, 1);
 435                 mqflag = g_variant_get_uint64(tuple_child);
 436                 g_variant_unref(tuple_child);
 437                 return scpi_dmm_set_mq(sdi, mq, mqflag);
 438         default:
 439                 return SR_ERR_NA;
 440         }
 441 }
 442
 443 static int config_list(uint32_t key, GVariant **data,
 444         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 445 {
 446         struct dev_context *devc;
 447         GVariant *gvar, *arr[2];
 448         GVariantBuilder gvb;
 449         size_t i;
 450
 451         (void)cg;
 452
 453         devc = sdi ? sdi->priv : NULL;
 454
 455         switch (key) {
 456         case SR_CONF_SCAN_OPTIONS:
 457         case SR_CONF_DEVICE_OPTIONS:
 458                 if (!devc)
 459                         return STD_CONFIG_LIST(key, data, sdi, cg,
 460                                 scanopts, drvopts, devopts_generic);
 461                 return std_opts_config_list(key, data, sdi, cg,
 462                         ARRAY_AND_SIZE(scanopts), ARRAY_AND_SIZE(drvopts),
 463                         devc->model->devopts, devc->model->devopts_size);
 464         case SR_CONF_MEASURED_QUANTITY:
 465                 /* TODO Use std_gvar_measured_quantities() when available. */
 466                 if (!devc)
 467                         return SR_ERR_ARG;
 468                 g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 469                 for (i = 0; i < devc->model->mqopt_size; i++) {
 470                         arr[0] = g_variant_new_uint32(devc->model->mqopts[i].mq);
 471                         arr[1] = g_variant_new_uint64(devc->model->mqopts[i].mqflag);
 472                         gvar = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
 473                         g_variant_builder_add_value(&gvb, gvar);
 474                 }
 475                 *data = g_variant_builder_end(&gvb);
 476                 return SR_OK;
 477         default:
 478                 (void)devc;
 479                 return SR_ERR_NA;
 480         }
 481 }
 482
 483 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 484 {
 485         struct sr_scpi_dev_inst *scpi;
 486         struct dev_context *devc;
 487         int ret;
 488         const struct mqopt_item *item;
 489         const char *command;
 490         char *response;
 491
 492         scpi = sdi->conn;
 493         devc = sdi->priv;
 494
 495         ret = scpi_dmm_get_mq(sdi, &devc->start_acq_mq.curr_mq,
 496                 &devc->start_acq_mq.curr_mqflag, NULL, &item);
 497         if (ret != SR_OK)
 498                 return ret;
 499
 500         /*
 501          * Query for current precision if DMM supports the command
 502          */
 503         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_QUERY_PREC);
 504         if (command && *command) {
 505                 scpi_dmm_cmd_delay(scpi);
 506                 ret = sr_scpi_get_string(scpi, command, &response);
 507                 if (ret == SR_OK) {
 508                         g_strstrip(response);
 509                         g_free(devc->precision);
 510                         devc->precision = g_strdup(response);
 511                         g_free(response);
 512                         sr_dbg("%s: Precision: '%s'", __func__, devc->precision);
 513                 } else {
 514                         sr_info("Precision query ('%s') failed: %d",
 515                                 command, ret);
 516                 }
 517         }
 518
 519         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_START_ACQ);
 520         if (command && *command) {
 521                 scpi_dmm_cmd_delay(scpi);
 522                 ret = sr_scpi_send(scpi, command);
 523                 if (ret != SR_OK)
 524                         return ret;
 525         }
 526
 527         sr_sw_limits_acquisition_start(&devc->limits);
 528         ret = std_session_send_df_header(sdi);
 529         if (ret != SR_OK)
 530                 return ret;
 531
 532         ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 10,
 533                 scpi_dmm_receive_data, (void *)sdi);
 534         if (ret != SR_OK)
 535                 return ret;
 536
 537         return SR_OK;
 538 }
 539
 540 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 541 {
 542         struct sr_scpi_dev_inst *scpi;
 543         struct dev_context *devc;
 544         const char *command;
 545
 546         scpi = sdi->conn;
 547         devc = sdi->priv;
 548
 549         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_STOP_ACQ);
 550         if (command && *command) {
 551                 scpi_dmm_cmd_delay(scpi);
 552                 (void)sr_scpi_send(scpi, command);
 553         }
 554         sr_scpi_source_remove(sdi->session, scpi);
 555
 556         std_session_send_df_end(sdi);
 557
 558         g_free(devc->precision);
 559         devc->precision = NULL;
 560
 561         return SR_OK;
 562 }
 563
 564 static struct sr_dev_driver scpi_dmm_driver_info = {
 565         .name = "scpi-dmm",
 566         .longname = "SCPI DMM",
 567         .api_version = 1,
 568         .init = std_init,
 569         .cleanup = std_cleanup,
 570         .scan = scan,
 571         .dev_list = std_dev_list,
 572         .dev_clear = std_dev_clear,
 573         .config_get = config_get,
 574         .config_set = config_set,
 575         .config_list = config_list,
 576         .dev_open = dev_open,
 577         .dev_close = dev_close,
 578         .dev_acquisition_start = dev_acquisition_start,
 579         .dev_acquisition_stop = dev_acquisition_stop,
 580         .context = NULL,
 581 };
 582 SR_REGISTER_DEV_DRIVER(scpi_dmm_driver_info);