src/hardware/scpi-dmm/api.c

   1 /*
   2  * This file is part of the libsigrok project.
   3  *
   4  * Copyright (C) 2018 Gerhard Sittig <gerhard.sittig@gmx.net>
   5  *
   6  * This program is free software: you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation, either version 3 of the License, or
   9  * (at your option) any later version.
  10  *
  11  * This program is distributed in the hope that it will be useful,
  12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  14  * GNU General Public License for more details.
  15  *
  16  * You should have received a copy of the GNU General Public License
  17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  18  */
  19
  20 #include <string.h>
  21 #include "protocol.h"
  22
  23 static struct sr_dev_driver scpi_dmm_driver_info;
  24
  25 static const uint32_t scanopts[] = {
  26         SR_CONF_CONN,
  27         SR_CONF_SERIALCOMM,
  28 };
  29
  30 static const uint32_t drvopts[] = {
  31         SR_CONF_MULTIMETER,
  32 };
  33
  34 static const uint32_t devopts_generic[] = {
  35         SR_CONF_CONTINUOUS,
  36         SR_CONF_CONN | SR_CONF_GET,
  37         SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
  38         SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
  39         SR_CONF_MEASURED_QUANTITY | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
  40 };
  41
  42 static const uint32_t devopts_generic_range[] = {
  43         SR_CONF_CONTINUOUS,
  44         SR_CONF_CONN | SR_CONF_GET,
  45         SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
  46         SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
  47         SR_CONF_MEASURED_QUANTITY | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
  48         SR_CONF_RANGE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
  49 };
  50
  51 static const struct scpi_command cmdset_agilent[] = {
  52         { DMM_CMD_SETUP_REMOTE, "\n", },
  53         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  54         { DMM_CMD_QUERY_FUNC, "CONF?", },
  55         { DMM_CMD_START_ACQ, "INIT", },
  56         { DMM_CMD_STOP_ACQ, "ABORT", },
  57         { DMM_CMD_QUERY_VALUE, "READ?", },
  58         { DMM_CMD_QUERY_PREC, "CONF?", },
  59         { DMM_CMD_QUERY_RANGE_AUTO, "%s:RANGE:AUTO?", },
  60         { DMM_CMD_QUERY_RANGE, "%s:RANGE?", },
  61         { DMM_CMD_SETUP_RANGE_AUTO, "%s:RANGE:AUTO ON", },
  62         { DMM_CMD_SETUP_RANGE, "%s:RANGE %s", },
  63         ALL_ZERO,
  64 };
  65
  66 /*
  67  * cmdset_hp is used for the 34401A, which was added to this code after the
  68  * 34405A and 34465A. It differs in starting the measurement with INIT: using
  69  * MEAS without a trailing '?' (as used for the 34405A) is not valid for the
  70  * 34401A and gives an error.
  71  * I'm surprised the same instruction sequence doesn't work and INIT may
  72  * work for both, but I don't have the others to re-test.
  73  *
  74  * cmdset_hp also works well for the 34410A, using cmdset_agilent throws an
  75  * error on 'MEAS' without a '?'.
  76  *
  77  * On the 34401A,
  78  *  MEAS <optional parameters> ? configures, arms, triggers and waits
  79  *       for a reading
  80  *  CONF <parameters> configures
  81  *  INIT prepares for triggering (trigger mode is not set, assumed
  82  *       internal - external might time out)
  83  *  *OPC waits for completion, and
  84  *  READ? retrieves the result
  85  */
  86 static const struct scpi_command cmdset_hp[] = {
  87         { DMM_CMD_SETUP_REMOTE, "\n", },
  88         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
  89         { DMM_CMD_QUERY_FUNC, "CONF?", },
  90         { DMM_CMD_START_ACQ, "INIT", },
  91         { DMM_CMD_STOP_ACQ, "ABORT", },
  92         { DMM_CMD_QUERY_VALUE, "READ?", },
  93         { DMM_CMD_QUERY_PREC, "CONF?", },
  94         ALL_ZERO,
  95 };
  96
  97 static const struct scpi_command cmdset_gwinstek[] = {
  98         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
  99         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
 100         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
 101         { DMM_CMD_QUERY_FUNC, "CONF:STAT:FUNC?", },
 102         { DMM_CMD_START_ACQ, "*CLS;SYST:REM", },
 103         { DMM_CMD_QUERY_VALUE, "VAL1?", },
 104         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
 105         ALL_ZERO,
 106 };
 107
 108 static const struct scpi_command cmdset_gwinstek_906x[] = {
 109         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
 110         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
 111         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
 112         { DMM_CMD_QUERY_FUNC, "CONF?", },
 113         { DMM_CMD_START_ACQ, "INIT", },
 114         { DMM_CMD_STOP_ACQ, "ABORT", },
 115         { DMM_CMD_QUERY_VALUE, "VAL1?", },
 116         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
 117         ALL_ZERO,
 118 };
 119
 120 static const struct scpi_command cmdset_owon[] = {
 121         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
 122         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
 123         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
 124         { DMM_CMD_QUERY_FUNC, "FUNC?", },
 125         { DMM_CMD_QUERY_VALUE, "MEAS1?", },
 126         ALL_ZERO,
 127 };
 128
 129 static const struct mqopt_item mqopts_agilent_34405a[] = {
 130         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
 131         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, FLAGS_NONE, },
 132         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
 133         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, FLAGS_NONE, },
 134         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, FLAGS_NONE, },
 135         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
 136         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP ", NO_DFLT_PREC, FLAGS_NONE, },
 137         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
 138         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP ", NO_DFLT_PREC, FLAGS_NONE, },
 139         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, FLAGS_NONE, },
 140 };
 141
 142 static const struct mqopt_item mqopts_agilent_34401a[] = {
 143         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
 144         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, FLAGS_NONE, },
 145         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
 146         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, FLAGS_NONE, },
 147         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, FLAGS_NONE, },
 148         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES ", NO_DFLT_PREC, FLAGS_NONE, },
 149         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
 150         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
 151         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, FLAGS_NONE, },
 152         { SR_MQ_TIME, 0, "PER", "PER ", NO_DFLT_PREC, FLAGS_NONE, },
 153 };
 154
 155 static const struct mqopt_item mqopts_gwinstek_gdm8200a[] = {
 156         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "01", NO_DFLT_PREC, FLAGS_NONE, },
 157         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "02", NO_DFLT_PREC, FLAGS_NONE, },
 158         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "03", NO_DFLT_PREC, FLAGS_NONE, },
 159         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "04", NO_DFLT_PREC, FLAGS_NONE, },
 160         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "05", NO_DFLT_PREC, FLAGS_NONE, }, /* mA */
 161         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "06", NO_DFLT_PREC, FLAGS_NONE, }, /* mA */
 162         { SR_MQ_RESISTANCE, 0, "RES", "07", NO_DFLT_PREC, FLAGS_NONE, },
 163         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "16", NO_DFLT_PREC, FLAGS_NONE, },
 164         { SR_MQ_CONTINUITY, 0, "CONT", "13", -1, FLAGS_NONE, },
 165         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "17", -4, FLAGS_NONE, },
 166         { SR_MQ_TEMPERATURE, 0, "TEMP", "09", NO_DFLT_PREC, FLAGS_NONE, }, /* Celsius */
 167         { SR_MQ_TEMPERATURE, 0, "TEMP", "15", NO_DFLT_PREC, FLAGS_NONE, }, /* Fahrenheit */
 168         { SR_MQ_FREQUENCY, 0, "FREQ", "08", NO_DFLT_PREC, FLAGS_NONE, },
 169         { SR_MQ_TIME, 0, "PER", "14", NO_DFLT_PREC, FLAGS_NONE, },
 170 };
 171
 172 static const struct mqopt_item mqopts_gwinstek_gdm906x[] = {
 173         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
 174         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC", NO_DFLT_PREC, FLAGS_NONE, },
 175         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
 176         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC", NO_DFLT_PREC, FLAGS_NONE, },
 177         { SR_MQ_RESISTANCE, 0, "RES", "RES", NO_DFLT_PREC, FLAGS_NONE, },
 178         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES", NO_DFLT_PREC, FLAGS_NONE, },
 179         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
 180         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
 181         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP", NO_DFLT_PREC, FLAGS_NONE, },
 182         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ", NO_DFLT_PREC, FLAGS_NONE, },
 183         { SR_MQ_TIME, 0, "PER", "PER", NO_DFLT_PREC, FLAGS_NONE, },
 184         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, FLAGS_NONE, },
 185 };
 186
 187 static const struct mqopt_item mqopts_owon_xdm2041[] = {
 188         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT AC", NO_DFLT_PREC, FLAGS_NONE, },
 189         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT", NO_DFLT_PREC, FLAGS_NONE, },
 190         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR AC", NO_DFLT_PREC, FLAGS_NONE, },
 191         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR", NO_DFLT_PREC, FLAGS_NONE, },
 192         { SR_MQ_RESISTANCE, 0, "RES", "RES", NO_DFLT_PREC, FLAGS_NONE, },
 193         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES", NO_DFLT_PREC, FLAGS_NONE, },
 194         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
 195         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
 196         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP", NO_DFLT_PREC, FLAGS_NONE, },
 197         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ", NO_DFLT_PREC, FLAGS_NONE, },
 198         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, FLAGS_NONE, },
 199 };
 200
 201 SR_PRIV const struct scpi_dmm_model models[] = {
 202         {
 203                 "Agilent", "34405A",
 204                 1, 5, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 205                 scpi_dmm_get_meas_agilent,
 206                 ARRAY_AND_SIZE(devopts_generic_range),
 207                 0, 0, FALSE,
 208                 scpi_dmm_get_range_text, scpi_dmm_set_range_from_text, NULL,
 209         },
 210         {
 211                 "Agilent", "34410A",
 212                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 213                 scpi_dmm_get_meas_agilent,
 214                 ARRAY_AND_SIZE(devopts_generic),
 215                 0, 0, FALSE,
 216                 NULL, NULL, NULL,
 217         },
 218         {
 219                 "GW", "GDM8251A",
 220                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
 221                 scpi_dmm_get_meas_gwinstek,
 222                 ARRAY_AND_SIZE(devopts_generic),
 223                 1000 * 2500, 0, FALSE,
 224                 NULL, NULL, NULL,
 225         },
 226         {
 227                 "GW", "GDM8255A",
 228                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
 229                 scpi_dmm_get_meas_gwinstek,
 230                 ARRAY_AND_SIZE(devopts_generic),
 231                 1000 * 2500, 0, FALSE,
 232                 NULL, NULL, NULL,
 233         },
 234         {
 235                 "GWInstek", "GDM9060",
 236                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
 237                 scpi_dmm_get_meas_agilent,
 238                 ARRAY_AND_SIZE(devopts_generic),
 239                 0, 0, FALSE,
 240                 NULL, NULL, NULL,
 241         },
 242         {
 243                 "GWInstek", "GDM9061",
 244                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
 245                 scpi_dmm_get_meas_agilent,
 246                 ARRAY_AND_SIZE(devopts_generic),
 247                 0, 0, FALSE,
 248                 NULL, NULL, NULL,
 249         },
 250         {
 251                 "HP", "34401A",
 252                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34401a),
 253                 scpi_dmm_get_meas_agilent,
 254                 ARRAY_AND_SIZE(devopts_generic),
 255                 /* 34401A: typ. 1020ms for AC readings (default is 1000ms). */
 256                 1000 * 1500, 0, FALSE,
 257                 NULL, NULL, NULL,
 258         },
 259         {
 260                 "Keysight", "34465A",
 261                 1, 6, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
 262                 scpi_dmm_get_meas_agilent,
 263                 ARRAY_AND_SIZE(devopts_generic_range),
 264                 0, 0, FALSE,
 265                 scpi_dmm_get_range_text, scpi_dmm_set_range_from_text, NULL,
 266         },
 267         {
 268                 "OWON", "XDM2041",
 269                 1, 5, cmdset_owon, ARRAY_AND_SIZE(mqopts_owon_xdm2041),
 270                 scpi_dmm_get_meas_gwinstek,
 271                 ARRAY_AND_SIZE(devopts_generic),
 272                 0, 1e9, TRUE,
 273                 NULL, NULL, NULL,
 274         },
 275 };
 276
 277 static const struct scpi_dmm_model *is_compatible(const char *vendor, const char *model)
 278 {
 279         size_t i;
 280         const struct scpi_dmm_model *entry;
 281
 282         for (i = 0; i < ARRAY_SIZE(models); i++) {
 283                 entry = &models[i];
 284                 if (!entry->vendor || !entry->model)
 285                         continue;
 286                 if (strcmp(vendor, entry->vendor) != 0)
 287                         continue;
 288                 if (strcmp(model, entry->model) != 0)
 289                         continue;
 290                 return entry;
 291         }
 292
 293         return NULL;
 294 }
 295
 296 /*
 297  * Some devices (such as Owon XDM2041) do not support the standard
 298  * OPeration Complete? command. This function tests the command with
 299  * a short timeout, and returns TRUE if any reply (busy or not) is received.
 300  */
 301 static gboolean probe_opc_support(struct sr_scpi_dev_inst *scpi)
 302 {
 303         gboolean result;
 304         GString *response;
 305
 306         response = g_string_sized_new(128);
 307         result = TRUE;
 308         if (sr_scpi_get_data(scpi, SCPI_CMD_OPC, &response) != SR_OK)
 309                 result = FALSE;
 310         g_string_free(response, TRUE);
 311
 312         return result;
 313 }
 314
 315 static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
 316 {
 317         struct sr_scpi_hw_info *hw_info;
 318         int ret;
 319         const char *vendor;
 320         const struct scpi_dmm_model *model;
 321         struct sr_dev_inst *sdi;
 322         struct dev_context *devc;
 323         size_t i;
 324         gchar *channel_name;
 325         const char *command;
 326
 327         ret = sr_scpi_get_hw_id(scpi, &hw_info);
 328         if (ret != SR_OK) {
 329                 sr_info("Could not get IDN response.");
 330                 return NULL;
 331         }
 332         vendor = sr_vendor_alias(hw_info->manufacturer);
 333         model = is_compatible(vendor, hw_info->model);
 334         if (!model) {
 335                 sr_scpi_hw_info_free(hw_info);
 336                 return NULL;
 337         }
 338
 339         if (model->check_opc && !probe_opc_support(scpi))
 340                 scpi->no_opc_command = TRUE;
 341
 342         sdi = g_malloc0(sizeof(*sdi));
 343         sdi->vendor = g_strdup(hw_info->manufacturer);
 344         sdi->model = g_strdup(hw_info->model);
 345         sdi->version = g_strdup(hw_info->firmware_version);
 346         sdi->serial_num = g_strdup(hw_info->serial_number);
 347         sdi->conn = scpi;
 348         sdi->driver = &scpi_dmm_driver_info;
 349         sdi->inst_type = SR_INST_SCPI;
 350         ret = sr_scpi_connection_id(scpi, &sdi->connection_id);
 351         if (ret != SR_OK) {
 352                 g_free(sdi->connection_id);
 353                 sdi->connection_id = NULL;
 354         }
 355         sr_scpi_hw_info_free(hw_info);
 356         if (model->read_timeout_us)  /* non-default read timeout */
 357                 scpi->read_timeout_us = model->read_timeout_us;
 358         devc = g_malloc0(sizeof(*devc));
 359         sdi->priv = devc;
 360         devc->num_channels = model->num_channels;
 361         devc->cmdset = model->cmdset;
 362         devc->model = model;
 363
 364         for (i = 0; i < devc->num_channels; i++) {
 365                 channel_name = g_strdup_printf("P%zu", i + 1);
 366                 sr_channel_new(sdi, 0, SR_CHANNEL_ANALOG, TRUE, channel_name);
 367         }
 368
 369         /*
 370          * If device has DMM_CMD_SETUP_LOCAL command, send it now. To avoid
 371          * leaving device in remote mode (if only a "scan" is run).
 372          */
 373         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
 374         if (command && *command) {
 375                 scpi_dmm_cmd_delay(scpi);
 376                 sr_scpi_send(scpi, command);
 377         }
 378
 379         return sdi;
 380 }
 381
 382 static GSList *scan(struct sr_dev_driver *di, GSList *options)
 383 {
 384         return sr_scpi_scan(di->context, options, probe_device);
 385 }
 386
 387 static int dev_open(struct sr_dev_inst *sdi)
 388 {
 389         struct sr_scpi_dev_inst *scpi;
 390         int ret;
 391
 392         scpi = sdi->conn;
 393         ret = sr_scpi_open(scpi);
 394         if (ret < 0) {
 395                 sr_err("Failed to open SCPI device: %s.", sr_strerror(ret));
 396                 return SR_ERR;
 397         }
 398
 399         return SR_OK;
 400 }
 401
 402 static int dev_close(struct sr_dev_inst *sdi)
 403 {
 404         struct dev_context *devc;
 405         struct sr_scpi_dev_inst *scpi;
 406         const char *command;
 407
 408         devc = sdi->priv;
 409         scpi = sdi->conn;
 410         if (!scpi)
 411                 return SR_ERR_BUG;
 412
 413         sr_dbg("DIAG: sdi->status %d.", sdi->status - SR_ST_NOT_FOUND);
 414         if (sdi->status <= SR_ST_INACTIVE)
 415                 return SR_OK;
 416
 417         /*
 418          * If device has DMM_CMD_SETUP_LOCAL command, send it now
 419          * to avoid leaving device in remote mode.
 420          */
 421         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
 422         if (command && *command) {
 423                 scpi_dmm_cmd_delay(scpi);
 424                 sr_scpi_send(scpi, command);
 425         }
 426
 427         return sr_scpi_close(scpi);
 428 }
 429
 430 static int config_get(uint32_t key, GVariant **data,
 431         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 432 {
 433         struct dev_context *devc;
 434         enum sr_mq mq;
 435         enum sr_mqflag mqflag;
 436         GVariant *arr[2];
 437         int ret;
 438         const char *range;
 439
 440         (void)cg;
 441
 442         devc = sdi->priv;
 443
 444         switch (key) {
 445         case SR_CONF_CONN:
 446                 if (!sdi || !sdi->connection_id)
 447                         return SR_ERR_NA;
 448                 *data = g_variant_new_string(sdi->connection_id);
 449                 return SR_OK;
 450         case SR_CONF_LIMIT_SAMPLES:
 451         case SR_CONF_LIMIT_MSEC:
 452                 return sr_sw_limits_config_get(&devc->limits, key, data);
 453         case SR_CONF_MEASURED_QUANTITY:
 454                 ret = scpi_dmm_get_mq(sdi, &mq, &mqflag, NULL, NULL);
 455                 if (ret != SR_OK)
 456                         return ret;
 457                 arr[0] = g_variant_new_uint32(mq);
 458                 arr[1] = g_variant_new_uint64(mqflag);
 459                 *data = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
 460                 return SR_OK;
 461         case SR_CONF_RANGE:
 462                 if (!devc || !devc->model->get_range_text)
 463                         return SR_ERR_NA;
 464                 range = devc->model->get_range_text(sdi);
 465                 if (!range || !*range)
 466                         return SR_ERR_NA;
 467                 *data = g_variant_new_string(range);
 468                 return SR_OK;
 469         default:
 470                 return SR_ERR_NA;
 471         }
 472 }
 473
 474 static int config_set(uint32_t key, GVariant *data,
 475         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 476 {
 477         struct dev_context *devc;
 478         enum sr_mq mq;
 479         enum sr_mqflag mqflag;
 480         GVariant *tuple_child;
 481         const char *range;
 482
 483         (void)cg;
 484
 485         devc = sdi->priv;
 486
 487         switch (key) {
 488         case SR_CONF_LIMIT_SAMPLES:
 489         case SR_CONF_LIMIT_MSEC:
 490                 return sr_sw_limits_config_set(&devc->limits, key, data);
 491         case SR_CONF_MEASURED_QUANTITY:
 492                 tuple_child = g_variant_get_child_value(data, 0);
 493                 mq = g_variant_get_uint32(tuple_child);
 494                 g_variant_unref(tuple_child);
 495                 tuple_child = g_variant_get_child_value(data, 1);
 496                 mqflag = g_variant_get_uint64(tuple_child);
 497                 g_variant_unref(tuple_child);
 498                 return scpi_dmm_set_mq(sdi, mq, mqflag);
 499         case SR_CONF_RANGE:
 500                 if (!devc || !devc->model->set_range_from_text)
 501                         return SR_ERR_NA;
 502                 range = g_variant_get_string(data, NULL);
 503                 return devc->model->set_range_from_text(sdi, range);
 504         default:
 505                 return SR_ERR_NA;
 506         }
 507 }
 508
 509 static int config_list(uint32_t key, GVariant **data,
 510         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 511 {
 512         struct dev_context *devc;
 513         GVariant *gvar, *arr[2];
 514         GVariantBuilder gvb;
 515         size_t i;
 516
 517         (void)cg;
 518
 519         devc = sdi ? sdi->priv : NULL;
 520
 521         switch (key) {
 522         case SR_CONF_SCAN_OPTIONS:
 523         case SR_CONF_DEVICE_OPTIONS:
 524                 if (!devc)
 525                         return STD_CONFIG_LIST(key, data, sdi, cg,
 526                                 scanopts, drvopts, devopts_generic);
 527                 return std_opts_config_list(key, data, sdi, cg,
 528                         ARRAY_AND_SIZE(scanopts), ARRAY_AND_SIZE(drvopts),
 529                         devc->model->devopts, devc->model->devopts_size);
 530         case SR_CONF_MEASURED_QUANTITY:
 531                 /* TODO Use std_gvar_measured_quantities() when available. */
 532                 if (!devc)
 533                         return SR_ERR_ARG;
 534                 g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 535                 for (i = 0; i < devc->model->mqopt_size; i++) {
 536                         arr[0] = g_variant_new_uint32(devc->model->mqopts[i].mq);
 537                         arr[1] = g_variant_new_uint64(devc->model->mqopts[i].mqflag);
 538                         gvar = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
 539                         g_variant_builder_add_value(&gvb, gvar);
 540                 }
 541                 *data = g_variant_builder_end(&gvb);
 542                 return SR_OK;
 543         case SR_CONF_RANGE:
 544                 if (!devc || !devc->model->get_range_text_list)
 545                         return SR_ERR_NA;
 546                 *data = devc->model->get_range_text_list(sdi);
 547                 return SR_OK;
 548         default:
 549                 (void)devc;
 550                 return SR_ERR_NA;
 551         }
 552 }
 553
 554 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 555 {
 556         struct sr_scpi_dev_inst *scpi;
 557         struct dev_context *devc;
 558         int ret;
 559         const struct mqopt_item *item;
 560         const char *command;
 561         char *response;
 562
 563         scpi = sdi->conn;
 564         devc = sdi->priv;
 565
 566         ret = scpi_dmm_get_mq(sdi, &devc->start_acq_mq.curr_mq,
 567                 &devc->start_acq_mq.curr_mqflag, NULL, &item);
 568         if (ret != SR_OK)
 569                 return ret;
 570
 571         /*
 572          * Query for current precision if DMM supports the command
 573          */
 574         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_QUERY_PREC);
 575         if (command && *command) {
 576                 scpi_dmm_cmd_delay(scpi);
 577                 ret = sr_scpi_get_string(scpi, command, &response);
 578                 if (ret == SR_OK) {
 579                         g_strstrip(response);
 580                         g_free(devc->precision);
 581                         devc->precision = g_strdup(response);
 582                         g_free(response);
 583                         sr_dbg("%s: Precision: '%s'", __func__, devc->precision);
 584                 } else {
 585                         sr_info("Precision query ('%s') failed: %d",
 586                                 command, ret);
 587                 }
 588         }
 589
 590         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_START_ACQ);
 591         if (command && *command) {
 592                 scpi_dmm_cmd_delay(scpi);
 593                 ret = sr_scpi_send(scpi, command);
 594                 if (ret != SR_OK)
 595                         return ret;
 596         }
 597
 598         sr_sw_limits_acquisition_start(&devc->limits);
 599         ret = std_session_send_df_header(sdi);
 600         if (ret != SR_OK)
 601                 return ret;
 602
 603         ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 10,
 604                 scpi_dmm_receive_data, (void *)sdi);
 605         if (ret != SR_OK)
 606                 return ret;
 607
 608         return SR_OK;
 609 }
 610
 611 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 612 {
 613         struct sr_scpi_dev_inst *scpi;
 614         struct dev_context *devc;
 615         const char *command;
 616
 617         scpi = sdi->conn;
 618         devc = sdi->priv;
 619
 620         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_STOP_ACQ);
 621         if (command && *command) {
 622                 scpi_dmm_cmd_delay(scpi);
 623                 (void)sr_scpi_send(scpi, command);
 624         }
 625         sr_scpi_source_remove(sdi->session, scpi);
 626
 627         std_session_send_df_end(sdi);
 628
 629         g_free(devc->precision);
 630         devc->precision = NULL;
 631
 632         return SR_OK;
 633 }
 634
 635 static struct sr_dev_driver scpi_dmm_driver_info = {
 636         .name = "scpi-dmm",
 637         .longname = "SCPI DMM",
 638         .api_version = 1,
 639         .init = std_init,
 640         .cleanup = std_cleanup,
 641         .scan = scan,
 642         .dev_list = std_dev_list,
 643         .dev_clear = std_dev_clear,
 644         .config_get = config_get,
 645         .config_set = config_set,
 646         .config_list = config_list,
 647         .dev_open = dev_open,
 648         .dev_close = dev_close,
 649         .dev_acquisition_start = dev_acquisition_start,
 650         .dev_acquisition_stop = dev_acquisition_stop,
 651         .context = NULL,
 652 };
 653 SR_REGISTER_DEV_DRIVER(scpi_dmm_driver_info);