From: Gerhard Sittig <redacted>
Date: Fri, 9 Feb 2018 18:14:31 +0000 (+0100)
Subject: manson-hcs-3xxx: fix potential NULL dereference
X-Git-Url: https://sigrok.org/gitweb/?a=commitdiff_plain;h=4072d5b42fdbafe3866584c7405023c361459a40;hp=f62c2ad65d3c2e20eba512d6460c9c48e17cca08;p=libsigrok.git

manson-hcs-3xxx: fix potential NULL dereference

Check pointers' validity before dereferencing them.

This was reported by clang's scan-build.
---

diff --git a/src/hardware/manson-hcs-3xxx/api.c b/src/hardware/manson-hcs-3xxx/api.c
index 92240cea..765d9abc 100644
--- a/src/hardware/manson-hcs-3xxx/api.c
+++ b/src/hardware/manson-hcs-3xxx/api.c
@@ -281,10 +281,14 @@ static int config_list(uint32_t key, GVariant **data,
 	case SR_CONF_DEVICE_OPTIONS:
 		return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts);
 	case SR_CONF_VOLTAGE_TARGET:
+		if (!devc || !devc->model)
+			return SR_ERR_ARG;
 		a = devc->model->voltage;
 		*data = std_gvar_min_max_step(a[0], devc->voltage_max_device, a[2]);
 		break;
 	case SR_CONF_CURRENT_LIMIT:
+		if (!devc || !devc->model)
+			return SR_ERR_ARG;
 		a = devc->model->current;
 		*data = std_gvar_min_max_step(a[0], devc->current_max_device, a[2]);
 		break;