From: Bert Vermeulen <redacted>
Date: Thu, 2 Aug 2012 23:04:05 +0000 (+0200)
Subject: sr: drivers should remove their sources from the session when done
X-Git-Tag: dsupstream~739
X-Git-Url: https://sigrok.org/gitweb/?a=commitdiff_plain;h=2cbeb2b7fb5791dd765ab6eee180ee053cc20b1c;hp=310e9e9be4e4421f0171d47dfdb5fc299d6f749c;p=libsigrok.git

sr: drivers should remove their sources from the session when done
---

diff --git a/libsigrok.h b/libsigrok.h
index eda16c21..306c2057 100644
--- a/libsigrok.h
+++ b/libsigrok.h
@@ -509,7 +509,6 @@ struct sr_session {
 	/* list of sr_receive_data_callback_t */
 	GSList *datafeed_callbacks;
 	GTimeVal starttime;
-	gboolean running;
 
 	unsigned int num_sources;
 
diff --git a/session.c b/session.c
index 23e4e495..b1e3ebbb 100644
--- a/session.c
+++ b/session.c
@@ -205,27 +205,25 @@ SR_API int sr_session_datafeed_callback_add(sr_datafeed_callback_t cb)
 	return SR_OK;
 }
 
-/**
- * TODO.
- */
 static int sr_session_run_poll(void)
 {
 	unsigned int i;
 	int ret;
 
-	while (session->running) {
-		ret = g_poll(session->pollfds, session->num_sources, session->source_timeout);
-
+	while (session->num_sources > 0) {
+		ret = g_poll(session->pollfds, session->num_sources,
+				session->source_timeout);
 		for (i = 0; i < session->num_sources; i++) {
 			if (session->pollfds[i].revents > 0 || (ret == 0
 				&& session->source_timeout == session->sources[i].timeout)) {
 				/*
 				 * Invoke the source's callback on an event,
-				 * or if the poll timeout out and this source
+				 * or if the poll timed out and this source
 				 * asked for that timeout.
 				 */
-				if (!session->sources[i].cb(session->pollfds[i].fd, session->pollfds[i].revents,
-						  session->sources[i].cb_data))
+				if (!session->sources[i].cb(session->pollfds[i].fd,
+						session->pollfds[i].revents,
+						session->sources[i].cb_data))
 					sr_session_source_remove(session->sources[i].poll_object);
 			}
 		}
@@ -298,12 +296,11 @@ SR_API int sr_session_run(void)
 	}
 
 	sr_info("session: running");
-	session->running = TRUE;
 
 	/* Do we have real sources? */
 	if (session->num_sources == 1 && session->pollfds[0].fd == -1) {
 		/* Dummy source, freewheel over it. */
-		while (session->running)
+		while (session->num_sources)
 			session->sources[0].cb(-1, 0, session->sources[0].cb_data);
 	} else {
 		/* Real sources, use g_poll() main loop. */
@@ -346,7 +343,6 @@ SR_API int sr_session_stop(void)
 	}
 
 	sr_info("session: stopping");
-	session->running = FALSE;
 
 	for (l = session->devs; l; l = l->next) {
 		sdi = l->data;