From: Gerhard Sittig <redacted>
Date: Mon, 27 Jul 2020 15:57:04 +0000 (+0200)
Subject: sle44xx: remove incomplete Python output for now
X-Git-Url: https://sigrok.org/gitweb/?a=commitdiff_plain;h=0411c41c5787da0e6fab7f31503fffb4fdddce1b;p=libsigrokdecode.git

sle44xx: remove incomplete Python output for now

The current implementation exclusively communicated the 'RESET'
condition but nothing else. Remove the Python output from the decoder,
it's easy to re-introduce when a complete implementation materializes.
There also is no known recipient of SLE44xx Python output right now
which would expect to see even the currently implemented subset.
---

diff --git a/decoders/sle44xx/pd.py b/decoders/sle44xx/pd.py
index a1cd8f8..0bc3ec7 100644
--- a/decoders/sle44xx/pd.py
+++ b/decoders/sle44xx/pd.py
@@ -19,22 +19,6 @@
 
 import sigrokdecode as srd
 
-'''
-OUTPUT_PYTHON format:
-
-Packet:
-[<ptype>, <pdata>]
-
-<ptype>:
- - 'RESET'  (Reset/Abort condition)
- - 'ATR'    (ATR data from card)
- - 'CMD'    (Command from reader)
- - 'DATA'   (Data from card)
-
-<pdata> is the data to/from the card
-For 'RESET' <pdata> is None.
-'''
-
 # CMD: [annotation-type-index, long annotation, short annotation]
 proto = {
     'RESET':           [0, 'Reset',         'R'],
@@ -51,7 +35,7 @@ class Decoder(srd.Decoder):
     desc = 'SLE 4418/28/32/42 memory card serial protocol'
     license = 'gplv2+'
     inputs = ['logic']
-    outputs = ['sle44xx']
+    outputs = []
     tags = ['Memory']
     channels = (
         {'id': 'rst', 'name': 'RST', 'desc': 'Reset line'},
@@ -89,23 +73,18 @@ class Decoder(srd.Decoder):
             self.samplerate = value
 
     def start(self):
-        self.out_python = self.register(srd.OUTPUT_PYTHON)
         self.out_ann = self.register(srd.OUTPUT_ANN)
         self.out_binary = self.register(srd.OUTPUT_BINARY)
 
     def putx(self, data):
         self.put(self.ss, self.es, self.out_ann, data)
 
-    def putp(self, data):
-        self.put(self.ss, self.es, self.out_python, data)
-
     def putb(self, data):
         self.put(self.ss, self.es, self.out_binary, data)
 
     def handle_reset(self, pins):
         self.ss, self.es = self.samplenum, self.samplenum
         cmd = 'RESET' # No need to set the global self.cmd as this command is atomic
-        self.putp([cmd, None])
         self.putx([proto[cmd][0], proto[cmd][1:]])
         self.bitcount = self.databyte = 0
         self.bits = []