X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=tests%2Fversion.c;h=fa3a63cbd383a5c00201a33b4e0b92f47a872852;hb=996331ce9ba6f43e683b0b8ba4cbf3ef24546d36;hp=4217ad51ae36de8886aef31e1b5aad1db7336782;hpb=4960aeb03533f503c32c50cdd94277d561112c1a;p=libsigrok.git

diff --git a/tests/version.c b/tests/version.c
index 4217ad51..fa3a63cb 100644
--- a/tests/version.c
+++ b/tests/version.c
@@ -14,10 +14,10 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <config.h>
 #include <stdlib.h>
 #include <check.h>
 #include <libsigrok/libsigrok.h>
@@ -59,21 +59,38 @@ END_TEST
 /*
  * Check the version number API calls and macros.
  *
- * The string representations of the package/lib version must match the
- * version numbers, the string lengths must be >= 5 (e.g. "0.1.0"), and
- * the strings length must be <= 20 characters, otherwise something is
- * probably wrong.
+ * The string representations of the package/lib version must neither be
+ * NULL nor empty, and the length shall be within an expected range.
+ *
+ * The lower limit assumes:
+ * - A version text consists of three parts (major, minor, micro),
+ *   like "0.1.0".
+ * - Three numbers with at least one digit, and their separators,
+ *   result in a minimum length of 5.
+ *
+ * The upper limit assumes:
+ * - The major, minor, and micro parts won't contain more than two
+ *   digits each (this is an arbitrary choice).
+ * - An optional "-git-<hash>" suffix might follow. While git(1)
+ *   defaults to 7 hex digits for abbreviated hashes, projects of
+ *   larger scale might recommend to use more digits to avoid
+ *   potential ambiguity (e.g. Linux recommends core.abbrev=12).
+ *   Again, this is an arbitrary choice.
  */
 START_TEST(test_version_strings)
 {
 	const char *str;
+	const size_t len_min = 5;
+	const size_t len_max = 2 + 1 + 2 + 1 + 2 + 5 + 12;
 
 	str = sr_package_version_string_get();
 	fail_unless(str != NULL);
-	fail_unless(strlen(str) >= 5 && strlen(str) <= 20);
+	fail_unless(strlen(str) >= len_min);
+	fail_unless(strlen(str) <= len_max);
 	str = sr_lib_version_string_get();
 	fail_unless(str != NULL);
-	fail_unless(strlen(str) >= 5 && strlen(str) <= 20);
+	fail_unless(strlen(str) >= len_min);
+	fail_unless(strlen(str) <= len_max);
 }
 END_TEST