X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=src%2Foutput%2Fanalog.c;h=5e6e4aca49280b6f9625c456860cac74316f6c14;hb=f2a66a8ee669df5afa1b7bdade6e25ac0857fe4b;hp=6a9ab5973357ec86ae6841526136275538f3e3ad;hpb=6ec6c43b4738dbc7091f4a49a4ec80ea6102cb52;p=libsigrok.git

diff --git a/src/output/analog.c b/src/output/analog.c
index 6a9ab597..5e6e4aca 100644
--- a/src/output/analog.c
+++ b/src/output/analog.c
@@ -31,6 +31,7 @@ struct context {
 	int num_enabled_channels;
 	GPtrArray *channellist;
 	int digits;
+	float *fdata;
 };
 
 enum {
@@ -64,11 +65,12 @@ static int init(struct sr_output *o, GHashTable *options)
 		g_ptr_array_add(ctx->channellist, ch->name);
 		ctx->num_enabled_channels++;
 	}
+	ctx->fdata = NULL;
 
 	return SR_OK;
 }
 
-static void si_printf(float value, GString *out, char *unitstr)
+static void si_printf(float value, GString *out, const char *unitstr)
 {
 	float v;
 
@@ -278,8 +280,8 @@ static int receive(const struct sr_output *o, const struct sr_datafeed_packet *p
 		GString **out)
 {
 	struct context *ctx;
+	const struct sr_datafeed_analog_old *analog_old;
 	const struct sr_datafeed_analog *analog;
-	const struct sr_datafeed_analog2 *analog2;
 	struct sr_channel *ch;
 	GSList *l;
 	float *fdata;
@@ -299,44 +301,46 @@ static int receive(const struct sr_output *o, const struct sr_datafeed_packet *p
 	case SR_DF_FRAME_END:
 		*out = g_string_new("FRAME-END\n");
 		break;
-	case SR_DF_ANALOG:
-		analog = packet->payload;
-		fdata = (float *)analog->data;
+	case SR_DF_ANALOG_OLD:
+		analog_old = packet->payload;
+		fdata = (float *)analog_old->data;
 		*out = g_string_sized_new(512);
-		num_channels = g_slist_length(analog->channels);
-		for (si = 0; si < analog->num_samples; si++) {
-			for (l = analog->channels, c = 0; l; l = l->next, c++) {
+		num_channels = g_slist_length(analog_old->channels);
+		for (si = 0; si < analog_old->num_samples; si++) {
+			for (l = analog_old->channels, c = 0; l; l = l->next, c++) {
 				ch = l->data;
 				g_string_append_printf(*out, "%s: ", ch->name);
-				fancyprint(analog->unit, analog->mqflags,
+				fancyprint(analog_old->unit, analog_old->mqflags,
 						fdata[si * num_channels + c], *out);
 			}
 		}
 		break;
-	case SR_DF_ANALOG2:
-		analog2 = packet->payload;
-		if (!(fdata = g_try_malloc(analog2->num_samples * sizeof(float))))
+	case SR_DF_ANALOG:
+		analog = packet->payload;
+		num_channels = g_slist_length(analog->meaning->channels);
+		if (!(fdata = g_try_realloc(ctx->fdata,
+						analog->num_samples * num_channels * sizeof(float))))
 			return SR_ERR_MALLOC;
-		if ((ret = sr_analog_to_float(analog2, fdata)) != SR_OK)
+		ctx->fdata = fdata;
+		if ((ret = sr_analog_to_float(analog, fdata)) != SR_OK)
 			return ret;
 		*out = g_string_sized_new(512);
-		if (analog2->encoding->is_digits_decimal) {
+		if (analog->encoding->is_digits_decimal) {
 			if (ctx->digits == DIGITS_ALL)
-				digits = analog2->encoding->digits;
+				digits = analog->encoding->digits;
 			else
-				digits = analog2->spec->spec_digits;
+				digits = analog->spec->spec_digits;
 		} else {
 			/* TODO we don't know how to print by number of bits yet. */
 			digits = 6;
 		}
-		sr_analog_unit_to_string(analog2, &suffix);
-		num_channels = g_slist_length(analog2->meaning->channels);
-		for (i = 0; i < analog2->num_samples; i++) {
-			for (l = analog2->meaning->channels, c = 0; l; l = l->next, c++) {
+		sr_analog_unit_to_string(analog, &suffix);
+		for (i = 0; i < analog->num_samples; i++) {
+			for (l = analog->meaning->channels, c = 0; l; l = l->next, c++) {
 				ch = l->data;
 				g_string_append_printf(*out, "%s: ", ch->name);
-				sr_analog_float_to_string(fdata[i * num_channels + c],
-						digits, &number);
+				number = g_strdup_printf("%.*f", digits,
+						fdata[i * num_channels + c]);
 				g_string_append(*out, number);
 				g_free(number);
 				g_string_append(*out, " ");
@@ -351,21 +355,6 @@ static int receive(const struct sr_output *o, const struct sr_datafeed_packet *p
 	return SR_OK;
 }
 
-static int cleanup(struct sr_output *o)
-{
-	struct context *ctx;
-
-	if (!o || !o->sdi)
-		return SR_ERR_ARG;
-	ctx = o->priv;
-
-	g_ptr_array_free(ctx->channellist, 1);
-	g_free(ctx);
-	o->priv = NULL;
-
-	return SR_OK;
-}
-
 static struct sr_option options[] = {
 	{ "digits", "Digits", "Digits to show", NULL, NULL },
 	ALL_ZERO
@@ -384,6 +373,24 @@ static const struct sr_option *get_options(void)
 	return options;
 }
 
+static int cleanup(struct sr_output *o)
+{
+	struct context *ctx;
+
+	if (!o || !o->sdi)
+		return SR_ERR_ARG;
+	ctx = o->priv;
+
+	g_ptr_array_free(ctx->channellist, 1);
+	g_variant_unref(options[0].def);
+	g_slist_free_full(options[0].values, (GDestroyNotify)g_variant_unref);
+	g_free(ctx->fdata);
+	g_free(ctx);
+	o->priv = NULL;
+
+	return SR_OK;
+}
+
 SR_PRIV struct sr_output_module output_analog = {
 	.id = "analog",
 	.name = "Analog",