X-Git-Url: https://sigrok.org/gitweb/?a=blobdiff_plain;f=src%2Fhardware%2Fpce-322a%2Fprotocol.c;h=ee98c7c61128cd82cb0a1bdbb2d0a7ab724524d8;hb=deb7615262ac4f9cc0750a08351afa7cbf9c34d5;hp=564f2984de50cbc5574d174fa21ca4cf2be8837a;hpb=379e95c587e1d76eb5d6d1a144b938e6a4916b1f;p=libsigrok.git

diff --git a/src/hardware/pce-322a/protocol.c b/src/hardware/pce-322a/protocol.c
index 564f2984..ee98c7c6 100644
--- a/src/hardware/pce-322a/protocol.c
+++ b/src/hardware/pce-322a/protocol.c
@@ -19,12 +19,14 @@
  */
 
 #include <config.h>
+#include <string.h>
 #include "protocol.h"
 
 static int send_command(const struct sr_dev_inst *sdi, uint16_t command)
 {
 	struct sr_serial_dev_inst *serial;
 	uint8_t buffer[2];
+	int ret;
 
 	buffer[0] = command >> 8;
 	buffer[1] = command;
@@ -32,13 +34,20 @@ static int send_command(const struct sr_dev_inst *sdi, uint16_t command)
 	if (!(serial = sdi->conn))
 		return SR_ERR;
 
-	return serial_write_blocking(serial, (const void *)buffer, 2, 0);
+	ret = serial_write_blocking(serial, buffer, sizeof(buffer), 0);
+	if (ret < 0)
+		return ret;
+	if ((size_t)ret != sizeof(buffer))
+		return SR_ERR_IO;
+
+	return SR_OK;
 }
 
 static int send_long_command(const struct sr_dev_inst *sdi, uint32_t command)
 {
 	struct sr_serial_dev_inst *serial;
 	uint8_t buffer[4];
+	int ret;
 
 	buffer[0] = command >> 24;
 	buffer[1] = command >> 16;
@@ -48,7 +57,13 @@ static int send_long_command(const struct sr_dev_inst *sdi, uint32_t command)
 	if (!(serial = sdi->conn))
 		return SR_ERR;
 
-	return serial_write_blocking(serial, (const void *)buffer, 4, 0);
+	ret = serial_write_blocking(serial, buffer, sizeof(buffer), 0);
+	if (ret < 0)
+		return ret;
+	if ((size_t)ret != sizeof(buffer))
+		return SR_ERR_IO;
+
+	return SR_OK;
 }
 
 static void send_data(const struct sr_dev_inst *sdi, float sample)
@@ -134,15 +149,13 @@ static void process_memory_measurement(const struct sr_dev_inst *sdi)
 static void process_byte(const struct sr_dev_inst *sdi, const unsigned char c)
 {
 	struct dev_context *devc;
-	unsigned int i;
 
 	devc = sdi->priv;
 
 	if (devc->buffer_len < BUFFER_SIZE) {
 		devc->buffer[devc->buffer_len++] = c;
 	} else {
-		for (i = 1; i < BUFFER_SIZE; i++)
-			devc->buffer[i - 1] = devc->buffer[i];
+		memmove(devc->buffer, devc->buffer + 1, BUFFER_SIZE - 1);
 		devc->buffer[BUFFER_SIZE - 1] = c;
 	}
 
@@ -156,15 +169,13 @@ static void process_byte(const struct sr_dev_inst *sdi, const unsigned char c)
 static void process_usage_byte(const struct sr_dev_inst *sdi, uint8_t c)
 {
 	struct dev_context *devc;
-	unsigned int i;
 
 	devc = sdi->priv;
 
 	if (devc->buffer_len < MEM_USAGE_BUFFER_SIZE) {
 		devc->buffer[devc->buffer_len++] = c;
 	} else {
-		for (i = 1; i < MEM_USAGE_BUFFER_SIZE; i++)
-			devc->buffer[i - 1] = devc->buffer[i];
+		memmove(devc->buffer, devc->buffer + 1, MEM_USAGE_BUFFER_SIZE - 1);
 		devc->buffer[MEM_USAGE_BUFFER_SIZE - 1] = c;
 	}
 
@@ -187,15 +198,13 @@ static void process_usage_byte(const struct sr_dev_inst *sdi, uint8_t c)
 static void process_memory_byte(const struct sr_dev_inst *sdi, uint8_t c)
 {
 	struct dev_context *devc;
-	unsigned int i;
 
 	devc = sdi->priv;
 
 	if (devc->buffer_len < MEM_DATA_BUFFER_SIZE) {
 		devc->buffer[devc->buffer_len++] = c;
 	} else {
-		for (i = 1; i < MEM_DATA_BUFFER_SIZE; i++)
-			devc->buffer[i - 1] = devc->buffer[i];
+		memmove(devc->buffer, devc->buffer + 1, MEM_DATA_BUFFER_SIZE - 1);
 		devc->buffer[MEM_DATA_BUFFER_SIZE - 1] = c;
 	}